Subject: bug#48902: 28.0.50; Directory names containing apostrophes and backticks cause problems

From: Mattias Engdegård <[email-masked]>
Date: Tue, 8 Jun 2021 22:08:19 +0200

8 juni 2021 kl. 21.13 skrev [email-masked]:

> For example, another patch using STRING_SET_MULTIBYTE() is here.
> This looks still just a quick fix and bit weired, though..

Thank you, but it's probably better to always return an unencoded string from image_find_image_fd in that case. The current code looks like a premature optimisation.

> On the other hand, I cannot find out that non-UTF-8 filename coding is
> really needed on macOS.  It might be over-engineered thing, and just an overhead.

Maybe and in practice you are probably right, but the NS port is not exclusive to macOS.
There is the quasi-NFD normalisation step but I'm not sure how important that is today. There's no need to convert to NFD for accessing files; it only matters when comparing names (much like case folding on many file systems).