GNU bug report logs - #48853
[PATCH] profiles: Move some of the work to the build side.

Previous Next

Package: guix-patches;

Reported by: Ludovic Courtès <ludo <at> gnu.org>

Date: Sat, 5 Jun 2021 21:10:01 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


Message #10 received at 48853-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: 48853-done <at> debbugs.gnu.org
Subject: Re: bug#48853: [PATCH] profiles: Move some of the work to the build
 side.
Date: Sat, 12 Jun 2021 00:55:10 +0200
Ludovic Courtès <ludo <at> gnu.org> skribis:

> When running:
>
>   guix environment --ad-hoc gnome --no-grafts --search-paths
>
> this reduces wall-clock time by ~5%.  The number of object cache lookups
> goes down from 96K to 89K.  (Note that 'gnome' is an interesting example
> because it has many propagated inputs, which themselves have propagated
> inputs too, which would lead to a long input list and a long manifest in
> the 'profile-derivation' gexp.)
>
> * guix/profiles.scm (profile-derivation)[inputs, search-paths]: Remove.
> [extra-inputs]: New variable.
> [builder]: Adjust call to 'build-profile'.
> * guix/build/profiles.scm (manifest-sexp->inputs+search-paths): New
> procedure.
> (build-profile): Remove 'inputs' parameter; make 'manifest' the 2nd
> positional parameter and add #:extra-inputs.  Call
> 'manifest-sexp->inputs+search-paths' to obtain 'inputs' and
> 'search-paths'.
> ---
>  guix/build/profiles.scm | 86 +++++++++++++++++++++++++++--------------
>  guix/profiles.scm       | 25 ++++--------
>  2 files changed, 64 insertions(+), 47 deletions(-)

Pushed as 8cef92d0633850d97c1a1d4521812268f56672be.




This bug report was last modified 3 years and 347 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.