Subject: bug#48852: closed (Re: bug#48852: [PATCH] hg-download: Add helpers for defining packages.)

From: [email-masked] (GNU bug Tracking System)
Date: Sat, 05 Jun 2021 21:14:01 +0000

Your bug report

#48852: [PATCH] hg-download: Add helpers for defining packages.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
48852: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=48852
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#48852: [PATCH] hg-download: Add helpers for defining packages.
From: Ludovic Courtès <[email-masked]>
To: Xinglu Chen <[email-masked]>
Cc: [email-masked]
Date: Sat, 05 Jun 2021 23:13:26 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

Xinglu Chen <[email-masked]> skribis:

> Hg followup to commit ee17a9e06e636400e3354796a42ac445dbcc8f96.
>
> * hg-download.scm (hg-version, hg-file-name): New procedures.

Applied, thanks!

Ludo’.

Subject: [PATCH] hg-download: Add helpers for defining packages.
From: Xinglu Chen <[email-masked]>
To: [email-masked]
Date: Sat, 05 Jun 2021 21:18:26 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hg followup to commit ee17a9e06e636400e3354796a42ac445dbcc8f96.

* hg-download.scm (hg-version, hg-file-name): New procedures.
---
 guix/hg-download.scm | 22 +++++++++++++++++++++-
 1 file changed, 21 insertions(+), 1 deletion(-)

diff --git a/guix/hg-download.scm b/guix/hg-download.scm
index c6cee2dbb8..9f23e4c40d 100644
--- a/guix/hg-download.scm
+++ b/guix/hg-download.scm
@@ -1,6 +1,7 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2014, 2015, 2016, 2017, 2019 Ludovic Courtès <[email-masked]>
 ;;; Copyright © 2016 Ricardo Wurmus <[email-masked]>
+;;; Copyright © 2021 Xinglu Chen <[email-masked]>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -34,7 +35,9 @@
             hg-reference-changeset
             hg-reference-recursive?
             hg-predicate
-            hg-fetch))
+            hg-fetch
+            hg-version
+            hg-file-name))
 
 ;;; Commentary:
 ;;;
@@ -102,6 +105,23 @@ HASH-ALGO (a symbol).  Use NAME as the file name, or a generic name if #f."
                       #:recursive? #t
                       #:guile-for-build guile)))
 
+(define (hg-version version revision changeset)
+  "Return the version string for packages using hg-download."
+  ;; hg-version is almost exclusively executed while modules are being loaded.
+  ;; This makes any errors hide their backtrace. Avoid the mysterious error
+  ;; "Value out of range 0 to N: 7" when the commit ID is too short, which
+  ;; can happen, for example, when the user swapped the revision and commit
+  ;; arguments by mistake.
+  (when (< (string-length changeset) 7)
+    (raise
+     (condition
+      (&message (message "hg-version: changeset ID unexpectedly short")))))
+  (string-append version "-" revision "." (string-take changeset 7)))
+
+(define (hg-file-name name version)
+  "Return the file-name for packages using hg-download."
+  (string-append name "-" version "-checkout"))
+
 (define (hg-file-list directory)
   "Evaluates to a list of files contained in the repository at path
   @var{directory}"

base-commit: 9da90938c63208b7721276f8cefcdac82ba765f2
-- 
2.31.1