GNU bug report logs - #48849
[PATCH core-updates]: Add #:sh argument to wrap-qt-program

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#48849: closed ([PATCH core-updates]: Add #:sh argument to
 wrap-qt-program)
Date: Mon, 22 Jan 2024 05:13:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 22 Jan 2024 00:12:36 -0500
with message-id <878r4i3q9n.fsf <at> gmail.com>
and subject line Re: bug#48849: [PATCH core-updates]: Add #:sh argument to wrap-qt-program
has caused the debbugs.gnu.org bug report #48849,
regarding [PATCH core-updates]: Add #:sh argument to wrap-qt-program
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
48849: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=48849
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Maxime Devos <maximedevos <at> telenet.be>
To: guix-patches <at> gnu.org
Subject: [PATCH core-updates]: Add #:sh argument to wrap-qt-program
Date: Sat, 05 Jun 2021 13:49:23 +0200

[Message part 3 (text/plain, inline)]

Hi guix,

This patch series adds a #:sh keyword argument to wrap-qt-program
and adjusts callers to set this keyword argument appropriately.

Setting this argument appropriately is required for cross-compilation.
Otherwise, a bash for SYSTEM (as in --system=..) is used instead
of a bash for TARGET (as in --target=...).

I didn't test building some qt programs with this patch series yet,
as I'm currently waiting on the substitute servers to catch up
with recent changed to core-updates (to avoid building a tower
of rusts). I'll do that later.

Greetings,
Maxime

[0001-qt-utils-Allow-overriding-the-shell-interpreter-in-w.patch (text/x-patch, attachment)]

[0002-gnu-qbittorrent-Set-sh-argument-of-wrap-qt-program.patch (text/x-patch, attachment)]

[0003-gnu-electron-cash-Set-sh-argument-of-wrap-qt-program.patch (text/x-patch, attachment)]

[0004-gnu-qgis-Set-sh-argument-of-wrap-qt-program.patch (text/x-patch, attachment)]

[0005-gnu-keepassxc-Set-sh-argument-of-wrap-qt-program.patch (text/x-patch, attachment)]

[0006-gnu-qtpass-Set-sh-argument-of-wrap-qt-program.patch (text/x-patch, attachment)]

[0007-gnu-openshot-Set-sh-argument-of-wrap-qt-program.patch (text/x-patch, attachment)]

[0008-gnu-kristall-Set-sh-argument-of-wrap-qt-program.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

[Message part 13 (message/rfc822, inline)]

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 48849-done <at> debbugs.gnu.org
Subject: Re: bug#48849: [PATCH core-updates]: Add #:sh argument to
 wrap-qt-program
Date: Mon, 22 Jan 2024 00:12:36 -0500

Hi again,

Maxime Devos <maximedevos <at> telenet.be> writes:

> Hi guix,
>
> This patch series adds a #:sh keyword argument to wrap-qt-program
> and adjusts callers to set this keyword argument appropriately.
>
> Setting this argument appropriately is required for cross-compilation.
> Otherwise, a bash for SYSTEM (as in --system=..) is used instead
> of a bash for TARGET (as in --target=...).
>
> I didn't test building some qt programs with this patch series yet,
> as I'm currently waiting on the substitute servers to catch up
> with recent changed to core-updates (to avoid building a tower
> of rusts). I'll do that later.
>
> Greetings,
> Maxime
>
> From 27d42f25f54b16f382e18b9ef0fb202fb00da90d Mon Sep 17 00:00:00 2001
> From: Maxime Devos <maximedevos <at> telenet.be>
> Date: Sat, 5 Jun 2021 11:02:16 +0200
> Subject: [PATCH 1/8] qt-utils: Allow overriding the shell interpreter in
>  'wrap-qt-program'.
>
> * guix/build/qt-utils.scm (wrap-qt-program): Introduce a #:sh keyword
>   argument and pass it to 'wrap-program'.

I see this patch was already merged by Mathieu in
77b98bf1874aac8ed447e9f0b0ee0865a1d652ba; thus, I'm closing this ticket.

Thank you!

-- 
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.