From unknown Sun Aug 17 22:11:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#48834: 28.0.50; [PATCH] gnus-summary-limit functions with prefix fail when no articles are left to display Resent-From: Alex Bochannek Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Jun 2021 19:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 48834 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 48834@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.162283470928562 (code B ref -1); Fri, 04 Jun 2021 19:26:02 +0000 Received: (at submit) by debbugs.gnu.org; 4 Jun 2021 19:25:09 +0000 Received: from localhost ([127.0.0.1]:47889 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lpFRN-0007Qc-D8 for submit@debbugs.gnu.org; Fri, 04 Jun 2021 15:25:09 -0400 Received: from lists.gnu.org ([209.51.188.17]:56556) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lpFRK-0007QQ-EW for submit@debbugs.gnu.org; Fri, 04 Jun 2021 15:25:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55976) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lpFRK-0005Hd-88 for bug-gnu-emacs@gnu.org; Fri, 04 Jun 2021 15:25:06 -0400 Received: from ns.lapseofthought.com ([50.0.39.240]:5441 helo=mail.lapseofthought.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lpFRG-0000D5-UA for bug-gnu-emacs@gnu.org; Fri, 04 Jun 2021 15:25:05 -0400 Received: from awb-mbp.local (unknown [IPv6:2601:646:4200:b470:6d0d:ee85:8d40:371e]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.lapseofthought.com (Postfix) with ESMTPSA id 4FxXlT2mLGz3pkm1 for ; Fri, 4 Jun 2021 12:24:53 -0700 (PDT) From: Alex Bochannek Date: Fri, 04 Jun 2021 12:24:52 -0700 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (darwin) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Authentication-Results: ORIGINATING; auth=pass smtp.auth=alex smtp.mailfrom=alex@bochannek.com Received-SPF: pass client-ip=50.0.39.240; envelope-from=alex@bochannek.com; helo=mail.lapseofthought.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain Hello! I noticed that when I am trying to exclude articles from summary view, I incorrectly get the "Found no matches" error when all articles match (i.e., no articles are left to display.) --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/lisp/gnus/gnus-sum.el b/lisp/gnus/gnus-sum.el index 48794ceb3f..3279c3221e 100644 --- a/lisp/gnus/gnus-sum.el +++ b/lisp/gnus/gnus-sum.el @@ -8247,7 +8247,7 @@ gnus-summary-limit-to-subject (let ((articles (gnus-summary-find-matching (or header "subject") subject 'all nil nil not-matching))) - (unless articles + (unless (or articles not-matching) (error "Found no matches for \"%s\"" subject)) (gnus-summary-limit articles)) (gnus-summary-position-point)))) @@ -8318,7 +8318,7 @@ gnus-summary-limit-to-recipient (and (memq a to) a)) cc) (nconc to cc)))) - (unless articles + (unless (or articles not-matching) (error "Found no matches for \"%s\"" recipient)) (gnus-summary-limit articles)) (gnus-summary-position-point)))) @@ -8374,7 +8374,7 @@ gnus-summary-limit-to-address (nconc (if (eq to t) nil to) (if (eq cc t) nil cc) from)))) - (unless articles + (unless (or articles not-matching) (error "Found no matches for \"%s\"" address)) (gnus-summary-limit articles)) (gnus-summary-position-point)))) @@ -8465,7 +8465,7 @@ gnus-summary-limit-to-extra (let ((articles (gnus-summary-find-matching (cons 'extra header) regexp 'all nil nil not-matching))) - (unless articles + (unless (or articles not-matching) (error "Found no matches for \"%s\"" regexp)) (gnus-summary-limit articles)) (gnus-summary-position-point)))) --=-=-= Content-Type: text/plain -- Alex. --=-=-=-- From unknown Sun Aug 17 22:11:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#48834: 28.0.50; [PATCH] gnus-summary-limit functions with prefix fail when no articles are left to display Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Jun 2021 20:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48834 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Alex Bochannek Cc: 48834@debbugs.gnu.org Received: via spool by 48834-submit@debbugs.gnu.org id=B48834.162292503031804 (code B ref 48834); Sat, 05 Jun 2021 20:31:02 +0000 Received: (at 48834) by debbugs.gnu.org; 5 Jun 2021 20:30:30 +0000 Received: from localhost ([127.0.0.1]:50132 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lpcwA-0008GZ-75 for submit@debbugs.gnu.org; Sat, 05 Jun 2021 16:30:30 -0400 Received: from quimby.gnus.org ([95.216.78.240]:51960) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lpcw6-00086q-Ap for 48834@debbugs.gnu.org; Sat, 05 Jun 2021 16:30:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=7hEXhwkFl45oLN0y8ITvSEvwjh75ssyn2bwSn9u5/FI=; b=d+AHseMaRyXuocWBNl6Johav1V ZcYaTb18j9+MuMHDD6yRtq7g3A/Eyxqjb0oIwXJrke8XvAAn2l9bKeHDqXScvHsypGoId2ryBNL2y nxyUROyDvvQj585MQBQz0tkhAyWdm9CB0fZKqEm3qBvOxaxx6RWzW6mkUdZ7USFLhsKQ=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lpcvw-0007MR-UO; Sat, 05 Jun 2021 22:30:19 +0200 From: Lars Ingebrigtsen References: X-Now-Playing: Anne Clark's _R.V.S.P._: "Sleeper In Metropolis" Date: Sat, 05 Jun 2021 22:30:16 +0200 In-Reply-To: (Alex Bochannek's message of "Fri, 04 Jun 2021 12:24:52 -0700") Message-ID: <878s3ovyuf.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Alex Bochannek writes: > I noticed that when I am trying to exclude articles from summary view, I > incorrectly get the "Found no matches" error when all articles match > (i.e., no articles are left to display.) Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Alex Bochannek writes: > I noticed that when I am trying to exclude articles from summary view, I > incorrectly get the "Found no matches" error when all articles match > (i.e., no articles are left to display.) Thanks; applied to Emacs 28. In future patches, can you also include ChangeLog-style commit messages? (I added them myself here.) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 05 16:30:32 2021 Received: (at control) by debbugs.gnu.org; 5 Jun 2021 20:30:33 +0000 Received: from localhost ([127.0.0.1]:50135 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lpcwC-0008Iv-HH for submit@debbugs.gnu.org; Sat, 05 Jun 2021 16:30:32 -0400 Received: from quimby.gnus.org ([95.216.78.240]:51974) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lpcwA-0008Bh-Nd for control@debbugs.gnu.org; Sat, 05 Jun 2021 16:30:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=epQ/8HEX/M9S2vyLIVWy/jXY3gmEJboyjTDW6SwQwgM=; b=V4IbFAgHsTK+Xbc+IBF543lC6C NaZr+DkSoxWNEZ4Z21jl6Yr6FiYiy0oYI5U5wZk6w9dj/ab2MQiuKZnG28r/a9RGStB/pRVWAvevw SBPmwGJ4gZdKI3gAp/v0ORtJX9vJgyBIY5k9C3tVPg7hQq4Z1/tUGqXaHBfrwxLCtUXc=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lpcw3-0007Ma-BY for control@debbugs.gnu.org; Sat, 05 Jun 2021 22:30:25 +0200 Date: Sat, 05 Jun 2021 22:30:22 +0200 Message-Id: <877dj8vyu9.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #48834 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 48834 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) close 48834 28.1 quit