GNU bug report logs - #48825
[PATCH] gnu: Simplify the use of --with-long-double-128 on powerpc64le.

Previous Next

Full log

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Chris Marusich <cmmarusich <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: Re: bug#48825: [PATCH] gnu: Simplify the use of
 --with-long-double-128 on powerpc64le.
Date: Fri, 18 Jun 2021 11:49:13 -0700

[Message part 1 (text/plain, inline)]

Hi Efraim,

Efraim Flashner <efraim <at> flashner.co.il> writes:

> couple of thoughts:
> powerpc64le is in 'technology preview', so IMO it's fine to make big
> changes to it as needed.

That's true, but since we now have a stable place from which to work
(master), I feel less concerned about getting changes into master.  I
thought about this again now, and I think I will plan to push this
change to core-updates instead of master.

> On master (and probably on core-updates too) we have a patch for glibc
> to force ... something (that I don't remember) on powerpc architectures,
> which has the side effect of needing '--with-long-double-128' on
> powerpc-linux also in commencement.scm. If we could drop that patch then
> I don't think we would need it anymore for powerpc.

I'm not sure what change this would be, but if you ever figure it out,
please do let me know!

>> diff --git a/gnu/packages/commencement.scm b/gnu/packages/commencement.scm
>> index d4511ed914..db564db9c4 100644
>> --- a/gnu/packages/commencement.scm
>> +++ b/gnu/packages/commencement.scm
>> @@ -2819,13 +2819,6 @@ exec " gcc "/bin/" program
>>                             "--disable-shared"
>>                             "--enable-languages=c,c++"
>>  
>
> I've adjusted this on core-updates to also take effect on powerpc-linux.

Thank you for mentioning this.  In light of your change, I needed to
modify my patch.  I've attached a new patch which takes powerpc into
account.  I modified the commit message a bit, too.

I'm confident the attached patch is correct for powerpc64le-linux, but
if you could take a peek and make sure I didn't miss something related
to powerpc, I would appreciate it!

> This can be just 'powerpc64le'

When checking the string prefix, that does probably work for little
endian powerpc 64, since I don't think there are any other architectures
that start with "powerpc64le".  However, if you did something similar
for powerpc (like in your change on core-updates), please keep in mind
that it will affect not only powerpc64le, but also big-endian powerpc64,
and any other powerpc architecture.  For that reason, I personally
prefer to keep the hyphen when I have a specific architecture in mind.

-- 
Chris

[0001-gnu-Simplify-the-use-of-with-long-double-128.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.