From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 04 01:08:11 2021 Received: (at submit) by debbugs.gnu.org; 4 Jun 2021 05:08:11 +0000 Received: from localhost ([127.0.0.1]:45141 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lp243-0000aT-2w for submit@debbugs.gnu.org; Fri, 04 Jun 2021 01:08:11 -0400 Received: from lists.gnu.org ([209.51.188.17]:43322) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lp241-0000aH-Eo for submit@debbugs.gnu.org; Fri, 04 Jun 2021 01:08:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57714) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lp241-0002Z9-7i for guix-patches@gnu.org; Fri, 04 Jun 2021 01:08:09 -0400 Received: from mail-pj1-x102f.google.com ([2607:f8b0:4864:20::102f]:43957) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lp23z-0005lA-0a for guix-patches@gnu.org; Fri, 04 Jun 2021 01:08:08 -0400 Received: by mail-pj1-x102f.google.com with SMTP id l10-20020a17090a150ab0290162974722f2so5207913pja.2 for ; Thu, 03 Jun 2021 22:08:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:user-agent:mime-version; bh=foQjUA4JO1kMYlFfckZ0KigAMYaSC2VfOnjJQnr4exM=; b=IF7GacyU1KSaGP1+u0u/b5y/SvjCnc0QoHQR3ISU7UeI5x2U7ovfvYicD7ekodMkMQ eXZi/lIcXH2/1HOUuGfExqY0890lJLxrZv2PLwhvVR2ATL58Dt4H3TGaQC2EYze7xUMU aDuGmav3EphNXbCsdnO/X0ov3sdQpWlGrOLnSoEPZHwVpTISh7hVD8R56PxXXCTbFr9t 71zsQe6xtvuLsMFhLtr+FHdMKHSlyms5FQIxg8sgn8Wc5yybr9HCcykvr8lNmpEYMSSz p30SVimgP7kk2MYA16A3OlA3cT79lGj1bhWPDfmfRMznlTCf1qZmY7geHBERClJOc4j8 iR4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :mime-version; bh=foQjUA4JO1kMYlFfckZ0KigAMYaSC2VfOnjJQnr4exM=; b=sSqGvcfbvypc/LmmZ/aqvYtQAsu2l7pUOisCych0VGj++HWjqbxfRQtpxOPdQr2VcF eNYQ/Dt19kN1gP/i9OO8rd+9fV8Ix/GZfAV2IK7xX1JZf0QRGGYGTA84qzqjfVoK7AuA uqBZ/QUQpifFBFFrWDg7QcsbTOlzOtfpkiTLVE+KnB8MgZ0aqFsm+wOwh7G8Nk09jUCQ ClbINHWXgtTk58HuQ789VS41ezw3Skgh16s78alhGntG7w/ewDI6oHEOcbrqdSlp2kih MtG7eT8/DCaq9rc+o01sV4CTWTLBgYDbcDpU1M/P/512/ZqlAbkdw4hxUB2BpL0uU0T/ MSIQ== X-Gm-Message-State: AOAM531eKuYE/f8MmyUWd2U2Yt1kek7cDsm/f1/1dThO59y+qacnkLnY H3IXMl4yNdC7JLb2yTa7aUDcJLu4UoA= X-Google-Smtp-Source: ABdhPJwsx1cycZU50dF+FyAeDI7804udIi6wNAkbR+V6dLSsxNdwKLbXN8s+PXDI49QJmnVfEBwTpg== X-Received: by 2002:a17:90a:8902:: with SMTP id u2mr2974538pjn.143.1622783285174; Thu, 03 Jun 2021 22:08:05 -0700 (PDT) Received: from garuda-lan ([2601:601:9d01:3f90::b043]) by smtp.gmail.com with ESMTPSA id 4sm689640pgn.31.2021.06.03.22.08.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Jun 2021 22:08:04 -0700 (PDT) From: Chris Marusich To: guix-patches@gnu.org Subject: [PATCH] gnu: Simplify the use of --with-long-double-128 on powerpc64le. Date: Thu, 03 Jun 2021 22:08:00 -0700 Message-ID: <87o8cmtdxr.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Received-SPF: pass client-ip=2607:f8b0:4864:20::102f; envelope-from=cmmarusich@gmail.com; helo=mail-pj1-x102f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Efraim Flashner X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Currently in Guix, we explicitly specify --with-long-double-128 on powerpc64le-linux (and potentially other powerpc64-* systems) in two places. It turns out that this is not necessary. This patch simplifies our code. I originally authored this in order to try fixing bug 47698, but it didn't solve that problem, and it turns out the --with-long-double-128 option is probably unrelated to that bug. However, it's still worth making this change to simplify our code. If nobody has any issues with this, then in 2 weeks I will commit it. One question is: where should I commit it? I'd like to commit it to master, but it causes many rebuilds on powerpc64le-linux (it does not cause rebuilds on any other platforms), so per the guidelines ((guix) Submitting Patches) I ought to commit it to core-updates. However, because the glibc upgrade from 2.31 to 2.32 on core-updates causes many problems for powerpc64le-linux, core-updates has never once been a viable branch for powerpc64le-linux in the time since support was first added on master. So if I commit this patch to core-updates, it won't really do anyone any good right now. With all this in mind, I think master is the right place to commit this patch. =2D-=20 Chris --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-gnu-Simplify-the-use-of-with-long-double-128-on-powe.patch Content-Transfer-Encoding: quoted-printable From=20ad89f9f59d22cc10fbf7dd6f738ce15a6e79b640 Mon Sep 17 00:00:00 2001 From: Chris Marusich Date: Sat, 10 Apr 2021 18:16:17 -0700 Subject: [PATCH] gnu: Simplify the use of --with-long-double-128 on powerpc64le. In short, this change adds the "--with-long-double-128" configure option in one place and removes it from two other (now-redundant) places. It does not cause any rebuilds on systems other than powerpc64le-linux. * gnu/packages/gcc.scm (gcc-configure-flags-for-triplet): Add a clause for targets starting with "powerpc64le-" which adds the "--with-long-double-128" option. This causes any package using this procedure to be built using this new option on powerpc64le systems. In particular, this affects the gcc package and the gcc-final package, in addition to all the other versions of GCC defined in (gnu packages gcc). * gnu/packages/commencement.scm (gcc-boot0)[#:configure-flags]: Remove the code that adds the "--with-long-double-128" configure option for powerpc64l= e, since it is now redundant. The gcc-boot0 package uses (and adds to) the gcc package's configure options. This means that the above change in gcc.scm is sufficient to ensure that the gcc-boot0 package's configure options will include "--with-long-double-128" on powerpc64le systems. * gnu/packages/cross-base.scm (cross-gcc-arguments)[#:configure-flags]: Rem= ove the code that adds the "--with-long-double-128" configure option for powerpc64le, since it is now redundant. The cross-gcc-arguments procedure uses (and adds to) the configure options of its xgcc argument (a package). This means that regardless of which gcc from gcc.scm is used as the xgcc, t= he above change in gcc.scm is sufficient to ensure that the cross-gcc-arguments procedure's configure options will include "--with-long-double-128" on powerpc64le systems. =2D-- gnu/packages/commencement.scm | 7 ------- gnu/packages/cross-base.scm | 6 ------ gnu/packages/gcc.scm | 3 +++ 3 files changed, 3 insertions(+), 13 deletions(-) diff --git a/gnu/packages/commencement.scm b/gnu/packages/commencement.scm index d4511ed914..db564db9c4 100644 =2D-- a/gnu/packages/commencement.scm +++ b/gnu/packages/commencement.scm @@ -2819,13 +2819,6 @@ exec " gcc "/bin/" program "--disable-shared" "--enable-languages=3Dc,c++" =20 =2D ;; boot-triplet inserts "guix" in the triplet. =2D ,@(if (equal? "powerpc64le-guix-linux-gnu" (b= oot-triplet)) =2D ;; On POWER9 (little endian) glibc need= s the =2D ;; 128-bit long double type. =2D '("--with-long-double-128") =2D '()) =2D ;; libstdc++ cannot be built at this stage ;; ("Link tests are not allowed after ;; GCC_NO_EXECUTABLES."). diff --git a/gnu/packages/cross-base.scm b/gnu/packages/cross-base.scm index 180594509b..c1e5f2eb79 100644 =2D-- a/gnu/packages/cross-base.scm +++ b/gnu/packages/cross-base.scm @@ -153,12 +153,6 @@ base compiler and using LIBC (which may be either a li= bc package or #f.)" "--disable-decimal-float" ;would need libc "--disable-libcilkrts" =20 =2D ,@(if (string-prefix? "powerpc64le-" targe= t) =2D ;; On POWER9 (little endian) glibc ne= eds =2D ;; the 128-bit long double type. =2D '("--with-long-double-128") =2D '()) =2D ;; When target is any OS other than 'none' = these ;; libraries will fail if there is no libc ;; present. See diff --git a/gnu/packages/gcc.scm b/gnu/packages/gcc.scm index a412c93c29..22a0f35422 100644 =2D-- a/gnu/packages/gcc.scm +++ b/gnu/packages/gcc.scm @@ -79,6 +79,9 @@ where the OS part is overloaded to denote a specific ABI-= --into GCC ;; Cilk has been removed from GCC 8 anyway. '("--disable-libcilkrts")) =20 + ((string-prefix? "powerpc64le-" target) + '("--with-long-double-128")) + (else ;; TODO: Add `arm.*-gnueabi', etc. '()))) =2D-=20 2.30.2 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAmC5tTAVHGNtbWFydXNp Y2hAZ21haWwuY29tAAoJEN1AmhXYIkadI2EP/0VfqYHZTEbOxY3ATiks/2HAtT6q MF/0FvZ24nA7zvAJV+8D9tUDLK6RJYR2Ttx6Dc/awmDgTzvIebn3o2O2zgLMbZ5a rck16+7qlEpSMIei77AXma+k44mGbc1enanHgJbo3KXEOD6EE4Kn6SmOvLCh9PUZ nAqNszOpwj87geBgViFGiQ/g55Br/LdC0ajsWKT6Wjg3Rk8PztZfnJKOoqF5aUGP MS6p5FHQ7UkEIBEkKGz68TV+DlIiQ9GcyKTmpdrglmZavBubgMHMmJaapf2MAETW WBJ4ZW75/dln9qTlsiAiJJnkg9Xk4mMcF2Wihl4hG7F9z4oI08mxKeqWPMjI8sC8 AatpNYOmrmVqhHe6LTFC1XWbb7oq+CL8TqNlJUHpw6c18/MTV/gJ7PQ8lXwIO4/3 FwTwFnpa2lFpib+u0eKao1LRexfWYiYjNd4cHPOdUry2ILDtZmH17pEFmMRmuFM/ 0n4YvWwTBabnFbfCwx4dJKTS1X+JJu4wySb/HgkxlxqPLsGqkZ06GkjciRb4nP4M JKd/KL3HL14ulRd/PF0+dg8vmHOhZftTBbLpYY4vIygFfSu3HBm9187/fca0h8n6 hFaLjCtRPh5eDYepPWUm/G7jtr/U1c9gIX5pang+SlLkXaHhYkLqbgw9uT0T5qns 3LaZqRd+9tZGcg0P =8DL3 -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 06 04:14:08 2021 Received: (at submit) by debbugs.gnu.org; 6 Jun 2021 08:14:08 +0000 Received: from localhost ([127.0.0.1]:50558 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lpnv6-0001mN-Cy for submit@debbugs.gnu.org; Sun, 06 Jun 2021 04:14:08 -0400 Received: from lists.gnu.org ([209.51.188.17]:48730) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lpnv4-0001mF-7b for submit@debbugs.gnu.org; Sun, 06 Jun 2021 04:14:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58080) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lpnv4-0004HV-0O for guix-patches@gnu.org; Sun, 06 Jun 2021 04:14:06 -0400 Received: from flashner.co.il ([178.62.234.194]:53272) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lpnv1-00059j-VF for guix-patches@gnu.org; Sun, 06 Jun 2021 04:14:05 -0400 Received: from localhost (unknown [31.210.177.125]) by flashner.co.il (Postfix) with ESMTPSA id 62E45402D0; Sun, 6 Jun 2021 08:13:31 +0000 (UTC) Date: Sun, 6 Jun 2021 11:12:59 +0300 From: Efraim Flashner To: Chris Marusich Subject: Re: [PATCH] gnu: Simplify the use of --with-long-double-128 on powerpc64le. Message-ID: Mail-Followup-To: Chris Marusich , guix-patches@gnu.org References: <87o8cmtdxr.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="1dbK/XcJ4chkIrb0" Content-Disposition: inline In-Reply-To: <87o8cmtdxr.fsf@gmail.com> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Received-SPF: pass client-ip=178.62.234.194; envelope-from=efraim@flashner.co.il; helo=flashner.co.il X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --1dbK/XcJ4chkIrb0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 03, 2021 at 10:08:00PM -0700, Chris Marusich wrote: > Hi, >=20 > Currently in Guix, we explicitly specify --with-long-double-128 on > powerpc64le-linux (and potentially other powerpc64-* systems) in two > places. It turns out that this is not necessary. This patch simplifies > our code. >=20 > I originally authored this in order to try fixing bug 47698, but it > didn't solve that problem, and it turns out the --with-long-double-128 > option is probably unrelated to that bug. However, it's still worth > making this change to simplify our code. >=20 > If nobody has any issues with this, then in 2 weeks I will commit it. > One question is: where should I commit it? I'd like to commit it to > master, but it causes many rebuilds on powerpc64le-linux (it does not > cause rebuilds on any other platforms), so per the guidelines ((guix) > Submitting Patches) I ought to commit it to core-updates. However, > because the glibc upgrade from 2.31 to 2.32 on core-updates causes many > problems for powerpc64le-linux, core-updates has never once been a > viable branch for powerpc64le-linux in the time since support was first > added on master. So if I commit this patch to core-updates, it won't > really do anyone any good right now. With all this in mind, I think > master is the right place to commit this patch. >=20 > --=20 > Chris couple of thoughts: powerpc64le is in 'technology preview', so IMO it's fine to make big changes to it as needed. On master (and probably on core-updates too) we have a patch for glibc to force ... something (that I don't remember) on powerpc architectures, which has the side effect of needing '--with-long-double-128' on powerpc-linux also in commencement.scm. If we could drop that patch then I don't think we would need it anymore for powerpc. > From ad89f9f59d22cc10fbf7dd6f738ce15a6e79b640 Mon Sep 17 00:00:00 2001 > From: Chris Marusich > Date: Sat, 10 Apr 2021 18:16:17 -0700 > Subject: [PATCH] gnu: Simplify the use of --with-long-double-128 on > powerpc64le. >=20 > In short, this change adds the "--with-long-double-128" configure option = in > one place and removes it from two other (now-redundant) places. It does = not > cause any rebuilds on systems other than powerpc64le-linux. >=20 > * gnu/packages/gcc.scm (gcc-configure-flags-for-triplet): Add a clause for > targets starting with "powerpc64le-" which adds the "--with-long-double-1= 28" > option. This causes any package using this procedure to be built using t= his > new option on powerpc64le systems. In particular, this affects the gcc > package and the gcc-final package, in addition to all the other versions = of > GCC defined in (gnu packages gcc). > * gnu/packages/commencement.scm (gcc-boot0)[#:configure-flags]: Remove the > code that adds the "--with-long-double-128" configure option for powerpc6= 4le, > since it is now redundant. The gcc-boot0 package uses (and adds to) the g= cc > package's configure options. This means that the above change in gcc.scm = is > sufficient to ensure that the gcc-boot0 package's configure options will > include "--with-long-double-128" on powerpc64le systems. > * gnu/packages/cross-base.scm (cross-gcc-arguments)[#:configure-flags]: R= emove > the code that adds the "--with-long-double-128" configure option for > powerpc64le, since it is now redundant. The cross-gcc-arguments procedure > uses (and adds to) the configure options of its xgcc argument (a package). > This means that regardless of which gcc from gcc.scm is used as the xgcc,= the > above change in gcc.scm is sufficient to ensure that the cross-gcc-argume= nts > procedure's configure options will include "--with-long-double-128" on > powerpc64le systems. > --- > gnu/packages/commencement.scm | 7 ------- > gnu/packages/cross-base.scm | 6 ------ > gnu/packages/gcc.scm | 3 +++ > 3 files changed, 3 insertions(+), 13 deletions(-) >=20 > diff --git a/gnu/packages/commencement.scm b/gnu/packages/commencement.scm > index d4511ed914..db564db9c4 100644 > --- a/gnu/packages/commencement.scm > +++ b/gnu/packages/commencement.scm > @@ -2819,13 +2819,6 @@ exec " gcc "/bin/" program > "--disable-shared" > "--enable-languages=3Dc,c++" > =20 I've adjusted this on core-updates to also take effect on powerpc-linux. > - ;; boot-triplet inserts "guix" in the triplet. > - ,@(if (equal? "powerpc64le-guix-linux-gnu" (b= oot-triplet)) > - ;; On POWER9 (little endian) glibc need= s the > - ;; 128-bit long double type. > - '("--with-long-double-128") > - '()) > - > ;; libstdc++ cannot be built at this stage > ;; ("Link tests are not allowed after > ;; GCC_NO_EXECUTABLES."). > diff --git a/gnu/packages/cross-base.scm b/gnu/packages/cross-base.scm > index 180594509b..c1e5f2eb79 100644 > --- a/gnu/packages/cross-base.scm > +++ b/gnu/packages/cross-base.scm > @@ -153,12 +153,6 @@ base compiler and using LIBC (which may be either a = libc package or #f.)" > "--disable-decimal-float" ;would need libc > "--disable-libcilkrts" > =20 > - ,@(if (string-prefix? "powerpc64le-" targe= t) > - ;; On POWER9 (little endian) glibc ne= eds > - ;; the 128-bit long double type. > - '("--with-long-double-128") > - '()) > - > ;; When target is any OS other than 'none= ' these > ;; libraries will fail if there is no libc > ;; present. See > diff --git a/gnu/packages/gcc.scm b/gnu/packages/gcc.scm > index a412c93c29..22a0f35422 100644 > --- a/gnu/packages/gcc.scm > +++ b/gnu/packages/gcc.scm > @@ -79,6 +79,9 @@ where the OS part is overloaded to denote a specific AB= I---into GCC > ;; Cilk has been removed from GCC 8 anyway. > '("--disable-libcilkrts")) > =20 This can be just 'powerpc64le' > + ((string-prefix? "powerpc64le-" target) > + '("--with-long-double-128")) > + > (else > ;; TODO: Add `arm.*-gnueabi', etc. > '()))) > --=20 > 2.30.2 >=20 --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --1dbK/XcJ4chkIrb0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmC8g4oACgkQQarn3Mo9 g1E7pw/7BNfd7Pc5XiUhOOWmXpvJhLj0IREfH8ysn+YFdJtj0vZMfkWtv1Q+vhHZ G6t/QPn+2vJGDK9DvWNmruWCtkeYsKiY/EwWmJ/VikcKJ5QdqQkcCrnZpFrQEyfR LIcMo1wMqCWeiRglziGsN+Hx5lys9L3BkBN7qa9ndN1tDW6VwRpe6NKJ5HN/xnCC tOgkjjWfuoAZtiSn/TgMWFYcaBUMDxawan51wxxEqQDW9md9OtDDZRT4IKJi4xt+ ERifbsbZzMluUfYJFln2anEz258UT8fb+5tsieL1FP1iOImmSDa8YHME+ctlsZmz J9sZE0tMdmtxIlEzftmTTwwcVam6F0PjHl0zNXBriVKnw/KRxHehzBzgWEKqiL2H qIRDgqAvDNjtdeHWaoQwSgTZx2MXfkY7/6NDUUrIzHMqofZ+XTsZkyigoV8lzX1U w1ReyIeWAjZjRItEGz5g2aSpiNBUyPyJvGgdIskptuVNYhJuXBdlQ/yu7OOBPR4N Gs6skeWrZE9THAy4PxfhU4oqB5WjxuMyZCpzvCv12dPY3fJvbaShSlJ3hRBgnLv0 ambxOF1BqNdv3xSgDwTkYfIxtksfYaMNygJ84qYcSQ+gbXoqnAMHkyawGLHzMjqa FaVRhewitD3YGymE18KrFxxXehyxixHU5r2zARdnKdDYO61S5QA= =HX/K -----END PGP SIGNATURE----- --1dbK/XcJ4chkIrb0-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 18 14:49:29 2021 Received: (at submit) by debbugs.gnu.org; 18 Jun 2021 18:49:29 +0000 Received: from localhost ([127.0.0.1]:58197 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luJYX-00077c-7l for submit@debbugs.gnu.org; Fri, 18 Jun 2021 14:49:29 -0400 Received: from lists.gnu.org ([209.51.188.17]:40602) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luJYU-00077U-Oa for submit@debbugs.gnu.org; Fri, 18 Jun 2021 14:49:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52546) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1luJYU-0003vX-DU for guix-patches@gnu.org; Fri, 18 Jun 2021 14:49:26 -0400 Received: from mail-pf1-x435.google.com ([2607:f8b0:4864:20::435]:44580) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1luJYO-0001oZ-PY for guix-patches@gnu.org; Fri, 18 Jun 2021 14:49:26 -0400 Received: by mail-pf1-x435.google.com with SMTP id u18so2978775pfk.11 for ; Fri, 18 Jun 2021 11:49:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:references:date:in-reply-to:message-id:user-agent :mime-version; bh=urIk26l5aus6h6aep3LzmE4Gje+6sPhYvnX+ZJ623qA=; b=QL+TTdgPaC53zUZid4HU052X2ax/9dBvF62RU0+tiz1duOoXFQB4t8YdGMgpxOzjam CkaTelZR8c8oYQoL4JK19T2BfEvZ7YNA9b2nrdcajTx561Epx6qLC65MGQ53Aa3QdRxT AaOhMBaqu7t9zzmSs6m/hrxEUZ1fun5iDSmZm1hBeI8+7VDCYMPjhG80C7KRFIh2xpIT P3pW8LNp1uvmzpOU1f5zK/9Mot9I/lI2L/qSij+AM/0dQRj5vtRuGzSfcFKHPb0gg1+v TFF3R6Mh+aYyO1OZCQsuDBTRl9GhCaNfdopjxAUeReeqwhqlNOUWdXVzMg2/TFEKAx9F F16A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=urIk26l5aus6h6aep3LzmE4Gje+6sPhYvnX+ZJ623qA=; b=cKfGSIf90CEK+1C3dqzkYjDrEcWJFbAQmm5v0G1Mj4ml4NiGDMQneFrCZc/ocanQ2P bLEu6nkey4veKYLrETC1NHAKaDM0WEhg3fTfFFG8DGcigXW4A0U8M6yWUZnxSKpVasVN XW1ASXKzjJocDk39h82FD3YnFSPjyxPJoBsdVKpBFyGdmoKye0E2LxTnXZTZ0IfR7DmL v7LLpHuEeiq8i81bTq7aPSNeLnzZKPWGpFSbkeNbrNC95ZhoAKhSSbpe0TD4DmVWPoak JRMPjmUGPuPZYhL9LHVxQli30DQQ17WbOeH4sQczQ9clCYrRDN4dy8BMNgo4kq2QjEOI qVOA== X-Gm-Message-State: AOAM5309CtNy5WhBj1y23ZnCRDTmrT5dQ3WAz7gqDKSzyXxGVJjjyLrw ShwVltDljc+MeaZELLtA0eFKUeh0Wo//eA== X-Google-Smtp-Source: ABdhPJx+ctUJbHKxwwKvvcmmFic0mhuvztNJRP4s0xgH//7kBAjqvVUIAfd+sY8/t2bh+7Op7YFWOA== X-Received: by 2002:a62:27c5:0:b029:2f7:d4e3:7f2d with SMTP id n188-20020a6227c50000b02902f7d4e37f2dmr6405754pfn.59.1624042158793; Fri, 18 Jun 2021 11:49:18 -0700 (PDT) Received: from garuda-lan ([2601:601:9d01:3f90::24aa]) by smtp.gmail.com with ESMTPSA id n33sm2377967pgm.55.2021.06.18.11.49.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Jun 2021 11:49:17 -0700 (PDT) From: Chris Marusich To: guix-patches@gnu.org Subject: Re: bug#48825: [PATCH] gnu: Simplify the use of --with-long-double-128 on powerpc64le. References: <87o8cmtdxr.fsf@gmail.com> Date: Fri, 18 Jun 2021 11:49:13 -0700 In-Reply-To: (Efraim Flashner's message of "Sun, 6 Jun 2021 11:12:59 +0300") Message-ID: <87k0mr6mae.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Received-SPF: pass client-ip=2607:f8b0:4864:20::435; envelope-from=cmmarusich@gmail.com; helo=mail-pf1-x435.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Efraim, Efraim Flashner writes: > couple of thoughts: > powerpc64le is in 'technology preview', so IMO it's fine to make big > changes to it as needed. That's true, but since we now have a stable place from which to work (master), I feel less concerned about getting changes into master. I thought about this again now, and I think I will plan to push this change to core-updates instead of master. > On master (and probably on core-updates too) we have a patch for glibc > to force ... something (that I don't remember) on powerpc architectures, > which has the side effect of needing '--with-long-double-128' on > powerpc-linux also in commencement.scm. If we could drop that patch then > I don't think we would need it anymore for powerpc. I'm not sure what change this would be, but if you ever figure it out, please do let me know! >> diff --git a/gnu/packages/commencement.scm b/gnu/packages/commencement.s= cm >> index d4511ed914..db564db9c4 100644 >> --- a/gnu/packages/commencement.scm >> +++ b/gnu/packages/commencement.scm >> @@ -2819,13 +2819,6 @@ exec " gcc "/bin/" program >> "--disable-shared" >> "--enable-languages=3Dc,c++" >>=20=20 > > I've adjusted this on core-updates to also take effect on powerpc-linux. Thank you for mentioning this. In light of your change, I needed to modify my patch. I've attached a new patch which takes powerpc into account. I modified the commit message a bit, too. I'm confident the attached patch is correct for powerpc64le-linux, but if you could take a peek and make sure I didn't miss something related to powerpc, I would appreciate it! > This can be just 'powerpc64le' When checking the string prefix, that does probably work for little endian powerpc 64, since I don't think there are any other architectures that start with "powerpc64le". However, if you did something similar for powerpc (like in your change on core-updates), please keep in mind that it will affect not only powerpc64le, but also big-endian powerpc64, and any other powerpc architecture. For that reason, I personally prefer to keep the hyphen when I have a specific architecture in mind. =2D-=20 Chris --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-gnu-Simplify-the-use-of-with-long-double-128.patch Content-Transfer-Encoding: quoted-printable Content-Description: [PATCH] gnu: Simplify the use of --with-long-double-128. From=201d6043ea33236a7f35f990935e457ef440b365c4 Mon Sep 17 00:00:00 2001 From: Chris Marusich Date: Fri, 18 Jun 2021 11:26:31 -0700 Subject: [PATCH] gnu: Simplify the use of --with-long-double-128. In short, this change adds the hard-coded "--with-long-double-128" configure option in one place and removes it from two other places. This changes and simplifies the use of this option for various architectures that start with the string "powerpc". * gnu/packages/gcc.scm (gcc-configure-flags-for-triplet): Add a clause for targets starting with "powerpc64le-" or "powerpc-" which adds the "--with-long-double-128" option. This causes any package using this proced= ure to be built using this new option on these architectures. In particular, t= his affects the gcc package and the gcc-final package, in addition to all the other versions of GCC defined in (gnu packages gcc). * gnu/packages/commencement.scm (gcc-boot0)[#:configure-flags]: Remove the code that adds the "--with-long-double-128" configure option for all architectures starting with "powerpc", since it is now redundant on the architectures where it is needed. The gcc-boot0 package uses (and adds to) = the gcc package's configure options. This means that the above change in gcc.scm is sufficient to ensure that the gcc-boot0 package's configure options will include "--with-long-double-128" on powerpc64le and powerpc architectures. Additionally, since the option is apparently not required on the big-endian powerpc64 architecture, this change also has the nice effect of omitting the option in that case. * gnu/packages/cross-base.scm (cross-gcc-arguments)[#:configure-flags]: Rem= ove the code that adds the "--with-long-double-128" configure option for powerpc64le, since it is now redundant. The cross-gcc-arguments procedure u= ses (and adds to) the configure options of its xgcc argument (a package). This means that regardless of which gcc from gcc.scm is used as the xgcc, the ab= ove change in gcc.scm is sufficient to ensure that the cross-gcc-arguments procedure's configure options will include "--with-long-double-128" on the powerpc64le and powerpc architectures. =2D-- gnu/packages/commencement.scm | 7 ------- gnu/packages/cross-base.scm | 6 ------ gnu/packages/gcc.scm | 5 +++++ 3 files changed, 5 insertions(+), 13 deletions(-) diff --git a/gnu/packages/commencement.scm b/gnu/packages/commencement.scm index d44d1dd3ca..af61512129 100644 =2D-- a/gnu/packages/commencement.scm +++ b/gnu/packages/commencement.scm @@ -2733,13 +2733,6 @@ exec " gcc "/bin/" program "--disable-shared" "--enable-languages=3Dc,c++" =20 =2D ;; On POWER9 (little endian) glibc needs the = 128-bit =2D ;; long double type. 32-bit PPC is affected = by the =2D ;; changes applied for powerpc64le. =2D ,@(if (string-prefix? "powerpc" (boot-triplet= )) =2D '("--with-long-double-128") =2D '()) =2D ;; libstdc++ cannot be built at this stage ;; ("Link tests are not allowed after ;; GCC_NO_EXECUTABLES."). diff --git a/gnu/packages/cross-base.scm b/gnu/packages/cross-base.scm index 926b00ccdf..ced226ef34 100644 =2D-- a/gnu/packages/cross-base.scm +++ b/gnu/packages/cross-base.scm @@ -153,12 +153,6 @@ base compiler and using LIBC (which may be either a li= bc package or #f.)" "--disable-decimal-float" ;would need libc "--disable-libcilkrts" =20 =2D ,@(if (string-prefix? "powerpc64le-" targe= t) =2D ;; On POWER9 (little endian) glibc ne= eds =2D ;; the 128-bit long double type. =2D '("--with-long-double-128") =2D '()) =2D ;; When target is any OS other than 'none' = these ;; libraries will fail if there is no libc ;; present. See diff --git a/gnu/packages/gcc.scm b/gnu/packages/gcc.scm index 5d114dca87..31c7997fd0 100644 =2D-- a/gnu/packages/gcc.scm +++ b/gnu/packages/gcc.scm @@ -79,6 +79,11 @@ where the OS part is overloaded to denote a specific ABI= ---into GCC ;; Cilk has been removed from GCC 8 anyway. '("--disable-libcilkrts")) =20 + ;; glibc needs the 128-bit long double type on these architectures. + ((or (string-prefix? "powerpc64le-" target) + (string-prefix? "powerpc-" target)) + '("--with-long-double-128")) + (else ;; TODO: Add `arm.*-gnueabi', etc. '()))) =2D-=20 2.30.2 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAmDM6qkVHGNtbWFydXNp Y2hAZ21haWwuY29tAAoJEN1AmhXYIkadSw0P/AuqjFz9h5WAYLVOidcUzAAPoTz8 67Ub4YaOgCTpxP4MAavhdKtJgB64D4hxywTwWCmoSkszyUD9hINyMq8jyHp615yI yDas4Sj+9iyLukiERJ0nNUFhvJjRfdc9YkzNu2T+vL30KMH6nGl51Hn77E/x8oUl WmP9g3B9rYIeDncbfVIuJGrsGwNpo1JeZ+1cLow118yS/UGs42NK2uKblcAUcudc kz+eExso9En+6hPsZc2M1Fq5ol3eyq7tpltl4yfaEZW7o+SFtSPMsNFmLlcE3aAW 4fOH4bqI675dTOXj6qLX/vXnmRCcn7r5k4lge4BgJIu59eQC/u2LSiSL6WlvbhPm A9I+JQ3bfkGX6982w4kJgTxKq2Eyuv47Xr6FsJlnD6n2PLCaUdUubNXRQuOnZdOh WhKWHjBjjgB6DqRnk5AccX9u5gxYLZd6Ngej0us2B/290OHjmiqH562Qq4nsV2X8 daDMvHaI87nBpxAuxNg9k4jK7hf54fp52PDCsBLem1K1czvyVxsF1YuBijn4CJst UgyAZ/uKgW2ED6J+LqlC3QOocDsmTKdBDp8DG72jTC/uI2AbIeF31nns0uI5PoOS YJxDGvbqgodQR+xbYsG/tjX/glGVUCugIYNVoOg+E+Ye1VjHpfnwpLxebHRD3G4o 69wxTtiaV9iVZEIT =cGTn -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 24 23:47:36 2021 Received: (at 48825-close) by debbugs.gnu.org; 25 Jun 2021 03:47:36 +0000 Received: from localhost ([127.0.0.1]:44431 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lwcoa-0007H4-GW for submit@debbugs.gnu.org; Thu, 24 Jun 2021 23:47:36 -0400 Received: from mail-pj1-f49.google.com ([209.85.216.49]:55822) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lwcoX-0007Gl-7e for 48825-close@debbugs.gnu.org; Thu, 24 Jun 2021 23:47:35 -0400 Received: by mail-pj1-f49.google.com with SMTP id l11so4674392pji.5 for <48825-close@debbugs.gnu.org>; Thu, 24 Jun 2021 20:47:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:references:date:in-reply-to:message-id:user-agent :mime-version; bh=QtyyBYc6RRZNXw7WoDnQz76iW2fr6ho1HwN/63Uz7uQ=; b=nu8dxgkCBv3exxI8eJAjuKvcDr2wLoi0LT2ZijYz4zfLKZQ/3kO/TjLGRZVnSd47zF iHrZ62o9Bcb5+YiWXb+Wg5hRxZBilN2oRz2h7rzhLzFIc33no3Ld31kI2vvoSrWdj09u 0zTUYkvLT5FVnz7vDZyCEQGmIIUhVNiyQ82mfCXvhDV1BffG2ntTTitQkQv9pp++lym4 OfQkxtr6fWzC0PW/GYMPGmI/J4NNrIx3Oe6EAf4fIoybDeXassYJ2ffWAtvNyterNFbv MjOk/d26IgNASwH7R15xB9NHfmkSiYoZ3et3MKS+h8iObv1oHGANCLo1IWpf42/xZzd4 Tt4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=QtyyBYc6RRZNXw7WoDnQz76iW2fr6ho1HwN/63Uz7uQ=; b=NlxgEg0ZnpfFQojFRUZMRJfBiBnDbYJj5B2CpJXC+HeCIQ/+ZV567SnxRYrsZYU0we aVzTSh2EjRIin6hqsHZPfWQfc+KgXm/DLQCOK87grJylwdWLKvvA/cBBwEhrQL4h9D6Q h1S9mxWoZ4Iik2N73G6/Zvm9VCwkC1e6kPi7Kl0nVmq2yzD5MpxTmE82L/F/m02n7dZH 0/svUaEnnKXa6i0/5E0pOZ9jVVyV/gBcoIC6tiWiCIGGEEdvROwoM3ECl3gS2KXYjeaS W+qzTRkVYtGMjvz25Z6G89wDEgXH3joajrYC500PbMCCNMpO9CNzXwZCLtD+/qnfcbzK reww== X-Gm-Message-State: AOAM532a5zvJDxDtufsImeAtFuDUSgH5HxBx9cqsGV0BTJax2+ErqA09 j8Tjh1gUoPVG+rPlgDKGZ+qK2NOOJxqRtg== X-Google-Smtp-Source: ABdhPJwugRmq9yg6GIEjWI95vIcWc6HoEekn4AHs2AIK+O4qGN19vjU1/4Zvr4t+EzEPUz5Jdjy50w== X-Received: by 2002:a17:90b:8cc:: with SMTP id ds12mr8988326pjb.36.1624592847061; Thu, 24 Jun 2021 20:47:27 -0700 (PDT) Received: from garuda-lan ([2601:601:9d01:3f90::24aa]) by smtp.gmail.com with ESMTPSA id k63sm9203676pjh.13.2021.06.24.20.47.25 for <48825-close@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Jun 2021 20:47:25 -0700 (PDT) From: Chris Marusich To: 48825-close@debbugs.gnu.org Subject: Re: bug#48825: [PATCH] gnu: Simplify the use of --with-long-double-128 on powerpc64le. References: <87o8cmtdxr.fsf@gmail.com> <87k0mr6mae.fsf_-_@gmail.com> Date: Thu, 24 Jun 2021 20:47:24 -0700 In-Reply-To: <87k0mr6mae.fsf_-_@gmail.com> (Chris Marusich's message of "Fri, 18 Jun 2021 11:49:13 -0700") Message-ID: <874kdma9mb.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 48825-close X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Committed in 45dd2b4505095d24e253bd62d74474cad135cf3b. =2D-=20 Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAmDVUcwVHGNtbWFydXNp Y2hAZ21haWwuY29tAAoJEN1AmhXYIkadtngP/33WF8gmDA6yACX3n4eXX0BJdSnb GwiAFEDedsV98bo5hjNdRHWVo45paNzVMwByA2KzQXMB1ZcBaXVTPp6c8Ojs56V7 xRYo9bJ9LL51HKh1W0gBYBqiDMw4J1MK4SkobIgldIudALzV2aFyGYelk+gLQLds WQ2eaPSnOlES12rL3YPeMSXx6OBE4qRr8jfIqT7WwSPxgVuf46+w7vQZAfHAyLMS GAGKDyY67rvxjCeOIN9DeiYOEqZGAPWLNhOMNLy3c1cUX7BMk0XaaoI+i3pSL+e+ Ijnm7KPfrd77utY22V9iDXzGOo4B5fleeV0Vc7eNc+HgnMd+WdGgMIOCy+HQC/Z9 a1cPmFPH6tC/PD4eNoflmQwYG8atGjCK6tg3Ge8A84q6Ih22W8qNSF6qqKkpEQId Y5ta1f+kIqM84nocEYn5dr3QdmjOtuP+kH3sQFdSdTQjFQbIBMAfMWxkTjfpjvOb p7xfx83r2C0I43PLQUupy1t1eMrQ1hfzrphGdulFKXZvsEnZH1euc+MNsGqjxw1D 2tVS3lwrEOxJYQAVruLjgR+VFRMo5DR88PApYgJEbTk+c1eJKSH8XHh7n9MwZTzj vPWczhbNFBf1MZQrQpDwYXsRAvXC3PlJNnFusm5k6XnjlqsYCC39USquvwfNJPSk kqgU6Nb47jZkFumN =GSwF -----END PGP SIGNATURE----- --=-=-=-- From unknown Wed Jun 18 00:27:03 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 23 Jul 2021 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator