GNU bug report logs - #48817
[PATCH] gnu: Add emacs-kibit-helper.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#48817: closed ([PATCH] gnu: Add emacs-kibit-helper.)
Date: Sat, 05 Jun 2021 11:53:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 05 Jun 2021 13:52:33 +0200
with message-id <87a6o4edfi.fsf <at> nicolasgoaziou.fr>
and subject line Re: [bug#48817] [PATCH] gnu: Add emacs-kibit-helper.
has caused the debbugs.gnu.org bug report #48817,
regarding [PATCH] gnu: Add emacs-kibit-helper.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
48817: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=48817
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Alexandr Vityazev <avityazev <at> posteo.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add emacs-kibit-helper.
Date: Thu, 03 Jun 2021 20:39:32 +0000

* gnu/packages/emacs-xyz.scm (emacs-kibit-helper): New variable.
---
 gnu/packages/emacs-xyz.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index d145e8e16b..7d985c0d0f 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -28244,3 +28244,31 @@ shorter than usual, using mostly unprefixed keys.")
    (description "@code{emacs-multitran} is a zero-dependency Emacs interface
 to the https://multitran.com online dictionary.")
    (license license:gpl3+)))
+
+(define-public emacs-kibit-helper
+  (let ((version "0.1.1")
+        (revision "0")
+        (commit "16bdfff785ee05d8e74a5780f6808506d990cef7"))
+    (package
+      (name "emacs-kibit-helper")
+      (version (git-version version revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/brunchboy/kibit-helper")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "0s2hb2lvfmcvm3n1fg4biaafc1p7j7w990d7w15gicaw6rr2j4nr"))))
+      (build-system emacs-build-system)
+      (propagated-inputs `(("emacs-s" ,emacs-s)))
+      (home-page
+       "http://www.github.com/brunchboy/kibit-helper")
+      (synopsis
+       "Conveniently use the Kibit Leiningen plugin from Emacs")
+      (description
+       "Provides functions that make it easy to work with the Kibit
+Leiningen plugin for detecting and improving non-idiomatic
+Clojure source code, from within GNU Emacs. ")
+      (license license:gpl3+))))
-- 
2.31.1



-- 

Alexandr Vityazev

[Message part 3 (message/rfc822, inline)]

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Alexandr Vityazev <avityazev <at> posteo.org>
Cc: 48817-done <at> debbugs.gnu.org
Subject: Re: [bug#48817] [PATCH] gnu: Add emacs-kibit-helper.
Date: Sat, 05 Jun 2021 13:52:33 +0200

Hello,

Alexandr Vityazev <avityazev <at> posteo.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-kibit-helper): New variable.

Thank you. I applied your patch, with the changes mentioned below. 

> +(define-public emacs-kibit-helper
> +  (let ((version "0.1.1")
> +        (revision "0")
> +        (commit "16bdfff785ee05d8e74a5780f6808506d990cef7"))

I targeted exact "0.1.1" release instead.  The commit you use is just
three commits above it, which only apply to the README file.

> +      (synopsis
> +       "Conveniently use the Kibit Leiningen plugin from Emacs")

I removed the "conveniently" buzzword.

> +      (description
> +       "Provides functions that make it easy to work with the Kibit
> +Leiningen plugin for detecting and improving non-idiomatic
> +Clojure source code, from within GNU Emacs. ")

The description must use full sentences, so I reworded it a bit. Also,
there was a trailing white space at its end.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.