GNU bug report logs - #48810
[PATCH] gnu: Add matterbridge.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 48810 in the body.
You can then email your comments to 48810 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
To: guix-patches <at> gnu.org
Cc: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
Subject: [PATCH] gnu: Add matterbridge.
Date: Thu,  3 Jun 2021 15:22:31 +0200

* gnu/packages/messaging.scm (matterbridge): New variable.

Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
---
 gnu/packages/messaging.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index b326b68952..8554f9230a 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -28,6 +28,7 @@
 ;;; Copyright © 2020 Raghav Gururajan <raghavgururajan <at> disroot.org>
 ;;; Copyright © 2020, 2021 Robert Karszniewicz <avoidr <at> posteo.de>
 ;;; Copyright © 2020 Giacomo Leidi <goodoldpaul <at> autistici.org>
+;;; Copyright © 2021 Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -123,6 +124,7 @@
   #:use-module (gnu packages xml)
   #:use-module (gnu packages xorg)
   #:use-module (guix build-system cmake)
+  #:use-module (guix build-system go)
   #:use-module (guix build-system glib-or-gtk)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system meson)
@@ -2967,4 +2969,30 @@ designed for experienced users.")
     (description "This package contains Zulip's official terminal client.")
     (license license:asl2.0)))
 
+(define-public matterbridge
+  (package
+    (name "matterbridge")
+    (version "1.22.2")
+    (source
+     (origin
+      (method url-fetch)
+      (uri
+       (string-append
+        "https://github.com/42wim/matterbridge/archive/v" version ".tar.gz"))
+      (sha256
+       (base32
+        "1p3mkfzv4xwm7vz8ja7qsa99qwxb9s61hnjjv65dkkjivlsif5hk"))))
+    (build-system go-build-system)
+    (arguments
+     `(#:import-path "github.com/42wim/matterbridge"
+       #:unpack-path "github.com/42wim/matterbridge"))
+    (synopsis "Bridge together channels from various messaging networks and protocols")
+    (description "Relays messages between different channels from various
+messaging networks and protocols.  So far it supports mattermost, IRC, gitter,
+xmpp, slack, discord, telegram, rocketchat, twitch, ssh-chat, zulip, whatsapp,
+keybase, matrix, microsoft teams, nextcloud, mumble, vk and more with REST API.
+Mattermost is not required.")
+    (home-page "https://github.com/42wim/matterbridge")
+    (license license:asl2.0)))
+
 ;;; messaging.scm ends here
-- 
2.31.1

Message #8 received at 48810 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
Cc: 48810 <at> debbugs.gnu.org
Subject: Re: bug#48810: [PATCH] gnu: Add matterbridge.
Date: Fri, 04 Jun 2021 14:07:50 +0200

Hello,

The linter reports two problems:

--8<---------------cut here---------------start------------->8---
gnu/packages/messaging.scm:2977:5: matterbridge <at> 1.22.2: the source file name should contain the package name
gnu/packages/messaging.scm:2977:5: matterbridge <at> 1.22.2: the source URI should not be an autogenerated tarball
--8<---------------cut here---------------end--------------->8---

which means that you should use:

> +      (method url-fetch)

git-fetch here,

> +      (sha256
> +       (base32
> +        "1p3mkfzv4xwm7vz8ja7qsa99qwxb9s61hnjjv65dkkjivlsif5hk"))))

and introduce something like:

--8<---------------cut here---------------start------------->8---
       (file-name (git-file-name name version))
--8<---------------cut here---------------end--------------->8---

here. Could you please send an updated patch?

Thanks,

Mathieu

Message #11 received at 48810 <at> debbugs.gnu.org (full text, mbox):

From: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
To: othacehe <at> gnu.org
Cc: 48810 <at> debbugs.gnu.org, Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
Subject: [PATCH v2] gnu: Add matterbridge.
Date: Fri,  4 Jun 2021 18:11:41 +0200

* gnu/packages/messaging.scm (matterbridge): New variable.

Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
---
 gnu/packages/messaging.scm | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 96cbf95fe9..021888cfae 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -28,6 +28,7 @@
 ;;; Copyright © 2020 Raghav Gururajan <raghavgururajan <at> disroot.org>
 ;;; Copyright © 2020, 2021 Robert Karszniewicz <avoidr <at> posteo.de>
 ;;; Copyright © 2020 Giacomo Leidi <goodoldpaul <at> autistici.org>
+;;; Copyright © 2021 Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -123,6 +124,7 @@
   #:use-module (gnu packages xml)
   #:use-module (gnu packages xorg)
   #:use-module (guix build-system cmake)
+  #:use-module (guix build-system go)
   #:use-module (guix build-system glib-or-gtk)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system meson)
@@ -2967,4 +2969,31 @@ designed for experienced users.")
     (description "This package contains Zulip's official terminal client.")
     (license license:asl2.0)))
 
+(define-public matterbridge
+  (package
+    (name "matterbridge")
+    (version "1.22.2")
+    (source
+     (origin
+      (method git-fetch)
+      (uri (git-reference
+            (url "https://github.com/42wim/matterbridge")
+            (commit (string-append "v" version))))
+      (file-name (git-file-name name version))
+      (sha256
+       (base32
+        "07rgdc4v043fhzsalmlhickqizk6xjlpjkzn6l5v9ryp5gmv580z"))))
+    (build-system go-build-system)
+    (arguments
+     `(#:import-path "github.com/42wim/matterbridge"
+       #:unpack-path "github.com/42wim/matterbridge"))
+    (synopsis "Bridge together channels from various messaging networks and protocols")
+    (description "Relays messages between different channels from various
+messaging networks and protocols.  So far it supports mattermost, IRC, gitter,
+xmpp, slack, discord, telegram, rocketchat, twitch, ssh-chat, zulip, whatsapp,
+keybase, matrix, microsoft teams, nextcloud, mumble, vk and more with REST API.
+Mattermost is not required.")
+    (home-page "https://github.com/42wim/matterbridge")
+    (license license:asl2.0)))
+
 ;;; messaging.scm ends here
-- 
2.31.1

Message #14 received at 48810 <at> debbugs.gnu.org (full text, mbox):

From: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: 48810 <at> debbugs.gnu.org
Subject: Re: bug#48810: [PATCH] gnu: Add matterbridge.
Date: Fri, 4 Jun 2021 18:16:02 +0200

[Message part 1 (text/plain, inline)]

On Fri, 04 Jun 2021 14:07:50 +0200
Mathieu Othacehe <othacehe <at> gnu.org> wrote:

> Hello,
Hi,

> The linter reports two problems:
> 
> --8<---------------cut here---------------start------------->8---
> gnu/packages/messaging.scm:2977:5: matterbridge <at> 1.22.2: the source
> file name should contain the package name
> gnu/packages/messaging.scm:2977:5: matterbridge <at> 1.22.2: the source
> URI should not be an autogenerated tarball --8<---------------cut
> here---------------end--------------->8---
>
> which means that you should use:
> 
> > +      (method url-fetch)
> 
> git-fetch here,
> 
> > +      (sha256
> > +       (base32
> > +        "1p3mkfzv4xwm7vz8ja7qsa99qwxb9s61hnjjv65dkkjivlsif5hk"))))
> 
> and introduce something like:
> 
> --8<---------------cut here---------------start------------->8---
>        (file-name (git-file-name name version))
> --8<---------------cut here---------------end--------------->8---
Thanks a lot.

I've seen these warnings but I ignored thinking I couldn't fix it as I
didn't find any alternate files for the releases.

I've now sent an updated version.

By the way, I don't know much about go, and I'm pretty new to Guix, so
I did this package through trial and error and also looking at how
things were done in Parabola (through the Arch Linux Community
repository where the matterbridge package comes from).

And the Submitting Patches section of the manual[1] has the following:
> Make sure the package does not use bundled copies of software
> already available as separate packages. 

Here I'm unsure of what is being done under the hood, but at least
Parabola / Arch Linux don't seem to do anything special with that.

In any case I've already started deploying a matterbridge service by
using this package (with Guix pack) and a modified systemd service
file from Arch Linux on top of Trisquel 9 to bridge several IRC
channels, and so far it worked fine.

References:
-----------
[1]https://guix.gnu.org/manual/en/guix.html#Submitting-Patches 

Denis.

[Message part 2 (application/pgp-signature, inline)]

Message #19 received at 48810-done <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
Cc: 48810-done <at> debbugs.gnu.org
Subject: Re: [PATCH v2] gnu: Add matterbridge.
Date: Sun, 06 Jun 2021 18:34:48 +0200

Hello Denis,

> * gnu/packages/messaging.scm (matterbridge): New variable.

Thanks for this new version. I fixed the indentation, edited a bit the
synopsis and description and pushed as
3c401ca6df385b737363e5caea7396d3aa55863f.

Thanks,

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.