Subject: [bug#48767] [PATCH 5/6] gnu: Add gdb-msp430.

From: Maxime Devos <[email-masked]>
Date: Sun, 26 Sep 2021 18:16:14 +0200

[email-masked] schreef op zo 26-09-2021 om 10:51 [-0400]:
> From: Morgan Smith <[email-masked]>
> 
> * gnu/packages/embedded.scm (gdb-msp430): New variable.
> ---
>  gnu/packages/embedded.scm | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/gnu/packages/embedded.scm b/gnu/packages/embedded.scm
> index 8401f68542..f79092de72 100644
> --- a/gnu/packages/embedded.scm
> +++ b/gnu/packages/embedded.scm
> @@ -636,6 +636,17 @@ The supported programming language is C.")
>  (define-public msp430-toolchain
>    (make-msp430-toolchain gcc-msp430 newlib-msp430))
>  
> +(define-public gdb-msp430
> +  (package
> +    (inherit gdb)
> +    (name "gdb-msp430")
> +    (arguments
> +     `(#:configure-flags '("--target=msp430-elf"
> +                           "--enable-languages=c,c++"
> +                           "--disable-nls"
> +                           "--enable-initfini-array")
> +       ,@(package-arguments gdb)))))

It would be more future-proof to use 'substitute-keyword-arguments' here,
as possibly a future package definition of 'gdb' could set #:configure-flags.

It would also be nice to adjust the description and synopsis a bit.
Maybe something like

 (synopsis "The GNU debugger for remotely debugging msp430 systems")
 (description "This is the GNU debugger, configured for debugging msp430 systems
from a system of another architecture.")

and add to the description of 'gdb' something like

 "This variant of the GNU debugger only supports debugging programs compiled for
the same architecture as the GNU debugger runs on.  For remote debugging, the
variants @code{gdb-msp430} or @code{gdb-arm-none-eabi} may be required."

(Assuming that's correct.)  (These descriptions could be improved.)

Greetings,
Maxime.