GNU bug report logs - #48683
28.0.50; [PATCH] Feature suggestion gnus-summary-toggle-mark-as-processable

Previous Next

Full log

Message #44 received at 48683 <at> debbugs.gnu.org (full text, mbox):

From: Alex Bochannek <alex <at> bochannek.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 48683 <at> debbugs.gnu.org
Subject: Re: bug#48683: 28.0.50; [PATCH] Feature suggestion
 gnus-summary-toggle-mark-as-processable
Date: Tue, 01 Jun 2021 08:57:05 -0700

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Alex Bochannek <alex <at> bochannek.com> writes:
>
>>> It seems like many people would prefer to have the `#' command be a
>>> toggle.  Perhaps we should just add a user option to have `#' toggle or
>>> not?  (Defaulting to "not toggle" for backwards compatibility.)
>>
>> How about something like this?
>
> Looks good.  Some small comments:
>
>> +(defcustom gnus-summary-process-mark-toggle nil
>
> Perhaps this should be gnus-process-mark-toggle and also work in the
> Group buffer?

That makes sense and I can look at that. I have not dug into the
differences between group and topic mode, but I hope they are similar
enough.

>> +		(if (eq t unmark)
>> +		    (gnus-summary-remove-process-mark article)
>> +		  (if (eq t gnus-summary-process-mark-toggle)
>
> We shouldn't check against t in either of these cases -- any non-nil
> value is valid.

Good point, thank you!

-- 
Alex.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.