GNU bug report logs - #48683
28.0.50; [PATCH] Feature suggestion gnus-summary-toggle-mark-as-processable

Previous Next

Full log

View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Alex Bochannek <alex <at> bochannek.com>
Cc: 48683 <at> debbugs.gnu.org
Subject: bug#48683: 28.0.50; [PATCH] Feature suggestion gnus-summary-toggle-mark-as-processable
Date: Tue, 01 Jun 2021 08:23:00 +0200

Alex Bochannek <alex <at> bochannek.com> writes:

>> It seems like many people would prefer to have the `#' command be a
>> toggle.  Perhaps we should just add a user option to have `#' toggle or
>> not?  (Defaulting to "not toggle" for backwards compatibility.)
>
> How about something like this?

Looks good.  Some small comments:

> +(defcustom gnus-summary-process-mark-toggle nil

Perhaps this should be gnus-process-mark-toggle and also work in the
Group buffer?

> +		(if (eq t unmark)
> +		    (gnus-summary-remove-process-mark article)
> +		  (if (eq t gnus-summary-process-mark-toggle)

We shouldn't check against t in either of these cases -- any non-nil
value is valid.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.