From debbugs-submit-bounces@debbugs.gnu.org Wed May 26 15:57:51 2021 Received: (at submit) by debbugs.gnu.org; 26 May 2021 19:57:51 +0000 Received: from localhost ([127.0.0.1]:49978 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llzf4-00020Y-WA for submit@debbugs.gnu.org; Wed, 26 May 2021 15:57:51 -0400 Received: from lists.gnu.org ([209.51.188.17]:33566) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llzf3-00020R-HP for submit@debbugs.gnu.org; Wed, 26 May 2021 15:57:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50024) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llzf3-0004Cn-6f for bug-gnu-emacs@gnu.org; Wed, 26 May 2021 15:57:49 -0400 Received: from ns.lapseofthought.com ([50.0.39.240]:8261 helo=mail.lapseofthought.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llzex-0006UK-UM for bug-gnu-emacs@gnu.org; Wed, 26 May 2021 15:57:48 -0400 Received: from awb-mbp.local (unknown [IPv6:2601:646:4200:b470:e5ba:e8b3:f6eb:a5ab]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.lapseofthought.com (Postfix) with ESMTPSA id 4Fr1tq4pyqz3pdqX for ; Wed, 26 May 2021 12:57:07 -0700 (PDT) From: Alex Bochannek To: bug-gnu-emacs@gnu.org Subject: 28.0.50; [PATCH] Feature suggestion gnus-summary-toggle-mark-as-processable Date: Wed, 26 May 2021 12:57:06 -0700 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (darwin) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Authentication-Results: ORIGINATING; auth=pass smtp.auth=alex smtp.mailfrom=alex@bochannek.com Received-SPF: pass client-ip=50.0.39.240; envelope-from=alex@bochannek.com; helo=mail.lapseofthought.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain (Not sure if bug-gnu-emacs is the right place to send things like this, please let me know if there is a better list.) I have been missing a article process mark toggle for a while and would like to propose the below patch. If "+" is not an appropriate key to use for this, I am happy to accept an alternative. --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/doc/misc/gnus.texi b/doc/misc/gnus.texi index 7d6fa4cb5c..2862faadf0 100644 --- a/doc/misc/gnus.texi +++ b/doc/misc/gnus.texi @@ -6628,6 +6628,13 @@ Setting Process Marks Remove the process mark, if any, from the current article (@code{gnus-summary-unmark-as-processable}). +@item M P + +@itemx + +@kindex M P + @r{(Summary)} +@kindex + @r{(Summary)} +Toggle the process mark of the current article +(@code{gnus-summary-toggle-mark-as-processable}). + @item M P U @kindex M P U @r{(Summary)} @findex gnus-summary-unmark-all-processable diff --git a/lisp/gnus/gnus-sum.el b/lisp/gnus/gnus-sum.el index aa4c753287..93ea117ff1 100644 --- a/lisp/gnus/gnus-sum.el +++ b/lisp/gnus/gnus-sum.el @@ -1948,6 +1948,7 @@ gnus-summary-mode-map "e" gnus-summary-edit-article "#" gnus-summary-mark-as-processable "\M-#" gnus-summary-unmark-as-processable + "+" gnus-summary-toggle-mark-as-processable "\M-\C-t" gnus-summary-toggle-threads "\M-\C-s" gnus-summary-show-thread "\M-\C-h" gnus-summary-hide-thread @@ -2046,6 +2047,7 @@ gnus-summary-mode-map "B" gnus-summary-remove-bookmark "#" gnus-summary-mark-as-processable "\M-#" gnus-summary-unmark-as-processable + "+" gnus-summary-toggle-mark-as-processable "S" gnus-summary-limit-include-expunged "C" gnus-summary-catchup "H" gnus-summary-catchup-to-here @@ -2336,6 +2338,7 @@ gnus-summary-mode-map (gnus-define-keys (gnus-uu-mark-map "P" gnus-summary-mark-map) "p" gnus-summary-mark-as-processable "u" gnus-summary-unmark-as-processable + "+" gnus-summary-toggle-mark-as-processable "U" gnus-summary-unmark-all-processable "v" gnus-uu-mark-over "s" gnus-uu-mark-series @@ -2776,6 +2779,7 @@ gnus-summary-make-menu-bar ("Process Mark" ["Set mark" gnus-summary-mark-as-processable t] ["Remove mark" gnus-summary-unmark-as-processable t] + ["Toggle mark" gnus-summary-toggle-mark-as-processable t] ["Remove all marks" gnus-summary-unmark-all-processable t] ["Invert marks" gnus-uu-invert-processable t] ["Mark above" gnus-uu-mark-over t] @@ -10951,10 +10955,15 @@ gnus-summary-mark-as-processable (n (abs n))) (while (and (> n 0) - (if unmark - (gnus-summary-remove-process-mark - (gnus-summary-article-number)) - (gnus-summary-set-process-mark (gnus-summary-article-number))) + (let ((article (gnus-summary-article-number))) + (cond ((eq nil unmark) + (gnus-summary-set-process-mark article)) + ((eq t unmark) + (gnus-summary-remove-process-mark article)) + ((eq 'toggle unmark) + (if (memq article gnus-newsgroup-processable) + (gnus-summary-remove-process-mark article) + (gnus-summary-set-process-mark article))))) (zerop (gnus-summary-next-subject (if backward -1 1) nil t))) (setq n (1- n))) (when (/= 0 n) @@ -10970,6 +10979,13 @@ gnus-summary-unmark-as-processable (interactive "P" gnus-summary-mode) (gnus-summary-mark-as-processable n t)) +(defun gnus-summary-toggle-mark-as-processable (n) + "Toggle the process mark from the next N articles. +If N is negative, toggle mark backward instead. The difference between +N and the actual number of articles with their mark toggled is returned." + (interactive "P" gnus-summary-mode) + (gnus-summary-mark-as-processable n 'toggle)) + (defun gnus-summary-unmark-all-processable () "Remove the process mark from all articles." (interactive nil gnus-summary-mode) --=-=-= Content-Type: text/plain -- Alex. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu May 27 19:28:34 2021 Received: (at 48683) by debbugs.gnu.org; 27 May 2021 23:28:34 +0000 Received: from localhost ([127.0.0.1]:53057 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lmPQX-00009j-QN for submit@debbugs.gnu.org; Thu, 27 May 2021 19:28:33 -0400 Received: from quimby.gnus.org ([95.216.78.240]:47716) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lmPQW-00009U-6D for 48683@debbugs.gnu.org; Thu, 27 May 2021 19:28:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=CQN6HXGniuD4a4LDCHOffzLq0WxQz88ka3RYOkXiIkM=; b=rsb0qwjHOpLOyOz9MtJpFisn20 xW3FhwSXOIL+ka8X0kCjGCsAJ2Cgj7JirQ1v65EbMHA91lSTlvtKw/kxTIdt+mpPaFKV8rdS1/NyJ /YaWPOdmm7XoRpT2lPfYlshhBGdqnS8d9E/nP+AWNJy2ETsTziksJv66PbCgLC0u+71o=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lmPQO-0001o0-3i; Fri, 28 May 2021 01:28:26 +0200 From: Lars Ingebrigtsen To: Alex Bochannek Subject: Re: bug#48683: 28.0.50; [PATCH] Feature suggestion gnus-summary-toggle-mark-as-processable References: X-Now-Playing: The Residents's _The King & Eye: RMX_: "A Fool such as I" Date: Fri, 28 May 2021 01:28:23 +0200 In-Reply-To: (Alex Bochannek's message of "Wed, 26 May 2021 12:57:06 -0700") Message-ID: <87cztb4uzs.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Alex Bochannek writes: > I have been missing a article process mark toggle for a while and would > like to propose the below patch. If "+" is not an appropriate key to use > for this, I am happy to accept an alternative. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 48683 Cc: 48683@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Alex Bochannek writes: > I have been missing a article process mark toggle for a while and would > like to propose the below patch. If "+" is not an appropriate key to use > for this, I am happy to accept an alternative. Hm. A toggle command for the process mark? I'm not quite sure I see the utility, and it's unusual in a Gnus marking context -- none of the other marking commands toggle (like setting the tick mark). And the `+' key isn't very mnemonic for a command that toggles the `#' mark. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu May 27 21:08:16 2021 Received: (at submit) by debbugs.gnu.org; 28 May 2021 01:08:16 +0000 Received: from localhost ([127.0.0.1]:53221 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lmQz2-00018n-9Z for submit@debbugs.gnu.org; Thu, 27 May 2021 21:08:16 -0400 Received: from lists.gnu.org ([209.51.188.17]:58264) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lmQyy-00018d-Oc for submit@debbugs.gnu.org; Thu, 27 May 2021 21:08:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57454) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lmQyy-0000vJ-KG for bug-gnu-emacs@gnu.org; Thu, 27 May 2021 21:08:12 -0400 Received: from ciao.gmane.io ([116.202.254.214]:39052) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lmQyx-00042F-Ad for bug-gnu-emacs@gnu.org; Thu, 27 May 2021 21:08:12 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1lmQyu-0006Xi-L6 for bug-gnu-emacs@gnu.org; Fri, 28 May 2021 03:08:08 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: "Jose A. Ortega Ruiz" Subject: Re: bug#48683: 28.0.50; [PATCH] Feature suggestion gnus-summary-toggle-mark-as-processable Date: Fri, 28 May 2021 01:13:55 +0100 Message-ID: <87cztb7m0s.fsf@gnus.jao.io> References: <87cztb4uzs.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cancel-Lock: sha1:vOcHSFOQJumGQKcWIeT3uIZJFC8= X-Attribution: jao X-Clacks-Overhead: GNU Terry Pratchett X-URL: Received-SPF: pass client-ip=116.202.254.214; envelope-from=geb-bug-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -15 X-Spam_score: -1.6 X-Spam_bar: - X-Spam_report: (-1.6 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.25, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) On Fri, May 28 2021, Lars Ingebrigtsen wrote: > Alex Bochannek writes: > >> I have been missing a article process mark toggle for a while and would >> like to propose the below patch. If "+" is not an appropriate key to use >> for this, I am happy to accept an alternative. > > Hm. A toggle command for the process mark? I'm not quite sure I see > the utility, and it's unusual in a Gnus marking context -- none of the > other marking commands toggle (like setting the tick mark). i for one would use it. in my case, it's very common that i've marked an article by mistake (for instance when marking several for deletion). > And the `+' key isn't very mnemonic for a command that toggles the `#' > mark. i always forget it doesn't work, but my expectation is always that # on an already marked article would unmark it... just my 2cs jao From debbugs-submit-bounces@debbugs.gnu.org Thu May 27 22:04:34 2021 Received: (at 48683) by debbugs.gnu.org; 28 May 2021 02:04:34 +0000 Received: from localhost ([127.0.0.1]:53293 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lmRrW-0002sR-8u for submit@debbugs.gnu.org; Thu, 27 May 2021 22:04:34 -0400 Received: from ns.lapseofthought.com ([50.0.39.240]:32939 helo=mail.lapseofthought.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lmRrS-0002sG-Pw for 48683@debbugs.gnu.org; Thu, 27 May 2021 22:04:33 -0400 Received: from awb-mbp.local (unknown [IPv6:2601:646:4200:b470:64e0:3164:e44d:fad9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.lapseofthought.com (Postfix) with ESMTPSA id 4Frp0D4pDtz3pdpp; Thu, 27 May 2021 19:04:28 -0700 (PDT) From: Alex Bochannek To: Lars Ingebrigtsen Subject: Re: bug#48683: 28.0.50; [PATCH] Feature suggestion gnus-summary-toggle-mark-as-processable References: <87cztb4uzs.fsf@gnus.org> Date: Thu, 27 May 2021 19:04:27 -0700 In-Reply-To: <87cztb4uzs.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 28 May 2021 01:28:23 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (darwin) MIME-Version: 1.0 Content-Type: text/plain Authentication-Results: ORIGINATING; auth=pass smtp.auth=alex smtp.mailfrom=alex@bochannek.com X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 48683 Cc: 48683@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > Alex Bochannek writes: > >> I have been missing a article process mark toggle for a while and would >> like to propose the below patch. If "+" is not an appropriate key to use >> for this, I am happy to accept an alternative. > > Hm. A toggle command for the process mark? I'm not quite sure I see > the utility, and it's unusual in a Gnus marking context -- none of the > other marking commands toggle (like setting the tick mark). The downloadable mark is a toggle and because `@' is right next to `#' (at least on the US keyboard), I frequently mistyped it and noticed that the behavior is different. Let me explain how I use the process mark and why a toggle is useful to me. When processing a large number of messages, I sometimes mark a region (or multiple regions) and then want to remove the process mark from some messages in the region and add it to some other ones outside the region. I can absolutely use `#' and `M-#`, but switching between the two quickly when going through dozens of messages requires a fair amount of dexterity. That's why I would rather mark the largest region with the most messages and then pick out the ones to add/remove with a single key that toggles the process mark. I considered if this also makes sense for group and topic marking, but it's an optimization for processing a large number of items, which is why it is probably primarily useful in summary mode. > And the `+' key isn't very mnemonic for a command that toggles the `#' > mark. I saw the `+' glyph as a piece of a `#', which is why I suggested it. -- Alex. From debbugs-submit-bounces@debbugs.gnu.org Thu May 27 22:07:40 2021 Received: (at submit) by debbugs.gnu.org; 28 May 2021 02:07:41 +0000 Received: from localhost ([127.0.0.1]:53313 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lmRuW-0002yR-LQ for submit@debbugs.gnu.org; Thu, 27 May 2021 22:07:40 -0400 Received: from lists.gnu.org ([209.51.188.17]:51396) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lmRuU-0002yJ-OD for submit@debbugs.gnu.org; Thu, 27 May 2021 22:07:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38916) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lmRuU-0001mN-Iq for bug-gnu-emacs@gnu.org; Thu, 27 May 2021 22:07:38 -0400 Received: from ciao.gmane.io ([116.202.254.214]:46788) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lmRuT-0008Vg-5d for bug-gnu-emacs@gnu.org; Thu, 27 May 2021 22:07:38 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1lmRuR-0005ES-JP for bug-gnu-emacs@gnu.org; Fri, 28 May 2021 04:07:35 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Eric Abrahamsen Subject: Re: bug#48683: 28.0.50; [PATCH] Feature suggestion gnus-summary-toggle-mark-as-processable Date: Thu, 27 May 2021 19:07:28 -0700 Message-ID: <87wnrjtxun.fsf@ericabrahamsen.net> References: <87cztb4uzs.fsf@gnus.org> <87cztb7m0s.fsf@gnus.jao.io> Mime-Version: 1.0 Content-Type: text/plain User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cancel-Lock: sha1:s8IrcQS2IP0Z+RxTm0up+iG4ODU= Received-SPF: pass client-ip=116.202.254.214; envelope-from=geb-bug-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -15 X-Spam_score: -1.6 X-Spam_bar: - X-Spam_report: (-1.6 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.25, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) "Jose A. Ortega Ruiz" writes: > On Fri, May 28 2021, Lars Ingebrigtsen wrote: > >> Alex Bochannek writes: >> >>> I have been missing a article process mark toggle for a while and would >>> like to propose the below patch. If "+" is not an appropriate key to use >>> for this, I am happy to accept an alternative. >> >> Hm. A toggle command for the process mark? I'm not quite sure I see >> the utility, and it's unusual in a Gnus marking context -- none of the >> other marking commands toggle (like setting the tick mark). > > i for one would use it. in my case, it's very common that i've marked > an article by mistake (for instance when marking several for deletion). > >> And the `+' key isn't very mnemonic for a command that toggles the `#' >> mark. > > i always forget it doesn't work, but my expectation is always that # on > an already marked article would unmark it... Same here. My hands keep doing this, despite the fact that it never works. Given that "add mark" on an already-marked article is a no-op, it seems like it wouldn't hurt to have it toggle. From debbugs-submit-bounces@debbugs.gnu.org Thu May 27 22:16:23 2021 Received: (at 48683) by debbugs.gnu.org; 28 May 2021 02:16:24 +0000 Received: from localhost ([127.0.0.1]:53335 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lmS2x-0004Mo-Jx for submit@debbugs.gnu.org; Thu, 27 May 2021 22:16:23 -0400 Received: from quimby.gnus.org ([95.216.78.240]:49998) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lmS2v-0004Gr-LS for 48683@debbugs.gnu.org; Thu, 27 May 2021 22:16:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Y7QwTEA+atSKBRsCvEYblOTTgDA3bQYbE/2ffS+mArI=; b=BOsOat86hHVXGRnEFDUi6zlY5Z Rr2YfeelslEHwc6jOmkgOIEfH+P+jAQZ1Uycfy4DMr30y0vRt+A+TeZh/c4e8oFLq3bMwhrvorFG/ Zj4iymnujrXS6RkKW/ZIE3hbv2nnqpl2a6SyVvfJv0WzW6s5sW7PFDyUxu2jqWz4E7vs=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lmS2n-0003er-BG; Fri, 28 May 2021 04:16:15 +0200 From: Lars Ingebrigtsen To: Eric Abrahamsen Subject: Re: bug#48683: 28.0.50; [PATCH] Feature suggestion gnus-summary-toggle-mark-as-processable References: <87cztb4uzs.fsf@gnus.org> <87cztb7m0s.fsf@gnus.jao.io> <87wnrjtxun.fsf@ericabrahamsen.net> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEVHJiSgO0lXFiHV roz///+mf3AMAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+UFGxcoMklGNaAAAAFsSURBVDjLjZTRsQMh CEXFbUC0ATUNhKH/3t4F3F2Ttx9hkpnoES6gJKVllH6z8uO5PGF59rUadU77zjoYv3jW6gjrMXnw GOw2QRYgHMXuS6QJc8VnOoANC8Gi6i5YnsCMmwI08YUBU5x20oDqDiAQm0kbC58AMVjDqJlIPYHp 2vYbHmpJXcDSAkqujtTrBqYBMu3qXVgNGnb2jd4fBk7xHIEUnS7wuUFIsFI5at89FmhCmvtYoCzg ddM7jUj29rDahVJ+iZcXVxXZAqA7Gg2ZvWwaSLddYCsQgPgJWIGsIfENytBw+AZyg7KBlFDik0ei J4A2pmMD5QaS7M4fQuG4JtlBDvA+btB9DBYQB3cLL+DvKsA5OPkCAtBzAAr5EW8OGgHCHPgjxf31 dIUCGetJ5w7hO5RN8wJz/JvXI0A/x/l78PMDoHLtfxheQrnA5kFNhLe/DOLCvkaFTWOLvA5a1Xi6 4MaIPiTURE77A1cXXPxTHiI0AAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIxLTA1LTI3VDIzOjQwOjUw KzAwOjAwqGYyvwAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMS0wNS0yN1QyMzo0MDo1MCswMDowMNk7 igMAAAAASUVORK5CYII= X-Now-Playing: The Residents's _The King & Eye: RMX_: "A Fool such as I" Date: Fri, 28 May 2021 04:16:12 +0200 In-Reply-To: <87wnrjtxun.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Thu, 27 May 2021 19:07:28 -0700") Message-ID: <87h7iny55f.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eric Abrahamsen writes: > Same here. My hands keep doing this, despite the fact that it never > works. Given that "add mark" on an already-marked article is a no-op, it > seems like it wouldn't hurt to have it toggle. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 48683 Cc: 48683@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eric Abrahamsen writes: > Same here. My hands keep doing this, despite the fact that it never > works. Given that "add mark" on an already-marked article is a no-op, it > seems like it wouldn't hurt to have it toggle. That'd be highly surprising if you say `C-u 10 #' and you have some already-marked articles, etc. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu May 27 22:30:06 2021 Received: (at submit) by debbugs.gnu.org; 28 May 2021 02:30:06 +0000 Received: from localhost ([127.0.0.1]:53383 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lmSGE-0005q8-9m for submit@debbugs.gnu.org; Thu, 27 May 2021 22:30:06 -0400 Received: from lists.gnu.org ([209.51.188.17]:55438) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lmSGC-0005oM-Kv for submit@debbugs.gnu.org; Thu, 27 May 2021 22:30:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42154) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lmSGC-0005mU-DZ for bug-gnu-emacs@gnu.org; Thu, 27 May 2021 22:30:04 -0400 Received: from ciao.gmane.io ([116.202.254.214]:56418) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lmSGA-0005tI-OQ for bug-gnu-emacs@gnu.org; Thu, 27 May 2021 22:30:04 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1lmSG8-0000MR-JY for bug-gnu-emacs@gnu.org; Fri, 28 May 2021 04:30:00 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Eric Abrahamsen Subject: Re: bug#48683: 28.0.50; [PATCH] Feature suggestion gnus-summary-toggle-mark-as-processable Date: Thu, 27 May 2021 19:29:53 -0700 Message-ID: <87k0njtwta.fsf@ericabrahamsen.net> References: <87cztb4uzs.fsf@gnus.org> <87cztb7m0s.fsf@gnus.jao.io> <87wnrjtxun.fsf@ericabrahamsen.net> <87h7iny55f.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cancel-Lock: sha1:uoiI/rRiHFlQbI2YIMkNWvRMocs= Received-SPF: pass client-ip=116.202.254.214; envelope-from=geb-bug-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -15 X-Spam_score: -1.6 X-Spam_bar: - X-Spam_report: (-1.6 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.25, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) Lars Ingebrigtsen writes: > Eric Abrahamsen writes: > >> Same here. My hands keep doing this, despite the fact that it never >> works. Given that "add mark" on an already-marked article is a no-op, it >> seems like it wouldn't hurt to have it toggle. > > That'd be highly surprising if you say `C-u 10 #' and you have some > already-marked articles, etc. Dired already works like this, and it is already highly surprising :) From debbugs-submit-bounces@debbugs.gnu.org Fri May 28 14:08:17 2021 Received: (at submit) by debbugs.gnu.org; 28 May 2021 18:08:17 +0000 Received: from localhost ([127.0.0.1]:55315 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lmgu9-0003Tg-6A for submit@debbugs.gnu.org; Fri, 28 May 2021 14:08:17 -0400 Received: from lists.gnu.org ([209.51.188.17]:53690) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lmgu5-0003TX-BQ for submit@debbugs.gnu.org; Fri, 28 May 2021 14:08:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39848) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lmgu5-00007d-3C for bug-gnu-emacs@gnu.org; Fri, 28 May 2021 14:08:13 -0400 Received: from ciao.gmane.io ([116.202.254.214]:57832) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lmgu3-0003H1-4h for bug-gnu-emacs@gnu.org; Fri, 28 May 2021 14:08:12 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1lmgu0-0004l0-Mv for bug-gnu-emacs@gnu.org; Fri, 28 May 2021 20:08:08 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: "Jose A. Ortega Ruiz" Subject: Re: bug#48683: 28.0.50; [PATCH] Feature suggestion gnus-summary-toggle-mark-as-processable Date: Fri, 28 May 2021 18:39:48 +0100 Message-ID: <87k0ni69ln.fsf@gnus.jao.io> References: <87cztb4uzs.fsf@gnus.org> <87cztb7m0s.fsf@gnus.jao.io> <87wnrjtxun.fsf@ericabrahamsen.net> <87h7iny55f.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cancel-Lock: sha1:qJ4+3UAPhqTywt2FQsPYL5Cx5oI= X-Attribution: jao X-Clacks-Overhead: GNU Terry Pratchett X-URL: Received-SPF: pass client-ip=116.202.254.214; envelope-from=geb-bug-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -15 X-Spam_score: -1.6 X-Spam_bar: - X-Spam_report: (-1.6 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.25, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) On Fri, May 28 2021, Lars Ingebrigtsen wrote: > Eric Abrahamsen writes: > >> Same here. My hands keep doing this, despite the fact that it never >> works. Given that "add mark" on an already-marked article is a no-op, it >> seems like it wouldn't hurt to have it toggle. > > That'd be highly surprising if you say `C-u 10 #' and you have some > already-marked articles, etc. i guess suprise is in the eye of the beholder :) i think that, in my case, it'd do exactly what i expect (for the very little that's worth). From debbugs-submit-bounces@debbugs.gnu.org Fri May 28 22:18:47 2021 Received: (at 48683) by debbugs.gnu.org; 29 May 2021 02:18:48 +0000 Received: from localhost ([127.0.0.1]:55593 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lmoYp-0004x1-NA for submit@debbugs.gnu.org; Fri, 28 May 2021 22:18:47 -0400 Received: from quimby.gnus.org ([95.216.78.240]:33182) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lmoYm-0004wo-TI for 48683@debbugs.gnu.org; Fri, 28 May 2021 22:18:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=j/a6SP0FFXTHcOHk26Sy5EsCicuTBVm2wtDLKIn20NE=; b=Q6S4HV6BtuLkXUQT/S7iW3m5DY lfwOdtgbMM58pR5iqEdqIJW8D71gzV6EMVASYA0Hfy69eFVVUe7y/Y706kzXtYSpbJT1KhvmTsGcg Cx0Lzq+Nw/iyqlmSYct5Ykqw6cNL+SKEUFXf/G3SPT/dsckVn1C7PhevFHXim+mAuQbE=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lmoYe-0008LX-AC; Sat, 29 May 2021 04:18:38 +0200 From: Lars Ingebrigtsen To: Alex Bochannek Subject: Re: bug#48683: 28.0.50; [PATCH] Feature suggestion gnus-summary-toggle-mark-as-processable References: <87cztb4uzs.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEXLtaDx6+OIXEnM qU7////Dgg/GAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+UFHQIIB7X362YAAAHCSURBVDjLZZQN0q4g CIVRN4C1AS9ugGT/e/sOouU712aq8Qnk5xARU00ifTz1ZxFx4yxYjYnSAZhankBuo9NCqY25b1jP 6UrJt3M3G13rJW3aJyowGCoDFjKBTPCP/DHScmWHK+u5w0KG/R6CELlImwbyc3hJbBHUkN4OIO0W gSubQZ/A1xAk6s8DRHYe+Lx/AOHazInsQcE+0N2Rr24PPP4PSEyzpNcXIZp1TB9ZHgBnzAC2jvcy hkEKiwOcJTHrq6ASILHbwBWqbWVbmBEntNUBOqG3vcAUZSVeoJYD8JsHPN8OFqFVK7ymeiMX/6S/ hGqxB28WxwOof+hgplNH9/wHAsT1BPB1ywQdgoHJAS4L0KdYNATnt2yrjtguAZBoZbQLH8e+A16H F7p8MzSnrjuegLvefSluJU8+BsSqvLfI78kLSTiKNG1QzDitfmiqmsoGRd9GoQKGsFy7RlZWq2im M2i1qmh5legFkLx7mPaIQE44K7cSmRMdYvBS9VWSYh/wKK5t8QmIZleuFsMgIaCYcxdkbk2WtFL1 PwQuqAVVX5KT2CdHmJes3qQ5JPapPfojlJu/7oLsGcR4YIF9qv4DhcN+HZa5VD0AAAAldEVYdGRh dGU6Y3JlYXRlADIwMjEtMDUtMjlUMDI6MDg6MDcrMDA6MDCaVdqgAAAAJXRFWHRkYXRlOm1vZGlm eQAyMDIxLTA1LTI5VDAyOjA4OjA3KzAwOjAw6whiHAAAAABJRU5ErkJggg== X-Now-Playing: Joni Mitchell's _Joni Mitchell_: "Marcie" Date: Sat, 29 May 2021 04:18:35 +0200 In-Reply-To: (Alex Bochannek's message of "Thu, 27 May 2021 19:04:27 -0700") Message-ID: <878s3ywadg.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Alex Bochannek writes: > I can absolutely use `#' and `M-#`, but switching between > the two quickly when going through dozens of messages requires a fair > amount of dexterity. It seems like many people would prefer to have the `#' command be a toggle. Perhaps we should just add a user option to have `#' toggle or not? (Defaulting to "not toggle" for backwards compatibility. [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 48683 Cc: 48683@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Alex Bochannek writes: > I can absolutely use `#' and `M-#`, but switching between > the two quickly when going through dozens of messages requires a fair > amount of dexterity. It seems like many people would prefer to have the `#' command be a toggle. Perhaps we should just add a user option to have `#' toggle or not? (Defaulting to "not toggle" for backwards compatibility.) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat May 29 13:00:01 2021 Received: (at submit) by debbugs.gnu.org; 29 May 2021 17:00:01 +0000 Received: from localhost ([127.0.0.1]:57629 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ln2Jd-0001H2-38 for submit@debbugs.gnu.org; Sat, 29 May 2021 13:00:01 -0400 Received: from lists.gnu.org ([209.51.188.17]:58262) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ln2JY-0001Gr-G8 for submit@debbugs.gnu.org; Sat, 29 May 2021 12:59:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48004) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ln2JY-0002zx-7P for bug-gnu-emacs@gnu.org; Sat, 29 May 2021 12:59:56 -0400 Received: from ciao.gmane.io ([116.202.254.214]:38234) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ln2JW-0005QV-MU for bug-gnu-emacs@gnu.org; Sat, 29 May 2021 12:59:56 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1ln2JS-0009Jt-Ua for bug-gnu-emacs@gnu.org; Sat, 29 May 2021 18:59:50 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Eric Abrahamsen Subject: Re: bug#48683: 28.0.50; [PATCH] Feature suggestion gnus-summary-toggle-mark-as-processable Date: Sat, 29 May 2021 09:59:43 -0700 Message-ID: <87tumlqxvk.fsf@ericabrahamsen.net> References: <87cztb4uzs.fsf@gnus.org> <878s3ywadg.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cancel-Lock: sha1:pbD44jguv9x1fCNlxRzCOChrVvY= Received-SPF: pass client-ip=116.202.254.214; envelope-from=geb-bug-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) Lars Ingebrigtsen writes: > Alex Bochannek writes: > >> I can absolutely use `#' and `M-#`, but switching between >> the two quickly when going through dozens of messages requires a fair >> amount of dexterity. > > It seems like many people would prefer to have the `#' command be a > toggle. Perhaps we should just add a user option to have `#' toggle or > not? (Defaulting to "not toggle" for backwards compatibility.) Would it be too confusing to have it behave as a toggle with no prefix, but "always mark multiple articles" when used with a numeric prefix? To complicate things further, I think it would be worth making sure that group marking in *Group* and article marking in *Summary* work the same. This stuff is super prone to muscle memory, that consistency would be nice. 2ยข... From debbugs-submit-bounces@debbugs.gnu.org Sun May 30 00:32:56 2021 Received: (at 48683) by debbugs.gnu.org; 30 May 2021 04:32:56 +0000 Received: from localhost ([127.0.0.1]:58080 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lnD8C-0001jG-9A for submit@debbugs.gnu.org; Sun, 30 May 2021 00:32:56 -0400 Received: from quimby.gnus.org ([95.216.78.240]:44608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lnD8A-0001gD-NO for 48683@debbugs.gnu.org; Sun, 30 May 2021 00:32:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=UXJTf5E1ph61CdINxjwMjcn83TP0o391AXtLscPUn8o=; b=OYSXjDqAT9aywsUAGLJJwuX/0c h22+hXsToBGkOoxA716hiVNG8SCYJbfznbD8zahWNPmevVeqrYGdw7tPJnwPeBYHlh/mn8tgBWQgy yIZ/DZEnJnB8k5s5/1A1nwXNhp4jgrAXQ9FB+/b+y6RCAaPXwcxVz1GFh178SrKHwCJw=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lnD82-0005p8-L4; Sun, 30 May 2021 06:32:49 +0200 From: Lars Ingebrigtsen To: Eric Abrahamsen Subject: Re: bug#48683: 28.0.50; [PATCH] Feature suggestion gnus-summary-toggle-mark-as-processable References: <87cztb4uzs.fsf@gnus.org> <878s3ywadg.fsf@gnus.org> <87tumlqxvk.fsf@ericabrahamsen.net> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEVNHBlwSymUXCQz GRLAk0r///+AteMNAAAAAWJLR0QF+G/pxwAAAAd0SU1FB+UFHgM5NN8NSBsAAAGVSURBVDjLrZTb dcMwCEBBLCAkD2DTDIDDBHG1/0wFO/IjTT56TvlwZF/xhgD8SfL65I88jQRQcAQhQJz0ADzJWERy EkkgfujAzyOWFaY8+cvJ3Pjm5IJ7JPjifhoxM/AI5QWIsMjk5svVwymrfxF5Y34NdLm1K8DfGrk/ 7c09FwsBrzCQ2VHbeDuL4gXoDg4f272up6BXYNSBdfD8Ej/wdHHSCKn6FRoD5F0jbgKS1lAb1sg3 jeJMGw/tYYaN6x6vuM4s0lozGlqqW5ZItni4cymt3SpJS71lNi92r6kMt1zyzLspsiI1kcrAdP/W oY1T1wAlJsOSLX0RC49HtZQ55lbnGhXpIJLDoIiYATnvGl4Ot2bRI87MPSiESH1to49jLvhMA8LK XLObosJAiD3xrb5Y3Qcvrox0BqA16AqO79HXFcyPML3Pw9aNyXulD4/uGKbnEKivZ3a6Aw9ntWWl dNA7qOF+Jl+sHM1HmQ6gkMDurO4YpT2OKfF/ADKOSH2vb5epZ2RmzH6/LS8bEgX04n7Yny4/6PdH 7AKsn3wAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjEtMDUtMzBUMDM6NTc6NTIrMDA6MDCHmhC0AAAA JXRFWHRkYXRlOm1vZGlmeQAyMDIxLTA1LTMwVDAzOjU3OjUyKzAwOjAw9seoCAAAAABJRU5ErkJg gg== X-Now-Playing: Crosby, Stills, Nash & Young's =?utf-8?B?X0TDqWrDoA==?= Vu_: "Everybody I Love You" Date: Sun, 30 May 2021 06:32:46 +0200 In-Reply-To: <87tumlqxvk.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Sat, 29 May 2021 09:59:43 -0700") Message-ID: <87o8cs6du9.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eric Abrahamsen writes: > Would it be too confusing to have it behave as a toggle with no prefix, > but "always mark multiple articles" when used with a numeric prefix? Some people in this thread said they wanted mass marking also to work as a toggle. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 48683 Cc: 48683@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eric Abrahamsen writes: > Would it be too confusing to have it behave as a toggle with no prefix, > but "always mark multiple articles" when used with a numeric prefix? Some people in this thread said they wanted mass marking also to work as a toggle. > To complicate things further, I think it would be worth making sure that > group marking in *Group* and article marking in *Summary* work the same. > This stuff is super prone to muscle memory, that consistency would be > nice. Indeed. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon May 31 16:33:16 2021 Received: (at 48683) by debbugs.gnu.org; 31 May 2021 20:33:16 +0000 Received: from localhost ([127.0.0.1]:34985 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lnob6-00070f-0V for submit@debbugs.gnu.org; Mon, 31 May 2021 16:33:16 -0400 Received: from ns.lapseofthought.com ([50.0.39.240]:7137 helo=mail.lapseofthought.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lnob3-00070U-SJ for 48683@debbugs.gnu.org; Mon, 31 May 2021 16:33:15 -0400 Received: from awb-mbp.local (unknown [IPv6:2601:646:4200:b470:d4ed:23a2:4a34:7e85]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.lapseofthought.com (Postfix) with ESMTPSA id 4Fv6S60sGnz3pfWJ; Mon, 31 May 2021 13:33:10 -0700 (PDT) From: Alex Bochannek To: Lars Ingebrigtsen Subject: Re: bug#48683: 28.0.50; [PATCH] Feature suggestion gnus-summary-toggle-mark-as-processable References: <87cztb4uzs.fsf@gnus.org> <878s3ywadg.fsf@gnus.org> Date: Mon, 31 May 2021 13:33:08 -0700 In-Reply-To: <878s3ywadg.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 29 May 2021 04:18:35 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (darwin) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Authentication-Results: ORIGINATING; auth=pass smtp.auth=alex smtp.mailfrom=alex@bochannek.com X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 48683 Cc: 48683@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Lars Ingebrigtsen writes: > Alex Bochannek writes: > >> I can absolutely use `#' and `M-#`, but switching between >> the two quickly when going through dozens of messages requires a fair >> amount of dexterity. > > It seems like many people would prefer to have the `#' command be a > toggle. Perhaps we should just add a user option to have `#' toggle or > not? (Defaulting to "not toggle" for backwards compatibility.) How about something like this? --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/doc/misc/gnus.texi b/doc/misc/gnus.texi index 7d6fa4cb5c..b9c6952d60 100644 --- a/doc/misc/gnus.texi +++ b/doc/misc/gnus.texi @@ -6618,13 +6618,15 @@ Setting Process Marks @kindex M P p @r{(Summary)} @findex gnus-summary-mark-as-processable Mark the current article with the process mark -(@code{gnus-summary-mark-as-processable}). -@findex gnus-summary-unmark-as-processable +(@code{gnus-summary-mark-as-processable}).@* +If @code{gnus-summary-process-mark-toggle} is non-nil, toggle the +existing process mark for the current article. @item M P u @itemx M-# @kindex M P u @r{(Summary)} @kindex M-# @r{(Summary)} +@findex gnus-summary-unmark-as-processable Remove the process mark, if any, from the current article (@code{gnus-summary-unmark-as-processable}). @@ -10569,6 +10571,8 @@ Pick and Read it selects just the article. If given a numerical prefix, go to that thread or article and pick it. (The line number is normally displayed at the beginning of the summary pick lines.) +If @code{gnus-summary-process-mark-toggle} is non-nil, this key will +unpick an already picked article. @item @key{SPC} @kindex SPC @r{(Pick)} diff --git a/lisp/gnus/gnus-sum.el b/lisp/gnus/gnus-sum.el index aa4c753287..941cbaa7d1 100644 --- a/lisp/gnus/gnus-sum.el +++ b/lisp/gnus/gnus-sum.el @@ -562,6 +562,12 @@ gnus-move-group-prefix-function :group 'gnus-summary-mail :type 'function) +(defcustom gnus-summary-process-mark-toggle nil + "If non-nil the process mark command toggles the article's mark." + :version "28.1" + :group 'gnus-summary + :type 'boolean) + ;; FIXME: Although the custom type is `character' for the following variables, ;; using multibyte characters (Latin-1, UTF-8) doesn't work. -- rs @@ -2774,7 +2780,7 @@ gnus-summary-make-menu-bar ["Hide marked" gnus-summary-limit-exclude-marks t] ["Show expunged" gnus-summary-limit-include-expunged t]) ("Process Mark" - ["Set mark" gnus-summary-mark-as-processable t] + ["Set/Toggle mark" gnus-summary-mark-as-processable t] ["Remove mark" gnus-summary-unmark-as-processable t] ["Remove all marks" gnus-summary-unmark-all-processable t] ["Invert marks" gnus-uu-invert-processable t] @@ -10951,10 +10957,14 @@ gnus-summary-mark-as-processable (n (abs n))) (while (and (> n 0) - (if unmark - (gnus-summary-remove-process-mark - (gnus-summary-article-number)) - (gnus-summary-set-process-mark (gnus-summary-article-number))) + (let ((article (gnus-summary-article-number))) + (if (eq t unmark) + (gnus-summary-remove-process-mark article) + (if (eq t gnus-summary-process-mark-toggle) + (if (memq article gnus-newsgroup-processable) + (gnus-summary-remove-process-mark article) + (gnus-summary-set-process-mark article)) + (gnus-summary-set-process-mark article)))) (zerop (gnus-summary-next-subject (if backward -1 1) nil t))) (setq n (1- n))) (when (/= 0 n) --=-=-= Content-Type: text/plain -- Alex. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 01 02:23:12 2021 Received: (at 48683) by debbugs.gnu.org; 1 Jun 2021 06:23:12 +0000 Received: from localhost ([127.0.0.1]:35543 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lnxo0-0000aT-2K for submit@debbugs.gnu.org; Tue, 01 Jun 2021 02:23:12 -0400 Received: from quimby.gnus.org ([95.216.78.240]:39840) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lnxny-0000aG-A8 for 48683@debbugs.gnu.org; Tue, 01 Jun 2021 02:23:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=zy+GXn8qBtzD1XKhx3VkVoZhfmAvqta2f5LCeQw1jlU=; b=l7OPdM4jMmq6eMT3u/nOaj+h5G D51K5IbnW0J6nau6t5/WxMDl1CJvtImWM0nG1535jBZaycrS90FWMcquSP9OVBYLIO3yxjePOwWVq X6hwwVdOqCkstOzXghNO7ptSGoSinxnPafmtqttDShmgRAGV7libZ+C5p89hQ85N1KZs=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lnxnp-0004ev-Iv; Tue, 01 Jun 2021 08:23:03 +0200 From: Lars Ingebrigtsen To: Alex Bochannek Subject: Re: bug#48683: 28.0.50; [PATCH] Feature suggestion gnus-summary-toggle-mark-as-processable References: <87cztb4uzs.fsf@gnus.org> <878s3ywadg.fsf@gnus.org> X-Now-Playing: Grimes's _Miss Anthropocene_: "Before The Fever" Date: Tue, 01 Jun 2021 08:23:00 +0200 In-Reply-To: (Alex Bochannek's message of "Mon, 31 May 2021 13:33:08 -0700") Message-ID: <878s3uf6ij.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Alex Bochannek writes: >> It seems like many people would prefer to have the `#' command be a >> toggle. Perhaps we should just add a user option to have `#' toggle or >> not? (Defaulting to "not toggle" for backwards compa [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 48683 Cc: 48683@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Alex Bochannek writes: >> It seems like many people would prefer to have the `#' command be a >> toggle. Perhaps we should just add a user option to have `#' toggle or >> not? (Defaulting to "not toggle" for backwards compatibility.) > > How about something like this? Looks good. Some small comments: > +(defcustom gnus-summary-process-mark-toggle nil Perhaps this should be gnus-process-mark-toggle and also work in the Group buffer? > + (if (eq t unmark) > + (gnus-summary-remove-process-mark article) > + (if (eq t gnus-summary-process-mark-toggle) We shouldn't check against t in either of these cases -- any non-nil value is valid. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 01 11:57:12 2021 Received: (at 48683) by debbugs.gnu.org; 1 Jun 2021 15:57:13 +0000 Received: from localhost ([127.0.0.1]:37634 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lo6lU-00060X-MD for submit@debbugs.gnu.org; Tue, 01 Jun 2021 11:57:12 -0400 Received: from ns.lapseofthought.com ([50.0.39.240]:40391 helo=mail.lapseofthought.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lo6lQ-00060N-V3 for 48683@debbugs.gnu.org; Tue, 01 Jun 2021 11:57:11 -0400 Received: from awb-mbp.local (unknown [IPv6:2601:646:4200:b470:c5ce:264e:3af5:9738]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.lapseofthought.com (Postfix) with ESMTPSA id 4FvcH60hbQz3pdmR; Tue, 1 Jun 2021 08:57:06 -0700 (PDT) From: Alex Bochannek To: Lars Ingebrigtsen Subject: Re: bug#48683: 28.0.50; [PATCH] Feature suggestion gnus-summary-toggle-mark-as-processable References: <87cztb4uzs.fsf@gnus.org> <878s3ywadg.fsf@gnus.org> <878s3uf6ij.fsf@gnus.org> Date: Tue, 01 Jun 2021 08:57:05 -0700 In-Reply-To: <878s3uf6ij.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 01 Jun 2021 08:23:00 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (darwin) MIME-Version: 1.0 Content-Type: text/plain Authentication-Results: ORIGINATING; auth=pass smtp.auth=alex smtp.mailfrom=alex@bochannek.com X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 48683 Cc: 48683@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > Alex Bochannek writes: > >>> It seems like many people would prefer to have the `#' command be a >>> toggle. Perhaps we should just add a user option to have `#' toggle or >>> not? (Defaulting to "not toggle" for backwards compatibility.) >> >> How about something like this? > > Looks good. Some small comments: > >> +(defcustom gnus-summary-process-mark-toggle nil > > Perhaps this should be gnus-process-mark-toggle and also work in the > Group buffer? That makes sense and I can look at that. I have not dug into the differences between group and topic mode, but I hope they are similar enough. >> + (if (eq t unmark) >> + (gnus-summary-remove-process-mark article) >> + (if (eq t gnus-summary-process-mark-toggle) > > We shouldn't check against t in either of these cases -- any non-nil > value is valid. Good point, thank you! -- Alex. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 01 16:45:41 2021 Received: (at 48683) by debbugs.gnu.org; 1 Jun 2021 20:45:41 +0000 Received: from localhost ([127.0.0.1]:37997 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1loBGe-0007c1-VJ for submit@debbugs.gnu.org; Tue, 01 Jun 2021 16:45:41 -0400 Received: from ns.lapseofthought.com ([50.0.39.240]:54621 helo=mail.lapseofthought.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1loBGa-0007bq-Sh for 48683@debbugs.gnu.org; Tue, 01 Jun 2021 16:45:40 -0400 Received: from awb-mbp.local (unknown [IPv6:2601:646:4200:b470:c5ce:264e:3af5:9738]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.lapseofthought.com (Postfix) with ESMTPSA id 4Fvkgy1x7cz3pdjV; Tue, 1 Jun 2021 13:45:34 -0700 (PDT) From: Alex Bochannek To: Lars Ingebrigtsen Subject: Re: bug#48683: 28.0.50; [PATCH] Feature suggestion gnus-summary-toggle-mark-as-processable References: <87cztb4uzs.fsf@gnus.org> <878s3ywadg.fsf@gnus.org> <878s3uf6ij.fsf@gnus.org> Date: Tue, 01 Jun 2021 13:45:32 -0700 In-Reply-To: <878s3uf6ij.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 01 Jun 2021 08:23:00 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (darwin) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Authentication-Results: ORIGINATING; auth=pass smtp.auth=alex smtp.mailfrom=alex@bochannek.com X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 48683 Cc: 48683@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Lars Ingebrigtsen writes: > Alex Bochannek writes: > >>> It seems like many people would prefer to have the `#' command be a >>> toggle. Perhaps we should just add a user option to have `#' toggle or >>> not? (Defaulting to "not toggle" for backwards compatibility.) >> >> How about something like this? > > Looks good. Some small comments: > >> +(defcustom gnus-summary-process-mark-toggle nil > > Perhaps this should be gnus-process-mark-toggle and also work in the > Group buffer? See below. I tried to make sure that only `#' changes behavior and not `M-#' (this is why there is a `no-toggle' variable for some of the functions.) Have a look and let me know what you think. --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/doc/misc/gnus.texi b/doc/misc/gnus.texi index 7d6fa4cb5c..ebb1df5552 100644 --- a/doc/misc/gnus.texi +++ b/doc/misc/gnus.texi @@ -2583,7 +2583,9 @@ Marking Groups @itemx M m @kindex M m @r{(Group)} @findex gnus-group-mark-group -Set the mark on the current group (@code{gnus-group-mark-group}). +Set the mark on the current group (@code{gnus-group-mark-group}).@* +If @code{gnus-process-mark-toggle} is non-nil, toggle the +existing process mark for the current group. @item M-# @kindex M-# @r{(Group)} @@ -4043,7 +4045,9 @@ Topic Commands @findex gnus-topic-mark-topic Mark all groups in the current topic with the process mark (@code{gnus-topic-mark-topic}). This command works recursively on -sub-topics unless given a prefix. +sub-topics unless given a prefix.@* +If @code{gnus-process-mark-toggle} is non-nil, toggle the +existing process mark for the current topic. @item T M-# @kindex T M-# @r{(Topic)} @@ -6618,13 +6622,15 @@ Setting Process Marks @kindex M P p @r{(Summary)} @findex gnus-summary-mark-as-processable Mark the current article with the process mark -(@code{gnus-summary-mark-as-processable}). -@findex gnus-summary-unmark-as-processable +(@code{gnus-summary-mark-as-processable}).@* +If @code{gnus-process-mark-toggle} is non-nil, toggle the +existing process mark for the current article. @item M P u @itemx M-# @kindex M P u @r{(Summary)} @kindex M-# @r{(Summary)} +@findex gnus-summary-unmark-as-processable Remove the process mark, if any, from the current article (@code{gnus-summary-unmark-as-processable}). @@ -10569,6 +10575,8 @@ Pick and Read it selects just the article. If given a numerical prefix, go to that thread or article and pick it. (The line number is normally displayed at the beginning of the summary pick lines.) +If @code{gnus-process-mark-toggle} is non-nil, this key will unpick an +already picked article. @item @key{SPC} @kindex SPC @r{(Pick)} diff --git a/lisp/gnus/gnus-group.el b/lisp/gnus/gnus-group.el index 8c62c9424d..06d1313d37 100644 --- a/lisp/gnus/gnus-group.el +++ b/lisp/gnus/gnus-group.el @@ -894,14 +894,14 @@ gnus-group-make-menu-bar ["Sort by real name" gnus-group-sort-selected-groups-by-real-name (not (gnus-topic-mode-p))]) ("Mark" - ["Mark group" gnus-group-mark-group + ["Set/Toggle mark" gnus-group-mark-group (and (gnus-group-group-name) (not (memq (gnus-group-group-name) gnus-group-marked)))] - ["Unmark group" gnus-group-unmark-group + ["Remove mark" gnus-group-unmark-group (and (gnus-group-group-name) (memq (gnus-group-group-name) gnus-group-marked))] - ["Unmark all" gnus-group-unmark-all-groups gnus-group-marked] - ["Mark regexp..." gnus-group-mark-regexp t] + ["Remove all marks" gnus-group-unmark-all-groups gnus-group-marked] + ["Mark by regexp..." gnus-group-mark-regexp t] ["Mark region" gnus-group-mark-region :active mark-active] ["Mark buffer" gnus-group-mark-buffer t] ["Execute command" gnus-group-universal-argument @@ -1865,7 +1865,7 @@ gnus-group-mark-line-p (forward-char (or (cdr (assq 'process gnus-group-mark-positions)) 2)) (eq (char-after) gnus-process-mark))) -(defun gnus-group-mark-group (n &optional unmark no-advance) +(defun gnus-group-mark-group (n &optional unmark no-advance no-toggle) "Mark the current group." (interactive "p" gnus-group-mode) (let ((buffer-read-only nil) @@ -1877,23 +1877,33 @@ gnus-group-mark-group (beginning-of-line) (forward-char (or (cdr (assq 'process gnus-group-mark-positions)) 2)) (delete-char 1) - (if unmark - (progn - (setq gnus-group-marked (delete group gnus-group-marked)) - (insert-char ?\s 1 t)) - (setq gnus-group-marked - (cons group (delete group gnus-group-marked))) - (insert-char gnus-process-mark 1 t))) + (if (and gnus-process-mark-toggle (not no-toggle)) + (if (memq group gnus-group-marked) + (gnus-group-mark-update group t) + (gnus-group-mark-update group)) + (gnus-group-mark-update group unmark))) (unless no-advance (gnus-group-next-group 1)) (cl-decf n)) (gnus-group-position-point) n)) +(defun gnus-group-mark-update (n &optional unmark) + "Set the process mark on current group and update the group line." + (if unmark + (progn + (setq gnus-group-marked + (delete n gnus-group-marked)) + (insert-char ?\s 1 t)) + (progn + (setq gnus-group-marked + (cons n (delete n gnus-group-marked))) + (insert-char gnus-process-mark 1 t)))) + (defun gnus-group-unmark-group (n) "Remove the mark from the current group." (interactive "p" gnus-group-mode) - (gnus-group-mark-group n 'unmark) + (gnus-group-mark-group n 'unmark nil t) (gnus-group-position-point)) (defun gnus-group-unmark-all-groups () @@ -1910,7 +1920,7 @@ gnus-group-mark-region (let ((num (count-lines beg end))) (save-excursion (goto-char beg) - (- num (gnus-group-mark-group num unmark))))) + (- num (gnus-group-mark-group num unmark nil t))))) (defun gnus-group-mark-buffer (&optional unmark) "Mark all groups in the buffer. @@ -1935,7 +1945,7 @@ gnus-group-remove-mark Return nil if the group isn't displayed." (if (gnus-group-goto-group group nil test-marked) (save-excursion - (gnus-group-mark-group 1 'unmark t) + (gnus-group-mark-group 1 'unmark t t) t) (setq gnus-group-marked (delete group gnus-group-marked)) @@ -1945,7 +1955,7 @@ gnus-group-set-mark "Set the process mark on GROUP." (if (gnus-group-goto-group group) (save-excursion - (gnus-group-mark-group 1 nil t)) + (gnus-group-mark-group 1 nil t t)) (setq gnus-group-marked (cons group (delete group gnus-group-marked))))) (defun gnus-group-universal-argument (arg &optional _groups func) diff --git a/lisp/gnus/gnus-sum.el b/lisp/gnus/gnus-sum.el index aa4c753287..48794ceb3f 100644 --- a/lisp/gnus/gnus-sum.el +++ b/lisp/gnus/gnus-sum.el @@ -2774,7 +2774,7 @@ gnus-summary-make-menu-bar ["Hide marked" gnus-summary-limit-exclude-marks t] ["Show expunged" gnus-summary-limit-include-expunged t]) ("Process Mark" - ["Set mark" gnus-summary-mark-as-processable t] + ["Set/Toggle mark" gnus-summary-mark-as-processable t] ["Remove mark" gnus-summary-unmark-as-processable t] ["Remove all marks" gnus-summary-unmark-all-processable t] ["Invert marks" gnus-uu-invert-processable t] @@ -10951,10 +10951,14 @@ gnus-summary-mark-as-processable (n (abs n))) (while (and (> n 0) - (if unmark - (gnus-summary-remove-process-mark - (gnus-summary-article-number)) - (gnus-summary-set-process-mark (gnus-summary-article-number))) + (let ((article (gnus-summary-article-number))) + (if unmark + (gnus-summary-remove-process-mark article) + (if gnus-process-mark-toggle + (if (memq article gnus-newsgroup-processable) + (gnus-summary-remove-process-mark article) + (gnus-summary-set-process-mark article)) + (gnus-summary-set-process-mark article)))) (zerop (gnus-summary-next-subject (if backward -1 1) nil t))) (setq n (1- n))) (when (/= 0 n) diff --git a/lisp/gnus/gnus-topic.el b/lisp/gnus/gnus-topic.el index b3d17bc03f..c0484622f4 100644 --- a/lisp/gnus/gnus-topic.el +++ b/lisp/gnus/gnus-topic.el @@ -1112,7 +1112,7 @@ gnus-topic-make-menu-bar ["Delete" gnus-topic-delete t] ["Rename..." gnus-topic-rename t] ["Create..." gnus-topic-create-topic t] - ["Mark" gnus-topic-mark-topic t] + ["Set/Toggle mark" gnus-topic-mark-topic t] ["Indent" gnus-topic-indent t] ["Sort" gnus-topic-sort-topics t] ["Previous topic" gnus-topic-goto-previous-topic t] @@ -1436,7 +1436,7 @@ gnus-topic-show-topic (setcar (cdr (cadr topic)) 'visible) (gnus-group-list-groups))))) -(defun gnus-topic-mark-topic (topic &optional unmark non-recursive) +(defun gnus-topic-mark-topic (topic &optional unmark non-recursive no-toggle) "Mark all groups in the TOPIC with the process mark. If NON-RECURSIVE (which is the prefix) is t, don't mark its subtopics." (interactive @@ -1450,8 +1450,13 @@ gnus-topic-mark-topic (let ((groups (gnus-topic-find-groups topic gnus-level-killed t nil (not non-recursive)))) (while groups - (funcall (if unmark 'gnus-group-remove-mark 'gnus-group-set-mark) - (gnus-info-group (nth 1 (pop groups))))))))) + (let ((group (gnus-info-group (nth 1 (pop groups))))) + (if (and gnus-process-mark-toggle (not no-toggle)) + (if (memq group gnus-group-marked) + (gnus-group-remove-mark group ) + (gnus-group-set-mark group)) + (if unmark (gnus-group-remove-mark group) + (gnus-group-set-mark group))))))))) (defun gnus-topic-unmark-topic (topic &optional _dummy non-recursive) "Remove the process mark from all groups in the TOPIC. @@ -1462,7 +1467,7 @@ gnus-topic-unmark-topic gnus-topic-mode) (if (not topic) (call-interactively 'gnus-group-unmark-group) - (gnus-topic-mark-topic topic t non-recursive))) + (gnus-topic-mark-topic topic t non-recursive t))) (defun gnus-topic-get-new-news-this-topic (&optional n) "Check for new news in the current topic." diff --git a/lisp/gnus/gnus.el b/lisp/gnus/gnus.el index 7de1cd1ddb..21b5f31c14 100644 --- a/lisp/gnus/gnus.el +++ b/lisp/gnus/gnus.el @@ -1183,6 +1183,14 @@ gnus-process-mark :group 'gnus-summary-marks :type 'character) +(defcustom gnus-process-mark-toggle nil + "If non-nil the process mark command toggles the process mark." + :version "28.1" + :group 'gnus-summary + :group 'gnus-group-various + :group 'gnus-group-topic + :type 'boolean) + (defcustom gnus-large-newsgroup 200 "The number of articles which indicates a large newsgroup. If the number of articles in a newsgroup is greater than this value, --=-=-= Content-Type: text/plain -- Alex. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 02 01:42:19 2021 Received: (at 48683) by debbugs.gnu.org; 2 Jun 2021 05:42:19 +0000 Received: from localhost ([127.0.0.1]:38380 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1loJdz-0008Fa-8c for submit@debbugs.gnu.org; Wed, 02 Jun 2021 01:42:19 -0400 Received: from quimby.gnus.org ([95.216.78.240]:53560) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1loJdw-0008FH-Ds for 48683@debbugs.gnu.org; Wed, 02 Jun 2021 01:42:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=/quOaMEio0b8PZH7cLQKYYSJlwhUq4OaWdGLUJolaf0=; b=nqWa5Wo++5PerXVk3XfXC6tdIH bvgfu8EC6xOnWbdXBA+9OvJY3ZncpmUSi3tAPNtEzl/Zs3k03/OQ13PGwzgMgsqJqSahIOV4g43lV WGeDaykg6fgQ7hfSU0OSuysXcieI4kewYg/N/z6jKs74KkHcvAl2lPvhfSQzUzp3HTgc=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1loJdk-0002JH-PB; Wed, 02 Jun 2021 07:42:09 +0200 From: Lars Ingebrigtsen To: Alex Bochannek Subject: Re: bug#48683: 28.0.50; [PATCH] Feature suggestion gnus-summary-toggle-mark-as-processable References: <87cztb4uzs.fsf@gnus.org> <878s3ywadg.fsf@gnus.org> <878s3uf6ij.fsf@gnus.org> X-Now-Playing: Machinedrum's _Eyesdontlie_: "Body Touch" Date: Wed, 02 Jun 2021 07:42:04 +0200 In-Reply-To: (Alex Bochannek's message of "Tue, 01 Jun 2021 13:45:32 -0700") Message-ID: <874kegaklv.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Alex Bochannek writes: > See below. I tried to make sure that only `#' changes behavior and not > `M-#' (this is why there is a `no-toggle' variable for some of the > functions.) Have a look and let me know what you think. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 48683 Cc: 48683@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Alex Bochannek writes: > See below. I tried to make sure that only `#' changes behavior and not > `M-#' (this is why there is a `no-toggle' variable for some of the > functions.) Have a look and let me know what you think. Thanks! Pushed to Emacs 28 now with some tiny changes to the .texi files. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 02 01:42:29 2021 Received: (at control) by debbugs.gnu.org; 2 Jun 2021 05:42:29 +0000 Received: from localhost ([127.0.0.1]:38383 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1loJe5-0008Ft-FL for submit@debbugs.gnu.org; Wed, 02 Jun 2021 01:42:29 -0400 Received: from quimby.gnus.org ([95.216.78.240]:53574) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1loJe4-0008FY-6M for control@debbugs.gnu.org; Wed, 02 Jun 2021 01:42:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=DGUAmNZRNfVl518CQuw/xV5MIBKDL+VvGhPWfBH+qn4=; b=ge6X7gYjSeP5JbbvXBA/0NWOqw 1md/+oLZ3VWOOfbjOGVvIYPBHSb+XL7FmqTx7w7V3sPrcdEpsUKLpMUNsGgab53mIG+ijnmw9mAAH RrdY3pNLf1JYaJHIq3UbxYz8B8x+MyrYeCDzEC+Cbx6PxEnXMWuKnVk177fU2gOr3bBQ=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1loJdw-0002JO-Po for control@debbugs.gnu.org; Wed, 02 Jun 2021 07:42:18 +0200 Date: Wed, 02 Jun 2021 07:42:16 +0200 Message-Id: <8735u0aklj.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #48683 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 48683 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) close 48683 28.1 quit From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 02 02:35:25 2021 Received: (at 48683) by debbugs.gnu.org; 2 Jun 2021 06:35:25 +0000 Received: from localhost ([127.0.0.1]:38512 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1loKTN-0001Yd-5I for submit@debbugs.gnu.org; Wed, 02 Jun 2021 02:35:25 -0400 Received: from ns.lapseofthought.com ([50.0.39.240]:55263 helo=mail.lapseofthought.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1loKTJ-0001YS-7a for 48683@debbugs.gnu.org; Wed, 02 Jun 2021 02:35:23 -0400 Received: from awb-mbp.local (unknown [IPv6:2601:646:4200:b470:c95c:f324:6ce1:d577]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.lapseofthought.com (Postfix) with ESMTPSA id 4FvzmR2TBNz3pdmR; Tue, 1 Jun 2021 23:35:19 -0700 (PDT) From: Alex Bochannek To: Lars Ingebrigtsen Subject: Re: bug#48683: 28.0.50; [PATCH] Feature suggestion gnus-summary-toggle-mark-as-processable References: <87cztb4uzs.fsf@gnus.org> <878s3ywadg.fsf@gnus.org> <878s3uf6ij.fsf@gnus.org> <874kegaklv.fsf@gnus.org> Date: Tue, 01 Jun 2021 23:35:18 -0700 In-Reply-To: <874kegaklv.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 02 Jun 2021 07:42:04 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (darwin) MIME-Version: 1.0 Content-Type: text/plain Authentication-Results: ORIGINATING; auth=pass smtp.auth=alex smtp.mailfrom=alex@bochannek.com X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 48683 Cc: 48683@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > Alex Bochannek writes: > >> See below. I tried to make sure that only `#' changes behavior and not >> `M-#' (this is why there is a `no-toggle' variable for some of the >> functions.) Have a look and let me know what you think. > > Thanks! Pushed to Emacs 28 now with some tiny changes to the .texi files. Great, thank you! -- Alex. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 05 20:10:49 2021 Received: (at 48683) by debbugs.gnu.org; 6 Jun 2021 00:10:49 +0000 Received: from localhost ([127.0.0.1]:50323 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lpgNM-0004ss-K9 for submit@debbugs.gnu.org; Sat, 05 Jun 2021 20:10:49 -0400 Received: from ns.lapseofthought.com ([50.0.39.240]:1632 helo=mail.lapseofthought.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lpgNI-0004sg-Me for 48683@debbugs.gnu.org; Sat, 05 Jun 2021 20:10:47 -0400 Received: from awb-mbp.local (unknown [IPv6:2601:646:4200:b470:a963:78de:b9cb:ea2f]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.lapseofthought.com (Postfix) with ESMTPSA id 4FyH2p4JZzz3pkcS; Sat, 5 Jun 2021 17:10:42 -0700 (PDT) From: Alex Bochannek To: Lars Ingebrigtsen Subject: Re: master 16793dc: Add new user option to Gnus to allow `#' to toggle References: <20210602054134.32052.21793@vcs0.savannah.gnu.org> <20210602054135.CA6F2209AA@vcs0.savannah.gnu.org> <87v96vbfb6.fsf@gnus.org> <87sg1xx6p0.fsf@gnus.org> Date: Sat, 05 Jun 2021 17:10:42 -0700 In-Reply-To: <87sg1xx6p0.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 04 Jun 2021 12:30:51 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (darwin) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Authentication-Results: ORIGINATING; auth=pass smtp.auth=alex smtp.mailfrom=alex@bochannek.com X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 48683 Cc: Stefan Monnier , 48683@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Lars Ingebrigtsen writes: > Alex Bochannek writes: > >>> (And it's not just `#' itself, but the commands to mark regions and such >>> that are also affected.) >> >> That shouldn't be the case. In summary, the gnus-uu-mark functions call >> the set/remove process mark functions directly and in group/topic I >> introduced the no-toggle flag to avoid toggling for anything other than >> `#'. > > Ah, OK, then that should be less of a worry... Perhaps we should try to > default it to t on the trunk and see whether anybody complains? Below is the patch to enable it by default. Change the Gnus default to use `#' to toggle the process mark * lisp/gnus/gnus.el (gnus-process-mark-toggle): Change default. * lisp/gnus/gnus-topic.el (gnus-topic-make-menu-bar): Update menu. * lisp/gnus/gnus-sum.el (gnus-summary-make-menu-bar): Update menu. * lisp/gnus/gnus-group.el (gnus-group-make-menu-bar): Update menu. * doc/misc/gnus.texi (Marking Groups, Topic Commands): (Setting Process Marks, Pick and Read): Document the new default. --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/doc/misc/gnus.texi b/doc/misc/gnus.texi index 11bcfc16ae..0ab2aa5b82 100644 --- a/doc/misc/gnus.texi +++ b/doc/misc/gnus.texi @@ -2583,27 +2583,28 @@ Marking Groups @itemx M m @kindex M m @r{(Group)} @findex gnus-group-mark-group -Set the mark on the current group (@code{gnus-group-mark-group}).@* -If @code{gnus-process-mark-toggle} is non-@code{nil}, toggle the -existing process mark for the current group. +Toggle the process mark for the current group +(@code{gnus-group-mark-group}).@* +If @code{gnus-process-mark-toggle} is @code{nil}, set the process mark +for the current group. @item M-# @kindex M-# @r{(Group)} @itemx M u @kindex M u @r{(Group)} @findex gnus-group-unmark-group -Remove the mark from the current group +Remove the process mark, if any, from the current group (@code{gnus-group-unmark-group}). @item M U @kindex M U @r{(Group)} @findex gnus-group-unmark-all-groups -Remove the mark from all groups (@code{gnus-group-unmark-all-groups}). +Remove the process mark from all groups (@code{gnus-group-unmark-all-groups}). @item M w @kindex M w @r{(Group)} @findex gnus-group-mark-region -Mark all groups between point and mark (@code{gnus-group-mark-region}). +Mark groups in region (@code{gnus-group-mark-region}). @item M b @kindex M b @r{(Group)} @@ -4043,11 +4044,11 @@ Topic Commands @item T # @kindex T # @r{(Topic)} @findex gnus-topic-mark-topic -Mark all groups in the current topic with the process mark +Toggle the process mark for all groups in the current topic (@code{gnus-topic-mark-topic}). This command works recursively on sub-topics unless given a prefix.@* -If @code{gnus-process-mark-toggle} is non-@code{nil}, toggle the -existing process mark for the current topic. +If @code{gnus-process-mark-toggle} is @code{nil}, set the process mark +for the current topic. @item T M-# @kindex T M-# @r{(Topic)} @@ -6621,10 +6622,10 @@ Setting Process Marks @kindex # @r{(Summary)} @kindex M P p @r{(Summary)} @findex gnus-summary-mark-as-processable -Mark the current article with the process mark +Toggle the process mark for the current article (@code{gnus-summary-mark-as-processable}).@* -If @code{gnus-process-mark-toggle} is non-@code{nil}, toggle the -existing process mark for the current article. +If @code{gnus-process-mark-toggle} is @code{nil}, set the process mark +for the current article. @item M P u @itemx M-# @@ -10568,15 +10569,15 @@ Pick and Read @item . @kindex . @r{(Pick)} @findex gnus-pick-article-or-thread -Pick the article or thread on the current line -(@code{gnus-pick-article-or-thread}). If the variable +Pick the article or thread on the current line or unpick it if is +already picked (@code{gnus-pick-article-or-thread}). If the variable @code{gnus-thread-hide-subtree} is true, then this key selects the entire thread when used at the first article of the thread. Otherwise, it selects just the article. If given a numerical prefix, go to that thread or article and pick it. (The line number is normally displayed at the beginning of the summary pick lines.) If -@code{gnus-process-mark-toggle} is non-@code{nil}, this key will -unpick an already picked article. +@code{gnus-process-mark-toggle} is @code{nil}, this key will pick an +article or thread. @item @key{SPC} @kindex SPC @r{(Pick)} diff --git a/etc/NEWS b/etc/NEWS index 7d53eafbae..e44feff6bb 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -871,10 +871,15 @@ tags to be considered as well. ** Gnus ++++ +*** The '#' command in the Group and Summary buffer now toggles, +instead of sets, the process mark. + +++ *** New user option 'gnus-process-mark-toggle'. -If non-nil, the `#' command in the Group and Summary buffers will -toggle instead of setting the process mark. +If non-nil (the default), the `#' command in the Group and Summary +buffers will toggle, instead of set, the process mark. + +++ *** New user option 'gnus-registry-register-all'. diff --git a/lisp/gnus/gnus-group.el b/lisp/gnus/gnus-group.el index 06d1313d37..c8b95d9185 100644 --- a/lisp/gnus/gnus-group.el +++ b/lisp/gnus/gnus-group.el @@ -894,7 +894,7 @@ gnus-group-make-menu-bar ["Sort by real name" gnus-group-sort-selected-groups-by-real-name (not (gnus-topic-mode-p))]) ("Mark" - ["Set/Toggle mark" gnus-group-mark-group + ["Toggle/Set mark" gnus-group-mark-group (and (gnus-group-group-name) (not (memq (gnus-group-group-name) gnus-group-marked)))] ["Remove mark" gnus-group-unmark-group diff --git a/lisp/gnus/gnus-sum.el b/lisp/gnus/gnus-sum.el index 3279c3221e..bcd76dda29 100644 --- a/lisp/gnus/gnus-sum.el +++ b/lisp/gnus/gnus-sum.el @@ -2774,7 +2774,7 @@ gnus-summary-make-menu-bar ["Hide marked" gnus-summary-limit-exclude-marks t] ["Show expunged" gnus-summary-limit-include-expunged t]) ("Process Mark" - ["Set/Toggle mark" gnus-summary-mark-as-processable t] + ["Toggle/Set mark" gnus-summary-mark-as-processable t] ["Remove mark" gnus-summary-unmark-as-processable t] ["Remove all marks" gnus-summary-unmark-all-processable t] ["Invert marks" gnus-uu-invert-processable t] diff --git a/lisp/gnus/gnus-topic.el b/lisp/gnus/gnus-topic.el index c0484622f4..b974dff372 100644 --- a/lisp/gnus/gnus-topic.el +++ b/lisp/gnus/gnus-topic.el @@ -1112,7 +1112,7 @@ gnus-topic-make-menu-bar ["Delete" gnus-topic-delete t] ["Rename..." gnus-topic-rename t] ["Create..." gnus-topic-create-topic t] - ["Set/Toggle mark" gnus-topic-mark-topic t] + ["Toggle/Set mark" gnus-topic-mark-topic t] ["Indent" gnus-topic-indent t] ["Sort" gnus-topic-sort-topics t] ["Previous topic" gnus-topic-goto-previous-topic t] diff --git a/lisp/gnus/gnus.el b/lisp/gnus/gnus.el index 21b5f31c14..7dde799a5b 100644 --- a/lisp/gnus/gnus.el +++ b/lisp/gnus/gnus.el @@ -1183,8 +1183,8 @@ gnus-process-mark :group 'gnus-summary-marks :type 'character) -(defcustom gnus-process-mark-toggle nil - "If non-nil the process mark command toggles the process mark." +(defcustom gnus-process-mark-toggle t + "If nil the process mark command only sets the process mark." :version "28.1" :group 'gnus-summary :group 'gnus-group-various --=-=-= Content-Type: text/plain -- Alex. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 08 07:35:07 2021 Received: (at 48683) by debbugs.gnu.org; 8 Jun 2021 11:35:07 +0000 Received: from localhost ([127.0.0.1]:57560 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lqa0c-00049f-Gx for submit@debbugs.gnu.org; Tue, 08 Jun 2021 07:35:06 -0400 Received: from quimby.gnus.org ([95.216.78.240]:53746) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lqa0X-000493-M7 for 48683@debbugs.gnu.org; Tue, 08 Jun 2021 07:35:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=WlgCM6S4pgbdODdsh9HfYZvbNGi801lrIGlDRExsIWM=; b=PRCo1MSlGPXiR/uPqsXYuEzSAI sQpKGL9jUYQyKmZKnDuecBP+oW0WHWRhqhMpeBT2YnHyNblREeU58lWZ42T34CoENJWXnYuvgJS9M zkoCQ57T8+B8jf8/LB5iMycqQqZy0E7CJaPn76andfqkZFTQ5SzXs3XjcJmCx28twJRA=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lqa0L-0008D1-OE; Tue, 08 Jun 2021 13:34:50 +0200 From: Lars Ingebrigtsen To: Alex Bochannek Subject: Re: master 16793dc: Add new user option to Gnus to allow `#' to toggle References: <20210602054134.32052.21793@vcs0.savannah.gnu.org> <20210602054135.CA6F2209AA@vcs0.savannah.gnu.org> <87v96vbfb6.fsf@gnus.org> <87sg1xx6p0.fsf@gnus.org> X-Now-Playing: M. C. Schmidt's _Aqua Sauvage: Stuffed Concrete_: "(untitled)" Date: Tue, 08 Jun 2021 13:34:45 +0200 In-Reply-To: (Alex Bochannek's message of "Sat, 05 Jun 2021 17:10:42 -0700") Message-ID: <87eedcoai2.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Alex Bochannek writes: >> Ah, OK, then that should be less of a worry... Perhaps we should try to >> default it to t on the trunk and see whether anybody complains? > > Below is the patch to enable it by default. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 48683 Cc: Stefan Monnier , 48683@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Alex Bochannek writes: >> Ah, OK, then that should be less of a worry... Perhaps we should try to >> default it to t on the trunk and see whether anybody complains? > > Below is the patch to enable it by default. Thanks; applied to Emacs 28. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Mon Jun 23 20:17:38 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 07 Jul 2021 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator