GNU bug report logs - #48669
Inconsistent overlay placement between minibuffer-message and set-minibuffer-message

Previous Next

Package: emacs;

Reported by: João Guerra <joca.bt <at> gmail.com>

Date: Wed, 26 May 2021 12:52:02 UTC

Severity: normal

Tags: fixed, patch

Fixed in version 28.0.50

Done: Juri Linkov <juri <at> linkov.net>

Bug is archived. No further changes may be made.

Full log


Message #32 received at 48669 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Juri Linkov <juri <at> linkov.net>
Cc: joca.bt <at> gmail.com, 48669 <at> debbugs.gnu.org
Subject: Re: bug#48669: Inconsistent overlay placement between
 minibuffer-message and set-minibuffer-message
Date: Tue, 08 Jun 2021 21:12:10 +0300
> From: Juri Linkov <juri <at> linkov.net>
> Cc: joca.bt <at> gmail.com,  48669 <at> debbugs.gnu.org
> Date: Tue, 08 Jun 2021 19:52:07 +0300
> 
> >> If minibuffer--message-overlay-pos serves its purpose for
> >> set-minibuffer-message, it seems suitable for
> >> minibuffer-message as well.
> >
> > So you object to adding a comment there which would explain what that
> > call does?
> 
> Now I added a comment, and pushed to master.
> 
> >> >> -              (put-text-property 0 1 'cursor t message))
> >> >> +              (put-text-property 0 1 'cursor 1 message))
> >> >
> >> > Why this change?
> >> 
> >> Only to make minibuffer-message the identical copy of
> >> set-minibuffer-message.
> >
> > I'd say make it the other way around.  Handling the 'cursor' property
> > with a numeric value is more expensive and tricky than if the value is
> > t, and in this case the effect is exactly the same.
> 
> So I changed the 'cursor' property to t.

Thank you.




This bug report was last modified 3 years and 344 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.