From unknown Fri Jun 20 07:09:27 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#48666 <48666@debbugs.gnu.org> To: bug#48666 <48666@debbugs.gnu.org> Subject: Status: Leaks are still possible in hook--depth-alist Reply-To: bug#48666 <48666@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:09:27 +0000 retitle 48666 Leaks are still possible in hook--depth-alist reassign 48666 emacs submitter 48666 jakanakaevangeli@chiru.no severity 48666 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Wed May 26 04:52:32 2021 Received: (at submit) by debbugs.gnu.org; 26 May 2021 08:52:32 +0000 Received: from localhost ([127.0.0.1]:47595 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llpHE-0002tJ-IV for submit@debbugs.gnu.org; Wed, 26 May 2021 04:52:32 -0400 Received: from lists.gnu.org ([209.51.188.17]:45298) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llpHD-0002tC-K4 for submit@debbugs.gnu.org; Wed, 26 May 2021 04:52:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51586) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llpHD-00040A-CQ for bug-gnu-emacs@gnu.org; Wed, 26 May 2021 04:52:31 -0400 Received: from chiru.no ([142.4.209.132]:38828) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1llpHB-0002EZ-SJ for bug-gnu-emacs@gnu.org; Wed, 26 May 2021 04:52:31 -0400 Received: from localhost (BSN-77-156-43.static.siol.net [193.77.156.43]) by chiru.no (Postfix) with ESMTPSA id A5BE1128001C; Wed, 26 May 2021 08:52:23 +0000 (UTC) From: jakanakaevangeli@chiru.no To: bug-gnu-emacs@gnu.org Subject: Leaks are still possible in hook--depth-alist Date: Wed, 26 May 2021 10:57:47 +0200 Message-ID: <877djlrhx0.fsf@miha-pc> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: none client-ip=142.4.209.132; envelope-from=jakanakaevangeli@chiru.no; helo=chiru.no X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) (with-temp-buffer (add-hook 'post-command-hook (make-symbol "fun-sym") 77 t)) (get 'post-command-hook 'hook--depth-alist) Perhaps hook--depth-alist could be a hash table with weak keys. Best regards. From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 22 10:25:50 2022 Received: (at 48666) by debbugs.gnu.org; 22 Feb 2022 15:25:50 +0000 Received: from localhost ([127.0.0.1]:42383 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMX30-0000TM-BU for submit@debbugs.gnu.org; Tue, 22 Feb 2022 10:25:50 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:16862) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMX2z-0000T6-1Z for 48666@debbugs.gnu.org; Tue, 22 Feb 2022 10:25:49 -0500 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id F1F9D441115; Tue, 22 Feb 2022 10:25:42 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 7B34A4410ED; Tue, 22 Feb 2022 10:25:41 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1645543541; bh=ahQ+vHfZ7P6tAeGzUiFu74p3Nw1pABes4UX2a3GrRII=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=KyoIPPQVqerAOpFR8dxDzXLU2NuHsRnYrqeJJ6+IiUJ6cCyLGBMDyznZ4VMzDDLUG fIkA5+8y1fgFDnImQDDX8Ry9eOeK6uERCzGz8dyBa2ijUEnw2h+GUrEkY7jgQttnCQ tqS7JjBWM6U1kKj4CRNs/J9ThEwEAwtoWhPrUBZDZJniRy3LykJXGzuLb0rgJGC/2X U7Pj3tWk5xF5nBJbYBrxn6ZDs2f4PT0J5Go+sj4Cr1tXsmARRKE1JxKMygEkMZ7ooJ R30CGAT445fJ4dn6obbWGB05D7YmH2myUECzYmv8DkJPYKikpaW5LoFi92FeULz60a LVLXYdFEgiPmw== Received: from pastel (unknown [45.72.197.68]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 49F1D12023D; Tue, 22 Feb 2022 10:25:41 -0500 (EST) From: Stefan Monnier To: jakanakaevangeli@chiru.no Subject: Re: bug#48666: Leaks are still possible in hook--depth-alist Message-ID: References: <877djlrhx0.fsf@miha-pc> Date: Tue, 22 Feb 2022 10:25:35 -0500 In-Reply-To: <877djlrhx0.fsf@miha-pc> (jakanakaevangeli@chiru.no's message of "Wed, 26 May 2021 10:57:47 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.072 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48666 Cc: 48666@debbugs.gnu.org, Daniel Mendler X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) jakanakaevangeli@chiru.no [2021-05-26 10:57:47] wrote: > (with-temp-buffer > (add-hook 'post-command-hook (make-symbol "fun-sym") 77 t)) > (get 'post-command-hook 'hook--depth-alist) > Perhaps hook--depth-alist could be a hash table with weak keys. I just pushed to `master` a patch which should hopefully fix this problem for good (basically, the depth alist is now kept in an(other) variable (so for functions added to the buffer-local portion of the hook, the depth is stored in the buffer-local portion of the depth variable)). I hope it will also fix the problems seen in https://github.com/minad/corfu/issues/133 It makes it a bit harder to check if the old problem is still present or not, OTOH, because the depth-alist isn't just a quick (get 'hook--depth-alist) away but you need to (symbol-value (get 'hook--depth-alist)) and that will only show you the global portion or the portion relevant to the current buffer. Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 15 06:40:16 2022 Received: (at 48666) by debbugs.gnu.org; 15 Jul 2022 10:40:16 +0000 Received: from localhost ([127.0.0.1]:39607 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCIk3-0000Oc-W0 for submit@debbugs.gnu.org; Fri, 15 Jul 2022 06:40:16 -0400 Received: from quimby.gnus.org ([95.216.78.240]:45390) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCIk2-0000OI-At for 48666@debbugs.gnu.org; Fri, 15 Jul 2022 06:40:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=o+mHgfowirjEe6daWY3XQcP0eKf2pM/rEptuYqVEM+Q=; b=ajaYQ0JUvlqxDF7nwci7XiVlYs 3VqZKrCipmQUNsbgoZl/BPo5kGS38h6wdRPSpkJh1Kqv1nPcf4xpz3btjwA3Y10/ULMguHTlemL39 ZA+P/OF/jKtbq4G2XgS3a3wGsh2fcKHKCt1l/d9RaZCLRRLu2eWpMgQPuOqLREQqSsC8=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oCIjr-0005kE-5h; Fri, 15 Jul 2022 12:40:05 +0200 From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#48666: Leaks are still possible in hook--depth-alist In-Reply-To: (Stefan Monnier's message of "Tue, 22 Feb 2022 10:25:35 -0500") References: <877djlrhx0.fsf@miha-pc> X-Now-Playing: Autechre's _Plus_: "ecol4" Date: Fri, 15 Jul 2022 12:40:01 +0200 Message-ID: <871qummzge.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Monnier writes: > I just pushed to `master` a patch which should hopefully fix this > problem for good (basically, the depth alist is now kept in an(other) > variable (so for functions added to the buffer-local porti [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48666 Cc: 48666@debbugs.gnu.org, jakanakaevangeli@chiru.no, Daniel Mendler X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Monnier writes: > I just pushed to `master` a patch which should hopefully fix this > problem for good (basically, the depth alist is now kept in an(other) > variable (so for functions added to the buffer-local portion of the > hook, the depth is stored in the buffer-local portion of the depth > variable)). This was several months ago, so presumably Stefan's change fixed this issue, and I'm therefore closing this bug report. If the issue is still present, please respond to the debbugs address and we'll reopen. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 15 06:40:19 2022 Received: (at control) by debbugs.gnu.org; 15 Jul 2022 10:40:19 +0000 Received: from localhost ([127.0.0.1]:39610 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCIk7-0000Ow-8U for submit@debbugs.gnu.org; Fri, 15 Jul 2022 06:40:19 -0400 Received: from quimby.gnus.org ([95.216.78.240]:45402) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCIk5-0000ON-96 for control@debbugs.gnu.org; Fri, 15 Jul 2022 06:40:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Da7ZrRzCt5QlUeMjWDfVady2w6qTrD5dQZR4ISX5RF8=; b=iyZBo2rvEY0e6/N0DS5Hhruhps OqyHToMkiqAnqR8CVfsVK8bx5AteX6PK7b1cWo8ao6SrK2qZS9rsvJgzpLGXe+NWnL/8rne/5wO/H ZTZ/cD05XBB39JfDU8o5iRtAVKk3+rRBsw19yKjUPz8OyEvkDh9BqmRU3Y4aW1DrUE7w=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oCIjx-0005kM-Mc for control@debbugs.gnu.org; Fri, 15 Jul 2022 12:40:11 +0200 Date: Fri, 15 Jul 2022 12:40:09 +0200 Message-Id: <87zghalkvq.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #48666 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 48666 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 48666 quit From unknown Fri Jun 20 07:09:27 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 12 Aug 2022 11:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator