GNU bug report logs - #48663
[PATCH] gnu: Add emacs-org-inline-pdf.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#48663: closed ([PATCH] gnu: Add emacs-org-inline-pdf.)
Date: Wed, 26 May 2021 12:53:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 26 May 2021 14:52:31 +0200
with message-id <874kepirn4.fsf <at> nicolasgoaziou.fr>
and subject line Re: [bug#48663] [PATCH] gnu: Add emacs-org-inline-pdf.
has caused the debbugs.gnu.org bug report #48663,
regarding [PATCH] gnu: Add emacs-org-inline-pdf.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
48663: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=48663
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Xinglu Chen <public <at> yoctocell.xyz>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add emacs-org-inline-pdf.
Date: Wed, 26 May 2021 09:36:49 +0200

* gnu/packages/emacs-xyz.scm (emacs-org-inline-pdf): New variable.
---
 gnu/packages/emacs-xyz.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 886320cc34..22918c8f9b 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -4635,6 +4635,36 @@ strike through completed TODO headings, changes Org blocks, changes Org check
 boxes, and more.")
       (license license:gpl3+))))
 
+(define-public emacs-org-inline-pdf
+  (package
+    (name "emacs-org-inline-pdf")
+    (version "0.2")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/shg/org-inline-pdf.el")
+                    (commit version)))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "1qc92xvgxmnwjixk8bxwbc1l1jj0qk9dg73jyaip6lk4g0wjk6xf"))))
+    (build-system emacs-build-system)
+    (inputs
+     `(("pdf2svg" ,pdf2svg)))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'patch-exec-paths
+           (lambda* (#:key inputs #:allow-other-keys)
+             (let ((pdf2svg (assoc-ref inputs "pdf2svg")))
+               (substitute* "org-inline-pdf.el"
+                 (("\"pdf2svg\"") (string-append "\"" pdf2svg "/bin/pdf2svg\"")))))))))
+    (home-page "https://github.com/shg/org-inline-pdf.el")
+    (synopsis "Inline PDF previewing for Org ")
+    (description "This package provides a minor mode that enables
+inline PDF preview in Org buffers by using pdf2svg.")
+    (license license:gpl3+)))
+
 (define-public emacs-org-rich-yank
   (package
     (name "emacs-org-rich-yank")

base-commit: 0ffac75ece4f22a8595e19b8a375791e87d365aa
-- 
2.31.1

[Message part 3 (message/rfc822, inline)]

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Xinglu Chen <public <at> yoctocell.xyz>
Cc: 48663-done <at> debbugs.gnu.org
Subject: Re: [bug#48663] [PATCH] gnu: Add emacs-org-inline-pdf.
Date: Wed, 26 May 2021 14:52:31 +0200

Hello,

Xinglu Chen <public <at> yoctocell.xyz> writes:

> On Wed, May 26 2021, Xinglu Chen wrote:
>
>> +(define-public emacs-org-inline-pdf

Patch applied. Thank you.

> Oops, trailing whitespace.  Should I add a linter check for this?

Isn't it the case already? There's a `report-trailing-white-space'
checker in "lint.scm".

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.