GNU bug report logs - #48643
PATCH] gnu: fzf: Add fish shell functions to the package.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Solene Rapenne <solene <at> perso.pw>
Subject: bug#48643: closed (Re: [bug#48643] PATCH] gnu: fzf: Add fish
 shell functions to the package.)
Date: Sun, 26 Sep 2021 12:05:01 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#48643: PATCH] gnu: fzf: Add fish shell functions to the package.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 48643 <at> debbugs.gnu.org.

-- 
48643: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=48643
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Solene Rapenne <solene <at> perso.pw>
Cc: 48643-done <at> debbugs.gnu.org
Subject: Re: [bug#48643] PATCH] gnu: fzf: Add fish shell functions to the
 package.
Date: Sun, 26 Sep 2021 15:02:23 +0300

[Message part 3 (text/plain, inline)]

I adjusted the fish completion path slightly to match the other
packages. Patch pushed!

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: Solene Rapenne <solene <at> perso.pw>
To: guix-patches <at> gnu.org
Subject: PATCH] gnu: fzf: Add fish shell functions to the package.
Date: Tue, 25 May 2021 10:16:50 +0200

This allows to enable fzf functions for fish using the following code in
the file ~/.config/fish/config.fish 

source ~/.guix-profile/share/fish/functions/fzf
fzf_key_bindings


---
 gnu/packages/terminals.scm | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/gnu/packages/terminals.scm b/gnu/packages/terminals.scm
index 37636c7cdc..5273dce005 100644
--- a/gnu/packages/terminals.scm
+++ b/gnu/packages/terminals.scm
@@ -25,6 +25,7 @@
 ;;; Copyright © 2020 Leo Famulari <leo <at> famulari.name>
 ;;; Copyright © 2021 Ekaitz Zarraga <ekaitz <at> elenq.tech>
 ;;; Copyright © 2021 Raphaël Mélotte <raphael.melotte <at> mind.be>
+;;; Copyright © 2021 Solene Rapenne <solene <at> perso.pw>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -851,11 +852,15 @@ usable with any list--including files, command history, processes and more.")
             (lambda* (#:key outputs #:allow-other-keys)
               (let* ((out (assoc-ref outputs "out"))
                      (bash-completion (string-append out "/etc/bash_completion.d"))
+                     (fish-completion (string-append out "/share/fish/functions"))
                      (zsh-completion (string-append out "/share/zsh/site-functions")))
                 (with-directory-excursion "src/github.com/junegunn/fzf"
                   (mkdir-p bash-completion)
                   (copy-file "shell/completion.bash"
                              (string-append bash-completion "/fzf"))
+                  (mkdir-p fish-completion)
+                  (copy-file "shell/key-bindings.fish"
+                             (string-append fish-completion "/fzf"))
                   (mkdir-p zsh-completion)
                   (copy-file "shell/completion.zsh"
                              (string-append zsh-completion "/_fzf"))))))))))
-- 
2.31.1

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.