GNU bug report logs - #48643
PATCH] gnu: fzf: Add fish shell functions to the package.

Previous Next

Full log

Message #16 received at 48643-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: wp1148917-web <drwilly <at> drwilly.de>
Cc: 48643-done <at> debbugs.gnu.org
Subject: Re: [bug#48643]
Date: Sun, 3 Oct 2021 15:00:39 +0300

[Message part 1 (text/plain, inline)]

On Sat, Oct 02, 2021 at 10:43:15PM +0200, wp1148917-web wp1148917-web wrote:
> Efraim, there seems to be a bit of confusion about the nature of the installed file: It is NOT a completion, but code that sets fzf shell-hotkeys. This should become obvious if you look at the folder from the source: https://github.com/junegunn/fzf/tree/master/shell
> The file should probably be installed to vendor_functions.d/ as e.g. Arch does it: https://wiki.archlinux.org/title/Fzf#fish

First of all, thanks! I hadn't checked it too closely and relied on the
wording of 'fish completion'.

Checking the upstream documentation¹, Arch² and Debian³ the completions should
go in %output/share/fish/vendor_functions.d/fzf_key_bindings.fish, so
I've moved them there.

¹ https://fishshell.com/docs/current/completions.html?highlight=vendor#where-to-put-completions
² https://wiki.archlinux.org/title/Fzf#fish
³ https://sources.debian.org/src/fzf/0.24.3-1/debian/fzf.install/

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.