From unknown Sat Jun 21 10:18:52 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#48643 <48643@debbugs.gnu.org> To: bug#48643 <48643@debbugs.gnu.org> Subject: Status: PATCH] gnu: fzf: Add fish shell functions to the package. Reply-To: bug#48643 <48643@debbugs.gnu.org> Date: Sat, 21 Jun 2025 17:18:52 +0000 retitle 48643 PATCH] gnu: fzf: Add fish shell functions to the package. reassign 48643 guix-patches submitter 48643 Solene Rapenne severity 48643 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Tue May 25 04:17:15 2021 Received: (at submit) by debbugs.gnu.org; 25 May 2021 08:17:15 +0000 Received: from localhost ([127.0.0.1]:44618 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llSFQ-0002Hc-RM for submit@debbugs.gnu.org; Tue, 25 May 2021 04:17:14 -0400 Received: from lists.gnu.org ([209.51.188.17]:39116) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llSFN-0002HT-P2 for submit@debbugs.gnu.org; Tue, 25 May 2021 04:17:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48556) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llSFN-00036v-Gl for guix-patches@gnu.org; Tue, 25 May 2021 04:17:05 -0400 Received: from perso.pw ([163.172.223.238]:1328) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llSFL-0000xn-CR for guix-patches@gnu.org; Tue, 25 May 2021 04:17:05 -0400 Received: from perso.pw (localhost [127.0.0.1]) by perso.pw (OpenSMTPD) with ESMTP id 9e9c4c92 for ; Tue, 25 May 2021 10:16:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=perso.pw; h=date:from:to :subject:message-id:mime-version:content-type :content-transfer-encoding; s=1337; bh=n803k374evmv3WKlqhCha4zPe BY=; b=GCNdGThhGIse+KwmSPgUFhNXMMKtY6ULTjcG5JO1pE7DB2JdHYN1S7XUZ 60e4xmdTDtpnH+Rw+ghj8lKbGCoLM6zyt5CN8ebYl3oNVNmttk9UEqA4O5be6ksy ITB4FHiYU2upOHX2fKA9FIgMEwoSxITPQo88jcrTR8vkfTTQZM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=perso.pw; h=date:from:to :subject:message-id:mime-version:content-type :content-transfer-encoding; q=dns; s=1337; b=XvzPNzpUYpBXFH269+x pi0e+S5U+X+wTabn9F1ApHuqlvfaHf2ST7LSChFg8SF6M6P7nCj3Rha2qAl0l69T lZMkfFgqTfPXVYO4DI/UL19pO8rq+UHc2DgYzHE8MGQXfFnH3pqZR5NzDIYHx86d V/MMfgcpPOSPxLuBv+ianYl4= X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on perso.pw X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.5 Received: from localhost (176-154-164-34.abo.bbox.fr [176.154.164.34]) by perso.pw (OpenSMTPD) with ESMTPSA id d90440c1 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO) for ; Tue, 25 May 2021 10:16:51 +0200 (CEST) Date: Tue, 25 May 2021 10:16:50 +0200 From: Solene Rapenne To: guix-patches@gnu.org Subject: PATCH] gnu: fzf: Add fish shell functions to the package. Message-ID: <20210525101650.0706dd75@perso.pw> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=163.172.223.238; envelope-from=solene@perso.pw; helo=perso.pw X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) This allows to enable fzf functions for fish using the following code in the file ~/.config/fish/config.fish=20 source ~/.guix-profile/share/fish/functions/fzf fzf_key_bindings --- gnu/packages/terminals.scm | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/gnu/packages/terminals.scm b/gnu/packages/terminals.scm index 37636c7cdc..5273dce005 100644 --- a/gnu/packages/terminals.scm +++ b/gnu/packages/terminals.scm @@ -25,6 +25,7 @@ ;;; Copyright =C2=A9 2020 Leo Famulari ;;; Copyright =C2=A9 2021 Ekaitz Zarraga ;;; Copyright =C2=A9 2021 Rapha=C3=ABl M=C3=A9lotte +;;; Copyright =C2=A9 2021 Solene Rapenne ;;; ;;; This file is part of GNU Guix. ;;; @@ -851,11 +852,15 @@ usable with any list--including files, command histor= y, processes and more.") (lambda* (#:key outputs #:allow-other-keys) (let* ((out (assoc-ref outputs "out")) (bash-completion (string-append out "/etc/bash_comple= tion.d")) + (fish-completion (string-append out "/share/fish/func= tions")) (zsh-completion (string-append out "/share/zsh/site-f= unctions"))) (with-directory-excursion "src/github.com/junegunn/fzf" (mkdir-p bash-completion) (copy-file "shell/completion.bash" (string-append bash-completion "/fzf")) + (mkdir-p fish-completion) + (copy-file "shell/key-bindings.fish" + (string-append fish-completion "/fzf")) (mkdir-p zsh-completion) (copy-file "shell/completion.zsh" (string-append zsh-completion "/_fzf"))))))))= )) --=20 2.31.1 From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 26 08:04:59 2021 Received: (at 48643-done) by debbugs.gnu.org; 26 Sep 2021 12:04:59 +0000 Received: from localhost ([127.0.0.1]:36079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUStv-00081l-F0 for submit@debbugs.gnu.org; Sun, 26 Sep 2021 08:04:59 -0400 Received: from flashner.co.il ([178.62.234.194]:33032) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUSts-00081X-VP for 48643-done@debbugs.gnu.org; Sun, 26 Sep 2021 08:04:58 -0400 Received: from localhost (unknown [141.226.169.107]) by flashner.co.il (Postfix) with ESMTPSA id D2B4D40215; Sun, 26 Sep 2021 12:04:50 +0000 (UTC) Date: Sun, 26 Sep 2021 15:02:23 +0300 From: Efraim Flashner To: Solene Rapenne Subject: Re: [bug#48643] PATCH] gnu: fzf: Add fish shell functions to the package. Message-ID: Mail-Followup-To: Efraim Flashner , Solene Rapenne , 48643-done@debbugs.gnu.org References: <20210525101650.0706dd75@perso.pw> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="3SkZTwihGB9eFRBW" Content-Disposition: inline In-Reply-To: <20210525101650.0706dd75@perso.pw> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 48643-done Cc: 48643-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --3SkZTwihGB9eFRBW Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable I adjusted the fish completion path slightly to match the other packages. Patch pushed! --=20 Efraim Flashner =D7=A8=D7=A0=D7=A9=D7=9C=D7=A4 = =D7=9D=D7=99=D7=A8=D7=A4=D7=90 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --3SkZTwihGB9eFRBW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmFQYU8ACgkQQarn3Mo9 g1Hc1A/+Nx/V8Ix9R/P9HCUrYi+C1kcXIFWa1E0vikZxR7djHEYPClKyH4DxkPZl tZCFwZVPlf+Wkeo4s1qCD3EvOR4Okk7JTxQs2WZj0QaDdxFT8C9sk1jdzdjlRwWo KRbSt9fyS2GHaRS4xP3ovZCk1UEG7vp5uyNr0e1b4RuaWS5GnqRsMBH9QMjjV4oP 8nuY2dwnQv43io/qTGYLeyX8rdYnC53o9Y27iVc8YgJgg3dW57qEBQMnIeMKUyW+ sezrEjo9lPzhYGT7cwCxqshzNJM8mYTFdDjK+K9/CZIzuSsqAMJL9rw157MMp3AQ HZ7AsVuYq0bx9VGN8BVhp/mRfTRSC66afKsuRXAd81qDAQ86e94gZRDYHv3lBdfn 1AraKv2Xam9xPNj5Z5Ib/Tm29S86/UtktA4PYbIuUQCYiIKmZkU7F86K5DNltfmK VSF39Via7pS6NTbzneDXD+hQKlhxVGKfPe7t9mHQKK+ef9KePiat3mHz8OiqxLC/ hwh9pr8k0WtQYn+1x0vLl6+99jEayS4WL3+lZPuzWWCd0bNnKrq4WDzkKpijNadq LUdi0B/J1i4L7iQOokzrYjhyehmXrMsEfzFuY5H2Z1NW2GxELqiViNnJR6zuYJvK iJ6NCUdbxgm4SSnZAoiNvZyMn95vPO9tWsaRmVHKXlXalrIz4cM= =ZmBZ -----END PGP SIGNATURE----- --3SkZTwihGB9eFRBW-- From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 02 19:09:08 2021 Received: (at 48643) by debbugs.gnu.org; 2 Oct 2021 23:09:08 +0000 Received: from localhost ([127.0.0.1]:60762 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mWo7v-0007Ed-5z for submit@debbugs.gnu.org; Sat, 02 Oct 2021 19:09:08 -0400 Received: from wp180.webpack.hosteurope.de ([80.237.132.187]:39594) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mWlqo-0002VX-1Q for 48643@debbugs.gnu.org; Sat, 02 Oct 2021 16:43:18 -0400 Received: from app20-neu.ox.hosteurope.de ([92.51.170.154]); authenticated by wp180.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.0:ECDHE_RSA_AES_256_CBC_SHA1:256) id 1mWlqm-0004E4-B2; Sat, 02 Oct 2021 22:43:16 +0200 Date: Sat, 2 Oct 2021 22:43:15 +0200 (CEST) From: wp1148917-web wp1148917-web To: "48643@debbugs.gnu.org" <48643@debbugs.gnu.org> Message-ID: <1917298992.58524.1633207395967@ox.hosteurope.de> Subject: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.4-Rev25 X-Originating-IP: 78.34.209.94 X-Originating-Client: open-xchange-appsuite X-Originating-Sender: drwilly@drwilly.de X-bounce-key: webpack.hosteurope.de;drwilly@drwilly.de;1633207398;701c9dcb; X-HE-SMSGID: 1mWlqm-0004E4-B2 X-Spam-Score: 3.3 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Efraim, there seems to be a bit of confusion about the nature of the installed file: It is NOT a completion, but code that sets fzf shell-hotkeys. This should become obvious if you look at the folder [...] Content analysis details: (3.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [80.237.132.187 listed in list.dnswl.org] 0.0 SPF_NONE SPF: sender does not publish an SPF Record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 2.0 BLANK_SUBJECT Subject is present but empty 0.0 BODY_URI_ONLY Message body is only a URI in one line of text or for an image 1.0 XPRIO Has X-Priority header 1.0 XPRIO_SHORT_SUBJ Has X Priority header + short subject X-Debbugs-Envelope-To: 48643 X-Mailman-Approved-At: Sat, 02 Oct 2021 19:09:06 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) Efraim, there seems to be a bit of confusion about the nature of the installed file: It is NOT a completion, but code that sets fzf shell-hotkeys. This should become obvious if you look at the folder from the source: https://github.com/junegunn/fzf/tree/master/shell The file should probably be installed to vendor_functions.d/ as e.g. Arch does it: https://wiki.archlinux.org/title/Fzf#fish From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 03 08:03:31 2021 Received: (at 48643-done) by debbugs.gnu.org; 3 Oct 2021 12:03:31 +0000 Received: from localhost ([127.0.0.1]:33054 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mX0DL-0005Gz-2a for submit@debbugs.gnu.org; Sun, 03 Oct 2021 08:03:31 -0400 Received: from flashner.co.il ([178.62.234.194]:54032) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mX0DH-0005Gj-SY for 48643-done@debbugs.gnu.org; Sun, 03 Oct 2021 08:03:30 -0400 Received: from localhost (unknown [141.226.169.107]) by flashner.co.il (Postfix) with ESMTPSA id 9A1A54018B; Sun, 3 Oct 2021 12:03:21 +0000 (UTC) Date: Sun, 3 Oct 2021 15:00:39 +0300 From: Efraim Flashner To: wp1148917-web Subject: Re: [bug#48643] Message-ID: Mail-Followup-To: Efraim Flashner , wp1148917-web , 48643-done@debbugs.gnu.org References: <20210525101650.0706dd75@perso.pw> <1917298992.58524.1633207395967@ox.hosteurope.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="0hzkrDCb7PwDbpga" Content-Disposition: inline In-Reply-To: <1917298992.58524.1633207395967@ox.hosteurope.de> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 48643-done Cc: 48643-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0hzkrDCb7PwDbpga Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Oct 02, 2021 at 10:43:15PM +0200, wp1148917-web wp1148917-web wrote: > Efraim, there seems to be a bit of confusion about the nature of the inst= alled file: It is NOT a completion, but code that sets fzf shell-hotkeys. T= his should become obvious if you look at the folder from the source: https:= //github.com/junegunn/fzf/tree/master/shell > The file should probably be installed to vendor_functions.d/ as e.g. Arch= does it: https://wiki.archlinux.org/title/Fzf#fish First of all, thanks! I hadn't checked it too closely and relied on the wording of 'fish completion'. Checking the upstream documentation=C2=B9, Arch=C2=B2 and Debian=C2=B3 the = completions should go in %output/share/fish/vendor_functions.d/fzf_key_bindings.fish, so I've moved them there. =C2=B9 https://fishshell.com/docs/current/completions.html?highlight=3Dvend= or#where-to-put-completions =C2=B2 https://wiki.archlinux.org/title/Fzf#fish =C2=B3 https://sources.debian.org/src/fzf/0.24.3-1/debian/fzf.install/ --=20 Efraim Flashner =D7=A8=D7=A0=D7=A9=D7=9C=D7=A4 = =D7=9D=D7=99=D7=A8=D7=A4=D7=90 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --0hzkrDCb7PwDbpga Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmFZm2YACgkQQarn3Mo9 g1GKbhAAsOrngV7kp8bMUMJY92fN/jDdEMwQRdbXi83Isdwoq26RM/jK4ggf8ez3 bhK/oGwSGrkSeYxgo/qWZz4mMwNW4fpgldDHbNCaJLVOuaBfbJcnuBk5WaKfjfDj 1vk2kIGqbrH8tjUS5XFepHcTFvSvwrHltiVb8QyqC0jSdFiBSo6YOdTNZ9ywfcNW cpT+mWtsNRSaPIhMpxSQ7lnqspF7NOECPdNKRred3GxgLAxS8aegOa1nrsdDr6od KNtWOm8ZN+wArRpLWu5sRS851Q5PLq/zU3+ZfLWwIMGvvnbQjiPh2hgF6+rkhiyc JLMQHTrZi0cldM0Bl7bGMl/WbzW+i88S0SiRcbmfcE53qVBQG+wvZz+ScIPI9qxv JpnLnMr7B/Ie1jpqyxbtNbXaElLRu9ibNGVJsXakLP+D3jlE1g+9H58u2eJT9eJG 3HwkVAe91AhT0krPyzMQ6zy8FSmQAKa2A1ZByJfjkPU3gWdqNlusGX2p+f0+ca1z Bp+ZVER6RBnLvCnfEOjUtIRpriek4FqV3z3FLsBMvck4lzHPL/EMx4aWsi/VRuYB QUlII5Zh0gZckhGDvWbJqtevzdgATjNRGGen+d9kWCf4bzt2a1HWpEvTaJxvQqz+ AhD3ZKIqFUHd6nfv3002eawUPZR5Tx8bCV5fgpY9rS40X3ACbnk= =5vfq -----END PGP SIGNATURE----- --0hzkrDCb7PwDbpga-- From unknown Sat Jun 21 10:18:52 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 01 Nov 2021 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator