GNU bug report logs - #48642
[PATCH] Add kanatest

Previous Next

Full log

Message #11 received at 48642 <at> debbugs.gnu.org (full text, mbox):

From: Nicolò Balzarotti <anothersms <at> gmail.com>
To: Xinglu Chen <public <at> yoctocell.xyz>, 48642 <at> debbugs.gnu.org
Subject: Re: [bug#48642] [PATCH] Add kanatest
Date: Tue, 25 May 2021 10:39:10 +0200

[Message part 1 (text/plain, inline)]

Hi! Thanks for the fast review!

Xinglu Chen <public <at> yoctocell.xyz> writes:

> On Tue, May 25 2021, Nicolò Balzarotti wrote:
>
>> +(define-public kanatest
>> +  ;; Latest release tarball is 0.4.8, which is really old and does not build
>> +  ;; commit on sourceforge are not tagged, we take the latest
>> +  (let ((commit "860e790a35f547cc96669f805d371a5ba3d8daff"))
>> +    (package
>> +      (name "kanatest")
>> +      (version (string-append "0.4.10." (string-take commit 7)))
>
> Use ‘(git-version VERSION REVISION COMMIT)’.
>
I added revision "0" along with commit in the let block and used
git-version as suggested.

>> [...]
>> +      (home-page "https://kanatest.sourceforge.io/")
>
> Nit: ‘home-page’ usually comes before ‘synopsis’.
>
Moved above!

> Otherwise, LGTM!  Builds fine as well.

Thanks, here's version 2 of the patch!

Thanks again for the review,
Nicolò

[v2-0001-gnu-Add-kanatest.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.