Subject: [bug#48642] [PATCH] Add kanatest

From: Xinglu Chen <[email-masked]>
Date: Tue, 25 May 2021 10:32:21 +0200

On Tue, May 25 2021, Nicolò Balzarotti wrote:

> +(define-public kanatest
> +  ;; Latest release tarball is 0.4.8, which is really old and does not build
> +  ;; commit on sourceforge are not tagged, we take the latest
> +  (let ((commit "860e790a35f547cc96669f805d371a5ba3d8daff"))
> +    (package
> +      (name "kanatest")
> +      (version (string-append "0.4.10." (string-take commit 7)))

Use ‘(git-version VERSION REVISION COMMIT)’.

> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url "https://git.code.sf.net/p/kanatest/code")
> +               (commit commit)))
> +         (file-name (git-file-name name version))
> +         (sha256
> +          (base32 "0dz63m9p4ggzw0yb309qmgnl664qb5q268vaa3i9v0i8qsl66d78"))))
> +      (build-system gnu-build-system)
> +      (native-inputs
> +       `(("gettext" ,gettext-minimal)     ; for msgfmt
> +         ("pkg-config" ,pkg-config)))
> +      (inputs
> +       `(("libxml2" ,libxml2)
> +         ("gtk+" ,gtk+)))
> +      (synopsis "Hiragana and Katakana simple flashcard tool")
> +      (description "Kanatest is a Japanese kana (Hiragana and Katakana) simple
> +flashcard tool.
> +
> +During test the Kanatest displays randomly selected kana char (respecting mode
> +and lesson) and waits for user answer expected as romaji equivalent.  This
> +process continues until all questions will be answered or all questions will
> +be answered correctly (depends on options).  At the end of test a short info
> +about drilling time and correctness ratio is displayed.  The results are
> +stored and user can review his performance in any time.")
> +      (home-page "https://kanatest.sourceforge.io/")

Nit: ‘home-page’ usually comes before ‘synopsis’.

Otherwise, LGTM!  Builds fine as well.