GNU bug report logs - #48639
28.0.50; tabulated-list-mode: columns move if previous entry was too long

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#53133: closed (28.0.90; tabulated-list-sort doesn't work as
 expected)
Date: Wed, 06 Sep 2023 01:58:03 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 5 Sep 2023 18:57:26 -0700
with message-id <CADwFkm=zePNWwtXDCjDWPX0kWJK+U+Oi_8-OT=NZZwpAzPmrNg <at> mail.gmail.com>
and subject line Re: bug#53133: 28.0.90; tabulated-list-sort doesn't work as expected
has caused the debbugs.gnu.org bug report #48639,
regarding 28.0.90; tabulated-list-sort doesn't work as expected
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
48639: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=48639
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Shingo Tanaka <shingo.fg8 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.90; tabulated-list-sort doesn't work as expected
Date: Sun, 09 Jan 2022 11:03:27 +0900

Hi,

tabulated-list-sort sometimes doesn't work as expected due to the change between
28.0.90 and 28.0.50.

Here is how to reproduce:
1. Open Emacs from terminal with `emacs --no-init-file'
2. Type M-x list-buffers
3. Type C-x o (go to Buffer Menu)
4. Type C-M-Right 5 times to move on to "Fundamental" in "Mode" column
5. Type S 2 times or more to toggle sorting order
6. You will be able to see that "Size" column is selected as the sorting column
   unexpectedly

Looks like below change from 28.0.50 is releated to this issue, because it
disappears when I just rewind this change.

--- tabulated-list.el.org	2022-01-06 22:32:13.936852142 +0900
+++ tabulated-list.el	2022-01-07 15:15:42.000000000 +0900
@@ -574,7 +581,8 @@
       (when not-last-col
         (when (> pad-right 0) (insert (make-string pad-right ?\s)))
         (insert (propertize
-                 (make-string (- width (min width label-width)) ?\s)
+                 ;; We need at least one space to align correctly.
+                 (make-string (- width (min 1 width label-width)) ?\s)
                  'display `(space :align-to ,next-x))))
       (put-text-property opoint (point) 'tabulated-list-column-name name)
       next-x)))

Hope this will be fixed appropriately in the coming major release.

Regards,
Shingo

[Message part 3 (message/rfc822, inline)]

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 53133 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>,
 48639-done <at> debbugs.gnu.org, bugs <at> gnu.support
Subject: Re: bug#53133: 28.0.90; tabulated-list-sort doesn't work as expected
Date: Tue, 5 Sep 2023 18:57:26 -0700

> Indeed, that was the root cause of this.  This bug is now fixed on
> master (commit 2767c89db7).

This bug was accidentally left open, so I'm closing it now.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.