Subject: Re: [bug#48637] [PATCH] website: Add publications page

From: "pelzflorian (Florian Pelz)" <[email-masked]>
Date: Tue, 25 May 2021 15:44:05 +0200

On Mon, May 24, 2021 at 11:35:24PM +0000, Luis Felipe via Guix-patches via wrote:
> Hi,
> 
> This patch adds a new Publications page to the website.

Nice!

I could not test yet, but maybe make the date string in

> +(define (publication->shtml publication)
> +  "Return an SHTML representation of the given publication object.
> +
> +   PUBLICATION (<publication>)
> +     A publication object as defined in (apps media types)."
> +  `(a
> +    (@ (class "publication-preview")
> +       (href ,(publication-url publication)))
> +
> +    (h3
> +     (@ (lang ,(publication-language publication))
> +        (class "publication-title"))
> +     ,(publication-title publication))
> +
> +    (p
> +     (@ (class "publication-info"))
> +     ,(G_ `("Published "
> +            ,(date->string (publication-date publication) "~b ~d, ~Y")

translatable like website/apps/blog/templates/components.scm line 33.

> +(define (publication-list-t publications)
> +  "Return the Publication list page in SHTML.
> +
> +   PUBLICATIONS (list of <publication>)
> +     See the (apps media types) module for information on the
> +     <publication> type."
> +  (theme
> +   #:title (C_ "webpage title" '("Publications"))
> +   #:description
> +   (G_ "A list of written publications about GNU Guix.")
> +   #:keywords
> +   ;; TRANSLATORS: |-separated list of webpage keywords.
> +   (string-split (G_ "Publications|Papers") #\|)

I don’t know, but should there really be only none of the other pages’
SEO keywords?  All other occurrences of #:keywords begin with

GNU|Linux|Unix|Free software

Regards,
Florian