Subject: [bug#48637] [PATCH] website: Add publications page

From: Luis Felipe <[email-masked]>
Date: Tue, 25 May 2021 14:37:03 +0000

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Tuesday, May 25, 2021 1:44 PM, pelzflorian (Florian Pelz) <[email-masked]> wrote:

> On Mon, May 24, 2021 at 11:35:24PM +0000, Luis Felipe via Guix-patches via wrote:
>
> > Hi,
> > This patch adds a new Publications page to the website.
>
> Nice!
>
> I could not test yet, but maybe make the date string in
>
> > +(define (publication->shtml publication)
> >
> > -   "Return an SHTML representation of the given publication object.
> > -
> > -   PUBLICATION (<publication>)
> > -       A publication object as defined in (apps media types)."
> >
> >
> > -   `(a
> > -   (@ (class "publication-preview")
> > -         (href ,(publication-url publication)))
> >
> >
> > -
> > -   (h3
> > -       (@ (lang ,(publication-language publication))
> >
> >
> > -          (class "publication-title"))
> >
> >
> > -       ,(publication-title publication))
> >
> >
> > -
> > -   (p
> > -       (@ (class "publication-info"))
> >
> >
> > -       ,(G_ `("Published "
> >
> >
> > -              ,(date->string (publication-date publication) "~b ~d, ~Y")
> >
> >
>
> translatable like website/apps/blog/templates/components.scm line 33.

Yeah. Would it as follows? (I still struggle with i18n):

(p
 (@ (class "publication-info"))
 ,(G_ `("Published "
        ,(date->string (publication-date publication)
                       (C_ "SRFI-19 date->string format" "~b ~d, ~Y"))
        " by "
        ,(string-join (publication-authors publication) ", "))))

Also, I think the delimiter for "string-join" in the list of authors should be translated because that comma is not used in Japanese, for example. So would it be ok like this:

(p
 (@ (class "publication-info"))
 ,(G_ `("Published "
        ,(date->string (publication-date publication)
                       (C_ "SRFI-19 date->string format" "~b ~d, ~Y"))
        " by "
        ,(string-join (publication-authors publication)
                      (C_ "Separator of items in a list" ", ")))))

I'm still unsure about when I should use a context and when a TRANSLATORS comment...

> > +(define (publication-list-t publications)
> >
> > -   "Return the Publication list page in SHTML.
> > -
> > -   PUBLICATIONS (list of <publication>)
> > -       See the (apps media types) module for information on the
> >
> >
> > -       <publication> type."
> >
> >
> > -   (theme
> > -   #:title (C_ "webpage title" '("Publications"))
> > -   #:description
> > -   (G_ "A list of written publications about GNU Guix.")
> > -   #:keywords
> > -   ;; TRANSLATORS: |-separated list of webpage keywords.
> > -   (string-split (G_ "Publications|Papers") #\|)
>
> I don’t know, but should there really be only none of the other pages’
> SEO keywords? All other occurrences of #:keywords begin with
>
> GNU|Linux|Unix|Free software

Hmm, I don't know... Last time I checked, I think I saw that search engines care more about the page content than meta keywords. So I don't think it would make a difference.

Also, if it turns out to be important to repeat these keywords in all pages, maybe it would be better to add these by default in (apps base templates theme).