From unknown Tue Jun 17 20:40:15 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#48634] [PATCH] import: opam: Generate license for package. Resent-From: Xinglu Chen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 24 May 2021 21:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 48634 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 48634@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16218914843112 (code B ref -1); Mon, 24 May 2021 21:25:02 +0000 Received: (at submit) by debbugs.gnu.org; 24 May 2021 21:24:44 +0000 Received: from localhost ([127.0.0.1]:44032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llI44-0000o6-E4 for submit@debbugs.gnu.org; Mon, 24 May 2021 17:24:44 -0400 Received: from lists.gnu.org ([209.51.188.17]:57756) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llI40-0000nv-C9 for submit@debbugs.gnu.org; Mon, 24 May 2021 17:24:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47364) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llI40-0007tE-54 for guix-patches@gnu.org; Mon, 24 May 2021 17:24:40 -0400 Received: from h87-96-130-155.cust.a3fiber.se ([87.96.130.155]:51778 helo=mail.yoctocell.xyz) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llI3y-0006a2-8u for guix-patches@gnu.org; Mon, 24 May 2021 17:24:39 -0400 From: Xinglu Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yoctocell.xyz; s=mail; t=1621891469; bh=ol3kUULAVYb5K6tPMQ5qcw+9rojZEoGMZNdYW4FjcpA=; h=From:To:Subject:Date; b=I5PR8AnCG8vmN8W1SwiAXAZn3B8qwSLDwrYG+NLifo4pPc8dDAmnJo6EV0YEqWIUQ nnlkQEkpsYnjO2hBMgwTAngd6iUt/mht9fZCXQQXOZNcmHcGFguqcCYNFzzMpSkWVc MllG01VMdEpdw8GiU+vIsl7FIKPpTL4NmNhUrODM= Message-Id: <64e9ab50f40879b397587184cdcc1b8d0ba3eb42.1621891264.git.public@yoctocell.xyz> Date: Mon, 24 May 2021 23:24:28 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=87.96.130.155; envelope-from=public@yoctocell.xyz; helo=mail.yoctocell.xyz X-Spam_score_int: 33 X-Spam_score: 3.3 X-Spam_bar: +++ X-Spam_report: (3.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FROM_SUSPICIOUS_NTLD=0.498, FROM_SUSPICIOUS_NTLD_FP=1.896, PDS_OTHER_BAD_TLD=1.997, RDNS_DYNAMIC=0.982, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 3.1 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * guix/import/opam.scm (opam->guix-package): Generate license for the =?UTF-8?Q?=E2=80=98license=E2=80=99?= field. * tests/opam.scm (test-opam-file): Update accordingly. ("opam->guix-package"): Likewise. --- It uses SPDX ite [...] Content analysis details: (3.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.17 listed in list.dnswl.org] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: yoctocell.xyz (xyz)] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [209.51.188.17 listed in wl.mailspike.net] 1.9 FROM_SUSPICIOUS_NTLD_FP From abused NTLD 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) * guix/import/opam.scm (opam->guix-package): Generate license for the =E2=80=98license=E2=80=99 field. * tests/opam.scm (test-opam-file): Update accordingly. ("opam->guix-package"): Likewise. --- It uses SPDX itentifiers. =20=20=20 guix/import/opam.scm | 4 +++- tests/opam.scm | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/guix/import/opam.scm b/guix/import/opam.scm index 670973b193..0201376457 100644 --- a/guix/import/opam.scm +++ b/guix/import/opam.scm @@ -1,6 +1,7 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright =C2=A9 2018 Julien Lepiller ;;; Copyright =C2=A9 2020 Martin Becze +;;; Copyright =C2=A9 2021 Xinglu Chen ;;; ;;; This file is part of GNU Guix. ;;; @@ -335,7 +336,8 @@ or #f on failure." (home-page ,(metadata-ref opam-content "homepage")) (synopsis ,(metadata-ref opam-content "synopsis")) (description ,(metadata-ref opam-content "descripti= on")) - (license #f)) + (license ,(spdx-string->license + (metadata-ref opam-content "license")))) (filter (lambda (name) (not (member name '("dune" "jbuilder")))) diff --git a/tests/opam.scm b/tests/opam.scm index 11984b56a6..f1e3b70cb0 100644 --- a/tests/opam.scm +++ b/tests/opam.scm @@ -1,5 +1,6 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright =C2=A9 2018 Julien Lepiller +;;; Copyright =C2=A9 2021 Xinglu Chen ;;; ;;; This file is part of GNU Guix. ;;; @@ -55,6 +56,7 @@ depends: [ synopsis: \"Some example package\" description: \"\"\" This package is just an example.\"\"\" +license: \"BSD-3-Clause\" url { src: \"https://example.org/foo-1.0.0.tar.gz\" checksum: \"md5=3D74c6e897658e820006106f45f736381f\" @@ -109,7 +111,7 @@ url { ('home-page "https://example.org/") ('synopsis "Some example package") ('description "This package is just an example.") - ('license #f)) + ('license 'license:bsd-3)) (string=3D? (bytevector->nix-base32-string test-source-hash) hash)) base-commit: 488fc3d2e6e0a3d5fc4fe747587cf831989ece58 --=20 2.31.1 From unknown Tue Jun 17 20:40:15 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Xinglu Chen Subject: bug#48634: closed (Re: bug#48634: [PATCH] import: opam: Generate license for package.) Message-ID: References: <87h7injjoe.fsf@gnu.org> <64e9ab50f40879b397587184cdcc1b8d0ba3eb42.1621891264.git.public@yoctocell.xyz> X-Gnu-PR-Message: they-closed 48634 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 48634@debbugs.gnu.org Date: Fri, 28 May 2021 09:24:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1622193842-31035-1" This is a multi-part message in MIME format... ------------=_1622193842-31035-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #48634: [PATCH] import: opam: Generate license for package. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 48634@debbugs.gnu.org. --=20 48634: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D48634 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1622193842-31035-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 48634-done) by debbugs.gnu.org; 28 May 2021 09:23:58 +0000 Received: from localhost ([127.0.0.1]:53620 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lmYij-00084J-Qe for submit@debbugs.gnu.org; Fri, 28 May 2021 05:23:57 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35686) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lmYii-000844-4n for 48634-done@debbugs.gnu.org; Fri, 28 May 2021 05:23:56 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56156) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lmYib-0001d5-TA; Fri, 28 May 2021 05:23:49 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=35058 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lmYiY-00027C-Su; Fri, 28 May 2021 05:23:49 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Xinglu Chen Subject: Re: bug#48634: [PATCH] import: opam: Generate license for package. References: <64e9ab50f40879b397587184cdcc1b8d0ba3eb42.1621891264.git.public@yoctocell.xyz> Date: Fri, 28 May 2021 11:23:45 +0200 In-Reply-To: <64e9ab50f40879b397587184cdcc1b8d0ba3eb42.1621891264.git.public@yoctocell.xyz> (Xinglu Chen's message of "Mon, 24 May 2021 23:24:28 +0200") Message-ID: <87h7injjoe.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.3 (/) X-Debbugs-Envelope-To: 48634-done Cc: 48634-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) Hi, Xinglu Chen skribis: > * guix/import/opam.scm (opam->guix-package): Generate license for the > =E2=80=98license=E2=80=99 field. > * tests/opam.scm (test-opam-file): Update accordingly. > ("opam->guix-package"): Likewise. Applied, thanks! Ludo=E2=80=99. ------------=_1622193842-31035-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 24 May 2021 21:24:44 +0000 Received: from localhost ([127.0.0.1]:44032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llI44-0000o6-E4 for submit@debbugs.gnu.org; Mon, 24 May 2021 17:24:44 -0400 Received: from lists.gnu.org ([209.51.188.17]:57756) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llI40-0000nv-C9 for submit@debbugs.gnu.org; Mon, 24 May 2021 17:24:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47364) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llI40-0007tE-54 for guix-patches@gnu.org; Mon, 24 May 2021 17:24:40 -0400 Received: from h87-96-130-155.cust.a3fiber.se ([87.96.130.155]:51778 helo=mail.yoctocell.xyz) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llI3y-0006a2-8u for guix-patches@gnu.org; Mon, 24 May 2021 17:24:39 -0400 From: Xinglu Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yoctocell.xyz; s=mail; t=1621891469; bh=ol3kUULAVYb5K6tPMQ5qcw+9rojZEoGMZNdYW4FjcpA=; h=From:To:Subject:Date; b=I5PR8AnCG8vmN8W1SwiAXAZn3B8qwSLDwrYG+NLifo4pPc8dDAmnJo6EV0YEqWIUQ nnlkQEkpsYnjO2hBMgwTAngd6iUt/mht9fZCXQQXOZNcmHcGFguqcCYNFzzMpSkWVc MllG01VMdEpdw8GiU+vIsl7FIKPpTL4NmNhUrODM= To: guix-patches@gnu.org Subject: [PATCH] import: opam: Generate license for package. Message-Id: <64e9ab50f40879b397587184cdcc1b8d0ba3eb42.1621891264.git.public@yoctocell.xyz> Date: Mon, 24 May 2021 23:24:28 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=87.96.130.155; envelope-from=public@yoctocell.xyz; helo=mail.yoctocell.xyz X-Spam_score_int: 33 X-Spam_score: 3.3 X-Spam_bar: +++ X-Spam_report: (3.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FROM_SUSPICIOUS_NTLD=0.498, FROM_SUSPICIOUS_NTLD_FP=1.896, PDS_OTHER_BAD_TLD=1.997, RDNS_DYNAMIC=0.982, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 3.1 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * guix/import/opam.scm (opam->guix-package): Generate license for the ‘license’ field. * tests/opam.scm (test-opam-file): Update accordingly. ("opam->guix-package"): Likewise. --- It uses SPDX ite [...] Content analysis details: (3.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.17 listed in list.dnswl.org] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: yoctocell.xyz (xyz)] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [209.51.188.17 listed in wl.mailspike.net] 1.9 FROM_SUSPICIOUS_NTLD_FP From abused NTLD 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) * guix/import/opam.scm (opam->guix-package): Generate license for the =E2=80=98license=E2=80=99 field. * tests/opam.scm (test-opam-file): Update accordingly. ("opam->guix-package"): Likewise. --- It uses SPDX itentifiers. =20=20=20 guix/import/opam.scm | 4 +++- tests/opam.scm | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/guix/import/opam.scm b/guix/import/opam.scm index 670973b193..0201376457 100644 --- a/guix/import/opam.scm +++ b/guix/import/opam.scm @@ -1,6 +1,7 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright =C2=A9 2018 Julien Lepiller ;;; Copyright =C2=A9 2020 Martin Becze +;;; Copyright =C2=A9 2021 Xinglu Chen ;;; ;;; This file is part of GNU Guix. ;;; @@ -335,7 +336,8 @@ or #f on failure." (home-page ,(metadata-ref opam-content "homepage")) (synopsis ,(metadata-ref opam-content "synopsis")) (description ,(metadata-ref opam-content "descripti= on")) - (license #f)) + (license ,(spdx-string->license + (metadata-ref opam-content "license")))) (filter (lambda (name) (not (member name '("dune" "jbuilder")))) diff --git a/tests/opam.scm b/tests/opam.scm index 11984b56a6..f1e3b70cb0 100644 --- a/tests/opam.scm +++ b/tests/opam.scm @@ -1,5 +1,6 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright =C2=A9 2018 Julien Lepiller +;;; Copyright =C2=A9 2021 Xinglu Chen ;;; ;;; This file is part of GNU Guix. ;;; @@ -55,6 +56,7 @@ depends: [ synopsis: \"Some example package\" description: \"\"\" This package is just an example.\"\"\" +license: \"BSD-3-Clause\" url { src: \"https://example.org/foo-1.0.0.tar.gz\" checksum: \"md5=3D74c6e897658e820006106f45f736381f\" @@ -109,7 +111,7 @@ url { ('home-page "https://example.org/") ('synopsis "Some example package") ('description "This package is just an example.") - ('license #f)) + ('license 'license:bsd-3)) (string=3D? (bytevector->nix-base32-string test-source-hash) hash)) base-commit: 488fc3d2e6e0a3d5fc4fe747587cf831989ece58 --=20 2.31.1 ------------=_1622193842-31035-1--