GNU bug report logs - #48633
[PATCH]: Clean up gnu/packages/tryton.scm

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Maxime Devos <maximedevos <at> telenet.be>
Subject: bug#48633: closed (Re: bug#48633: [PATCH]: Clean up
 gnu/packages/tryton.scm)
Date: Fri, 28 May 2021 09:36:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#48633: [PATCH]: Clean up gnu/packages/tryton.scm

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 48633 <at> debbugs.gnu.org.

-- 
48633: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=48633
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: Adriano Peluso <catonano <at> gmail.com>, Vinicius Monego <monego <at> posteo.net>,
 48633-done <at> debbugs.gnu.org
Subject: Re: bug#48633: [PATCH]: Clean up gnu/packages/tryton.scm
Date: Fri, 28 May 2021 11:35:25 +0200

Howdy,

Maxime Devos <maximedevos <at> telenet.be> skribis:

> From 94fef963a6f5c0d8b0c60a5b2279ade8d686d4ec Mon Sep 17 00:00:00 2001
> From: Maxime Devos <maximedevos <at> telenet.be>
> Date: Mon, 24 May 2021 22:36:06 +0200
> Subject: [PATCH 3/3] gnu: tryton: Allow disabling the test suite.
>
> * gnu/packages/tryton.scm
>   (tryton-phases): Respect 'tests?' in the 'check' phase.

[...]

> From 3c05280e51e2b8bd7c03e460975169eee512cbf0 Mon Sep 17 00:00:00 2001
> From: Maxime Devos <maximedevos <at> telenet.be>
> Date: Mon, 24 May 2021 22:17:09 +0200
> Subject: [PATCH 2/3] gnu: tryton: Use local 'inputs' instead of global
>  '%build-inputs'.
>
> The former is preferred above the latter.
>
> * gnu/packages/tryton.scm (tryton-phases): Look up "trytond" in the
>   'inputs' argument instead of in '%build-inputs'.

[...]

> From aa0f2aabf11a45d47b8b8d287aa95d85ee35181c Mon Sep 17 00:00:00 2001
> From: Maxime Devos <maximedevos <at> telenet.be>
> Date: Mon, 24 May 2021 21:07:15 +0200
> Subject: [PATCH 1/3] =?UTF-8?q?gnu:=20tryton:=20Factor=20out=20custom=20?=
>  =?UTF-8?q?=E2=80=98check=E2=80=99=20phase.?=
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> * gnu/packages/tryton.scm
>   (tryton-phases): New procedure.
>   (tryton-arguments): New procedure.
>   (python-trytond-account)[arguments]: Use 'tryton-phases'.
>   (python-trytond-account-invoice)[arguments]: Likewise.
>   (python-trytond-account-invoice-stock)[arguments]: Likewise.
>   (python-trytond-account-product)[arguments]: Likewise.
>   (python-trytond-analytic-account)[arguments]: Likewise.
>   (python-trytond-company)[arguments]: Likewise.
>   (python-trytond-country)[arguments]: Likewise.
>   (python-trytond-currency)[arguments]: Likewise.
>   (python-trytond-party)[arguments]: Likewise.
>   (python-trytond-product)[arguments]: Likewise.
>   (python-trytond-purchase)[arguments]: Likewise.
>   (python-trytond-purchase-request)[arguments]: Likewise.
>   (python-trytond-stock)[arguments]: Likewise.
>   (python-trytond-stock-lot)[arguments]: Likewise.

Applied, thanks!

Ludo’.

[Message part 3 (message/rfc822, inline)]

From: Maxime Devos <maximedevos <at> telenet.be>
To: guix-patches <at> gnu.org
Cc: Adriano Peluso <catonano <at> gmail.com>, Vinicius Monego <monego <at> posteo.net>
Subject: [PATCH]: Clean up gnu/packages/tryton.scm
Date: Mon, 24 May 2021 22:53:48 +0200

[Message part 4 (text/plain, inline)]

CC'ing two people who are listed in the copyright lines.

Patch #1: factor out code the 'check' phase of tryton modules
  in a procedure, as they are almost all exactly the same except
  for the module name.

  This one does not cause any change in derivation (no rebuilds).

Patch #2: Use 'inputs' argument to the 'check' phase instead of
  %build-inputs.

  I tried building some tryton modules and it seemed to work well.
  No failures, but I didn't try all.

Patch #3: Respect tests?, allow --without-tests.

  I tested building a single tryton module.

Greetings,
Maxime.

[0003-gnu-tryton-Allow-disabling-the-test-suite.patch (text/x-patch, attachment)]

[0002-gnu-tryton-Use-local-inputs-instead-of-global-build-.patch (text/x-patch, attachment)]

[0001-gnu-tryton-Factor-out-custom-check-phase.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.