GNU bug report logs - #48633
[PATCH]: Clean up gnu/packages/tryton.scm

Previous Next

Package: guix-patches;

Reported by: Maxime Devos <maximedevos <at> telenet.be>

Date: Mon, 24 May 2021 20:55:01 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Maxime Devos <maximedevos <at> telenet.be>
To: 48633 <at> debbugs.gnu.org
Cc: Adriano Peluso <catonano <at> gmail.com>, Vinicius Monego <monego <at> posteo.net>
Subject: [bug#48633] [PATCH]: Clean up gnu/packages/tryton.scm
Date: Mon, 24 May 2021 22:53:48 +0200

[Message part 1 (text/plain, inline)]
CC'ing two people who are listed in the copyright lines.

Patch #1: factor out code the 'check' phase of tryton modules
  in a procedure, as they are almost all exactly the same except
  for the module name.

  This one does not cause any change in derivation (no rebuilds).

Patch #2: Use 'inputs' argument to the 'check' phase instead of
  %build-inputs.

  I tried building some tryton modules and it seemed to work well.
  No failures, but I didn't try all.

Patch #3: Respect tests?, allow --without-tests.

  I tested building a single tryton module.

Greetings,
Maxime.

[0003-gnu-tryton-Allow-disabling-the-test-suite.patch (text/x-patch, attachment)]
[0002-gnu-tryton-Use-local-inputs-instead-of-global-build-.patch (text/x-patch, attachment)]
[0001-gnu-tryton-Factor-out-custom-check-phase.patch (text/x-patch, attachment)]
[signature.asc (application/pgp-signature, inline)]
This bug report was last modified 3 years and 354 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.