GNU bug report logs - #48603
27.2; [PATCH] Quit minibuffers without aborting kmacros

Previous Next

Package: emacs;

Reported by: miha <at> kamnitnik.top

Date: Sun, 23 May 2021 14:32:02 UTC

Severity: normal

Tags: patch

Found in version 27.2

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 48603 <at> debbugs.gnu.org, miha <at> kamnitnik.top
Subject: bug#48603: 27.2; [PATCH] Quit minibuffers without aborting kmacros
Date: Tue, 17 Aug 2021 23:45:15 +0100
[Message part 1 (text/plain, inline)]
Lars Ingebrigtsen [2021-07-20 14:37 +0200] wrote:

> <miha <at> kamnitnik.top> writes:
>
>> Good idea, attaching a revised patch (which also adds two NEWS entries.)
>
> Sorry; I forgot all about this.  I've now re-read and tested the patch,
> and it seems to work fine for me, so I've pushed it to Emacs 28.

Thanks, but given the following file quit.el, which is distilled from
the Ivy package's batch-run test suite:

[quit.el (application/emacs-lisp, inline)]
[Message part 3 (text/plain, inline)]
the patch gives rise to the following change in behaviour.

Before:

  $ emacs -Q -batch -l quit.el

  (quit)
  $ echo $?
  0

After:

  $ emacs -Q -batch -l quit.el
  Quit
  $ echo $?
  255

IOW, it's no longer possible to catch the quit around execute-kbd-macro.
I tried wrapping it in (catch 'exit ...) as well, but to no avail.
Surely it should always be possible to catch a quit condition from Lisp?

Thanks,

-- 
Basil

This bug report was last modified 3 years and 337 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.