From debbugs-submit-bounces@debbugs.gnu.org Sat May 22 07:37:55 2021 Received: (at submit) by debbugs.gnu.org; 22 May 2021 11:37:55 +0000 Received: from localhost ([127.0.0.1]:38391 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lkPx4-00041Z-RE for submit@debbugs.gnu.org; Sat, 22 May 2021 07:37:55 -0400 Received: from lists.gnu.org ([209.51.188.17]:45894) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lkPx3-00041S-Tl for submit@debbugs.gnu.org; Sat, 22 May 2021 07:37:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38544) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lkPx3-0001VL-LP for bug-gnu-emacs@gnu.org; Sat, 22 May 2021 07:37:53 -0400 Received: from mail-ej1-x636.google.com ([2a00:1450:4864:20::636]:33721) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lkPx1-0005Wa-2w for bug-gnu-emacs@gnu.org; Sat, 22 May 2021 07:37:53 -0400 Received: by mail-ej1-x636.google.com with SMTP id z12so32883689ejw.0 for ; Sat, 22 May 2021 04:37:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=ItqNIsK1d0YZds13wikFBGHHw+B/M2WtiKV2j8X1Jug=; b=MKQ80ERl9Morl7mgb0enQlCSZbHL3pEFk1sPakhna8HOQ4lsWW+/QCyEDQh2MjPJJw d0DTqNQNy7AjVhIZIZtZHiQf9SEY02CMQ2LqxASVSTC26YzBIwVycVG0LJFETenZotDl rGg/NE/U+1LgocN+aBe+uAkkSFEchICZ6a0DlmpBDV81DumUsRMXfx2/h4vUeNOgj9zz rQlx6k+8CfT7ZlY1Y9dUOI97aTX6Hu9zvVOZgv0xpSpz/618CK/KHyv8/lVEtQVc6JAL w1n6KXCl1GI+BnCkvtBkfmONrtIwDcdnjPsPPoC0CkLi3TgE0utjhyP1kEON794rNL0N /tFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=ItqNIsK1d0YZds13wikFBGHHw+B/M2WtiKV2j8X1Jug=; b=SrzfJQ8K42WI32SMnbuy4MuTyTJNA2fkEr/EaPt/SwvZypuOiPGJqO5An/qZLirZKc 5mf5iulN+ueiCBudWROf1DUhYLME2t7pxB3azKaS49DJgV78b20GmCA03NZVmGXfbNkw z67nZPKApwJ4rMg/UnaCqsLTiTfw5HOq1FrxNs7L99gEheTEbULLc6zo1VPhmpGgKDvy glUnhHQyABEgJoEW7NVHSx5316ciZArYzrbJJ28sG2nSzyiDSkqvsX0qhOrgLz1PPKoE LSODOoaJ536jM5gbUVvvQ7ztoGj5bNl5oAHGd4lqEeE6ezsjJ8AYVPZrpMWOwgS28ETJ 4AFg== X-Gm-Message-State: AOAM533I7lL2ty7VBg05j+7NblhW8TeNk+8+8/Yupa1EFmLyDNjqmiFx 6yHOyfiWamZwENsRPlta1ZY6FODC83jtWw== X-Google-Smtp-Source: ABdhPJxbo9YuUiTKnkE6nbipUjosjvQ06jFK6UwPo5wZyWgKMtzDBBRjV99BimvBZRZGphvM13m9oA== X-Received: by 2002:a17:906:a84e:: with SMTP id dx14mr14279161ejb.220.1621683469290; Sat, 22 May 2021 04:37:49 -0700 (PDT) Received: from Philipps-MBP.fritz.box ([46.128.198.100]) by smtp.gmail.com with ESMTPSA id ia23sm1133227ejc.70.2021.05.22.04.37.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 May 2021 04:37:48 -0700 (PDT) From: Philipp To: bug-gnu-emacs@gnu.org Subject: 28.0.50; Missing Edebug instrumentation for some 'if-let' variants Date: Sat, 22 May 2021 13:37:48 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::636; envelope-from=p.stephani2@gmail.com; helo=mail-ej1-x636.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) Instrument the following definition using C-u C-M-x: (defun f (x) (if-let* (x) 1)) Then, evaluate this form: (f 2) Edebug will step into 'f', but won't stop at 'x'. The problem lies in this part of the Edebug specification for 'if-let*': [&or symbolp (symbolp form) (form)] The 'symbolp' specification element causes Edebug to not instrument the 'x' symbol. However, the 'symbolp' specification is also necessary here; we couldn't just replace it with 'form' because that would make the branches overlap. What we'd need here is something like [&and symbolp form], i.e. match only in case of a symbol, but also instrument as a form. IIUC Edebug doesn't support such constructs yet. In GNU Emacs 28.0.50 (build 125, aarch64-apple-darwin20.4.0, NS appkit-2022.44 Version 11.3.1 (Build 20E241)) of 2021-05-22 Repository revision: 91fa95bde0619b4f3bc7d93d06c7c75998b1588d Repository branch: master Windowing system distributor 'Apple', version 10.3.2022 System Description: macOS 11.3.1 Configured using: 'configure --with-modules --without-xml2 --without-pop --with-mailutils --enable-gcc-warnings=warn-only --enable-checking=all --enable-check-lisp-object-type 'CFLAGS=-ggdb3 -O0'' Configured features: ACL GNUTLS JSON LCMS2 MODULES NOTIFY KQUEUE NS PDUMPER PNG THREADS TOOLKIT_SCROLL_BARS ZLIB Important settings: value of $LANG: de_DE.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc dired dired-loaddefs rfc822 mml mml-sec epa epg epg-config gnus-util rmail rmail-loaddefs time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils phst skeleton derived edmacro kmacro pcase ffap thingatpt url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map url-vars mailcap rx gnutls puny dbus xml subr-x seq byte-opt gv bytecomp byte-compile cconv compile text-property-search comint ansi-color ring cl-loaddefs cl-lib iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads kqueue cocoa ns lcms2 multi-tty make-network-process emacs) Memory information: ((conses 16 70783 6422) (symbols 48 8363 1) (strings 32 24254 2096) (string-bytes 1 793113) (vectors 16 16076) (vector-slots 8 212949 7797) (floats 8 26 28) (intervals 56 219 0) (buffers 992 10)) From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 15 06:16:42 2022 Received: (at 48585) by debbugs.gnu.org; 15 Jul 2022 10:16:42 +0000 Received: from localhost ([127.0.0.1]:39510 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCINF-0005kJ-VP for submit@debbugs.gnu.org; Fri, 15 Jul 2022 06:16:42 -0400 Received: from quimby.gnus.org ([95.216.78.240]:45018) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCINC-0005k1-H9 for 48585@debbugs.gnu.org; Fri, 15 Jul 2022 06:16:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=REK+tx2n9PL3N+UDz0D4DAe5aE3PKFXbGJ4sL99ra1c=; b=R2FDZdwXVAkyS+CPI5Ti5Yjhj9 aRyub5K5PR+S3zeD2l3pLD6x+afNnPvBPhbiDg7har3ONkmX9W4oQfCrOQzDxXMq7i0qX0dmIVZ1i u9Va3wg1C2sPc9DUCiWH94/iRKnvdfCAJ0KSmFtxl/xlrUpWYHijFMtFzDYMl5ikVAMk=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oCIN1-0005SH-6e; Fri, 15 Jul 2022 12:16:29 +0200 From: Lars Ingebrigtsen To: Philipp Subject: Re: bug#48585: 28.0.50; Missing Edebug instrumentation for some 'if-let' variants In-Reply-To: (Philipp's message of "Sat, 22 May 2021 13:37:48 +0200") References: X-Now-Playing: Peter Broderick's _Blackberry_: "Wild Food" Date: Fri, 15 Jul 2022 12:16:25 +0200 Message-ID: <87wncen0jq.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Philipp writes: > Instrument the following definition using C-u C-M-x: > (defun f (x) (if-let* (x) 1)) > > Then, evaluate this form: > (f 2) > > Edebug will step into 'f', but won't stop at 'x'. > > The problem lies [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48585 Cc: 48585@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Philipp writes: > Instrument the following definition using C-u C-M-x: > (defun f (x) (if-let* (x) 1)) > > Then, evaluate this form: > (f 2) > > Edebug will step into 'f', but won't stop at 'x'. > > The problem lies in this part of the Edebug specification for 'if-let*': > > [&or symbolp (symbolp form) (form)] > > The 'symbolp' specification element causes Edebug to not instrument the > 'x' symbol. However, the 'symbolp' specification is also necessary > here; we couldn't just replace it with 'form' because that would make > the branches overlap. What we'd need here is something like > [&and symbolp form], i.e. match only in case of a symbol, but also > instrument as a form. IIUC Edebug doesn't support such constructs yet. Perhaps Stefan has some comments here; added to the CCs. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 15 19:15:20 2022 Received: (at 48585) by debbugs.gnu.org; 15 Jul 2022 23:15:20 +0000 Received: from localhost ([127.0.0.1]:42380 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCUWm-0004PH-AB for submit@debbugs.gnu.org; Fri, 15 Jul 2022 19:15:20 -0400 Received: from mout.web.de ([212.227.15.4]:41285) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCUWh-0004Oy-OC for 48585@debbugs.gnu.org; Fri, 15 Jul 2022 19:15:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1657926909; bh=eFgqC+Pv4g6bVsy6Wb44zwT7506iUyfTAVdULKVc3WE=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=IBsz6pruos5CNrgQUEQDd5q4+I3YXyIWglW2iPsVqd3tkc4tRYY9EB7DxzlcVKmix 59ygjk3T0oZ5Ur8OYlVYNkFzbxfA6/R7NTdEdhy8FP/8oHLivsbFmLjQRJcQENWkuD //urvhWKtI7krwk5wiBmcCUKXOx9lQdg1dQe0D80= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([84.57.248.18]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1Myf3x-1nK6JU0LdN-00yrdD; Sat, 16 Jul 2022 01:15:09 +0200 From: Michael Heerdegen To: Philipp Subject: Re: bug#48585: 28.0.50; Missing Edebug instrumentation for some 'if-let' variants In-Reply-To: (Philipp's message of "Sat, 22 May 2021 13:37:48 +0200") References: Date: Sat, 16 Jul 2022 01:15:06 +0200 Message-ID: <87v8ry2cjp.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:H+d6GBd4JwEI6U42Zo8Bu0MFKrBTsRlhUQwqXyDbrvQ0ZR4TrZo CqbOqJx+ijcJF68RHhQ/ddf8GFZEGXXBW+Cd08ua+4W3JSF0tmv7W3jvocUF8NM9MG8tAfU BFYJdnH4eeAb9Mw9v2I59OY7725TjHl6b0VBnAWSNeaRF8KK8ELZ/IqurccLFaqfodlquUm 8RQbfF0eEZp60s4wh4xZQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:z+Pjes4ZtkQ=:OvxEUfeAOiSafT8Py3kQLw helqUX5rwsbBGHzOaklhpX6cp2Ze5ncgRpSnOyast8zMxnMoXFuTG/nr8+m1aHM55Emyy86hC Q79rRRGXXa7bMlVv5D57Oshmrz04uc+fq+unezI6fpdcRlAM0ADYyrk85HODLlFLpsenGIXDT hXkLPGj0Q90DQBlY0349yZksygq2LYRt3goWL3kgP95ewCst2/ErVDzGBvHqfAB37/VnOWLDh gpjFUQUEZW4V3TxnK7VHRhH0JhOHWX/ZGCdktXtfkkszhFbfT8wtUPnqizubgkg47UNfU5ZRP WVV/pJRHGdNnnIidM7pqVjXRPsYkrGL8YAKL7lFe+t0vd8uFd2s6ooQ8g7jJlxk5dIhmfwtwb aCgVBMqXP13mZWq1XNDb1GF1kAdtHmcycSwwztkVjJhfjxKNxvKvQzAowJ+OicmQeh/NvyJN8 SuxD9j6L2+T2k5aR+hLUX5LnOZhFu/VvjmFNO7bnN1QAFER67XojpAApgQSlg5XZcChpAUGYs 4076WGvquUafws7LR8RD/kbLTRWuCXcla4fvjC3hn4aJW4pz6k+5G47cj9UCVmCXeoUExyPdT W7P43D4j+T3MQyFYV3ZAKEhD4zJClt+1nKca6fY4rSYFlb05B4eZLFYrgEDNZbARVT/KBcaD0 +s729lFqxg6HGTpomTPUU1XIrP18XQUzPljWV3fxeBDfeyT9N2x2ctS89ZhLlFm9iL0aoL8I4 tKA4Dcd7k3y2X0q/OfOlQ5ui2FTd6yCT2PHEQ9tiVZD5ut+ZGsqKyegT0l7SbRpVv4e6ZvYbx 0FNfIKBjfeGxJCPItjJK9V6DXIyLT6wrdCHoLOzQtl/xK5D1DwzChZkUXwgqP01nQ2ZsyoKSR DKWtZsOBrnQXcXHFtYCMldR58rXqxMXKmUQgHhfUesNtSp5MyitaTwcosdig/6Ns0+vzqEMyM LupMOuJRU6x85WJ1gHMjOBuEKbTmZES6s0g+tWsX6bVtHzBuqW29ghYWT42pKBV7JUDRNoz9X LEEoo1Ki3CnaJNneozVVoemxmhLGn+ndpyG9X2IOv+4ZGlSwPkBOow0Gmd3ScM5XJdNX8tgrd ncFpEDdha25hT0Kq2GWIQ9pnKtSXSbVn/d0dYHczbQ8ILFr6RHUJt3CLw== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 48585 Cc: 48585@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Philipp writes: > Instrument the following definition using C-u C-M-x: > (defun f (x) (if-let* (x) 1)) > > Then, evaluate this form: > (f 2) > > Edebug will step into 'f', but won't stop at 'x'. > > The problem lies in this part of the Edebug specification for 'if-let*': > > [&or symbolp (symbolp form) (form)] > > The 'symbolp' specification element causes Edebug to not instrument the > 'x' symbol. However, the 'symbolp' specification is also necessary > here; we couldn't just replace it with 'form' because that would make > the branches overlap. Dunno how bad an overlap is. I tried this: (debug ((&rest [&or (symbolp form) (form) form]) body)) That lets instrumenting error: | internal-macroexpand-for-load: Eager macro-expansion failure: (error | "`let' bindings can have only one value-form" edebug-after 0 1 x) Does that happen because `x` appears as binding _variable_ in the expansion, and Ebebug messes with that? Then we would have a second problem. Michael. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 16 18:26:07 2022 Received: (at 48585) by debbugs.gnu.org; 16 Jul 2022 22:26:07 +0000 Received: from localhost ([127.0.0.1]:46288 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCqEh-0000kU-2P for submit@debbugs.gnu.org; Sat, 16 Jul 2022 18:26:07 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:24209) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCqEe-0000k0-IQ for 48585@debbugs.gnu.org; Sat, 16 Jul 2022 18:26:05 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id A7852441650; Sat, 16 Jul 2022 18:25:58 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 3DE6C4415E5; Sat, 16 Jul 2022 18:25:57 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1658010357; bh=It8M6vAo/ROpkQtTqU+0tnpPo4Lw5bkrYvGrLWnHEsw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Wpq2AFha8nxtEcjOv+s4Q1N+8orjoeXCNT8FTLWCn6Jr4rWO9iCFySEMJ6aSiSC9I lq2gPmUGxZXWMmy93gVSSysLZKBgh0nqCOR7owa5+KwoVDBRxBqsahZj3QmhytqiIS FFsVwZtCx9Oa7NzfvTJXHt4GATuQtSjcYvJ89443ZXkFvmfHUR9ZoJMSv8NE+cDwBZ qvcjGCjDOO6ZjbmmjRyEZbtXLfPH9UTuTTWQr1o9l4KBGW/AvEQqq5gj4u0AOsj+FP cdK7DbFfmcpR5CqaWpTr2hEmdR5Cj5qwa4+f1BjrybIGeBxuOsDkYAhnnfCZlrEigZ EKRKlrPycP/SA== Received: from alfajor (unknown [45.72.196.165]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 053E912084F; Sat, 16 Jul 2022 18:25:56 -0400 (EDT) From: Stefan Monnier To: Lars Ingebrigtsen Subject: Re: bug#48585: 28.0.50; Missing Edebug instrumentation for some 'if-let' variants In-Reply-To: <87wncen0jq.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 15 Jul 2022 12:16:25 +0200") Message-ID: References: <87wncen0jq.fsf@gnus.org> Date: Sat, 16 Jul 2022 18:25:55 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.068 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48585 Cc: Philipp , 48585@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> The 'symbolp' specification element causes Edebug to not instrument the >> 'x' symbol. However, the 'symbolp' specification is also necessary >> here; we couldn't just replace it with 'form' because that would make >> the branches overlap. What we'd need here is something like >> [&and symbolp form], i.e. match only in case of a symbol, but also >> instrument as a form. IIUC Edebug doesn't support such constructs yet. > > Perhaps Stefan has some comments here; added to the CCs. The instrumentation takes place before expanding the macro, so either we instrument the `x` into a form (edebug- ... x ...) or we leave the `x` untouched and have no instrumentation. We can't have it both ways from that side. So if we want the occurrence of `x` which *evaluates* `x` (as opposed to the occurrence that *binds* the new variable) to be instrumented, we need to change the macro to accept a "variable name" of the form (edebug- ... x ...) and somehow strip the edebug instrumentation when we use the argument as a variable name in a binding position. As someone who doesn't much like `if-let`, I'll let someone else figure out how to that somewhat cleanly. Also to be honest I also wonder if that would be worthwhile. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 16 20:13:50 2022 Received: (at submit) by debbugs.gnu.org; 17 Jul 2022 00:13:50 +0000 Received: from localhost ([127.0.0.1]:46364 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCruw-0003R8-0p for submit@debbugs.gnu.org; Sat, 16 Jul 2022 20:13:50 -0400 Received: from lists.gnu.org ([209.51.188.17]:46562) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCrut-0003R0-A0 for submit@debbugs.gnu.org; Sat, 16 Jul 2022 20:13:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45350) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oCrut-0007jB-5S for bug-gnu-emacs@gnu.org; Sat, 16 Jul 2022 20:13:47 -0400 Received: from mout.web.de ([212.227.17.12]:52019) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oCruo-0003u2-KL for bug-gnu-emacs@gnu.org; Sat, 16 Jul 2022 20:13:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1658016804; bh=Qb/ZbyN2q9/sz724rJdNuyFYXMeZVavHrhuVvUADY1M=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=JipZutXMjhMRQxWmm5yNp7GhIB51authGp9OjT1eyoHUJOIlqatt6D14yoIgege7Q YMg/BGRRi79fZVAA2pktZ0Wc2RZBowUaETQfwfNvdhg2xscrmvpdhAYvBrDN5bof4t ddnMVvujMZJk/EJurUHdPmp2jwW9w+KBfUmwCVxQ= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([84.57.248.18]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MgANA-1nc9Fq1S98-00hu0f; Sun, 17 Jul 2022 02:13:24 +0200 From: Michael Heerdegen To: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Subject: Re: bug#48585: 28.0.50; Missing Edebug instrumentation for some 'if-let' variants In-Reply-To: (Stefan Monnier via's message of "Sat, 16 Jul 2022 18:25:55 -0400") References: <87wncen0jq.fsf@gnus.org> Date: Sun, 17 Jul 2022 02:13:22 +0200 Message-ID: <877d4ch9zx.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:dfPEw7h5/7gZAZF5Mt5rztX8X72ijshNvNJcV6lfkgMJusKNrIT kWgz59GRm7+fm1fVjlJvM5a8WsOuqb2T9KzmSvmH/vkODm3dKw6lhFhsASzhFBJzTmxNeb2 MK+AXBW9c4cfnHNTYL2Igo7x0ldSLVMNCdVJDT/702geROp1VSrXs2drqpMYzk25+w3ZvkD TgPDV9ONu8Pk0xkmMKUbg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:YNpamf/xils=:Ou1MiKVCIZKcaSjzQ5bSxQ ZOlAV52dfkWClS8KhGmqAU/jHDSv2dRy0CqsrUb4Fii9YLx5cnh5SSOcobWtYYUAqmcPSHaAW vISDPcUefbyenVGq9lUmp5wvjVQiGzmIYwgwPPMffrr8Jv1b2oXrUx8tkUbxLuI13fsqZ/dZo 83TEokBs/fNuEq3W1CDyvj5O7dYsJR2IRfsXvM00Y22R6FBmKjyQAx9wi9ecEhRCmpVs8OmbH 7/KDi0nN5KCxIbPrXKDub0HGo/Hn8wu+ye5xmycfNMRzBeq8ciN93Udg1hvz/59E0skavXmC4 QkyB91aPvcOqt1dHXn2KAIpoycYP7bFDxcIRpv3XGEd+1Lkn9dhV0eYi5+jWp7/DPnmLD8fk5 XTA4e+rZP7hoOQK6AeQncJ8saYGyPy5yqrBC0nNvjPAqfJQJ0tgJRVatQ3XSfKV5KS0RUWb37 J3SOrC1c9fXa/azWzXdvldXvAJoQmCH60MC504PkThgRbyxvJe3JlDEhOW6UyVTnEHR1VlBck b3QxFEu3rDD+oEQ5QKIAhk0i4K1ING2noW5IQYQRHt2MEYH9Uhd+yM5Vf8OaBkNkzrcCEz7pz 8AghwTSoOnuwLxFWrJxAXqj9PNo0yAFcMATO15r/XYpvdmvxyC2DZCklXkByf7/Lu8bEY3bRw 8PdiXHXRaUQww01G218d2EmQUu9rQs9dU8Y6wMU7ztwVeKPdyl+MJyJnJzELmvqMoN467awnr FoBUA6B/QXFlMf4Sake0j3kpQ7uWwW7wwg1Kfa1MY6efEwnn2pVQTEg91a+EhYj7xwnI/3Lt5 C74myZd+5JRaKgdWiSfAzNX83sYyXieAAWK60eyi9HGdEoAc6LtOWi491REdg/3TMK65M5wXO Q8+JPNtMQ2sCpcefV5mFhgXsoIOvul5Q5uZstvfyXet03kCBYJ+d/3vKvMLVgZv9c5ZS6IQCO 9K6VuYlyjpo+XwqR93giOU9s0qQLtCX/T550qyOKJ2OV3AvxuC/tj11LPMPYnoEot3YY467Sk YLC7Gc7d+hcE8aFo+Z1m1WSBQLuRoG6QmRzNJ08jFUq91Jtg0WGgmp8clvQeXyEW7fFeafpZw XECB1jcb6yRlFPnrjR6+c0Nyi7oONnWdQheCwsYfIxseyms0D0PqU2zNw== Received-SPF: pass client-ip=212.227.17.12; envelope-from=michael_heerdegen@web.de; helo=mout.web.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: Philipp , Lars Ingebrigtsen , 48585@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > As someone who doesn't much like `if-let`, I'll let someone else figure > out how to that somewhat cleanly. Also to be honest I also wonder if > that would be worthwhile. It's easy to get rid of the `x` occurrence that *binds* (in the expansion) by changing `internal--build-binding' - the name of the binding symbol doesn't matter in this case. Then I guess we could use this `&interpose' Edebug spec but it's undocumented and not really trivial to understand. But looks like the right tool for this case... (?) Michael. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 16 21:36:53 2022 Received: (at submit) by debbugs.gnu.org; 17 Jul 2022 01:36:53 +0000 Received: from localhost ([127.0.0.1]:46396 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCtDJ-0005em-I9 for submit@debbugs.gnu.org; Sat, 16 Jul 2022 21:36:53 -0400 Received: from lists.gnu.org ([209.51.188.17]:53078) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCtDI-0005ef-8q for submit@debbugs.gnu.org; Sat, 16 Jul 2022 21:36:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55048) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oCtDI-0001M2-3k for bug-gnu-emacs@gnu.org; Sat, 16 Jul 2022 21:36:52 -0400 Received: from mout.web.de ([212.227.15.14]:49609) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oCtDG-0006Jz-ED for bug-gnu-emacs@gnu.org; Sat, 16 Jul 2022 21:36:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1658021795; bh=5drbpDIoQR6jMSkTFmPRwxtkDqVMdMiwFL443CtRXmA=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=Hld4om9ZkU0R9YtV+n3G/ATZwPHN1QFPdxtQTDm0w01tiPHGIZct/OrrsfrHBwUi+ qt5Wr2XrXLzhiovm06HiyHcYWrclBvyuzbJi/F4LQCryOfcFbw3pCkzu132+uv8ymX YcUG1i3WHvlPprtAyZbPb7sc6OHW/1rLMazVQY3Y= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([84.57.248.18]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1N3oyy-1nUvUR0Yoy-00zf1j; Sun, 17 Jul 2022 03:36:35 +0200 From: Michael Heerdegen To: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Subject: Re: bug#48585: 28.0.50; Missing Edebug instrumentation for some 'if-let' variants In-Reply-To: <877d4ch9zx.fsf@web.de> (Michael Heerdegen's message of "Sun, 17 Jul 2022 02:13:22 +0200") References: <87wncen0jq.fsf@gnus.org> <877d4ch9zx.fsf@web.de> Date: Sun, 17 Jul 2022 03:36:33 +0200 Message-ID: <87mtd8ed0e.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:SM8ntVTD+pRE/KrkYVvpnefAXeRP8DSEmEHsjuNgQJwYXd1O1S6 +lVVqLMCCWVqAFNsDdOj6T+nsfqXuhUtj7zhT13uivE9I8qzV2+yXgA5X20AWHXT2dceEIK 8ExxaSvWDM++zn9FfKrAHIdzUNlweyZbwF8aZH7jkvFm5oRpNp3t06y5+XUkQed3TVI2gLB tAoCjfpmJFHiTKQIkL1KA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:pN3IEa/0gFQ=:A8kL+gx0/4pGyXOOH0kZvG ddXvxSmAFYZYtIqBKXTsNU7OpwzmX6zZn98/hn9H1a0vgxTmn7IztiZph1I4/WWv5py1y9UCs 44KJHTWWNcshtsWNU9THUYh/iyGFgFfbq/mlyoj64ZVUDdoBGlRxrCjCFbhKNB+YMk4n0/eAS r62S9YuDKYzm/7ORQdYRCcLE6VY9peIFxwemQGwY+iqq92TjV25YIxiStuC5P61OqvIVij1L7 nyASdcz2hhlf6ATGYbCzLnM7PhbhTMqnWjASFFCU6P5RXwdhf53IyCmRVMP8xTA/mBP3sftXj gexKTL7NyJH+C16fUVLF7Y//WkCVSayf0cUSVh4WXa2X3KeFKjg5UI0Tz+AgLCMRWu25SJOby k+Fj+SLhXtqD9YQy4xjx3HqwxnNbUT2zxUy8aAotkRmmmRiCYDxx59PtJ2PdsuxFvkYX0Zup2 R6/fkfUAslPKkDVFAm2051owesjjsjFuuMWShs0rFrMiSj2JdsbdUAOsfhu8hADx4p0Kn0xjG 9aYcO8XPMypq76j0IbGUBc3hzi5CcS6C0uNR4SQve7dfFfH3G2WcofVqHeTX7CUtijhWOdFwl 22DLXTq93aLjLrdAOFAN1H9u3zlWxJ+zEigXY5RvfSK5xPgR8+9a9SOeSu/BZdUJ6ipPh3/sH rWTxoFF/kaP0Vrl2MLfTRmQjKFnBO1fVakxqJsRIztNPLUvobLNjqfvaE+LhdK4fopnDYc/d7 movJsrgLd1h1aBFFzvSwi6U/lWnJ//Hpzc2hlQGftr/QOjxpELlnbApMTaaAfAuJQ0vFwWypz C6Wnb+14CMkZD9A7eRcgMyXmQaBLk+khs+xddHtNeP4+XQ89SfbrIKIoZx/ARZIOA9XmmhMhX BNOnkNamiauYv6dr6b+ZgDgU7DGhVAtucETZSBsuw5vOJ1Lq9KvxDJFrhAvmKlahw7eU4oQc1 87a/Tk82ze9ym9rP8NU5pfH7NVZN/RvX/qTmb4CtZl3SRGw6fxS8CKaY8yIn2z/fPEF7sTblg UlzlBIhGEz+9ahKENDlun+8zvAsElG9nEMGB+tQUHGJGuLfvEYX/7CUpA3rjq/K1CYuxX0RRr hClJzjr6uVL3KA7mtoEdmuR6YI6SnTwcUct8GgqbmgaeWQLMVzw7Zzw3w== Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=212.227.15.14; envelope-from=michael_heerdegen@web.de; helo=mout.web.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: Philipp , Lars Ingebrigtsen , 48585@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Michael Heerdegen writes: > Then I guess we could use this `&interpose' Edebug spec but it's > undocumented and not really trivial to understand. But seems the return value is an Edebug spec again. This would not help in this case then. Michael. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 16 22:05:02 2022 Received: (at 48585) by debbugs.gnu.org; 17 Jul 2022 02:05:02 +0000 Received: from localhost ([127.0.0.1]:46422 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCteY-0006O2-Er for submit@debbugs.gnu.org; Sat, 16 Jul 2022 22:05:02 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:55244) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCteV-0006NU-GL for 48585@debbugs.gnu.org; Sat, 16 Jul 2022 22:05:00 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id B02F1805C8; Sat, 16 Jul 2022 22:04:53 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 663258025F; Sat, 16 Jul 2022 22:04:52 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1658023492; bh=vN/8sBwqiq8Q1Hdze+NyHIyVSlZrweAQi34+UFKuCp0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=lHHnkkFDSLt84fDX8mMb45ObkEO3uPGRsRC1pXYV/xVRrqahxLKo4afq0i4NAN8UJ dWhAsraz9w+CgEIkQr9nbrxXMFcRtnPTCYgyZxmS+RrU3oGIYISJJxAIZQ4a2iE80g +G3uaFGzKrNasG7aet2SZBdjGeVFCw9DIPj6YbMWDUL56ZqnG0qZtRcrdz4PrWtuLF xLPWxmIKyGgk5lU5H2lrb4csMwPzxDOOAKwx9Xn5CDRkHaDXaxVoZyPu90czIjh+BE fB7tTRt8CdSOEHeEvHCGQHVGp7yjHgkgQyDY4p3hqxbtjep8lIhHDmWy2gbwr6vtA0 b1SW0F0tIuQZw== Received: from pastel (unknown [45.72.196.165]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 28D581207B8; Sat, 16 Jul 2022 22:04:52 -0400 (EDT) From: Stefan Monnier To: Michael Heerdegen Subject: Re: bug#48585: 28.0.50; Missing Edebug instrumentation for some 'if-let' variants In-Reply-To: <87mtd8ed0e.fsf@web.de> (Michael Heerdegen's message of "Sun, 17 Jul 2022 03:36:33 +0200") Message-ID: References: <87wncen0jq.fsf@gnus.org> <877d4ch9zx.fsf@web.de> <87mtd8ed0e.fsf@web.de> Date: Sat, 16 Jul 2022 22:04:51 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.059 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48585 Cc: Lars Ingebrigtsen , 48585@debbugs.gnu.org, Philipp X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Michael Heerdegen [2022-07-17 03:36:33] wrote: > Michael Heerdegen writes: >> Then I guess we could use this `&interpose' Edebug spec but it's >> undocumented and not really trivial to understand. > But seems the return value is an Edebug spec again. This would not help > in this case then. No, the problem can't be fixed in the edebug-spec. Either we live with the current behavior (perfectly acceptable if you ask me), or you need to change the definition of the macro so it explicitly strips the Edebug instrumentation (if present) at those places where it's not desired. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 17 11:45:48 2022 Received: (at submit) by debbugs.gnu.org; 17 Jul 2022 15:45:48 +0000 Received: from localhost ([127.0.0.1]:48375 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oD6Sq-0007IQ-BL for submit@debbugs.gnu.org; Sun, 17 Jul 2022 11:45:48 -0400 Received: from lists.gnu.org ([209.51.188.17]:47202) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oD6So-0007II-BI for submit@debbugs.gnu.org; Sun, 17 Jul 2022 11:45:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54462) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oD6Sn-0003qX-2B for bug-gnu-emacs@gnu.org; Sun, 17 Jul 2022 11:45:46 -0400 Received: from mout.web.de ([212.227.15.3]:55575) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oD6Sl-00066N-B0 for bug-gnu-emacs@gnu.org; Sun, 17 Jul 2022 11:45:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1658072728; bh=PC2UFtjFTCywcuY2JmBmpWJmBC4lLTIPVxPYfvvdKvo=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=MVi4gwn3S7GQKMEMAgGwn/ZBVXW7T8zI2Kvxgl9xmUmavlsgQfsf5NneXz1oS0k9Y z4HOInkOI6H5902J9RCzi8de5d/KiCGv9ZlUFrG/r66apQh83FX4YF5ZHhg7kO2zCo LrpU1lVencA2WLXfYxgrJ0tXNXwtcL6WLLfDWvec= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([84.57.248.18]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1Mw9x2-1nLPNU3Gq4-00rypY; Sun, 17 Jul 2022 17:45:28 +0200 From: Michael Heerdegen To: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Subject: Re: bug#48585: 28.0.50; Missing Edebug instrumentation for some 'if-let' variants In-Reply-To: (Stefan Monnier via's message of "Sat, 16 Jul 2022 22:04:51 -0400") References: <87wncen0jq.fsf@gnus.org> <877d4ch9zx.fsf@web.de> <87mtd8ed0e.fsf@web.de> Date: Sun, 17 Jul 2022 17:45:27 +0200 Message-ID: <87h73feoa0.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:NF831mFFBJpECH2KGjVBzYXW1DO6hcvdtFev6zVTySJLyoat36j LVZfKanhLnkOI/OATWpUiAA2fOSj5ZQGQ0XTaIm7bYhprzt8X6zKHXIUJsnlVbwgYEN/vkS 8puLwHJ3zUGc4wGJygVx/AsUuB+Y78wfC58nQiCSb90yDxqeycNI9J1+0UEW3ml1D3qmF96 obUPctzRJfA3wj3npURrA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:3E6ar7p4YrU=:tDUPtaOSWg5SMdezCeWeQV uPayUoeiVDGrslJvK3wH7V+ZKfKmt9rOHP+zV+vAJ3W+19frGZg8sLYaZRoUay1Ms2QjJRNRL 5oLj21AUt6zSDyzV2qEiy64Rjfj3oCsD2t6byMok49HJE0JRPYq0+GrQ5J+Q3PMe9sDcJokQz o+6d3SweybsFqhAMJFd056zGsrLxjP39s1ALe3fnIIChGsoEwD+vlHtgcTeua3svajrvuosuf eVqQYU0fLbTWVE/fBa/+HvhezEuuOTWKA7hl7hDY7z8QP3gT+4YkltPlIV338Q9T4wWHO7bPe nhLjMof338X3q1unAgpTdAVHg7h1bcThhF2Y37AtwIWIrcRgwyKOfTSXFmxncqPQa9suIiXDA GAZapJgx1V09TTZ8+DuleIgCs5oUintzVPZD+IY05/eMgGYtCOabajtez9wtPFrVJhgwgojQq CYalQ+N2VrDfM5IoDkGJkFviu7Llg9c1NOH9VTGtsUlLQO+hmJzaaJwIuImem/pHMFP0QSrv1 nZxLNWOQeq+/ZJ/OKWtYafw8twA7VlgpvIlV52L/SYoVOLykDTZdpKkZ7cTM0DZhoZMfVVq7e K9KoYoPIdgqaxAqwTxFSeediwJngmRHjUUu2JgQDHanAhQJsMmT92r3eJ2qXBPToDZFg5/k4d aTACbSeeODeyeStUzUZANEV8dDydQ5w9ioydlrz2MzO5j/3f4KVKWMtdOoCCEQGWY6ZwTRf5x hBtr9vlvZNh2gSP86w837n6nDKwx2pofLx0CO/ne50F31XSPija7OwRxoQh0AjbK5uHcPuWfY dCqmeUZv15SqR0FDtPJjL0kd4WwzuTt34Ycr/4fLk++H/PxLDPjDzeOQsyf5uh8jxHTP703bi zGvDsfwMifztdPCVb70LOMy/Y5PpQSnGAj6S8UBFXZjNmB6Spmkn2r9m74xgtSK8RiwraNzck TYHQPz+ANdmgPSwVGL3D8dAulcvjOtVlLcZZtdktMdidhin4Azbcpwlxsa+NDowRQQavZfpil dx6qzBZMRT3nlLd2IE9BsSDHsHZWyU9efMYSnEW87au1huPIM3tyybZLDsKe9PHGs84G4g0Lu 6UTsMHXGiY0Z46uJgNYC/UpxbYZYFVXhFCAda3Vqsfru5MK5aCkLFFdnQ== Received-SPF: pass client-ip=212.227.15.3; envelope-from=michael_heerdegen@web.de; helo=mout.web.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: Philipp , Lars Ingebrigtsen , 48585@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > [...] or you need to change the definition of the macro so it > explicitly strips the Edebug instrumentation (if present) at those > places where it's not desired. That would be ugly. I agree it's then acceptable to live with the current behavior. Michael.