GNU bug report logs - #48578
28.0.50; Native-compiled files of some preloaded files not loaded at dump time

Previous Next

Full log

Message #56 received at 48578 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Andrea Corallo <akrl <at> sdf.org>
Cc: 48578 <at> debbugs.gnu.org
Subject: Re: bug#48578: 28.0.50; Native-compiled files of some preloaded
 files not loaded at dump time
Date: Thu, 27 May 2021 16:45:20 +0300

> From: Andrea Corallo <akrl <at> sdf.org>
> Cc: 48578 <at> debbugs.gnu.org
> Date: Thu, 27 May 2021 11:57:22 +0000
> 
> >   . why do you use Fexpand_file_name _after_ realpath? shouldn't we
> >     call it before realpath instead?
> 
> Right that's correct.
> 
> >   . we need to encode the file name before passing it to realpath, and
> >     decode the result, right?
> 
> Correct
> 
> >   . realpath could potentially return NULL, and we should check for
> >     that, and return the result of Fexpand_file_name if it does
> 
> Of course
> 
> >   . we don't need to support remote files here via file-handlers,
> >     right?
> 
> Correct, so far we do not support it.
> 
> > If you agree with the above, I will prepare a proper patch and install
> > it, including the necessary changes for WINDOWSNT.
> 
> Agreed, thanks.

Thanks, I installed a fix along these lines, please review and
comment.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.