From unknown Mon Jun 16 23:53:11 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#48578 <48578@debbugs.gnu.org> To: bug#48578 <48578@debbugs.gnu.org> Subject: Status: 28.0.50; Native-compiled files of some preloaded files not loaded at dump time Reply-To: bug#48578 <48578@debbugs.gnu.org> Date: Tue, 17 Jun 2025 06:53:11 +0000 retitle 48578 28.0.50; Native-compiled files of some preloaded files not lo= aded at dump time reassign 48578 emacs submitter 48578 Eli Zaretskii severity 48578 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sat May 22 03:20:38 2021 Received: (at submit) by debbugs.gnu.org; 22 May 2021 07:20:38 +0000 Received: from localhost ([127.0.0.1]:38229 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lkLw6-000438-0n for submit@debbugs.gnu.org; Sat, 22 May 2021 03:20:38 -0400 Received: from lists.gnu.org ([209.51.188.17]:52064) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lkLw4-00042y-N6 for submit@debbugs.gnu.org; Sat, 22 May 2021 03:20:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57194) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lkLw4-0004Cv-Fj for bug-gnu-emacs@gnu.org; Sat, 22 May 2021 03:20:36 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:53092) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lkLw4-0000yI-5v for bug-gnu-emacs@gnu.org; Sat, 22 May 2021 03:20:36 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3473 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lkLw3-0007U9-HL for bug-gnu-emacs@gnu.org; Sat, 22 May 2021 03:20:35 -0400 Date: Sat, 22 May 2021 10:20:33 +0300 Message-Id: <83k0nrkzem.fsf@gnu.org> From: Eli Zaretskii To: bug-gnu-emacs@gnu.org Subject: 28.0.50; Native-compiled files of some preloaded files not loaded at dump time X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Something strange is going on on this GNU/Linux system, unlike other systems where I build Emacs with native-compilation: when dumping, some of the preloaded files seem to be loaded in their byte-compiled form, not native-compiled form. The files are the ones loaded at the very beginning of 'loadup': Loading emacs-lisp/byte-run... Loading emacs-lisp/backquote... Loading subr... Loading version... Loading widget... Loading custom... Loading emacs-lisp/map-ynp... Loading international/mule... Loading international/mule-conf... Loading env... Loading format... Loading bindings... Loading window... Loading files... All the preloaded files after these ones are loaded as native-compiled Lisp, as expected. I forced native compilation of the offending files, and verified the corresponding *.eln files are refreshed in the native-lisp directory, but the problem persists. Why does this happen, and how do I fix it? In GNU Emacs 28.0.50 (build 3, x86_64-pc-linux-gnu, GTK+ Version 3.22.30, cairo version 1.15.10) of 2021-05-22 built on fencepost.gnu.org Repository revision: a3de48687eb28121f3dbfc20be19bd06c4cd6e98 Repository branch: master System Description: Trisquel GNU/Linux Etiona (9.0) Configured using: 'configure --with-gif=no --with-tiff=no --with-jpeg=no --with-xpm=ifavailable --with-modules --enable-checking=yes,glyphs --with-native-compilation 'CFLAGS=-O0 -g3'' Configured features: ACL CAIRO DBUS FREETYPE GLIB GMP GNUTLS GSETTINGS HARFBUZZ LIBOTF LIBSELINUX LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG SECCOMP SOUND THREADS TOOLKIT_SCROLL_BARS X11 XDBE XIM GTK3 ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs rfc822 mml mml-sec epa derived epg epg-config gnus-util rmail rmail-loaddefs auth-source eieio eieio-core eieio-loaddefs password-cache json map text-property-search time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils comp comp-cstr warnings subr-x rx cl-seq cl-macs cl-extra help-mode seq cl-loaddefs cl-lib term/xterm xterm byte-opt gv bytecomp byte-compile cconv iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process native-compile emacs) Memory information: ((conses 16 80499 8044) (symbols 48 7882 1) (strings 32 21664 3880) (string-bytes 1 739515) (vectors 16 14774) (vector-slots 8 245438 10812) (floats 8 29 316) (intervals 56 200 0) (buffers 992 11)) From debbugs-submit-bounces@debbugs.gnu.org Mon May 24 02:55:17 2021 Received: (at 48578) by debbugs.gnu.org; 24 May 2021 06:55:17 +0000 Received: from localhost ([127.0.0.1]:42226 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ll4Ue-0007Rb-KJ for submit@debbugs.gnu.org; Mon, 24 May 2021 02:55:16 -0400 Received: from mx.sdf.org ([205.166.94.24]:53547) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ll4Ua-0007RO-26 for 48578@debbugs.gnu.org; Mon, 24 May 2021 02:55:14 -0400 Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 14O6tAOM000095 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Mon, 24 May 2021 06:55:10 GMT From: Andrea Corallo To: Eli Zaretskii Subject: Re: bug#48578: 28.0.50; Native-compiled files of some preloaded files not loaded at dump time References: <83k0nrkzem.fsf@gnu.org> Date: Mon, 24 May 2021 06:55:10 +0000 In-Reply-To: <83k0nrkzem.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 22 May 2021 10:20:33 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 48578 Cc: 48578@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > Something strange is going on on this GNU/Linux system, unlike other > systems where I build Emacs with native-compilation: when dumping, > some of the preloaded files seem to be loaded in their byte-compiled > form, not native-compiled form. The files are the ones loaded at the > very beginning of 'loadup': > > Loading emacs-lisp/byte-run... > Loading emacs-lisp/backquote... > Loading subr... > Loading version... > Loading widget... > Loading custom... > Loading emacs-lisp/map-ynp... > Loading international/mule... > Loading international/mule-conf... > Loading env... > Loading format... > Loading bindings... > Loading window... > Loading files... > > All the preloaded files after these ones are loaded as native-compiled > Lisp, as expected. > > I forced native compilation of the offending files, and verified the > corresponding *.eln files are refreshed in the native-lisp directory, > but the problem persists. > > Why does this happen, and how do I fix it? Hi Eli, I just did a fresh build on GNU/Linux and I cannot reproduce this. === Loading emacs-lisp/byte-run (native compiled elisp)... Loading emacs-lisp/backquote (native compiled elisp)... Loading subr (native compiled elisp)... Loading version (native compiled elisp)... Loading widget (native compiled elisp)... Loading custom (native compiled elisp)... Loading emacs-lisp/map-ynp (native compiled elisp)... Loading international/mule (native compiled elisp)... Loading international/mule-conf (native compiled elisp)... Loading env (native compiled elisp)... Loading format (native compiled elisp)... Loading bindings (native compiled elisp)... Loading window (native compiled elisp)... Loading files (native compiled elisp)... Loading emacs-lisp/macroexp (native compiled elisp)... === Maybe related to the fix for bug#48497 and some state of your build? Regards Andrea From debbugs-submit-bounces@debbugs.gnu.org Mon May 24 03:30:23 2021 Received: (at 48578) by debbugs.gnu.org; 24 May 2021 07:30:23 +0000 Received: from localhost ([127.0.0.1]:42272 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ll52d-0008Kj-9F for submit@debbugs.gnu.org; Mon, 24 May 2021 03:30:23 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42818) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ll52b-0008KQ-My for 48578@debbugs.gnu.org; Mon, 24 May 2021 03:30:22 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58556) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ll52U-00089c-8l; Mon, 24 May 2021 03:30:14 -0400 Received: from [2a02:14f:1fb:57ce::1f5a:dfeb] (port=39974) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ll52T-0008JH-JM; Mon, 24 May 2021 03:30:14 -0400 Date: Mon, 24 May 2021 10:30:11 +0300 User-Agent: K-9 Mail for Android In-Reply-To: References: <83k0nrkzem.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Autocrypt: addr=eliz@gnu.org; keydata= mQENBF+pf4UBCAC6vjkWLSAsQpe8YIGKLQzNOJx/IjGtCdFF8uzmO5jmME+SD8ROuJN+t5KXVw58 uzu75EFD0vHTY9e+udJ2gkpuy0NnzkFcbumdLLo2ERKCoSctZZRhzKXI5z5cHxCqW0B2ygHRrRLt oNlGID7bAgcgSViT1ptGqTXO7zGVu4Airok7dNzcPtHgns8GlR5YAFX0TvE6oGd0l2VPghNeVJKJ OjrbfhoDxl3ucFpqbqMH8z9HTLDOFpz8UaYYUdJMi3xX6vwTZxI2sM2RRVLUpZyllAkSMI4lln1O OgazM/62DJUs/rKIHKBnF6h3/qsJUjUYXaAHbrXY26mWllAd536lABEBAAG0I0VsaSBaYXJldHNr aWkgKGVsaXopIDxlbGl6QGdudS5vcmc+iQE4BBMBAgAiBQJfqX+FAhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgAAKCRCRwSYvAeuNOYUQB/4/iIKKOG45ijNaRoTvmJJZMvj1S07WQxEm7c5SHEeE QbLOAxB9vESOV7sLueuN3oqEndtzyYt4x1WTSBmHFF7h5fcCMjBs41siOIp5Sj/xD0Bvaa0IKGCR SZ7PAo8Mq3wgajXpTpn9vxE2PmtzA8KdEE0K1+f9pVAfOpUIcCl44rIxLUW352XG0y7iz6c/O6LB 1deOKMiKFctKO7pBti1dJEm1ImewLH3H8uTbwspLOs3EB8xhsESxmTidnze68HX2jt+2EeMgCdki NU+LWbexQZPfIS7+ZmE06ll0v6+Jy7ZdTkCCRypKWTnW7pIFsq/p4kybV8O/kHSV6B4vvQBfuQEN BF+pf4UBCACvFrdx/m22lgObypSmSS4TNlNvQnMUorrMmp0U32hv5adt6CKXeMjk05F+GcIfVMrp xqMBn4sEUIXWhhogQJa9ZbWEP/HbS8XjMMbz0Q0Siaty9+DSspK/9u2GWKsz3uQzLCexIJtzmXvj AVmvoMCAU/F2t038ggygjYLRgyLRNLgbbartu2dMkvrfxRjheip60S4S3utOcwUf/qdoa1grNann CFluHr/ftXCeeuGB4H8iO0BXWNby6NZPizxJttx9gdcH8/OmDOJkXyRMTT/3sSem76CSOjfXcz7s aJlg680NQhG5TmuYERjJD4+U02K5RuqTsEnOuWeFy4p+/mslABEBAAGJAR8EGAECAAkFAl+pf4UC GwwACgkQkcEmLwHrjTno7Af/a1XoLHxAUkS43nmF8iazn3ZnuwWKWLEAsNrxk56yUxhUPRzNs0/f sABDQR1o0DyTqbScKOcOMSG2YMCctLiDd7FdfMWwkUsV9GUpPBiRtD60Ewmn9sbNJKrEoZ5L6sqO UEslJRVABu5taOzVIRfeUPPaMRjvCcr0d+epKjW81J9Aqj8SskuNkHwvHchTYFYVT22aemjjZ1MG OUm7QiybWQgYL6aSPV2gR+NQQ7pEhOBoEi6GLEiBkoYOIXvmxsqQLBrUPbsJq8lItYEaw4HGt8Ba PxtK2yZ9mSqC2xhWYr1j1YAIHffzubC0jxc5znXERsRANoJOwNUXmiddD7UM9A== Subject: Re: bug#48578: 28.0.50; Native-compiled files of some preloaded files not loaded at dump time To: Andrea Corallo From: Eli Zaretskii Message-ID: <0D04DA9F-BDFB-431E-9F14-385BE7CAAD54@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48578 Cc: 48578@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On May 24, 2021 9:55:10 AM GMT+03:00, Andrea Corallo wrote= : > Eli Zaretskii writes: >=20 > > Something strange is going on on this GNU/Linux system, unlike other > > systems where I build Emacs with native-compilation: when dumping, > > some of the preloaded files seem to be loaded in their byte-compiled > > form, not native-compiled form=2E The files are the ones loaded at > the > > very beginning of 'loadup': > > > > Loading emacs-lisp/byte-run=2E=2E=2E > > Loading emacs-lisp/backquote=2E=2E=2E > > Loading subr=2E=2E=2E > > Loading version=2E=2E=2E > > Loading widget=2E=2E=2E > > Loading custom=2E=2E=2E > > Loading emacs-lisp/map-ynp=2E=2E=2E > > Loading international/mule=2E=2E=2E > > Loading international/mule-conf=2E=2E=2E > > Loading env=2E=2E=2E > > Loading format=2E=2E=2E > > Loading bindings=2E=2E=2E > > Loading window=2E=2E=2E > > Loading files=2E=2E=2E > > > > All the preloaded files after these ones are loaded as > native-compiled > > Lisp, as expected=2E > > > > I forced native compilation of the offending files, and verified the > > corresponding *=2Eeln files are refreshed in the native-lisp > directory, > > but the problem persists=2E > > > > Why does this happen, and how do I fix it? >=20 > Hi Eli, >=20 > I just did a fresh build on GNU/Linux and I cannot reproduce this=2E >=20 > =3D=3D=3D > Loading emacs-lisp/byte-run (native compiled elisp)=2E=2E=2E > Loading emacs-lisp/backquote (native compiled elisp)=2E=2E=2E > Loading subr (native compiled elisp)=2E=2E=2E > Loading version (native compiled elisp)=2E=2E=2E > Loading widget (native compiled elisp)=2E=2E=2E > Loading custom (native compiled elisp)=2E=2E=2E > Loading emacs-lisp/map-ynp (native compiled elisp)=2E=2E=2E > Loading international/mule (native compiled elisp)=2E=2E=2E > Loading international/mule-conf (native compiled elisp)=2E=2E=2E > Loading env (native compiled elisp)=2E=2E=2E > Loading format (native compiled elisp)=2E=2E=2E > Loading bindings (native compiled elisp)=2E=2E=2E > Loading window (native compiled elisp)=2E=2E=2E > Loading files (native compiled elisp)=2E=2E=2E > Loading emacs-lisp/macroexp (native compiled elisp)=2E=2E=2E > =3D=3D=3D >=20 > Maybe related to the fix for bug#48497 and some state of your build? >=20 > Regards >=20 > Andrea What state could that be? And what do I do to escape from that state? From debbugs-submit-bounces@debbugs.gnu.org Mon May 24 03:47:13 2021 Received: (at 48578) by debbugs.gnu.org; 24 May 2021 07:47:13 +0000 Received: from localhost ([127.0.0.1]:42285 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ll5Iv-0000Ki-3T for submit@debbugs.gnu.org; Mon, 24 May 2021 03:47:13 -0400 Received: from mx.sdf.org ([205.166.94.24]:64177) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ll5Is-0000KU-4S for 48578@debbugs.gnu.org; Mon, 24 May 2021 03:47:12 -0400 Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 14O7l6he020527 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Mon, 24 May 2021 07:47:06 GMT From: Andrea Corallo To: Eli Zaretskii Subject: Re: bug#48578: 28.0.50; Native-compiled files of some preloaded files not loaded at dump time References: <83k0nrkzem.fsf@gnu.org> <0D04DA9F-BDFB-431E-9F14-385BE7CAAD54@gnu.org> Date: Mon, 24 May 2021 07:47:06 +0000 In-Reply-To: <0D04DA9F-BDFB-431E-9F14-385BE7CAAD54@gnu.org> (Eli Zaretskii's message of "Mon, 24 May 2021 10:30:11 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 48578 Cc: 48578@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > On May 24, 2021 9:55:10 AM GMT+03:00, Andrea Corallo wrote: >> Eli Zaretskii writes: >> >> > Something strange is going on on this GNU/Linux system, unlike other >> > systems where I build Emacs with native-compilation: when dumping, >> > some of the preloaded files seem to be loaded in their byte-compiled >> > form, not native-compiled form. The files are the ones loaded at >> the >> > very beginning of 'loadup': >> > >> > Loading emacs-lisp/byte-run... >> > Loading emacs-lisp/backquote... >> > Loading subr... >> > Loading version... >> > Loading widget... >> > Loading custom... >> > Loading emacs-lisp/map-ynp... >> > Loading international/mule... >> > Loading international/mule-conf... >> > Loading env... >> > Loading format... >> > Loading bindings... >> > Loading window... >> > Loading files... >> > >> > All the preloaded files after these ones are loaded as >> native-compiled >> > Lisp, as expected. >> > >> > I forced native compilation of the offending files, and verified the >> > corresponding *.eln files are refreshed in the native-lisp >> directory, >> > but the problem persists. >> > >> > Why does this happen, and how do I fix it? >> >> Hi Eli, >> >> I just did a fresh build on GNU/Linux and I cannot reproduce this. >> >> === >> Loading emacs-lisp/byte-run (native compiled elisp)... >> Loading emacs-lisp/backquote (native compiled elisp)... >> Loading subr (native compiled elisp)... >> Loading version (native compiled elisp)... >> Loading widget (native compiled elisp)... >> Loading custom (native compiled elisp)... >> Loading emacs-lisp/map-ynp (native compiled elisp)... >> Loading international/mule (native compiled elisp)... >> Loading international/mule-conf (native compiled elisp)... >> Loading env (native compiled elisp)... >> Loading format (native compiled elisp)... >> Loading bindings (native compiled elisp)... >> Loading window (native compiled elisp)... >> Loading files (native compiled elisp)... >> Loading emacs-lisp/macroexp (native compiled elisp)... >> === >> >> Maybe related to the fix for bug#48497 and some state of your build? >> >> Regards >> >> Andrea > > What state could that be? Hard to say, mine is just a guess as I cannot reproduce it here. > And what do I do to escape from that state? make bootstrap or even better restart from a git clean? Andrea From debbugs-submit-bounces@debbugs.gnu.org Mon May 24 04:10:44 2021 Received: (at 48578) by debbugs.gnu.org; 24 May 2021 08:10:44 +0000 Received: from localhost ([127.0.0.1]:42309 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ll5fg-0000ww-AM for submit@debbugs.gnu.org; Mon, 24 May 2021 04:10:44 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52168) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ll5fd-0000wi-VL for 48578@debbugs.gnu.org; Mon, 24 May 2021 04:10:43 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59154) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ll5fY-0008F6-Fr; Mon, 24 May 2021 04:10:36 -0400 Received: from [2a02:14f:1fb:57ce::1f5a:dfeb] (port=40080) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ll5fW-0007fi-Hl; Mon, 24 May 2021 04:10:36 -0400 Date: Mon, 24 May 2021 11:10:32 +0300 User-Agent: K-9 Mail for Android In-Reply-To: References: <83k0nrkzem.fsf@gnu.org> <0D04DA9F-BDFB-431E-9F14-385BE7CAAD54@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Autocrypt: addr=eliz@gnu.org; keydata= mQENBF+pf4UBCAC6vjkWLSAsQpe8YIGKLQzNOJx/IjGtCdFF8uzmO5jmME+SD8ROuJN+t5KXVw58 uzu75EFD0vHTY9e+udJ2gkpuy0NnzkFcbumdLLo2ERKCoSctZZRhzKXI5z5cHxCqW0B2ygHRrRLt oNlGID7bAgcgSViT1ptGqTXO7zGVu4Airok7dNzcPtHgns8GlR5YAFX0TvE6oGd0l2VPghNeVJKJ OjrbfhoDxl3ucFpqbqMH8z9HTLDOFpz8UaYYUdJMi3xX6vwTZxI2sM2RRVLUpZyllAkSMI4lln1O OgazM/62DJUs/rKIHKBnF6h3/qsJUjUYXaAHbrXY26mWllAd536lABEBAAG0I0VsaSBaYXJldHNr aWkgKGVsaXopIDxlbGl6QGdudS5vcmc+iQE4BBMBAgAiBQJfqX+FAhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgAAKCRCRwSYvAeuNOYUQB/4/iIKKOG45ijNaRoTvmJJZMvj1S07WQxEm7c5SHEeE QbLOAxB9vESOV7sLueuN3oqEndtzyYt4x1WTSBmHFF7h5fcCMjBs41siOIp5Sj/xD0Bvaa0IKGCR SZ7PAo8Mq3wgajXpTpn9vxE2PmtzA8KdEE0K1+f9pVAfOpUIcCl44rIxLUW352XG0y7iz6c/O6LB 1deOKMiKFctKO7pBti1dJEm1ImewLH3H8uTbwspLOs3EB8xhsESxmTidnze68HX2jt+2EeMgCdki NU+LWbexQZPfIS7+ZmE06ll0v6+Jy7ZdTkCCRypKWTnW7pIFsq/p4kybV8O/kHSV6B4vvQBfuQEN BF+pf4UBCACvFrdx/m22lgObypSmSS4TNlNvQnMUorrMmp0U32hv5adt6CKXeMjk05F+GcIfVMrp xqMBn4sEUIXWhhogQJa9ZbWEP/HbS8XjMMbz0Q0Siaty9+DSspK/9u2GWKsz3uQzLCexIJtzmXvj AVmvoMCAU/F2t038ggygjYLRgyLRNLgbbartu2dMkvrfxRjheip60S4S3utOcwUf/qdoa1grNann CFluHr/ftXCeeuGB4H8iO0BXWNby6NZPizxJttx9gdcH8/OmDOJkXyRMTT/3sSem76CSOjfXcz7s aJlg680NQhG5TmuYERjJD4+U02K5RuqTsEnOuWeFy4p+/mslABEBAAGJAR8EGAECAAkFAl+pf4UC GwwACgkQkcEmLwHrjTno7Af/a1XoLHxAUkS43nmF8iazn3ZnuwWKWLEAsNrxk56yUxhUPRzNs0/f sABDQR1o0DyTqbScKOcOMSG2YMCctLiDd7FdfMWwkUsV9GUpPBiRtD60Ewmn9sbNJKrEoZ5L6sqO UEslJRVABu5taOzVIRfeUPPaMRjvCcr0d+epKjW81J9Aqj8SskuNkHwvHchTYFYVT22aemjjZ1MG OUm7QiybWQgYL6aSPV2gR+NQQ7pEhOBoEi6GLEiBkoYOIXvmxsqQLBrUPbsJq8lItYEaw4HGt8Ba PxtK2yZ9mSqC2xhWYr1j1YAIHffzubC0jxc5znXERsRANoJOwNUXmiddD7UM9A== Subject: Re: bug#48578: 28.0.50; Native-compiled files of some preloaded files not loaded at dump time To: Andrea Corallo From: Eli Zaretskii Message-ID: <1064AF16-6F08-4DEA-A63B-D8781420F287@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48578 Cc: 48578@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On May 24, 2021 10:47:06 AM GMT+03:00, Andrea Corallo wrot= e: > Eli Zaretskii writes: >=20 > >>=20 > >> Maybe related to the fix for bug#48497 and some state of your > build? > >>=20 > >> Regards > >>=20 > >> Andrea > > > > What state could that be? >=20 > Hard to say, mine is just a guess as I cannot reproduce it here=2E >=20 > > And what do I do to escape from that state? >=20 > make bootstrap or even better restart from a git clean? That would erase all the traces of the problem=2E I would prefer to try t= o understand why it happens, there could be a subtle bug here=2E Suggestions for where to look for the reasons of the problem? From debbugs-submit-bounces@debbugs.gnu.org Mon May 24 04:48:45 2021 Received: (at 48578) by debbugs.gnu.org; 24 May 2021 08:48:45 +0000 Received: from localhost ([127.0.0.1]:42387 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ll6GS-0001wB-P3 for submit@debbugs.gnu.org; Mon, 24 May 2021 04:48:44 -0400 Received: from mx.sdf.org ([205.166.94.24]:57521) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ll6GQ-0001w1-Hf for 48578@debbugs.gnu.org; Mon, 24 May 2021 04:48:43 -0400 Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 14O8mdQv002847 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Mon, 24 May 2021 08:48:39 GMT From: Andrea Corallo To: Eli Zaretskii Subject: Re: bug#48578: 28.0.50; Native-compiled files of some preloaded files not loaded at dump time References: <83k0nrkzem.fsf@gnu.org> <0D04DA9F-BDFB-431E-9F14-385BE7CAAD54@gnu.org> <1064AF16-6F08-4DEA-A63B-D8781420F287@gnu.org> Date: Mon, 24 May 2021 08:48:39 +0000 In-Reply-To: <1064AF16-6F08-4DEA-A63B-D8781420F287@gnu.org> (Eli Zaretskii's message of "Mon, 24 May 2021 11:10:32 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 48578 Cc: 48578@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > On May 24, 2021 10:47:06 AM GMT+03:00, Andrea Corallo wrote: >> Eli Zaretskii writes: >> >> >> >> >> Maybe related to the fix for bug#48497 and some state of your >> build? >> >> >> >> Regards >> >> >> >> Andrea >> > >> > What state could that be? >> >> Hard to say, mine is just a guess as I cannot reproduce it here. >> >> > And what do I do to escape from that state? >> >> make bootstrap or even better restart from a git clean? > > That would erase all the traces of the problem. I would prefer to try to understand why it happens, there could be a subtle bug here. > > Suggestions for where to look for the reasons of the problem? I'd start verifying what given the el source file `comp-el-to-eln-rel-filename' suggests as eln filename and if this is present as native compiled file (I guess so if you recompiled manually). The next step would be verifying why when loading in lread.c 'maybe_swap_for_eln' does not decide to load the eln file in place of the elc one. Andrea From debbugs-submit-bounces@debbugs.gnu.org Mon May 24 12:22:29 2021 Received: (at 48578) by debbugs.gnu.org; 24 May 2021 16:22:29 +0000 Received: from localhost ([127.0.0.1]:43769 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llDLZ-0007wT-Hm for submit@debbugs.gnu.org; Mon, 24 May 2021 12:22:29 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47230) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llDLW-0007wE-66 for 48578@debbugs.gnu.org; Mon, 24 May 2021 12:22:28 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42618) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llDLP-0006N7-F1; Mon, 24 May 2021 12:22:20 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1856 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llDLO-0004f6-UK; Mon, 24 May 2021 12:22:19 -0400 Date: Mon, 24 May 2021 19:22:12 +0300 Message-Id: <834kesdruz.fsf@gnu.org> From: Eli Zaretskii To: Andrea Corallo In-Reply-To: (message from Andrea Corallo on Mon, 24 May 2021 08:48:39 +0000) Subject: Re: bug#48578: 28.0.50; Native-compiled files of some preloaded files not loaded at dump time References: <83k0nrkzem.fsf@gnu.org> <0D04DA9F-BDFB-431E-9F14-385BE7CAAD54@gnu.org> <1064AF16-6F08-4DEA-A63B-D8781420F287@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48578 Cc: 48578@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Andrea Corallo > Cc: 48578@debbugs.gnu.org > Date: Mon, 24 May 2021 08:48:39 +0000 > > > Suggestions for where to look for the reasons of the problem? > > I'd start verifying what given the el source file > `comp-el-to-eln-rel-filename' suggests as eln filename and if this is > present as native compiled file (I guess so if you recompiled manually). > > The next step would be verifying why when loading in lread.c > 'maybe_swap_for_eln' does not decide to load the eln file in place of > the elc one. Thanks. The problem is in comp-el-to-eln-rel-filename, in this fragment at its beginning: /* Use `file-truename' or fall back to `expand-file-name' when the first is not available (bug#44701). `file-truename' is not available only for a short phases of the bootstrap before file.el is loaded, given we do not symlink inside the build directory this should work. */ filename = NILP (Ffboundp (intern_c_string ("file-truename"))) ? Fexpand_file_name (filename, Qnil) : CALL1I (file-truename, filename); During loadup, file-truename is not available until files.elc/eln is loaded. But the assumption above that it isn't a problem because "we do not symlink inside the build directory" in false in my case, because my home directory, where I build Emacs, is itself a symlink: (expand-file-name "~") => "/home/e/eliz" (file-truename "~") => "/srv/data/home/e/eliz" So every one of the *.eln files loaded before and including files.elc will fail in the above logic and will produce a different path_hash, thus failing the attempt to find the correct .eln file. We could use 'realpath' (and a suitable emulation on WINDOWSNT) instead of file-truename. From debbugs-submit-bounces@debbugs.gnu.org Tue May 25 08:34:34 2021 Received: (at 48578) by debbugs.gnu.org; 25 May 2021 12:34:34 +0000 Received: from localhost ([127.0.0.1]:44915 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llWGX-00052k-TF for submit@debbugs.gnu.org; Tue, 25 May 2021 08:34:34 -0400 Received: from mx.sdf.org ([205.166.94.24]:53509) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llWGT-00052W-U5 for 48578@debbugs.gnu.org; Tue, 25 May 2021 08:34:32 -0400 Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 14PCYR0u003036 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Tue, 25 May 2021 12:34:28 GMT From: Andrea Corallo To: Eli Zaretskii Subject: Re: bug#48578: 28.0.50; Native-compiled files of some preloaded files not loaded at dump time References: <83k0nrkzem.fsf@gnu.org> <0D04DA9F-BDFB-431E-9F14-385BE7CAAD54@gnu.org> <1064AF16-6F08-4DEA-A63B-D8781420F287@gnu.org> <834kesdruz.fsf@gnu.org> Date: Tue, 25 May 2021 12:34:27 +0000 In-Reply-To: <834kesdruz.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 24 May 2021 19:22:12 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 48578 Cc: 48578@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> From: Andrea Corallo >> Cc: 48578@debbugs.gnu.org >> Date: Mon, 24 May 2021 08:48:39 +0000 >> >> > Suggestions for where to look for the reasons of the problem? >> >> I'd start verifying what given the el source file >> `comp-el-to-eln-rel-filename' suggests as eln filename and if this is >> present as native compiled file (I guess so if you recompiled manually). >> >> The next step would be verifying why when loading in lread.c >> 'maybe_swap_for_eln' does not decide to load the eln file in place of >> the elc one. > > Thanks. The problem is in comp-el-to-eln-rel-filename, in this > fragment at its beginning: > > /* Use `file-truename' or fall back to `expand-file-name' when the > first is not available (bug#44701). > > `file-truename' is not available only for a short phases of the > bootstrap before file.el is loaded, given we do not symlink > inside the build directory this should work. */ > filename = NILP (Ffboundp (intern_c_string ("file-truename"))) > ? Fexpand_file_name (filename, Qnil) > : CALL1I (file-truename, filename); > > During loadup, file-truename is not available until files.elc/eln is > loaded. But the assumption above that it isn't a problem because "we > do not symlink inside the build directory" in false in my case, > because my home directory, where I build Emacs, is itself a symlink: > > (expand-file-name "~") => "/home/e/eliz" > (file-truename "~") => "/srv/data/home/e/eliz" > > So every one of the *.eln files loaded before and including files.elc > will fail in the above logic and will produce a different path_hash, > thus failing the attempt to find the correct .eln file. > > We could use 'realpath' (and a suitable emulation on WINDOWSNT) > instead of file-truename. Hi Eli, I see, it would then look something like the attached I guess. It does bootstrap on GNU/Linux but I'm no expert on how to fill the WINDOWSNT ifdef branch. Thanks Andrea --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=48578.patch diff --git a/src/comp.c b/src/comp.c index 340ed85038..e6debefa1d 100644 --- a/src/comp.c +++ b/src/comp.c @@ -4008,15 +4008,23 @@ DEFUN ("comp-el-to-eln-rel-filename", Fcomp_el_to_eln_rel_filename, { CHECK_STRING (filename); - /* Use `file-truename' or fall back to `expand-file-name' when the - first is not available (bug#44701). - - `file-truename' is not available only for a short phases of the - bootstrap before file.el is loaded, given we do not symlink - inside the build directory this should work. */ - filename = NILP (Ffboundp (intern_c_string ("file-truename"))) - ? Fexpand_file_name (filename, Qnil) - : CALL1I (file-truename, filename); + /* Use `file-truename' or fall back to 'realpath' `expand-file-name' + when the first is not available. (`file-truename' is not + available only for a short phases of the bootstrap before file.el + is loaded). */ + + if (NILP (Ffboundp (intern_c_string ("file-truename")))) + { +#ifndef WINDOWSNT + char *file_normalized = realpath (SSDATA (filename), NULL); +#else + char *file_normalized = ??? ; +#endif + filename = Fexpand_file_name (build_string (file_normalized), Qnil); + xfree (file_normalized); + } + else + filename = CALL1I (file-truename, filename); if (NILP (Ffile_exists_p (filename))) xsignal1 (Qfile_missing, filename); --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue May 25 09:02:21 2021 Received: (at 48578) by debbugs.gnu.org; 25 May 2021 13:02:21 +0000 Received: from localhost ([127.0.0.1]:44948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llWhR-0005nI-Jy for submit@debbugs.gnu.org; Tue, 25 May 2021 09:02:21 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60188) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llWhQ-0005n5-22 for 48578@debbugs.gnu.org; Tue, 25 May 2021 09:02:20 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43938) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llWhK-00047K-OX; Tue, 25 May 2021 09:02:14 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2606 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llWhK-0007r3-3V; Tue, 25 May 2021 09:02:14 -0400 Date: Tue, 25 May 2021 16:02:14 +0300 Message-Id: <8335ubc6g9.fsf@gnu.org> From: Eli Zaretskii To: Andrea Corallo In-Reply-To: (message from Andrea Corallo on Tue, 25 May 2021 12:34:27 +0000) Subject: Re: bug#48578: 28.0.50; Native-compiled files of some preloaded files not loaded at dump time References: <83k0nrkzem.fsf@gnu.org> <0D04DA9F-BDFB-431E-9F14-385BE7CAAD54@gnu.org> <1064AF16-6F08-4DEA-A63B-D8781420F287@gnu.org> <834kesdruz.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48578 Cc: 48578@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Andrea Corallo > Cc: 48578@debbugs.gnu.org > Date: Tue, 25 May 2021 12:34:27 +0000 > > + /* Use `file-truename' or fall back to 'realpath' `expand-file-name' > + when the first is not available. (`file-truename' is not > + available only for a short phases of the bootstrap before file.el > + is loaded). */ > + > + if (NILP (Ffboundp (intern_c_string ("file-truename")))) > + { > +#ifndef WINDOWSNT > + char *file_normalized = realpath (SSDATA (filename), NULL); > +#else > + char *file_normalized = ??? ; > +#endif > + filename = Fexpand_file_name (build_string (file_normalized), Qnil); > + xfree (file_normalized); > + } > + else > + filename = CALL1I (file-truename, filename); > > if (NILP (Ffile_exists_p (filename))) > xsignal1 (Qfile_missing, filename); Thanks, I will try that. But why not use realpath at all times, even if file-truename is available? They do the same thing, AFAIK, no? From debbugs-submit-bounces@debbugs.gnu.org Tue May 25 09:18:20 2021 Received: (at 48578) by debbugs.gnu.org; 25 May 2021 13:18:21 +0000 Received: from localhost ([127.0.0.1]:44996 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llWwu-0006D0-Lu for submit@debbugs.gnu.org; Tue, 25 May 2021 09:18:20 -0400 Received: from mx.sdf.org ([205.166.94.24]:50823) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llWwr-0006Cr-Jw for 48578@debbugs.gnu.org; Tue, 25 May 2021 09:18:19 -0400 Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 14PDIGoF001023 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Tue, 25 May 2021 13:18:16 GMT From: Andrea Corallo To: Eli Zaretskii Subject: Re: bug#48578: 28.0.50; Native-compiled files of some preloaded files not loaded at dump time References: <83k0nrkzem.fsf@gnu.org> <0D04DA9F-BDFB-431E-9F14-385BE7CAAD54@gnu.org> <1064AF16-6F08-4DEA-A63B-D8781420F287@gnu.org> <834kesdruz.fsf@gnu.org> <8335ubc6g9.fsf@gnu.org> Date: Tue, 25 May 2021 13:18:16 +0000 In-Reply-To: <8335ubc6g9.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 25 May 2021 16:02:14 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 48578 Cc: 48578@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> From: Andrea Corallo >> Cc: 48578@debbugs.gnu.org >> Date: Tue, 25 May 2021 12:34:27 +0000 >> >> + /* Use `file-truename' or fall back to 'realpath' `expand-file-name' >> + when the first is not available. (`file-truename' is not >> + available only for a short phases of the bootstrap before file.el >> + is loaded). */ >> + >> + if (NILP (Ffboundp (intern_c_string ("file-truename")))) >> + { >> +#ifndef WINDOWSNT >> + char *file_normalized = realpath (SSDATA (filename), NULL); >> +#else >> + char *file_normalized = ??? ; >> +#endif >> + filename = Fexpand_file_name (build_string (file_normalized), Qnil); >> + xfree (file_normalized); >> + } >> + else >> + filename = CALL1I (file-truename, filename); >> >> if (NILP (Ffile_exists_p (filename))) >> xsignal1 (Qfile_missing, filename); > > Thanks, I will try that. But why not use realpath at all times, even > if file-truename is available? They do the same thing, AFAIK, no? AFAIK yes but the file-truename implementation didn't look sufficiently trivial to be sure they are really equivalent with the quick skim I had. I agree with the idea of using always one (realpath), should be also easier to ideantify issues in case. Attached the updated patch. Andrea --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=48578.patch diff --git a/src/comp.c b/src/comp.c index 340ed85038..e961161fc6 100644 --- a/src/comp.c +++ b/src/comp.c @@ -4008,15 +4008,18 @@ DEFUN ("comp-el-to-eln-rel-filename", Fcomp_el_to_eln_rel_filename, { CHECK_STRING (filename); - /* Use `file-truename' or fall back to `expand-file-name' when the - first is not available (bug#44701). - - `file-truename' is not available only for a short phases of the - bootstrap before file.el is loaded, given we do not symlink - inside the build directory this should work. */ - filename = NILP (Ffboundp (intern_c_string ("file-truename"))) - ? Fexpand_file_name (filename, Qnil) - : CALL1I (file-truename, filename); + /* Use `file-truename' or fall back to 'realpath' `expand-file-name' + when the first is not available. (`file-truename' is not + available only for a short phases of the bootstrap before file.el + is loaded). */ + +#ifndef WINDOWSNT + char *file_normalized = realpath (SSDATA (filename), NULL); +#else + char *file_normalized = ??? ; +#endif + filename = Fexpand_file_name (build_string (file_normalized), Qnil); + xfree (file_normalized); if (NILP (Ffile_exists_p (filename))) xsignal1 (Qfile_missing, filename); --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue May 25 09:22:48 2021 Received: (at submit) by debbugs.gnu.org; 25 May 2021 13:22:48 +0000 Received: from localhost ([127.0.0.1]:45009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llX1E-0006KR-Fn for submit@debbugs.gnu.org; Tue, 25 May 2021 09:22:48 -0400 Received: from lists.gnu.org ([209.51.188.17]:44098) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llX1C-0006KJ-Tf for submit@debbugs.gnu.org; Tue, 25 May 2021 09:22:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58874) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llX1C-0007Dm-LQ for bug-gnu-emacs@gnu.org; Tue, 25 May 2021 09:22:46 -0400 Received: from mx.sdf.org ([205.166.94.24]:50408) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llX18-0000AS-44; Tue, 25 May 2021 09:22:46 -0400 Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 14PDMdYe010942 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Tue, 25 May 2021 13:22:39 GMT From: Andrea Corallo To: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Subject: Re: bug#48578: 28.0.50; Native-compiled files of some preloaded files not loaded at dump time References: <83k0nrkzem.fsf@gnu.org> <0D04DA9F-BDFB-431E-9F14-385BE7CAAD54@gnu.org> <1064AF16-6F08-4DEA-A63B-D8781420F287@gnu.org> <834kesdruz.fsf@gnu.org> <8335ubc6g9.fsf@gnu.org> Date: Tue, 25 May 2021 13:22:39 +0000 In-Reply-To: (Andrea Corallo via's message of "Tue, 25 May 2021 13:18:16 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=205.166.94.24; envelope-from=akrl@sdf.org; helo=mx.sdf.org X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: Eli Zaretskii , 48578@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > Eli Zaretskii writes: > >>> From: Andrea Corallo >>> Cc: 48578@debbugs.gnu.org >>> Date: Tue, 25 May 2021 12:34:27 +0000 >>> >>> + /* Use `file-truename' or fall back to 'realpath' `expand-file-name' >>> + when the first is not available. (`file-truename' is not >>> + available only for a short phases of the bootstrap before file.el >>> + is loaded). */ >>> + >>> + if (NILP (Ffboundp (intern_c_string ("file-truename")))) >>> + { >>> +#ifndef WINDOWSNT >>> + char *file_normalized = realpath (SSDATA (filename), NULL); >>> +#else >>> + char *file_normalized = ??? ; >>> +#endif >>> + filename = Fexpand_file_name (build_string (file_normalized), Qnil); >>> + xfree (file_normalized); >>> + } >>> + else >>> + filename = CALL1I (file-truename, filename); >>> >>> if (NILP (Ffile_exists_p (filename))) >>> xsignal1 (Qfile_missing, filename); >> >> Thanks, I will try that. But why not use realpath at all times, even >> if file-truename is available? They do the same thing, AFAIK, no? > > AFAIK yes but the file-truename implementation didn't look sufficiently > trivial to be sure they are really equivalent with the quick skim I had. > > I agree with the idea of using always one (realpath), should be also > easier to ideantify issues in case. > > Attached the updated patch. Well... attached updating also the comment. Andrea --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=48578.patch diff --git a/src/comp.c b/src/comp.c index 340ed85038..8e40ea0f25 100644 --- a/src/comp.c +++ b/src/comp.c @@ -4008,15 +4008,15 @@ DEFUN ("comp-el-to-eln-rel-filename", Fcomp_el_to_eln_rel_filename, { CHECK_STRING (filename); - /* Use `file-truename' or fall back to `expand-file-name' when the - first is not available (bug#44701). - - `file-truename' is not available only for a short phases of the - bootstrap before file.el is loaded, given we do not symlink - inside the build directory this should work. */ - filename = NILP (Ffboundp (intern_c_string ("file-truename"))) - ? Fexpand_file_name (filename, Qnil) - : CALL1I (file-truename, filename); + /* `file-truename' is not available only during bootstrap before + file.el is loaded. */ +#ifndef WINDOWSNT + char *file_normalized = realpath (SSDATA (filename), NULL); +#else + char *file_normalized = ??? ; +#endif + filename = Fexpand_file_name (build_string (file_normalized), Qnil); + xfree (file_normalized); if (NILP (Ffile_exists_p (filename))) xsignal1 (Qfile_missing, filename); --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue May 25 14:13:12 2021 Received: (at 48578) by debbugs.gnu.org; 25 May 2021 18:13:12 +0000 Received: from localhost ([127.0.0.1]:46720 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llbYG-0005rP-K5 for submit@debbugs.gnu.org; Tue, 25 May 2021 14:13:12 -0400 Received: from mail-wr1-f47.google.com ([209.85.221.47]:38451) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llbYD-0005rA-V0 for 48578@debbugs.gnu.org; Tue, 25 May 2021 14:13:11 -0400 Received: by mail-wr1-f47.google.com with SMTP id j14so31441406wrq.5 for <48578@debbugs.gnu.org>; Tue, 25 May 2021 11:13:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=cw+ND++xMrqMyDpqFuvP5fRgOG3MHvg2qxkd16tAbyI=; b=LYr+FqtgPohomZenp/CIjEReDjjhdH1kobCOzbAmy9XSTMitmwdFuYIWIJ4oL69jyu 7AngOtDfBAp3nk1NJSU97A90fE4Ex2u280BrkEH8fJvUo4rs1NlVYh35t/9RBTMGPf6E lSYKnvAikkegjhohfO+COZ3kl5p0mnTecU0ohanCHqwQcmxIAFoO7sEuVDsyK9vKNw6g 7xghCYivW1zk1/+OnRb1exJARpgl8bfPVmwVZ/1kOjyctbDGf3szsVslOojxUIAGhUF0 gDSVk2A5xDBV6WnUyVAeld5HEdgMpbH1GSS3JuKXA7Q3/AlFFnNrF+U6qUkUXFvOqRsv carg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=cw+ND++xMrqMyDpqFuvP5fRgOG3MHvg2qxkd16tAbyI=; b=WzUblqa6CIe919qg5kZaS8rxdKJynt+nfZjthVKm7iCV48cJDhJ1TGrGleLanilEKB 9qolkHJENHMukixVF9P5+Pm23gtc8v7QeEQ5o7dtLrwiwncW18h6B3cEn4lutBVulfw4 kZXKgk7bFTdQPHZbHFflO60AFb+qgkHMsAcGpIVcKBCuuvYrJe9YGnHupHe49PVQP1OI goD+4pbB2fOHg1lmKI0m1uLQx/ubc5XkUh74q9GpbaY58yH93ha6Hhrrid1s1PvG0IId GjMCqsS8y6yXdMNJMae7+eswbibbagjxAQiGJpAhGUSNGKxUljOvafHbAPReTjOeqePG 6kbA== X-Gm-Message-State: AOAM531r6OqfRxxto84DKK7I6PXF6a1Is18HaAUktrrMWhuNiPYK4jn4 iaYqT1EvMKmJ/Knud1xJGj9CaA== X-Google-Smtp-Source: ABdhPJxMZxCU4pe8f5LvDWSjZFnr/TpyIKOQhLwnt644979edlz91IO4fstmnA9PuJ7YegkI54i2+w== X-Received: by 2002:a5d:678c:: with SMTP id v12mr29378571wru.246.1621966384186; Tue, 25 May 2021 11:13:04 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:d15:339e:aa10:60f1]) by smtp.gmail.com with ESMTPSA id c7sm16835756wrs.23.2021.05.25.11.13.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 May 2021 11:13:03 -0700 (PDT) From: "Basil L. Contovounesios" To: Eli Zaretskii Subject: Re: bug#48578: 28.0.50; Native-compiled files of some preloaded files not loaded at dump time References: <83k0nrkzem.fsf@gnu.org> <0D04DA9F-BDFB-431E-9F14-385BE7CAAD54@gnu.org> <1064AF16-6F08-4DEA-A63B-D8781420F287@gnu.org> <834kesdruz.fsf@gnu.org> <8335ubc6g9.fsf@gnu.org> Date: Tue, 25 May 2021 19:13:02 +0100 In-Reply-To: (Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors"'s message of "Tue, 25 May 2021 13:18:16 +0000") Message-ID: <87bl8yy95d.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 48578 Cc: 48578@debbugs.gnu.org, Andrea Corallo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > Eli Zaretskii writes: > >> Thanks, I will try that. But why not use realpath at all times, even >> if file-truename is available? They do the same thing, AFAIK, no? > > AFAIK yes but the file-truename implementation didn't look sufficiently > trivial to be sure they are really equivalent with the quick skim I had. The main difference is that file-truename heeds file name handlers, no? Thanks, -- Basil From debbugs-submit-bounces@debbugs.gnu.org Tue May 25 14:16:06 2021 Received: (at 48578) by debbugs.gnu.org; 25 May 2021 18:16:06 +0000 Received: from localhost ([127.0.0.1]:46724 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llbb4-0006vU-1g for submit@debbugs.gnu.org; Tue, 25 May 2021 14:16:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55438) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llbb0-0006n8-GM for 48578@debbugs.gnu.org; Tue, 25 May 2021 14:16:04 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58170) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llbat-00041d-CI; Tue, 25 May 2021 14:15:56 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2358 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llbas-0006is-Pb; Tue, 25 May 2021 14:15:55 -0400 Date: Tue, 25 May 2021 21:15:54 +0300 Message-Id: <83eedubrxh.fsf@gnu.org> From: Eli Zaretskii To: "Basil L. Contovounesios" In-Reply-To: <87bl8yy95d.fsf@tcd.ie> (contovob@tcd.ie) Subject: Re: bug#48578: 28.0.50; Native-compiled files of some preloaded files not loaded at dump time References: <83k0nrkzem.fsf@gnu.org> <0D04DA9F-BDFB-431E-9F14-385BE7CAAD54@gnu.org> <1064AF16-6F08-4DEA-A63B-D8781420F287@gnu.org> <834kesdruz.fsf@gnu.org> <8335ubc6g9.fsf@gnu.org> <87bl8yy95d.fsf@tcd.ie> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48578 Cc: 48578@debbugs.gnu.org, akrl@sdf.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: "Basil L. Contovounesios" > Cc: Andrea Corallo , 48578@debbugs.gnu.org > Date: Tue, 25 May 2021 19:13:02 +0100 > > Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of > text editors" writes: > > > Eli Zaretskii writes: > > > >> Thanks, I will try that. But why not use realpath at all times, even > >> if file-truename is available? They do the same thing, AFAIK, no? > > > > AFAIK yes but the file-truename implementation didn't look sufficiently > > trivial to be sure they are really equivalent with the quick skim I had. > > The main difference is that file-truename heeds file name handlers, no? Yes, but is that an issue when building Emacs or, more generally, native-compiling *.el files? From debbugs-submit-bounces@debbugs.gnu.org Tue May 25 14:31:56 2021 Received: (at 48578) by debbugs.gnu.org; 25 May 2021 18:31:56 +0000 Received: from localhost ([127.0.0.1]:46741 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llbqO-0008WO-AV for submit@debbugs.gnu.org; Tue, 25 May 2021 14:31:56 -0400 Received: from mail-wm1-f41.google.com ([209.85.128.41]:34404) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llbqL-0008WA-PC for 48578@debbugs.gnu.org; Tue, 25 May 2021 14:31:54 -0400 Received: by mail-wm1-f41.google.com with SMTP id u5-20020a7bc0450000b02901480e40338bso2128306wmc.1 for <48578@debbugs.gnu.org>; Tue, 25 May 2021 11:31:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Skqu4MSJhc2X7lGzqi67jef8OpmVmZQ241PIz2XCK/8=; b=J86Rue+skR6v/KuvgAALMrKVSZirokjuzVRRGuiH1s+r8P6HcnxAW5AId+hA8/0EM6 IvG4AdDw9ER96yHsrFMva1mLWGKbElehM4CWsbyty1XhO1GpakZctZSg/IAVvatyicSM NGQGl4CdJHqAHgVY9WyKHuxTuQL3CzI03kXXtwEeVL7j4S27v1XouhAStuyjMJjIdLXV CqhgFsp2tr3KbjtZT0OfRNpskSFO/Iw0NMzYoGyRw4FzjtDmI2YoEQCkA4EqoSn+ke43 hWqO5ZmFXj9FrM1PG+nr3WTewgnY58KGn1EH3qyDhKk/idd627E+OH1t4/wSMx1pYGCt 4+3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=Skqu4MSJhc2X7lGzqi67jef8OpmVmZQ241PIz2XCK/8=; b=CSHByJi6NjERHKIBHbJbSA0CH0ZIEtQSlnLT4sWeEaIsOrxd0ajgbhtB1tqGWZJg7d 6m3+3TKQE3yMUP+wWvTQjGOgI0ON6RrY7Gw5YVVg3GjQTlCSxDx51UT9X8uvlaBqdxY6 47YIsrvVz56QBUPnAPV9iTVLxgyI0K2QSIKm1yUQmfzFV3sfiCA6it0d0kTtqBep2K5k 2ZmR0Fi8CvWjAEb+DsY1IR73UN73E4Ds+YO5JCG3SENlMfzCUkeq+xjkkhfHtHEQ2jhd o76HqKwApUQtpTU/relM9F/Q7JNuf1WL2bPhrmw4C3Zl+0zd4dgkgXy8pkatFbROYR0F ATqg== X-Gm-Message-State: AOAM531Hf+4USy2rc5FD+3A2+wlffqzQiNUyJpZaZX+/y2aLddmSW2vx dJKrDRi5hY3907C2RGkaTsW/3g== X-Google-Smtp-Source: ABdhPJxQOh/zcEgeQOzV8bu6CpBNOj9Y9Vb7k9Ap80bI7tRUeiUtre4347QI9xCZZVvJoWndmoO2zg== X-Received: by 2002:a7b:c8ce:: with SMTP id f14mr25318438wml.81.1621967507772; Tue, 25 May 2021 11:31:47 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:d15:339e:aa10:60f1]) by smtp.gmail.com with ESMTPSA id s11sm3710746wmf.14.2021.05.25.11.31.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 May 2021 11:31:47 -0700 (PDT) From: "Basil L. Contovounesios" To: Eli Zaretskii Subject: Re: bug#48578: 28.0.50; Native-compiled files of some preloaded files not loaded at dump time References: <83k0nrkzem.fsf@gnu.org> <0D04DA9F-BDFB-431E-9F14-385BE7CAAD54@gnu.org> <1064AF16-6F08-4DEA-A63B-D8781420F287@gnu.org> <834kesdruz.fsf@gnu.org> <8335ubc6g9.fsf@gnu.org> <87bl8yy95d.fsf@tcd.ie> <83eedubrxh.fsf@gnu.org> Date: Tue, 25 May 2021 19:31:46 +0100 In-Reply-To: <83eedubrxh.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 25 May 2021 21:15:54 +0300") Message-ID: <87k0nmwtpp.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 48578 Cc: 48578@debbugs.gnu.org, akrl@sdf.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: "Basil L. Contovounesios" >> Cc: Andrea Corallo , 48578@debbugs.gnu.org >> Date: Tue, 25 May 2021 19:13:02 +0100 >> >> Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of >> text editors" writes: >> >> > Eli Zaretskii writes: >> > >> >> Thanks, I will try that. But why not use realpath at all times, even >> >> if file-truename is available? They do the same thing, AFAIK, no? >> > >> > AFAIK yes but the file-truename implementation didn't look sufficiently >> > trivial to be sure they are really equivalent with the quick skim I had. >> >> The main difference is that file-truename heeds file name handlers, no? > > Yes, but is that an issue when building Emacs or, more generally, > native-compiling *.el files? I don't know, but I wouldn't have guessed so. -- Basil From debbugs-submit-bounces@debbugs.gnu.org Wed May 26 09:43:29 2021 Received: (at 48578) by debbugs.gnu.org; 26 May 2021 13:43:29 +0000 Received: from localhost ([127.0.0.1]:47929 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llton-0004aH-6p for submit@debbugs.gnu.org; Wed, 26 May 2021 09:43:29 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35432) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lltol-0004a2-81 for 48578@debbugs.gnu.org; Wed, 26 May 2021 09:43:27 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34338) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lltoe-0005sw-Od; Wed, 26 May 2021 09:43:20 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2723 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lltoe-0007vF-91; Wed, 26 May 2021 09:43:20 -0400 Date: Wed, 26 May 2021 16:43:20 +0300 Message-Id: <83pmxda9vr.fsf@gnu.org> From: Eli Zaretskii To: Andrea Corallo In-Reply-To: (message from Andrea Corallo on Tue, 25 May 2021 13:22:39 +0000) Subject: Re: bug#48578: 28.0.50; Native-compiled files of some preloaded files not loaded at dump time References: <83k0nrkzem.fsf@gnu.org> <0D04DA9F-BDFB-431E-9F14-385BE7CAAD54@gnu.org> <1064AF16-6F08-4DEA-A63B-D8781420F287@gnu.org> <834kesdruz.fsf@gnu.org> <8335ubc6g9.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48578 Cc: 48578@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Andrea Corallo > Cc: Eli Zaretskii , 48578@debbugs.gnu.org > Date: Tue, 25 May 2021 13:22:39 +0000 > > diff --git a/src/comp.c b/src/comp.c > index 340ed85038..8e40ea0f25 100644 > --- a/src/comp.c > +++ b/src/comp.c > @@ -4008,15 +4008,15 @@ DEFUN ("comp-el-to-eln-rel-filename", Fcomp_el_to_eln_rel_filename, > { > CHECK_STRING (filename); > > - /* Use `file-truename' or fall back to `expand-file-name' when the > - first is not available (bug#44701). > - > - `file-truename' is not available only for a short phases of the > - bootstrap before file.el is loaded, given we do not symlink > - inside the build directory this should work. */ > - filename = NILP (Ffboundp (intern_c_string ("file-truename"))) > - ? Fexpand_file_name (filename, Qnil) > - : CALL1I (file-truename, filename); > + /* `file-truename' is not available only during bootstrap before > + file.el is loaded. */ > +#ifndef WINDOWSNT > + char *file_normalized = realpath (SSDATA (filename), NULL); > +#else > + char *file_normalized = ??? ; > +#endif > + filename = Fexpand_file_name (build_string (file_normalized), Qnil); > + xfree (file_normalized); > > if (NILP (Ffile_exists_p (filename))) > xsignal1 (Qfile_missing, filename); Thanks, this works. But I have a few questions/comments: . why do you use Fexpand_file_name _after_ realpath? shouldn't we call it before realpath instead? . we need to encode the file name before passing it to realpath, and decode the result, right? . realpath could potentially return NULL, and we should check for that, and return the result of Fexpand_file_name if it does . we don't need to support remote files here via file-handlers, right? If you agree with the above, I will prepare a proper patch and install it, including the necessary changes for WINDOWSNT. From debbugs-submit-bounces@debbugs.gnu.org Thu May 27 07:57:26 2021 Received: (at 48578) by debbugs.gnu.org; 27 May 2021 11:57:26 +0000 Received: from localhost ([127.0.0.1]:50765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lmEdh-0005CM-R0 for submit@debbugs.gnu.org; Thu, 27 May 2021 07:57:26 -0400 Received: from mx.sdf.org ([205.166.94.24]:51717) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lmEdg-0005CD-DJ for 48578@debbugs.gnu.org; Thu, 27 May 2021 07:57:25 -0400 Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 14RBvMOS012160 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Thu, 27 May 2021 11:57:23 GMT From: Andrea Corallo To: Eli Zaretskii Subject: Re: bug#48578: 28.0.50; Native-compiled files of some preloaded files not loaded at dump time References: <83k0nrkzem.fsf@gnu.org> <0D04DA9F-BDFB-431E-9F14-385BE7CAAD54@gnu.org> <1064AF16-6F08-4DEA-A63B-D8781420F287@gnu.org> <834kesdruz.fsf@gnu.org> <8335ubc6g9.fsf@gnu.org> <83pmxda9vr.fsf@gnu.org> Date: Thu, 27 May 2021 11:57:22 +0000 In-Reply-To: <83pmxda9vr.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 26 May 2021 16:43:20 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 48578 Cc: 48578@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Andrea Corallo >> Cc: Eli Zaretskii , 48578@debbugs.gnu.org >> Date: Tue, 25 May 2021 13:22:39 +0000 >> >> diff --git a/src/comp.c b/src/comp.c >> index 340ed85038..8e40ea0f25 100644 >> --- a/src/comp.c >> +++ b/src/comp.c >> @@ -4008,15 +4008,15 @@ DEFUN ("comp-el-to-eln-rel-filename", Fcomp_el_to_eln_rel_filename, >> { >> CHECK_STRING (filename); >> >> - /* Use `file-truename' or fall back to `expand-file-name' when the >> - first is not available (bug#44701). >> - >> - `file-truename' is not available only for a short phases of the >> - bootstrap before file.el is loaded, given we do not symlink >> - inside the build directory this should work. */ >> - filename = NILP (Ffboundp (intern_c_string ("file-truename"))) >> - ? Fexpand_file_name (filename, Qnil) >> - : CALL1I (file-truename, filename); >> + /* `file-truename' is not available only during bootstrap before >> + file.el is loaded. */ >> +#ifndef WINDOWSNT >> + char *file_normalized = realpath (SSDATA (filename), NULL); >> +#else >> + char *file_normalized = ??? ; >> +#endif >> + filename = Fexpand_file_name (build_string (file_normalized), Qnil); >> + xfree (file_normalized); >> >> if (NILP (Ffile_exists_p (filename))) >> xsignal1 (Qfile_missing, filename); > > Thanks, this works. But I have a few questions/comments: > > . why do you use Fexpand_file_name _after_ realpath? shouldn't we > call it before realpath instead? Right that's correct. > . we need to encode the file name before passing it to realpath, and > decode the result, right? Correct > . realpath could potentially return NULL, and we should check for > that, and return the result of Fexpand_file_name if it does Of course > . we don't need to support remote files here via file-handlers, > right? Correct, so far we do not support it. > If you agree with the above, I will prepare a proper patch and install > it, including the necessary changes for WINDOWSNT. Agreed, thanks. Andrea From debbugs-submit-bounces@debbugs.gnu.org Thu May 27 09:45:26 2021 Received: (at 48578) by debbugs.gnu.org; 27 May 2021 13:45:26 +0000 Received: from localhost ([127.0.0.1]:50911 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lmGKE-0003oM-Kh for submit@debbugs.gnu.org; Thu, 27 May 2021 09:45:26 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56894) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lmGKC-0003o9-UG for 48578@debbugs.gnu.org; Thu, 27 May 2021 09:45:25 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44356) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lmGK3-0006Xf-IK; Thu, 27 May 2021 09:45:19 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4829 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lmGK2-0003Tg-U7; Thu, 27 May 2021 09:45:15 -0400 Date: Thu, 27 May 2021 16:45:20 +0300 Message-Id: <83tumo8f4f.fsf@gnu.org> From: Eli Zaretskii To: Andrea Corallo In-Reply-To: (message from Andrea Corallo on Thu, 27 May 2021 11:57:22 +0000) Subject: Re: bug#48578: 28.0.50; Native-compiled files of some preloaded files not loaded at dump time References: <83k0nrkzem.fsf@gnu.org> <0D04DA9F-BDFB-431E-9F14-385BE7CAAD54@gnu.org> <1064AF16-6F08-4DEA-A63B-D8781420F287@gnu.org> <834kesdruz.fsf@gnu.org> <8335ubc6g9.fsf@gnu.org> <83pmxda9vr.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48578 Cc: 48578@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Andrea Corallo > Cc: 48578@debbugs.gnu.org > Date: Thu, 27 May 2021 11:57:22 +0000 > > > . why do you use Fexpand_file_name _after_ realpath? shouldn't we > > call it before realpath instead? > > Right that's correct. > > > . we need to encode the file name before passing it to realpath, and > > decode the result, right? > > Correct > > > . realpath could potentially return NULL, and we should check for > > that, and return the result of Fexpand_file_name if it does > > Of course > > > . we don't need to support remote files here via file-handlers, > > right? > > Correct, so far we do not support it. > > > If you agree with the above, I will prepare a proper patch and install > > it, including the necessary changes for WINDOWSNT. > > Agreed, thanks. Thanks, I installed a fix along these lines, please review and comment. From debbugs-submit-bounces@debbugs.gnu.org Sat May 29 03:02:48 2021 Received: (at 48578) by debbugs.gnu.org; 29 May 2021 07:02:48 +0000 Received: from localhost ([127.0.0.1]:55889 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lmszg-0004rC-Jx for submit@debbugs.gnu.org; Sat, 29 May 2021 03:02:48 -0400 Received: from mx.sdf.org ([205.166.94.24]:59081) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lmszf-0004r4-4Z for 48578@debbugs.gnu.org; Sat, 29 May 2021 03:02:47 -0400 Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 14T72jJO008020 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Sat, 29 May 2021 07:02:46 GMT From: Andrea Corallo To: Eli Zaretskii Subject: Re: bug#48578: 28.0.50; Native-compiled files of some preloaded files not loaded at dump time References: <83k0nrkzem.fsf@gnu.org> <0D04DA9F-BDFB-431E-9F14-385BE7CAAD54@gnu.org> <1064AF16-6F08-4DEA-A63B-D8781420F287@gnu.org> <834kesdruz.fsf@gnu.org> <8335ubc6g9.fsf@gnu.org> <83pmxda9vr.fsf@gnu.org> <83tumo8f4f.fsf@gnu.org> Date: Sat, 29 May 2021 07:02:45 +0000 In-Reply-To: <83tumo8f4f.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 27 May 2021 16:45:20 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 48578 Cc: 48578@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Andrea Corallo >> Cc: 48578@debbugs.gnu.org >> Date: Thu, 27 May 2021 11:57:22 +0000 >> >> > . why do you use Fexpand_file_name _after_ realpath? shouldn't we >> > call it before realpath instead? >> >> Right that's correct. >> >> > . we need to encode the file name before passing it to realpath, and >> > decode the result, right? >> >> Correct >> >> > . realpath could potentially return NULL, and we should check for >> > that, and return the result of Fexpand_file_name if it does >> >> Of course >> >> > . we don't need to support remote files here via file-handlers, >> > right? >> >> Correct, so far we do not support it. >> >> > If you agree with the above, I will prepare a proper patch and install >> > it, including the necessary changes for WINDOWSNT. >> >> Agreed, thanks. > > Thanks, I installed a fix along these lines, please review and > comment. Hi Eli, it looks good to me. Thanks for fixing this. Andrea From debbugs-submit-bounces@debbugs.gnu.org Sat May 29 04:57:19 2021 Received: (at 48578-done) by debbugs.gnu.org; 29 May 2021 08:57:19 +0000 Received: from localhost ([127.0.0.1]:55987 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lmumV-0007cw-C5 for submit@debbugs.gnu.org; Sat, 29 May 2021 04:57:19 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38398) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lmumU-0007ci-0U for 48578-done@debbugs.gnu.org; Sat, 29 May 2021 04:57:18 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38996) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lmumO-0004FO-Ht; Sat, 29 May 2021 04:57:12 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2745 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lmumO-0002Am-29; Sat, 29 May 2021 04:57:12 -0400 Date: Sat, 29 May 2021 11:57:17 +0300 Message-Id: <8335u57w9e.fsf@gnu.org> From: Eli Zaretskii To: Andrea Corallo In-Reply-To: (message from Andrea Corallo on Sat, 29 May 2021 07:02:45 +0000) Subject: Re: bug#48578: 28.0.50; Native-compiled files of some preloaded files not loaded at dump time References: <83k0nrkzem.fsf@gnu.org> <0D04DA9F-BDFB-431E-9F14-385BE7CAAD54@gnu.org> <1064AF16-6F08-4DEA-A63B-D8781420F287@gnu.org> <834kesdruz.fsf@gnu.org> <8335ubc6g9.fsf@gnu.org> <83pmxda9vr.fsf@gnu.org> <83tumo8f4f.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48578-done Cc: 48578-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Andrea Corallo > Cc: 48578@debbugs.gnu.org > Date: Sat, 29 May 2021 07:02:45 +0000 > > > Thanks, I installed a fix along these lines, please review and > > comment. > > Hi Eli, > > it looks good to me. > > Thanks for fixing this. Great, so I'm closing this bug. From unknown Mon Jun 16 23:53:11 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 26 Jun 2021 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator