Subject: Re: bug#48578: 28.0.50; Native-compiled files of some preloaded files not loaded at dump time

From: Andrea Corallo <[email-masked]>
Date: Sat, 29 May 2021 07:02:45 +0000

Eli Zaretskii <[email-masked]> writes:

>> From: Andrea Corallo <[email-masked]>
>> Cc: [email-masked]
>> Date: Thu, 27 May 2021 11:57:22 +0000
>> 
>> >   . why do you use Fexpand_file_name _after_ realpath? shouldn't we
>> >     call it before realpath instead?
>> 
>> Right that's correct.
>> 
>> >   . we need to encode the file name before passing it to realpath, and
>> >     decode the result, right?
>> 
>> Correct
>> 
>> >   . realpath could potentially return NULL, and we should check for
>> >     that, and return the result of Fexpand_file_name if it does
>> 
>> Of course
>> 
>> >   . we don't need to support remote files here via file-handlers,
>> >     right?
>> 
>> Correct, so far we do not support it.
>> 
>> > If you agree with the above, I will prepare a proper patch and install
>> > it, including the necessary changes for WINDOWSNT.
>> 
>> Agreed, thanks.
>
> Thanks, I installed a fix along these lines, please review and
> comment.

Hi Eli,

it looks good to me.

Thanks for fixing this.

  Andrea