GNU bug report logs - #48545
28.0.50; `icomplete-vertical-mode` does not support the `group-function`

Previous Next

Package: emacs;

Reported by: Daniel Mendler <mail <at> daniel-mendler.de>

Date: Thu, 20 May 2021 18:57:02 UTC

Severity: normal

Found in version 28.0.50

Done: João Távora <joaotavora <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: João Távora <joaotavora <at> gmail.com>
Cc: mail <at> daniel-mendler.de, 48545 <at> debbugs.gnu.org
Subject: bug#48545: 28.0.50; `icomplete-vertical-mode` does not support the `group-function`
Date: Fri, 20 Aug 2021 01:37:54 +0300
On 19.08.2021 22:41, João Távora wrote:

>> We discussed this problem when group-function was introduced. Another
>> approach is to just change the method of grouping: first the
>> completions are sorted, and then they are sorted into groups.
> 
> That's a possiblity. But it might be performing too much work, at least
> at first sight.

Not sure I understand. Grouping is a linear operation, isn't it? O(N).

Which is generally cheaper than the sorting step that came before.

> For the C-x 8 RET case and the xref table (the only
> tables I know which use this) things seem to be naturally put into
> groups already.  So sorting them alphabetically, by length, by history,
> and _then_ destroying most (but not all) with the grouping could be not
> so interesting if the there's a big a price to pay.

Could be it misses information.

OTOH, if you split completions belonging to the same group apart, you 
can end up with a list where there as as many group headers, as there 
completions (in the extreme case).

What behavior does (setq completions-group t) have? It affects the 
default UI, IIUC.




This bug report was last modified 3 years and 326 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.