GNU bug report logs - #48535
28.0.50; ff-find-other-file no longer sets current-buffer?

Previous Next

Full log

Message #8 received at 48535 <at> debbugs.gnu.org (full text, mbox):

From: Stephen Leake <stephen_leake <at> stephe-leake.org>
To: 48535 <at> debbugs.gnu.org
Subject: 28.0.50; ff-find-other-file no longer sets current-buffer?
Date: Fri, 21 May 2021 14:09:44 -0700

This breaks emacs ada-mode automated tests, which rely on evaluating
elisp forms in Ada comments.

git bisect says this commit is to blame:

commit: c105017c44d4a679f7af739b2c0390b2c7850569
Author: Stefan Monnier <monnier <at> iro.umontreal.ca>
Date:   Tue Apr 6 17:06:07 2021 -0400

    * lisp/find-file.el: Make the commands oblivious to mouse/non-mouse

    (ff-find-other-file): Add `event` argument.
    (ff-find-other-file-other-window): Rename from
    `ff-mouse-find-other-file-other-window` and use this new argument.
    (ff-mouse-find-other-file, ff-mouse-find-other-file-other-window):
    Make them obsolete aliases.
    (ff-upcase-p): Remove unused `start` and `end` arguments and
    simplify accordingly.

I looked thru the diff, but I didn't see anything obvious, so I'm
blaming the lexical-binding change. But I don't know how to fix it.

I've confirmed that disabling lexical-binding fixes the problem.

-- 
-- Stephe

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.