GNU bug report logs - #48502
[PATCH 0/1] gnu: luakit: Update to 2.3.

Previous Next

Package: guix-patches;

Reported by: Raphaël Mélotte <raphael.melotte <at> mind.be>

Date: Tue, 18 May 2021 16:49:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Raphaël Mélotte
 <raphael.melotte <at> mind.be>
Subject: bug#48502: closed (Re: bug#48502: [PATCH 0/1] gnu: luakit: Update
 to 2.3.)
Date: Sat, 22 May 2021 21:38:02 +0000
[Message part 1 (text/plain, inline)]
Your bug report

#48502: [PATCH 0/1] gnu: luakit: Update to 2.3.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 48502 <at> debbugs.gnu.org.

-- 
48502: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=48502
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Ludovic Courtès <ludo <at> gnu.org>
To: Raphaël Mélotte <raphael.melotte <at> mind.be>
Cc: 48502-done <at> debbugs.gnu.org
Subject: Re: bug#48502: [PATCH 0/1] gnu: luakit: Update to 2.3.
Date: Sat, 22 May 2021 23:37:06 +0200
Hi,

Raphaël Mélotte <raphael.melotte <at> mind.be> skribis:

> * gnu/packages/web-browsers.scm (luakit): Update to 2.3
> [arguments]: Add 'set-version' phase.

[...]

> +         (add-before 'build 'set-version
> +           (lambda _
> +             (setenv "VERSION_FROM_GIT" ,(package-version luakit))

I changed this to (package-version this-package), which works also when
inheriting from the package, and applied.

Thanks!

Ludo’.

[Message part 3 (message/rfc822, inline)]
From: Raphaël Mélotte <raphael.melotte <at> mind.be>
To: guix-patches <at> gnu.org
Cc: Raphaël Mélotte <raphael.melotte <at> mind.be>
Subject: [PATCH 0/1] gnu: luakit: Update to 2.3.
Date: Tue, 18 May 2021 18:47:10 +0200
Hello,

While updating luakit to 2.3 I noticed the version wasn't detected properly at
built-time (it's supposed to either use git-describe or a version embedded in
the release tarball).

Since we build from the git repository, I added a phase to set the version to
manually.

Raphaël Mélotte (1):
  gnu: luakit: Update to 2.3.

 gnu/packages/web-browsers.scm | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

-- 
2.31.1




This bug report was last modified 4 years and 42 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.