From unknown Fri Jun 13 11:01:02 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#48501] [PATCH] daemon: Replace Unicode single quotes with poor simulacra. Resent-From: Tobias Geerinckx-Rice Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 18 May 2021 16:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 48501 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 48501@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.162135566518875 (code B ref -1); Tue, 18 May 2021 16:35:01 +0000 Received: (at submit) by debbugs.gnu.org; 18 May 2021 16:34:25 +0000 Received: from localhost ([127.0.0.1]:57112 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lj2fl-0004uJ-K3 for submit@debbugs.gnu.org; Tue, 18 May 2021 12:34:25 -0400 Received: from lists.gnu.org ([209.51.188.17]:47258) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lj2fh-0004u9-O0 for submit@debbugs.gnu.org; Tue, 18 May 2021 12:34:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53116) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lj2fh-0005co-GW for guix-patches@gnu.org; Tue, 18 May 2021 12:34:17 -0400 Received: from tobias.gr ([2a02:c205:2020:6054::1]:49446) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lj2fd-0006LG-7S for guix-patches@gnu.org; Tue, 18 May 2021 12:34:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tobias.gr; s=2018; bh=Fu9Tu3YqNI9kSfinx5Kyit0aifooWcaAFkUjdggVuUQ=; h=date:subject:to: from; b=ZiWfcIRxY4XTwN+IjIRaOgfnbgzXlIDPTUDyI+4HGjDSQPGn+QbX47Rja+gzbu mdvXE8Wosyyv9EIKo5xPoMueGBFXvnuWHPRPflG4NaC71pcKgLhYgW0Zg7dxdWt0Bbebeo X9nLUQP3H/R7lEskZBdFj9Dl8Rd85+9qtABaAK0J7AU5w6sXijRlyEG/nGfJ6GiPuOmJ6c mx7C+lkbTwg0jqH4O1TFMUxvbgJHzHg8TonaUjOG4XTk1JVYShB2WYdERbf9ulOh2uBbiV Y30/hHrlmy6Yc5VXapFNUZKnYMjwMD1SYAKUIqvgML9hOnMwTgOm2j+XvwZ6S0eRqCy3QA == Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id d294dc95 (TLSv1.2:ECDHE-ECDSA-AES256-GCM-SHA384:256:NO) for ; Tue, 18 May 2021 16:34:21 +0000 (UTC) From: Tobias Geerinckx-Rice Date: Tue, 18 May 2021 18:34:05 +0200 Message-Id: <20210518163405.3618-1-me@tobias.gr> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@tobias.gr; helo=tobias.gr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) The correct ‘ and ’ are not considered word boundaries by some(?) terminal emulators like Alacritty, making double-click selection tedious. Avoid them in untranslated strings like it's 1992. * nix/libstore/build.cc (UserLock::acquire) (DerivationGoal::haveDerivation, DerivationGoal::closureRepaired) (DerivationGoal::startBuilder, DerivationGoal::runChild) (DerivationGoal::registerOutputs): Replace ‘’ with `' in output. * nix/libstore/local-store.cc (canonicalisePathMetaData_) (LocalStore::queryValidPathId): Likewise. * nix/libstore/optimise-store.cc (LocalStore::optimisePath_): Likewise. * nix/libutil/util.cc (readLink): Likewise. --- nix/libstore/build.cc | 24 ++++++++++++------------ nix/libstore/local-store.cc | 4 ++-- nix/libstore/optimise-store.cc | 4 ++-- nix/libutil/util.cc | 2 +- 4 files changed, 17 insertions(+), 17 deletions(-) diff --git a/nix/libstore/build.cc b/nix/libstore/build.cc index 5697ae5a43..d6f9a15a46 100644 --- a/nix/libstore/build.cc +++ b/nix/libstore/build.cc @@ -525,7 +525,7 @@ void UserLock::acquire() int err = getgrouplist(pw->pw_name, pw->pw_gid, supplementaryGIDs.data(), &ngroups); if (err == -1) - throw Error(format("failed to get list of supplementary groups for ‘%1%’") % pw->pw_name); + throw Error(format("failed to get list of supplementary groups for `%1%’") % pw->pw_name); supplementaryGIDs.resize(ngroups); @@ -903,7 +903,7 @@ void DerivationGoal::haveDerivation() trace("loading derivation"); if (nrFailed != 0) { - printMsg(lvlError, format("cannot build missing derivation ‘%1%’") % drvPath); + printMsg(lvlError, format("cannot build missing derivation `%1%’") % drvPath); done(BuildResult::MiscFailure); return; } @@ -1058,7 +1058,7 @@ void DerivationGoal::closureRepaired() { trace("closure repaired"); if (nrFailed > 0) - throw Error(format("some paths in the output closure of derivation ‘%1%’ could not be repaired") % drvPath); + throw Error(format("some paths in the output closure of derivation `%1%’ could not be repaired") % drvPath); done(BuildResult::AlreadyValid); } @@ -1748,10 +1748,10 @@ void DerivationGoal::startBuilder() printMsg(lvlChatty, format("setting up chroot environment in `%1%'") % chrootRootDir); if (mkdir(chrootRootDir.c_str(), 0750) == -1) - throw SysError(format("cannot create ‘%1%’") % chrootRootDir); + throw SysError(format("cannot create `%1%’") % chrootRootDir); if (chown(chrootRootDir.c_str(), 0, buildUser.getGID()) == -1) - throw SysError(format("cannot change ownership of ‘%1%’") % chrootRootDir); + throw SysError(format("cannot change ownership of `%1%’") % chrootRootDir); /* Create a writable /tmp in the chroot. Many builders need this. (Of course they should really respect $TMPDIR @@ -1808,7 +1808,7 @@ void DerivationGoal::startBuilder() chmod_(chrootStoreDir, 01775); if (chown(chrootStoreDir.c_str(), 0, buildUser.getGID()) == -1) - throw SysError(format("cannot change ownership of ‘%1%’") % chrootStoreDir); + throw SysError(format("cannot change ownership of `%1%’") % chrootStoreDir); foreach (PathSet::iterator, i, inputPaths) { struct stat st; @@ -2007,13 +2007,13 @@ void DerivationGoal::runChild() local to the namespace, though, so setting MS_PRIVATE does not affect the outside world. */ if (mount(0, "/", 0, MS_REC|MS_PRIVATE, 0) == -1) { - throw SysError("unable to make ‘/’ private mount"); + throw SysError("unable to make `/’ private mount"); } /* Bind-mount chroot directory to itself, to treat it as a different filesystem from /, as needed for pivot_root. */ if (mount(chrootRootDir.c_str(), chrootRootDir.c_str(), 0, MS_BIND, 0) == -1) - throw SysError(format("unable to bind mount ‘%1%’") % chrootRootDir); + throw SysError(format("unable to bind mount `%1%’") % chrootRootDir); /* Set up a nearly empty /dev, unless the user asked to bind-mount the host /dev. */ @@ -2423,7 +2423,7 @@ void DerivationGoal::registerOutputs() if (pathExists(dst)) deletePath(dst); if (rename(actualPath.c_str(), dst.c_str())) throw SysError(format("renaming `%1%' to `%2%'") % actualPath % dst); - throw Error(format("derivation `%1%' may not be deterministic: output `%2%' differs from ‘%3%’") + throw Error(format("derivation `%1%' may not be deterministic: output `%2%' differs from `%3%’") % drvPath % path % dst); } else throw Error(format("derivation `%1%' may not be deterministic: output `%2%' differs") @@ -2501,11 +2501,11 @@ void DerivationGoal::registerOutputs() Path prev = i->path + checkSuffix; if (pathExists(prev)) throw NotDeterministic( - format("output ‘%1%’ of ‘%2%’ differs from ‘%3%’ from previous round") + format("output `%1%’ of `%2%’ differs from `%3%’ from previous round") % i->path % drvPath % prev); else throw NotDeterministic( - format("output ‘%1%’ of ‘%2%’ differs from previous round") + format("output `%1%’ of `%2%’ differs from previous round") % i->path % drvPath); } assert(false); // shouldn't happen @@ -2518,7 +2518,7 @@ void DerivationGoal::registerOutputs() if (curRound < nrRounds) { Path dst = i.second.path + checkSuffix; if (rename(i.second.path.c_str(), dst.c_str())) - throw SysError(format("renaming ‘%1%’ to ‘%2%’") % i.second.path % dst); + throw SysError(format("renaming `%1%’ to `%2%’") % i.second.path % dst); } } diff --git a/nix/libstore/local-store.cc b/nix/libstore/local-store.cc index 675d1ba66f..8b9c9bebd5 100644 --- a/nix/libstore/local-store.cc +++ b/nix/libstore/local-store.cc @@ -380,7 +380,7 @@ static void canonicalisePathMetaData_(const Path & path, uid_t fromUid, InodesSe /* Really make sure that the path is of a supported type. */ if (!(S_ISREG(st.st_mode) || S_ISDIR(st.st_mode) || S_ISLNK(st.st_mode))) - throw Error(format("file ‘%1%’ has an unsupported type") % path); + throw Error(format("file `%1%’ has an unsupported type") % path); /* Fail if the file is not owned by the build user. This prevents us from messing up the ownership/permissions of files @@ -647,7 +647,7 @@ uint64_t LocalStore::queryValidPathId(const Path & path) { auto use(stmtQueryPathInfo.use()(path)); if (!use.next()) - throw Error(format("path ‘%1%’ is not valid") % path); + throw Error(format("path `%1%’ is not valid") % path); return use.getInt(0); } diff --git a/nix/libstore/optimise-store.cc b/nix/libstore/optimise-store.cc index eb303ab4c3..2662253b91 100644 --- a/nix/libstore/optimise-store.cc +++ b/nix/libstore/optimise-store.cc @@ -181,12 +181,12 @@ void LocalStore::optimisePath_(OptimiseStats & stats, const Path & path, InodeHa } if (st.st_size != stLink.st_size) { - printMsg(lvlError, format("removing corrupted link ‘%1%’") % linkPath); + printMsg(lvlError, format("removing corrupted link `%1%’") % linkPath); unlink(linkPath.c_str()); goto retry; } - printMsg(lvlTalkative, format("linking ‘%1%’ to ‘%2%’") % path % linkPath); + printMsg(lvlTalkative, format("linking `%1%’ to `%2%’") % path % linkPath); /* Make the containing directory writable, but only if it's not the store itself (we don't want or need to mess with its diff --git a/nix/libutil/util.cc b/nix/libutil/util.cc index 69f1c634a9..cf5099a4fe 100644 --- a/nix/libutil/util.cc +++ b/nix/libutil/util.cc @@ -202,7 +202,7 @@ Path readLink(const Path & path) if (rlsize == -1) throw SysError(format("reading symbolic link '%1%'") % path); else if (rlsize > st.st_size) - throw Error(format("symbolic link ‘%1%’ size overflow %2% > %3%") + throw Error(format("symbolic link `%1%’ size overflow %2% > %3%") % path % rlsize % st.st_size); return string(buf, st.st_size); } -- 2.31.1 From unknown Fri Jun 13 11:01:02 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#48501] [PATCH] daemon: Replace Unicode single quotes with poor simulacra. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 18 May 2021 17:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48501 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Tobias Geerinckx-Rice , 48501@debbugs.gnu.org Received: via spool by 48501-submit@debbugs.gnu.org id=B48501.162135805131150 (code B ref 48501); Tue, 18 May 2021 17:15:02 +0000 Received: (at 48501) by debbugs.gnu.org; 18 May 2021 17:14:11 +0000 Received: from localhost ([127.0.0.1]:57191 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lj3II-00086M-QY for submit@debbugs.gnu.org; Tue, 18 May 2021 13:14:11 -0400 Received: from albert.telenet-ops.be ([195.130.137.90]:45314) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lj3IE-00086B-Rv for 48501@debbugs.gnu.org; Tue, 18 May 2021 13:14:09 -0400 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by albert.telenet-ops.be with bizsmtp id 6HE32500B0mfAB406HE3H9; Tue, 18 May 2021 19:14:03 +0200 Message-ID: <0ec7123db2721333ebe103200e42a266c4015d03.camel@telenet.be> From: Maxime Devos Date: Tue, 18 May 2021 19:13:56 +0200 In-Reply-To: <20210518163405.3618-1-me@tobias.gr> References: <20210518163405.3618-1-me@tobias.gr> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-MA1DpldOvqRjVvONRRfd" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1621358043; bh=JCD2dwoDObFYx5gd3l3wk9rs40jzRzpdDJ2uKYupwNg=; h=Subject:From:To:Date:In-Reply-To:References; b=aP/uOpv7+ayFKMgg2gIYGBUIZuIeK0/FJ0SxLCgV1zM3kZEHXxCIXBL/ugDmUBW3B 8Dfqy0T/Wnc9RficXZpjmAzk2WJkvArPcZJ7NXWrtQQP3taBjiDyTGNpmQRq9QtsJf ry668XK2yvdhmbFx64V7zRT/cUsyqAfd2HqVs7KAAOQaD2fgs0xa4DvCE+aXAiOz9a TOyuaPO1cVBK+ORavKiLef//JLCHIGqW/CP5x+mOJtky9Aszc4wRmrwRKtiDhF1xzA gA8lSzCcESfVvaZFfPBQmGNvcRkMK3UlbLfmKwYPxX7m+EBynSfyQa2RX8FUI2RRn9 OnpWO41d08PsQ== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-MA1DpldOvqRjVvONRRfd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Tobias Geerinckx-Rice via Guix-patches via schreef op di 18-05-2021 om 18:3= 4 [+0200]: > The correct =E2=80=98 and =E2=80=99 are not considered word boundaries by= some(?) > terminal emulators like Alacritty, making double-click selection > tedious. Avoid them in untranslated strings like it's 1992. N months later, while Tobias Geerinckx-Rice is asleep, a new patch appears: Typographically Correct via Guix-patches [...] > It isn't 1992 anymore; the proper =E2=80=98 and =E2=80=99 quotation marks= are now > well-supported in software. Use the typographically-correct =E2=80=98 an= d =E2=80=99 > in the English translation instead of the unrelated characters ` and '. > > [...] FWIW, double-click seems to work well in Emacs, Gnome Terminal. Instead of working-around bugs, can =E2=80=98we=E2=80=99 fix the bug in Ala= critty? Or at least, open a bug report? Unfortunately, GitHub's TOS and Privacy Policy were ... not great last time I checked, though I can't find the =E2=80=98badness=E2=80=99 anym= ore except for some weird section on =E2=80=98idemnity=E2=80=99. In any case, there i= s an #alacritty channel: Greetings, Maxime. --=-MA1DpldOvqRjVvONRRfd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYKP11RccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7pa/AP43GEjb39oLL2eW9z6fCdcPDg0A zxUMZAd1XPWZ+3HfQQEApl/d41lhfOVNNCKsVCNjSja4XUBV8pqSyAoZ/YHJWAI= =2Dc2 -----END PGP SIGNATURE----- --=-MA1DpldOvqRjVvONRRfd-- From unknown Fri Jun 13 11:01:02 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#48501] [PATCH] daemon: Replace Unicode single quotes with poor simulacra. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 21 May 2021 10:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48501 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Tobias Geerinckx-Rice Cc: 48501@debbugs.gnu.org Received: via spool by 48501-submit@debbugs.gnu.org id=B48501.162159292013397 (code B ref 48501); Fri, 21 May 2021 10:29:02 +0000 Received: (at 48501) by debbugs.gnu.org; 21 May 2021 10:28:40 +0000 Received: from localhost ([127.0.0.1]:35901 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lk2OS-0003Tx-7b for submit@debbugs.gnu.org; Fri, 21 May 2021 06:28:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57628) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lk2OQ-0003Ti-9h for 48501@debbugs.gnu.org; Fri, 21 May 2021 06:28:34 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49302) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lk2OK-0004AY-U6; Fri, 21 May 2021 06:28:28 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=55960 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lk2OK-0003nB-7e; Fri, 21 May 2021 06:28:28 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20210518163405.3618-1-me@tobias.gr> Date: Fri, 21 May 2021 12:28:27 +0200 In-Reply-To: <20210518163405.3618-1-me@tobias.gr> (Tobias Geerinckx-Rice's message of "Tue, 18 May 2021 18:34:05 +0200") Message-ID: <87h7iw4bzo.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Tobias Geerinckx-Rice skribis: > The correct =E2=80=98 and =E2=80=99 are not considered word boundaries by= some(?) > terminal emulators like Alacritty, making double-click selection > tedious. Avoid them in untranslated strings like it's 1992. > > * nix/libstore/build.cc (UserLock::acquire) > (DerivationGoal::haveDerivation, DerivationGoal::closureRepaired) > (DerivationGoal::startBuilder, DerivationGoal::runChild) > (DerivationGoal::registerOutputs): Replace =E2=80=98=E2=80=99 with `' in = output. > * nix/libstore/local-store.cc (canonicalisePathMetaData_) > (LocalStore::queryValidPathId): Likewise. > * nix/libstore/optimise-store.cc (LocalStore::optimisePath_): Likewise. > * nix/libutil/util.cc (readLink): Likewise. > --- > nix/libstore/build.cc | 24 ++++++++++++------------ > nix/libstore/local-store.cc | 4 ++-- > nix/libstore/optimise-store.cc | 4 ++-- > nix/libutil/util.cc | 2 +- > 4 files changed, 17 insertions(+), 17 deletions(-) No objection from me! Ludo=E2=80=99. From unknown Fri Jun 13 11:01:02 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#48501] [PATCH] daemon: Replace Unicode single quotes with poor simulacra. Resent-From: Thiago Jung Bauermann Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 21 May 2021 14:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48501 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 48501@debbugs.gnu.org Cc: Tobias Geerinckx-Rice X-Debbugs-Original-To: 48501@debbugs.gnu.org, guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.162160702421116 (code B ref -1); Fri, 21 May 2021 14:24:01 +0000 Received: (at submit) by debbugs.gnu.org; 21 May 2021 14:23:44 +0000 Received: from localhost ([127.0.0.1]:37340 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lk640-0005UW-9J for submit@debbugs.gnu.org; Fri, 21 May 2021 10:23:44 -0400 Received: from lists.gnu.org ([209.51.188.17]:59668) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lk63x-0005UN-Va for submit@debbugs.gnu.org; Fri, 21 May 2021 10:23:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42908) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lk63w-0005HO-PY for guix-patches@gnu.org; Fri, 21 May 2021 10:23:41 -0400 Received: from mx.kolabnow.com ([95.128.36.41]:58126) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lk63s-0003qj-8G for guix-patches@gnu.org; Fri, 21 May 2021 10:23:39 -0400 Received: from localhost (unknown [127.0.0.1]) by ext-mx-out002.mykolab.com (Postfix) with ESMTP id EC58AB46; Fri, 21 May 2021 16:23:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kolabnow.com; h= content-type:content-type:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:date:subject:subject :from:from:received:received:received; s=dkim20160331; t= 1621607010; x=1623421411; bh=DWKbEkARUJgUojNzHckSzCJ5YWiuyeTrwjq Nq/sISq8=; b=usWFdrWtjyiUSRizmUwHjEyG/e3AbswZz43jD2MKNSa8pCWmQie SQXkl/rFGpQ63aMCOvaTTJVleZze5DjV6Lbw9FbsmWNuW9LIcrUH5r5Wu9NV3aIV izanbVCkL2/GBKLdPcKsUD4w3WFMMTHn8otQlvknwoPIPIaAYgRYpRBMV408d9Li AY/5WHDGIpupf0dC3qLCMgfadc0KqRP/uPvr8CpkfpGIbhFlkTdFZz6d9tXyr/MB aTch/KTsx+V1AT7T1Z81dhEy7eLc+H36la7MeDumTZvlpbAo57/Pk+4k9xA2wkqj 681zzZs+g5J+AgBoWKxw6a/GXr5AKOoUkJh6ryjl3SHnf7eSzlRMoSE6uar3o+/w eg4dOWZHiIn6mOxr/4Yl5D5Mvj2Z1iYauD4m9yXZ9/Hc/9gKtRLW+5pwB+xp6LSG mbiT6IWU9uaLSSO2/mB55z06Buf6Qvw2pIrQUNV5jA4dFjimpk2YwopX7zVKlogP PhnN2dkas9mZi+b2JzV1i+gEd8pFj/fV3+flEoXOim/6/Wv11TLYbLf3FXw1Sb+w anCraNrgoX8dRHixaKABt3U3NHqbrlAUMPrfebUZnYlTsU42EZlWS7SAIyu2LOAB m1z3bAzfq5wcpJxRgLeruzZ1F9GYwlK0tf9Mkiti0LgGkyRejTyCGH8c= X-Virus-Scanned: amavisd-new at mykolab.com X-Spam-Flag: NO X-Spam-Score: -1.9 X-Spam-Level: X-Spam-Status: No, score=-1.9 tagged_above=-10 required=5 tests=[BAYES_00=-1.9] autolearn=ham autolearn_force=no Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out002.mykolab.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DM5eGN0PXBqI; Fri, 21 May 2021 16:23:30 +0200 (CEST) Received: from int-mx002.mykolab.com (unknown [10.9.13.2]) by ext-mx-out002.mykolab.com (Postfix) with ESMTPS id 6CFCA806; Fri, 21 May 2021 16:23:30 +0200 (CEST) Received: from ext-subm002.mykolab.com (unknown [10.9.6.2]) by int-mx002.mykolab.com (Postfix) with ESMTPS id DB2B74589; Fri, 21 May 2021 16:23:26 +0200 (CEST) From: Thiago Jung Bauermann Date: Fri, 21 May 2021 11:23:20 -0300 Message-ID: <3094026.NOWVCxSc26@popigai> In-Reply-To: <20210518163405.3618-1-me@tobias.gr> References: <20210518163405.3618-1-me@tobias.gr> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=95.128.36.41; envelope-from=bauermann@kolabnow.com; helo=mx.kolabnow.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Hello, [ I'm just an onlooker on the Guix mailing lists, so don't assign much=20 weight to this comment. ] Em ter=C3=A7a-feira, 18 de maio de 2021, =C3=A0s 13:34:05 -03, Tobias Geeri= nckx-Rice=20 via Guix-patches via escreveu: > The correct =E2=80=98 and =E2=80=99 are not considered word boundaries by= some(?) > terminal emulators like Alacritty, making double-click selection > tedious. Avoid them in untranslated strings like it's 1992. >=20 > * nix/libstore/build.cc (UserLock::acquire) > (DerivationGoal::haveDerivation, DerivationGoal::closureRepaired) > (DerivationGoal::startBuilder, DerivationGoal::runChild) > (DerivationGoal::registerOutputs): Replace =E2=80=98=E2=80=99 with `' in = output. > * nix/libstore/local-store.cc (canonicalisePathMetaData_) > (LocalStore::queryValidPathId): Likewise. > * nix/libstore/optimise-store.cc (LocalStore::optimisePath_): Likewise. > * nix/libutil/util.cc (readLink): Likewise. > --- > nix/libstore/build.cc | 24 ++++++++++++------------ > nix/libstore/local-store.cc | 4 ++-- > nix/libstore/optimise-store.cc | 4 ++-- > nix/libutil/util.cc | 2 +- > 4 files changed, 17 insertions(+), 17 deletions(-) >=20 > diff --git a/nix/libstore/build.cc b/nix/libstore/build.cc > index 5697ae5a43..d6f9a15a46 100644 > --- a/nix/libstore/build.cc > +++ b/nix/libstore/build.cc > @@ -525,7 +525,7 @@ void UserLock::acquire() > int err =3D getgrouplist(pw->pw_name, pw->pw_gid, > supplementaryGIDs.data(), &ngroups); > if (err =3D=3D -1) > - throw Error(format("failed to get list of supplementary > groups for =E2=80=98%1%=E2=80=99") % pw->pw_name); + throw > Error(format("failed to get list of supplementary groups for `%1%=E2=80= =99") % > pw->pw_name); IMHO the backtick looks ugly when it tries to mimick the opening quote=20 character. I think the text looks better if both quote characters are=20 replaced with the straight quote character, e.g. '%1'. =2D-=20 Regards from the peanut gallery, Thiago