Subject: bug#48494: 28.0.50; [PATCH] AngeFTP fails on macOS 10.14 with GNU inetutils FTP

From: Alex Bochannek <[email-masked]>
Date: Tue, 25 May 2021 12:33:36 -0700

Michael Albinus <[email-masked]> writes:

> Alex Bochannek <[email-masked]> writes:
>
> Hi Alex,
>
>> Follow-up to this. The issue on macOS appears to be caused by inetutils
>> picking up libedit for Readline during configuration. Once I installed a
>> proper libreadline and configured with the right prefix, the problem was
>> resolved.
>>
>> Adding the -e comment to the docstring still seems sensible to me.
>
> D'accord. Perhaps you could also add a comment with this fact, and
> referring to bug#48494.

Sounds good. See below.

diff --git a/lisp/net/ange-ftp.el b/lisp/net/ange-ftp.el
index 04ea809127..3f3a3df8e5 100644
--- a/lisp/net/ange-ftp.el
+++ b/lisp/net/ange-ftp.el
@@ -949,7 +949,11 @@ ange-ftp-gateway-ftp-program-name
   :type 'string)
 
 (defcustom ange-ftp-ftp-program-args '("-i" "-n" "-g" "-v")
-  "A list of arguments passed to the FTP program when started."
+  ;; Clients that use the BSD editline instead of the GNU readline
+  ;; library may need to disable command line editing. (Bug#48494)
+  "A list of arguments passed to the FTP program when started.
+Some FTP clients may also require the \"-e\" argument, which disables
+command line editing."
   :group 'ange-ftp
   :type '(repeat string))

-- 
Alex.