Subject: Re: bug#48494: 28.0.50; [PATCH] AngeFTP fails on macOS 10.14 with GNU inetutils FTP

From: Michael Albinus <[email-masked]>
Date: Fri, 21 May 2021 10:25:02 +0200

Alex Bochannek <[email-masked]> writes:

Hi Alex,

>> Perhaps the `ange-ftp-ftp-program-args' doc string should mention that
>> some ftp clients require "-e"?  That should help with discoverability
>> for people who have these problems.
>
> diff --git a/lisp/net/ange-ftp.el b/lisp/net/ange-ftp.el
> index 04ea809127..064aca5abf 100644
> --- a/lisp/net/ange-ftp.el
> +++ b/lisp/net/ange-ftp.el
> @@ -949,7 +949,9 @@ ange-ftp-gateway-ftp-program-name
>    :type 'string)
>
>  (defcustom ange-ftp-ftp-program-args '("-i" "-n" "-g" "-v")
> -  "A list of arguments passed to the FTP program when started."
> +  "A list of arguments passed to the FTP program when started.
> +Some FTP clients may also require the \"-e\" argument, which disables
> +command line editing."
>    :group 'ange-ftp
>    :type '(repeat string))

LGTM. As I see, you have already submitted several patches to
Emacs. Have you signed already the FSF copyright papers? Otherwise, I
fear your contributions would exceed the max tiny patch limit.

In case you haven't signed yet, would you like to do that? It would
enable you to submit as many patches to Emacs as you like :-)

Best regards, Michael.