GNU bug report logs - #48493
28.0.50; quit-window doesn't work

Previous Next

Full log

View this message in rfc822 format

From: pillule <pillule <at> riseup.net>
To: pillule <pillule <at> riseup.net>
Cc: martin rudalics <rudalics <at> gmx.at>, 48493 <at> debbugs.gnu.org, Sujith Manoharan <sujith.wall <at> gmail.com>
Subject: bug#48493: 28.0.50; quit-window doesn't work
Date: Wed, 09 Jun 2021 15:36:44 +0200

[Message part 1 (text/plain, inline)]

pillule <pillule <at> riseup.net> writes:

>>> What's wrong with putting the first disjunct into the 
>>> conditional as in
>>> the below?  In general, always try to avoid larger indentation 
>>> changes -
>>> they can make forensics cumbersome while bisecting.
>>>
>>>      (cond
>>>       ;; First try to delete dedicated windows that are not 
>>>       side       windows
>>>       ((and dedicated (not (eq dedicated 'side))
>>>             (window--delete window 'dedicated (eq bury-or-kill 
>>>             'kill))))
>>>       ((and (not prev-buffer)
>>>              (eq (nth 1 quit-restore) 'tab)
>>>              (eq (nth 3 quit-restore) buffer))
>>
>> The difference is a window dedicated with flag t may not be 
>> deletable, and in this case, we want
>> it
>> to pass through the others conditionals branch of 
>> quit-restore-window, so it can try to use the
>> 'quit-restore parameter, close the tab or to fallback in t, 
>> etc.
>> Explaining it makes me thing I could use 'window-deletable-p' 
>> in its conditional and ...
>> I guess, problem solved
>>
>
> I read it again and think you were right,
> when  (window--delete window 'dedicated (eq bury-or-kill 'kill))
> is part of the conditional, it indeed already fail if the window 
> is not deletable ;
>
> I will correct that in the next revision.

hm. here again minors corrections. sorry for the noise.

[0004-Improve-handling-of-side-dedicated-flag.patch (text/x-diff, attachment)]

[Message part 3 (text/plain, inline)]

--

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.