GNU bug report logs - #48492
[PATCH] Fix wrong-type-argument error while loading pdump file

Previous Next

Full log

Message #15 received at 48492 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: 48492 <at> debbugs.gnu.org
Cc: Gong Qijian <gongqijian <at> gmail.com>
Subject: Re: master ab20f38: Fix `custom-delayed-init-variables' problem
 when re-dumping emacs
Date: Tue, 18 May 2021 10:48:16 -0400

>     * lisp/startup.el (command-line): Don't bug out on redumping Emacs
>     (bug#48492).
[...]
> @@ -1197,11 +1197,11 @@ please check its value")
>  
>    ;; Re-evaluate predefined variables whose initial value depends on
>    ;; the runtime context.
> -  (setq custom-delayed-init-variables
> -        ;; Initialize them in the same order they were loaded, in case there
> -        ;; are dependencies between them.
> -        (nreverse custom-delayed-init-variables))
> -  (mapc #'custom-reevaluate-setting custom-delayed-init-variables)
> +  (when (listp custom-delayed-init-variables)
> +    (mapc #'custom-reevaluate-setting
> +          ;; Initialize them in the same order they were loaded, in
> +          ;; case there are dependencies between them.
> +          (reverse custom-delayed-init-variables)))
>    (setq custom-delayed-init-variables t)
>  
>    ;; Warn for invalid user name.

While this is a good short term fix, I think what we would ideally want
instead is that those settings be re-evaluated yet-again when we start
the re-dumped Emacs.

So maybe instead of setting the var to t, we should use another var to
denote that we've already init'd those vars (and re-set that other var
some time when we redump).


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.