From unknown Fri Jun 13 13:25:30 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#48489 <48489@debbugs.gnu.org> To: bug#48489 <48489@debbugs.gnu.org> Subject: Status: 28.0.50; Incorrect Edebug instrumentation for old `when-let' form Reply-To: bug#48489 <48489@debbugs.gnu.org> Date: Fri, 13 Jun 2025 20:25:30 +0000 retitle 48489 28.0.50; Incorrect Edebug instrumentation for old `when-let' = form reassign 48489 emacs submitter 48489 Philipp severity 48489 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Mon May 17 18:08:40 2021 Received: (at submit) by debbugs.gnu.org; 17 May 2021 22:08:40 +0000 Received: from localhost ([127.0.0.1]:53964 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lilPk-00036I-8I for submit@debbugs.gnu.org; Mon, 17 May 2021 18:08:40 -0400 Received: from lists.gnu.org ([209.51.188.17]:47022) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lilPg-000368-Q4 for submit@debbugs.gnu.org; Mon, 17 May 2021 18:08:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59146) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lilPg-0006Wm-Lv for bug-gnu-emacs@gnu.org; Mon, 17 May 2021 18:08:36 -0400 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]:38739) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lilPe-0008Hr-RH for bug-gnu-emacs@gnu.org; Mon, 17 May 2021 18:08:36 -0400 Received: by mail-wm1-x329.google.com with SMTP id u4-20020a05600c00c4b02901774b80945cso354709wmm.3 for ; Mon, 17 May 2021 15:08:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=dOfuk/siKxw/qQx1iEE+WDWjzSVR7SuYYNa2Nvu5+Ds=; b=dbTn830++fGaKAB2ga8bHtQGbiula09xiYbl0A3D7D8sz/q+HxSNpxqJZ3zOohs+sZ YIAt5vxkrcMFxewATMGml32yqlQbU6ihmrfLw7YatRSKQNl9RR/YPQVQLy06iHZGTmoc T0p2GjIQWgXNUSis3ko4ovNNGltkpHTx1o0pRznn+V0Blc5gPzI8PLy4e8TiL/zUdkqA eplNNz6VV6zeXq+UazrsMV51RyQ57gr7BCSpZeSEQaW3G2B4g9UoFcLx9zHd8TvEFnqf ffCJ2SX5z1pR50GXnV1yKvGObinA3R3PgvGr0gHbZZi3A4Rwn9fnThceuzFYEqe2BdaV dOtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=dOfuk/siKxw/qQx1iEE+WDWjzSVR7SuYYNa2Nvu5+Ds=; b=O7u6Wv/CgsW/Kj7/RSc6guzqdgnyW1DyGiDcw4AViWqu16UZoqWL5Fg1cMpFe/ZwD7 iORVH3a8Tc27MI7Yu/ttHjsx5SL5mdl4GQ3xHv0LigWf3nPxFnetOEYUOkTdNNVgBP4w fg3gf1rIf7SiFr4KobXXK4uTgR/W4JxAyOIQpswnUlnUV/1oC7kiICXK/dadPnCZOOYb TUDQ5u9uJUpKQh2jb7s4EUDiEH77Z7Rwx4v2XZq/MfHwLEXRRBMTGlMM7JB2JPsgSoN3 fwXa6zHv98j1Qg0o9Rud7PudHKez7TCRfFb+0P/yWynvSTbXgsBCC5vco1wkSBf1zq3k fxQg== X-Gm-Message-State: AOAM5336S1PahXTQs06JHhnTVfL3sn7KTykiMWwQCzjl2cgiyFmpflf3 5lsNSkozP9fGgEvI/ZEn7rnnhOjfP5XF3Q== X-Google-Smtp-Source: ABdhPJx8KsSxMQluQ676kp3/E5/YtLE4w4Ct6jbp9Jec8i0kQgwWiEQFl3JRlbylAbt2dNnYC5f80w== X-Received: by 2002:a1c:55ca:: with SMTP id j193mr1181949wmb.58.1621289311959; Mon, 17 May 2021 15:08:31 -0700 (PDT) Received: from Philipps-MBP.fritz.box ([46.128.198.100]) by smtp.gmail.com with ESMTPSA id q13sm17387819wrw.56.2021.05.17.15.08.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 May 2021 15:08:31 -0700 (PDT) From: Philipp To: bug-gnu-emacs@gnu.org Subject: 28.0.50; Incorrect Edebug instrumentation for old `when-let' form Date: Tue, 18 May 2021 00:08:30 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=p.stephani2@gmail.com; helo=mail-wm1-x329.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) Insert the following form into *scratch*: (defun f (a) (when-let (b (not a)) b)) Edebug-evaluate it using C-u M-C-x. Now evaluate (f 1). Edebug will not stop at the (not a) form, only the `a' symbol. The instrumented form is indeed incorrect: (symbol-function 'f) gives (closure (t) (a) (edebug-enter 'f (list a) #'(lambda nil (edebug-after (edebug-before 0) 3 (let* ((b (and t (not (edebug-after 0 1 a))))) (if b (edebug-after 0 2 b) nil)))))) Note the missing edebug-before/after around the `not' form. This can be rectified by swapping the two `&or' branches in the Edebug specification for `if-let', which makes sense given the first branch is often a superset of the second. I don't mind doing that, but maybe there are negative conseqences from that that I don't see? In GNU Emacs 28.0.50 (build 120, aarch64-apple-darwin20.4.0, NS appkit-2022.44 Version 11.3.1 (Build 20E241)) of 2021-05-17 Repository revision: f572735c5105a84da3175ae6cdad807fa103dfe1 Repository branch: master Windowing system distributor 'Apple', version 10.3.2022 System Description: macOS 11.3.1 Configured using: 'configure --with-modules --without-xml2 --without-pop --with-mailutils --enable-gcc-warnings=warn-only --enable-checking=all --enable-check-lisp-object-type 'CFLAGS=-ggdb3 -O0'' Configured features: ACL GNUTLS JSON LCMS2 MODULES NOTIFY KQUEUE NS PDUMPER PNG THREADS TOOLKIT_SCROLL_BARS ZLIB Important settings: value of $LANG: de_DE.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc dired dired-loaddefs rfc822 mml mml-sec epa epg epg-config gnus-util rmail rmail-loaddefs time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils phst skeleton derived edmacro kmacro pcase ffap thingatpt url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map url-vars mailcap rx gnutls puny dbus xml subr-x seq byte-opt gv bytecomp byte-compile cconv compile text-property-search comint ansi-color ring cl-loaddefs cl-lib iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads kqueue cocoa ns lcms2 multi-tty make-network-process emacs) Memory information: ((conses 16 70904 5824) (symbols 48 8362 1) (strings 32 24249 2101) (string-bytes 1 793015) (vectors 16 16050) (vector-slots 8 212531 11281) (floats 8 26 28) (intervals 56 219 0) (buffers 992 10)) From debbugs-submit-bounces@debbugs.gnu.org Tue May 18 03:29:31 2021 Received: (at 48489-done) by debbugs.gnu.org; 18 May 2021 07:29:31 +0000 Received: from localhost ([127.0.0.1]:54324 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1liuAV-00024b-Jn for submit@debbugs.gnu.org; Tue, 18 May 2021 03:29:31 -0400 Received: from mail-ot1-f49.google.com ([209.85.210.49]:40925) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1liuAU-00024O-Hu for 48489-done@debbugs.gnu.org; Tue, 18 May 2021 03:29:30 -0400 Received: by mail-ot1-f49.google.com with SMTP id s5-20020a05683004c5b029032307304915so577499otd.7 for <48489-done@debbugs.gnu.org>; Tue, 18 May 2021 00:29:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=z3GZFStJBcig9mZKmb9dKrakAjZTes6q8AQP4GsZGp4=; b=h/sWUZy/x5sgDrT+rtjrrKK8OMy+7nC38wDjbPqWKCK7MhPCwV7S1kFWysDXq5V1eB yP/llu8zqm3InyDEo7WchGPjeRmOTriac7LigUXz5wIcgOxJuQlsV4PZ1UMbEGHVJdQb 9MjfZ9RUmtVO5V8kRLIu91d3CZ2s8xcaLc0RNXYEx5PPVOBrUFrjRW5XfKgzTXIVhghU 2hxKdedhvD8YjSprBMo1cgoClxEepg5LR43UIqT5wMxnx0W551iLP1cuIe67i1+U7cLm ddMwQiWXRYuzZXuUF11uzxIeqA6nTgBJkIflPCHY1tYe2pwbJrg5iYu6WkSYuM77CA8b KS9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=z3GZFStJBcig9mZKmb9dKrakAjZTes6q8AQP4GsZGp4=; b=VpRQxClmXkRODj3O7Fq+mMNxsxEluBRkfJ2HhsRW22hjaU20q1rppjqyAVI5AE9Tvn bSpJUanbzUEpauMWDfub0/jzcTBFBF6wOmn3PodH+m/AcDFQw+qY1Wxlv6sI2cRgq2bx XnSw2+URMHucdr+m6bjAQQQuOy4Val5BMyKwaoPj+0H2g6jrIrjtfAz5swdC981a/8aD jmUMumsDdEvDHBD0K0w9gBW2X7CxcN1b30EcQqQHVytLDdMSacr3PNDybTrn0iuXHF+n euAJL4NqkXHniT72hSvx5NL4VEfDGunvGY/xiVZRMHFfK+qzLiaEnDHiUm6h8J07z/TV k+nw== X-Gm-Message-State: AOAM533ZN6Ye1Yb5QvkFRkFaDAWrsK1MB33FAtcun81mhyAP/c6QssNH EyI2EEdsN/zsn9rLi3srOM8VgURAMjqOWKjIKUZSbP+MYgUjOg== X-Google-Smtp-Source: ABdhPJz/HinztMQD2WkI0KIWKSNbknYwSRBP88hTngzTmz2t55DnXO8zlrdrfM5W2fgzygfgmC6nooOdE1Mg14P9Xrg= X-Received: by 2002:a05:6830:2248:: with SMTP id t8mr3122719otd.156.1621322964597; Tue, 18 May 2021 00:29:24 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Philipp Stephani Date: Tue, 18 May 2021 09:29:13 +0200 Message-ID: Subject: Re: bug#48489: 28.0.50; Incorrect Edebug instrumentation for old `when-let' form To: 48489-done@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 48489-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Am Di., 18. Mai 2021 um 00:09 Uhr schrieb Philipp : > This can be rectified by swapping the two `&or' branches in the Edebug > specification for `if-let', which makes sense given the first branch is > often a superset of the second. I don't mind doing that, but maybe > there are negative conseqences from that that I don't see? I guess the easiest way to find out is to make the change and see whether anything breaks ;-) Done with commit 9676d41b8301b84e07717e633059a3f2b5c4c9d8. From debbugs-submit-bounces@debbugs.gnu.org Tue May 18 10:59:17 2021 Received: (at 48489) by debbugs.gnu.org; 18 May 2021 14:59:17 +0000 Received: from localhost ([127.0.0.1]:56909 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lj1Bk-00027Y-UP for submit@debbugs.gnu.org; Tue, 18 May 2021 10:59:17 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35584) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lj1Bi-00027K-SH for 48489@debbugs.gnu.org; Tue, 18 May 2021 10:59:15 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38932) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lj1Bd-0002xc-J9; Tue, 18 May 2021 10:59:09 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1lj1Bd-00023U-01; Tue, 18 May 2021 10:59:09 -0400 From: Glenn Morris To: Philipp Subject: Re: bug#48489: 28.0.50; Incorrect Edebug instrumentation for old `when-let' form References: X-Spook: Public Health CipherTAC-2000 Torreon primacord X-Ran: 5>|XbFrs?m`*p"Zr3+6Rxa5bc^sZQ<+xttYG7fZVIYc>1tvLE![7|F;}[u:y~tE{W0EqA5 X-Hue: brightred X-Attribution: GM Date: Tue, 18 May 2021 10:59:08 -0400 In-Reply-To: (Philipp's message of "Tue, 18 May 2021 00:08:30 +0200") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48489 Cc: 48489@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Philipp wrote: > This can be rectified by swapping the two `&or' branches in the Edebug > specification for `if-let', which makes sense given the first branch is > often a superset of the second. I don't mind doing that, but maybe > there are negative conseqences from that that I don't see? Since 9676d41, edebug-tests-duplicate-symbol-backtrack fails. Ref eg https://hydra.nixos.org/build/143298928 Reproduced on CentOS 8.3. From debbugs-submit-bounces@debbugs.gnu.org Tue May 18 11:56:15 2021 Received: (at 48489) by debbugs.gnu.org; 18 May 2021 15:56:16 +0000 Received: from localhost ([127.0.0.1]:57009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lj24t-0005mV-MA for submit@debbugs.gnu.org; Tue, 18 May 2021 11:56:15 -0400 Received: from mail-oi1-f172.google.com ([209.85.167.172]:36433) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lj24s-0005mD-1j for 48489@debbugs.gnu.org; Tue, 18 May 2021 11:56:15 -0400 Received: by mail-oi1-f172.google.com with SMTP id f184so10225408oig.3 for <48489@debbugs.gnu.org>; Tue, 18 May 2021 08:56:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=I7vNCpfIxLiEgbjEx8/w5KUj6lAy00G7tqYzB2A69ZU=; b=obPKlPI+nieY+5dZQCYvtp1Eo2rmrAIvUlbZMLiZtAF8nMRAJuk1DpXwNJgPnl0k4X ywJX73kj1ycn4VDKi/ObtJ5fgAfu22P6PETuh4xhOZhpazFgkebd0ich3q+WgT0KQmCP P1iuOQ0komJKTemG2pObgIe3bTAjBNmUWjRUsGcDsqwkKbKrfFVyL9I3ssQCSKutBLxQ dewdc8CiozloPodVeHmbmI+mJ/z2GkJRSlEFtLbGsQJ9HUTfrDgBRHVNiTWsga2NUc3q 0mBky/kHwcSpp9GxNqGyB1l4mRlW38tNhIOPrgj8RyMNNdwA+qIu8Dv1TzTe5+QDmMAr Wl8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=I7vNCpfIxLiEgbjEx8/w5KUj6lAy00G7tqYzB2A69ZU=; b=CnLApYtmqU8UdRZAKbiVnGTJ5XLnGlgM0ykVJ4idBgwZzb6gqPlEc/1P6YQaw0jzfh jBH9pyIa6frzYSoYNuhI8YEKFhr8prBA104RNfeQkEiBrYGw9RfJDwHTahCgjC9bcIqB BdF6XjTjfky6VoAN/yZijx4UHcYdW7g9s3KTlF8VaRLsaLhwZW7VJ+s3EyNEnpg8aPox FA8fKUmAsFjxwulHAqe0Kn+y0EFyriMgeMU9XdxApssQy8R3H3bqaaOwqdFn4E4j2Ltm FrN46QjJ8gtMPvKIAyNXef8+5hv2dtb61jLA/UJf6yOMk5zR9othH0/EBWmpAwI1JX7T Cpeg== X-Gm-Message-State: AOAM530pMHSRCbuyVflkHmThhy164CJOY5BWfesYvx6XJ8NQDEeO75on z9nzzHZcqT0QN0U9cLFmrMKwQvwL5UuQ4ziJbaU= X-Google-Smtp-Source: ABdhPJxoDfNo7J853BRwiSNfQ1aQQq0xc/YQjJ6IRlwZfvB/yj7/iRZALzeucHeYqQtewTpf9lmhIgCrPG4Gq7zENBw= X-Received: by 2002:aca:4d01:: with SMTP id a1mr4507230oib.158.1621353368091; Tue, 18 May 2021 08:56:08 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Philipp Stephani Date: Tue, 18 May 2021 17:55:57 +0200 Message-ID: Subject: Re: bug#48489: 28.0.50; Incorrect Edebug instrumentation for old `when-let' form To: Glenn Morris Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 48489 Cc: 48489@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Am Di., 18. Mai 2021 um 16:59 Uhr schrieb Glenn Morris : > > Philipp wrote: > > > This can be rectified by swapping the two `&or' branches in the Edebug > > specification for `if-let', which makes sense given the first branch is > > often a superset of the second. I don't mind doing that, but maybe > > there are negative conseqences from that that I don't see? > > Since 9676d41, edebug-tests-duplicate-symbol-backtrack fails. > Ref eg https://hydra.nixos.org/build/143298928 > Reproduced on CentOS 8.3. Hmm, I can't reproduce this on Debian. But I don't see how this could be OS-dependent. From debbugs-submit-bounces@debbugs.gnu.org Tue May 18 12:25:12 2021 Received: (at 48489) by debbugs.gnu.org; 18 May 2021 16:25:12 +0000 Received: from localhost ([127.0.0.1]:57090 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lj2Wu-0002TB-2o for submit@debbugs.gnu.org; Tue, 18 May 2021 12:25:12 -0400 Received: from quimby.gnus.org ([95.216.78.240]:43882) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lj2Wr-0002Sk-TR for 48489@debbugs.gnu.org; Tue, 18 May 2021 12:25:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ElJ8xeTMKyaJxdTxAKqQH82PMU8cVJlbLLwrWqxyq3Q=; b=cR8ZLFWl0A9rBtMgYJAKXVseVI eaAFJ7fYtjz7Uwr1IXO6G4nJP/+OZpkRZQC/2hHQNDXBRFfRo+aiwsCCK1lt+jJsI2zcOwiZuKkEj lYdDzfFkBCcbrE1Vt3oEAbXm/9ctfgUBNWTd+OYczvTNQXq5tpdoW6r2BoG3PzzdLPQg=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lj2Wi-0007LW-Rk; Tue, 18 May 2021 18:25:03 +0200 From: Lars Ingebrigtsen To: Philipp Stephani Subject: Re: bug#48489: 28.0.50; Incorrect Edebug instrumentation for old `when-let' form References: Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAG1BMVEWS/mZnsEcxNh6J t3GM+1+59p7s/eSIRjf///8TDg0eAAAAAWJLR0QIht6VegAAAAd0SU1FB+UFEhAYKv0rwgoAAAF5 SURBVDjL7VNBboMwENwkxmfs0gd4q5ZrmlTK1USmZ6RinznEfgCXfL9jaNOQ9AOVOsDKzHjHi70Q 6a1aKdWYVamASqmjpYw1G96xYp05k7XGkWtK0sSAMWsoLqc46zxtIDRIYWWaidzvK+Gc917QkXWF DF06wILq3TSiFQu4m3XlFrDIMNlL3wuay7y8uBU0a5vLuhMYZrkqsWAF0SN1+43v3j72WzWjYaVV STKkFHFHHwoUW/gc/eBJxkBhUhDx4ErveKOQIOScwafkfUKM7ylEStnLY36XJk8EzJUDwTD6InZB SIwKL2Nsu6LoSMIv56ZTCCH1U7AC5YpoU1/IIQzwaRFC6KeDsrFN1MbioPgLYz1iJ6gdZDhhuR0v YMj2vu3xYTulv8l6EnCSwmJ/LjSfzyPXW5pbguyPwPWZnyO5pTDOXi/XQq1n+4ynSNZeZeirqpy9 WwM4GCL6TeCLgK6cOxd4UK+qon/8HeT/kpwg6xa0u4Wd6E/w7otMGjOfawAAACV0RVh0ZGF0ZTpj cmVhdGUAMjAyMS0wNS0xOFQxNjoyNDo0MiswMDowMK4z40cAAAAldEVYdGRhdGU6bW9kaWZ5ADIw MjEtMDUtMThUMTY6MjQ6NDIrMDA6MDDfblv7AAAAAElFTkSuQmCC X-Now-Playing: Oneohtrix Point Never's _KCRW Session_: "Chrome Country" Date: Tue, 18 May 2021 18:25:00 +0200 In-Reply-To: (Philipp Stephani's message of "Tue, 18 May 2021 17:55:57 +0200") Message-ID: <87mtssc8mb.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Philipp Stephani writes: > Hmm, I can't reproduce this on Debian. But I don't see how this could > be OS-dependent. It reproduces fine here on Debian/bullseye, at least: Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 48489 Cc: Glenn Morris , 48489@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Philipp Stephani writes: > Hmm, I can't reproduce this on Debian. But I don't see how this could > be OS-dependent. It reproduces fine here on Debian/bullseye, at least: 1 unexpected results: FAILED edebug-tests-duplicate-symbol-backtrack -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue May 18 12:27:55 2021 Received: (at 48489) by debbugs.gnu.org; 18 May 2021 16:27:55 +0000 Received: from localhost ([127.0.0.1]:57095 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lj2ZX-0002Wv-HK for submit@debbugs.gnu.org; Tue, 18 May 2021 12:27:55 -0400 Received: from mail-oi1-f172.google.com ([209.85.167.172]:45887) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lj2ZV-0002Wi-IL for 48489@debbugs.gnu.org; Tue, 18 May 2021 12:27:54 -0400 Received: by mail-oi1-f172.google.com with SMTP id w127so6485217oig.12 for <48489@debbugs.gnu.org>; Tue, 18 May 2021 09:27:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=P/5R9goGXyru605OIc9ziLjbMKSt91qSYLZFx0lNbgU=; b=bTd2/q9ilwKlckt8HKQ7JYkhvSbeEvBIqR7wsW5KfjRgHrJuTezaqzFlTa301x66oj Gnj9LHyzWuKlsYlaWZRzEpqkR4i0w0Y0kKbRARzdBaqa5q707sJeJRv/o9SEvpRanfes /e5vPAI/O3+Rx6b6SuLVXVHUxjZv8+As1EEjOJknEavDOjbBmcVU75oCl8ZpCjuOjk7B Nyqg9mpCPf2fVynKhUTCQ7bb0kfk/B/qDaKtotOXmM2F3uA1/s/wxuIVGCeIRe1Knd6S bKkawe/bziyHPN8HLrOHYjFSj3ARrtXJ7fH0iI897mnezjGZ8UNq+AgkLE19lsLTXU31 VVGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=P/5R9goGXyru605OIc9ziLjbMKSt91qSYLZFx0lNbgU=; b=q7KVelWnwooOxbSnq7gF9ya4UUPCuvIOInXOxHupZpOUixgXF41QxBikNaIS5FgPlc NRqMA3V7S337TCOFrAB1n1WFArbPg3/OHoix2ddbvlXjD0iGvYnLzYu9Qka4cEHkcUFL JvULjWPkWJusxul+UkG6zBu0e7pHSc9x+E6bgW4LWmSZ4Pfe7PtCMZwn1gxnJfE6ys57 93LMm551EuW1Y0n2Hs+qfeYppuPcWSyArZbsPJfN6AWj0RJsPRWTYhVDi74qK0tVXYLB t7DL8SnPdQssZ7gO7ZnQ8DVRq+xLTfTAa1542pvH7j4XEhH6VT4So54TmGxp3colEEWJ OELw== X-Gm-Message-State: AOAM530jTpwcfehi+G9/o3U7YqLYdycxFeogzDf3CUPqBzjFXcSLS6Ns M+wtdxjeKNCsLwXtUQNxKC0uPzLIde5Dp3NR4OU= X-Google-Smtp-Source: ABdhPJwC3+M1gZdHQE8d+8eHKjmPAbU+uDiLaLogUD9glG0Pr9p36IsdOgARl0RAvCQThlaebaEZE/42WPPBjczCl84= X-Received: by 2002:aca:1a18:: with SMTP id a24mr4019022oia.150.1621355267830; Tue, 18 May 2021 09:27:47 -0700 (PDT) MIME-Version: 1.0 References: <87mtssc8mb.fsf@gnus.org> In-Reply-To: <87mtssc8mb.fsf@gnus.org> From: Philipp Stephani Date: Tue, 18 May 2021 18:27:36 +0200 Message-ID: Subject: Re: bug#48489: 28.0.50; Incorrect Edebug instrumentation for old `when-let' form To: Lars Ingebrigtsen Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 48489 Cc: Glenn Morris , 48489@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Am Di., 18. Mai 2021 um 18:25 Uhr schrieb Lars Ingebrigtsen : > > Philipp Stephani writes: > > > Hmm, I can't reproduce this on Debian. But I don't see how this could > > be OS-dependent. > > It reproduces fine here on Debian/bullseye, at least: > > 1 unexpected results: > FAILED edebug-tests-duplicate-symbol-backtrack > Yeah, I can also reproduce it now. Not sure what changed in the meantime on my system. From debbugs-submit-bounces@debbugs.gnu.org Tue May 18 12:34:55 2021 Received: (at 48489) by debbugs.gnu.org; 18 May 2021 16:34:55 +0000 Received: from localhost ([127.0.0.1]:57118 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lj2gI-0004vD-Pm for submit@debbugs.gnu.org; Tue, 18 May 2021 12:34:55 -0400 Received: from mail-ot1-f53.google.com ([209.85.210.53]:35661) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lj2gG-0004ur-Cj for 48489@debbugs.gnu.org; Tue, 18 May 2021 12:34:53 -0400 Received: by mail-ot1-f53.google.com with SMTP id 69-20020a9d0a4b0000b02902ed42f141e1so9176613otg.2 for <48489@debbugs.gnu.org>; Tue, 18 May 2021 09:34:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DfBKtJNPG5gJSS12zfmd8Rqx8dA9my3Pk8Yxc+8tEko=; b=O5YlExVI6GgMU2d37o9gVhru01fsfehj6AD4PdJPxBnadGvcX0g9qczzyOSJxiLSHV JOV5Vtt858hihcSTdNwgPochb5DlE/iiTM464bhgDFz2+H2c5n2fvF7yUZstrdyI3Vtd m85IfMSBWEbzHDH/6nIu24EPBPVv0x3tOF9BfnLxVfUuKJr092+MUdInE9tdwOTJGAj7 SUHYfGxUadJX1Zah9Dsr8cEOtyvy6j2xkVjbX7iMHJu4qq7vY+C8NS9/CkmjRTCQ6snQ H667r4XRiJ9SFrUCSuO6+rwGfUDlizYroIsQt/XOp+/5fPb44wf4sCkr8BnrTy2+nqO3 V+3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DfBKtJNPG5gJSS12zfmd8Rqx8dA9my3Pk8Yxc+8tEko=; b=XnTn5BEsSi2QJH7/9AMJ73Lyt0vv2tG9p9qpElAEig7B+0pk6RdtmoXXnP3BNcDqXT LFr8tGmwEeBtASzAFkyCN6mBAnOY6koHNKdlhwwFdIZLAPieJms6roZxw/KtEDaBaDms TcHzvkv57GKkSOV3Eb1DEIVcKOyElETC3iV+ayX2mkMxwwHDor1UxkMhLJ6SIhyPAOtT o3j5U0dVYsYLl5COUIQ8XwLwwRe38o47HIocnlJ7k5tyJrNSFRvwF5GuT8c9SnoGxHEV lvN+cHhpZ0wuJd69dpEE29loaEsBh+kYBiEPWoTfeR+yuCueUrE8V6JTUQXPseWwfHN5 GoFQ== X-Gm-Message-State: AOAM5333yc7cogo66tgz7adrO0AhuiFFT6Dj1qzIWfD0L2sSyfshYHUt fRf2xBVD3JWkmO2K25EED/cA4ZaHMw2vmoWlf1GFpzDql/ho7A== X-Google-Smtp-Source: ABdhPJzGeDh9yJTDr9RhbCmKRNvBavApf/tme9ubpZu5lDXydQMQD7UMoh0iNfgHo3h89CN7fDfUiwhWN0P99ONikQ0= X-Received: by 2002:a05:6830:2248:: with SMTP id t8mr4948289otd.156.1621355686739; Tue, 18 May 2021 09:34:46 -0700 (PDT) MIME-Version: 1.0 References: <87mtssc8mb.fsf@gnus.org> In-Reply-To: From: Philipp Stephani Date: Tue, 18 May 2021 18:34:35 +0200 Message-ID: Subject: Re: bug#48489: 28.0.50; Incorrect Edebug instrumentation for old `when-let' form To: Lars Ingebrigtsen Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 48489 Cc: Glenn Morris , 48489@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Am Di., 18. Mai 2021 um 18:27 Uhr schrieb Philipp Stephani : > > Am Di., 18. Mai 2021 um 18:25 Uhr schrieb Lars Ingebrigtsen : > > > > Philipp Stephani writes: > > > > > Hmm, I can't reproduce this on Debian. But I don't see how this could > > > be OS-dependent. > > > > It reproduces fine here on Debian/bullseye, at least: > > > > 1 unexpected results: > > FAILED edebug-tests-duplicate-symbol-backtrack > > > > Yeah, I can also reproduce it now. Not sure what changed in the > meantime on my system. Ah. See the FIXME in the test: ;; FIXME: There are twice as many inner ;; definitions as expected due to Bug#42701. ;; Once that bug is fixed, remove the duplicates. Bug#42701 still isn't fixed, but the fix to bug#48489 has "suppressed" its symptom in this case. We can therefore resolve this FIXME. However, then the edebug-tests-duplicate-symbol-backtrack doesn't really test any more what it should be testing. So I'll see that I can change it to restore the previous behavior (which requires backtracking and overlapping &or branches). From debbugs-submit-bounces@debbugs.gnu.org Tue May 18 12:50:17 2021 Received: (at 48489) by debbugs.gnu.org; 18 May 2021 16:50:17 +0000 Received: from localhost ([127.0.0.1]:57159 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lj2vB-0007WA-K4 for submit@debbugs.gnu.org; Tue, 18 May 2021 12:50:17 -0400 Received: from mail-oi1-f174.google.com ([209.85.167.174]:46837) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lj2v9-0007Vo-O4 for 48489@debbugs.gnu.org; Tue, 18 May 2021 12:50:16 -0400 Received: by mail-oi1-f174.google.com with SMTP id x15so10348977oic.13 for <48489@debbugs.gnu.org>; Tue, 18 May 2021 09:50:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=c09D7NgF2YvplqTanFykSbhs7VOh4jqIKmtl9acfMCU=; b=i7Z+LFnMyoWgIF1JYgZbrN5R3gcTCbrRjrXVZgzilB4+YDBX/xZzXA3J/Pbe//RCxY qyzvE9FkX+rvcTgSpGSeHiZVoG142/uEWuJC0AqiBxHdKrcxvlOFVUcDxkINGokhJ/gT dEFl6Ha2gm0HaD1ztQyPAYFMJM6ua5JUN1iQyA8BEhroiXHnQ36xC1UqgGeaI5HmdYfX BteKj0GDyjTg4DM4GBtSZw9eZ8T4AntL2Eqi/1vALevxzJOfpXf3ABaif3iWleNmbwqL a37ISu35Wxbd2bk/sOy/VutCDdtnPVk7SGQVVrwGZ6ObuNE9CwhS3RjVHUOITEGdJQeJ aOIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=c09D7NgF2YvplqTanFykSbhs7VOh4jqIKmtl9acfMCU=; b=aOmEo3gbSmksc61NZHxqqfPsl0FVS5v5NbG50KD/4u2a/xD5PQx68FPweyCMMHig5a 0muXtnMZeOoywMYy6XQhMQGh7E+7aqQZL3UymdG5BB760fTDKWkVXsrPIOXUd8bjg5ZG a44ITdoLx946G0gwHF5QzPpOBfSKqMvVJ/QgQi9OPZ0eZp0j6UrIUB/zXiz0J7YMNE5V 6tJZ8ZrTNa5nBHPneZr9U000XOLYrfa3h66bSCcXpxYzbGHnibDqQNceTZdfqpYoT8CW z2n8JjRJMFH00BT1gh+DZwpgQRwX8F5Upk50rehbUHUn8+iLRwHVM3day3uP/ZKhV764 cZxQ== X-Gm-Message-State: AOAM531zaLwWhLxEUTh8iAvCgOj8+++ZiF8GuhfboA1DqFjyxYTMH5dy TW2mLrzH9uakc/tM4vrVMmd34RVfC08t3N7dPLs= X-Google-Smtp-Source: ABdhPJzupyKn1NhcU4vwAPvwNUxWVzN3cvA0cxaqt7SP+T8Bp6V+yL8Wt7I4SX3rOtVT9Y4sVNIwvvfKf0CLrcWI5lE= X-Received: by 2002:aca:1a18:: with SMTP id a24mr4088010oia.150.1621356610097; Tue, 18 May 2021 09:50:10 -0700 (PDT) MIME-Version: 1.0 References: <87mtssc8mb.fsf@gnus.org> In-Reply-To: From: Philipp Stephani Date: Tue, 18 May 2021 18:49:59 +0200 Message-ID: Subject: Re: bug#48489: 28.0.50; Incorrect Edebug instrumentation for old `when-let' form To: Lars Ingebrigtsen Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 48489 Cc: Glenn Morris , 48489@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Am Di., 18. Mai 2021 um 18:34 Uhr schrieb Philipp Stephani : > > Am Di., 18. Mai 2021 um 18:27 Uhr schrieb Philipp Stephani > : > > > > Am Di., 18. Mai 2021 um 18:25 Uhr schrieb Lars Ingebrigtsen : > > > > > > Philipp Stephani writes: > > > > > > > Hmm, I can't reproduce this on Debian. But I don't see how this could > > > > be OS-dependent. > > > > > > It reproduces fine here on Debian/bullseye, at least: > > > > > > 1 unexpected results: > > > FAILED edebug-tests-duplicate-symbol-backtrack > > > > > > > Yeah, I can also reproduce it now. Not sure what changed in the > > meantime on my system. > > Ah. See the FIXME in the test: > > ;; FIXME: There are twice as many inner > ;; definitions as expected due to Bug#42701. > ;; Once that bug is fixed, remove the duplicates. > > Bug#42701 still isn't fixed, but the fix to bug#48489 has "suppressed" > its symptom in this case. We can therefore resolve this FIXME. > However, then the edebug-tests-duplicate-symbol-backtrack doesn't > really test any more what it should be testing. So I'll see that I can > change it to restore the previous behavior (which requires > backtracking and overlapping &or branches). Done with commit 63e4ed1c8f1c5bbf59c366134d379bae972201f9. From unknown Fri Jun 13 13:25:30 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 16 Jun 2021 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator