GNU bug report logs - #48483
[PATCH 0/1] Fix broken emacs-libyaml

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Leo Prikler <leo.prikler <at> student.tugraz.at>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#48483: closed ([PATCH 0/1] Fix broken emacs-libyaml)
Date: Mon, 17 May 2021 18:03:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 17 May 2021 20:02:11 +0200
with message-id <e3d31c42dacd8e627a4affba65a3a6a843a9ee91.camel <at> student.tugraz.at>
and subject line Re: [PATCH 1/1] gnu: emacs-libyaml: fix broken phase.
has caused the debbugs.gnu.org bug report #48483,
regarding [PATCH 0/1] Fix broken emacs-libyaml
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
48483: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=48483
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Fredrik Salomonsson <plattfot <at> posteo.net>
To: guix-patches <at> gnu.org
Cc: Fredrik Salomonsson <plattfot <at> posteo.net>
Subject: [PATCH 0/1] Fix broken emacs-libyaml
Date: Mon, 17 May 2021 17:29:14 +0000

Hi,

Getting:

File is missing: Cannot open load file, No such file or directory, libyaml-core

After a guix pull and launching emacs.

I tracked it down to the phase that fixes the load path of emacs-libyaml
(substitute-libyaml-core-path) was not being run during the build. Seems that
the phase it was using in the add-before procedure has been removed/renamed
and therefore substitute-libyaml-core-path phase didn't run.

I changed it to add the phase substitute-libyaml-core-path after the unpack
phase and that fixes the issue.


Fredrik Salomonsson (1):
  gnu: emacs-libyaml: fix broken phase.

 gnu/packages/emacs-xyz.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


base-commit: 0d85c83602c58cf83117643571e56205cfaeadc9
-- 
2.31.1

[Message part 3 (message/rfc822, inline)]

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Fredrik Salomonsson <plattfot <at> posteo.net>, 48483-done <at> debbugs.gnu.org
Subject: Re: [PATCH 1/1] gnu: emacs-libyaml: fix broken phase.
Date: Mon, 17 May 2021 20:02:11 +0200

Pushed with the adjustments listed below:

Am Montag, den 17.05.2021, 17:36 +0000 schrieb Fredrik Salomonsson:
> * gnu/packages/emacs-xyz.scm (emacs-libyaml): Change
> substitute-libyaml-core-path phase to be added after the unpack
> phase. As the
> add-source-to-load-path phase which it was added to before seems to
> been
> removed, which resulted in the phase not being run.
I've rewritten the header so as to not contain "fix" (there has been
recent discussion to avoid said word unless necessary), and simplified
this line as well.
> ---
>  gnu/packages/emacs-xyz.scm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 7a62b6b7ef..6f67083d01 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -22533,7 +22533,7 @@ utilities.")
>  (define-public emacs-libyaml
>    ;; Upstream made no release so far.
>    (let ((version "0")
> -        (revision "1")
> +        (revision "2")
>          (commit "703e0d448c7ee24e25b513a3c65980c80e166805"))
>      (package
>        (name "emacs-libyaml")
You don't need to change the revision if the source has not changed.

Regards,
Leo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.