From debbugs-submit-bounces@debbugs.gnu.org Sun May 16 16:06:07 2021 Received: (at submit) by debbugs.gnu.org; 16 May 2021 20:06:07 +0000 Received: from localhost ([127.0.0.1]:51547 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1liN1X-0007Vd-8p for submit@debbugs.gnu.org; Sun, 16 May 2021 16:06:07 -0400 Received: from lists.gnu.org ([209.51.188.17]:51074) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1liN1V-0007Ut-B3 for submit@debbugs.gnu.org; Sun, 16 May 2021 16:06:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46272) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liN1V-0001pk-51 for bug-gnu-emacs@gnu.org; Sun, 16 May 2021 16:06:01 -0400 Received: from mail-qk1-x733.google.com ([2607:f8b0:4864:20::733]:39920) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1liN1S-0004Xb-Gu for bug-gnu-emacs@gnu.org; Sun, 16 May 2021 16:06:00 -0400 Received: by mail-qk1-x733.google.com with SMTP id k127so3924106qkc.6 for ; Sun, 16 May 2021 13:05:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:user-agent:from:to:subject:message-id:date:mime-version; bh=B/fdUDLHDLEsFegA0N1YKSoK1UCzj7jBpf5Ggx2OJAw=; b=nQLdVCt6srgAAGHrct/w2VUazuE3a9qhptUYHMoIO8YK08MU5DgK331pJcYHfSHYIG VIVCQExEBpyYUtQeq+lJkXFsbnxZcGtu2ls2xZZnfyfTTDkg680c+jhnFf72dppaMP2k DxLudawk4wM1c74yvlf7z/KwJeyw9QoCxLA59pkb7QwsySItEymmIHDEYICIzsgeos26 v3/r9Upqg/AfUzRgCdcwModcyTkpak2EObg5B6oYC4zycGn473PCKUpMnK+RU3Hg13DE F8V5uCpMRjBWIVpuimGmaFSgzOwp2oeUvDOuRApCN2g9U2q/bOzFo7iuIVpGKj/BTzCs O7GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:user-agent:from:to:subject:message-id :date:mime-version; bh=B/fdUDLHDLEsFegA0N1YKSoK1UCzj7jBpf5Ggx2OJAw=; b=p1eKBUwUK1/qDNnAVkZKRfr3iD24HEClRBSGeZrhZ/MYB2ugswzFFhRiw8TFL1bYX4 iaiXJWuXlE0v8Oqh7haC72pBgs3OfaQeSAZ2XLRsZFmBzQdQNfdUQoOSXHA0M0jljD3f F+TKxbl81vPsIaqx8ezIZigG43iqEghD/f9dgRJEHA7FfVuHveskiA4PCGWWr4+5+R8h cUo8AntLMNXsFYporEzrA6MsTl3Pu9oqvoBA/MdAXBhcYxZq7XkjOFv/qglepm/meAxc pZ9x5WnZpIOvGbvLQAH2VUIaRNu5W6edfBcuKt9VA0R/tQvc3KP4dHWLJz3L1WENL7r8 g6qg== X-Gm-Message-State: AOAM530KCKjL3vKjiUSEZFf3NZaiU+r+2pz4vkApWoEFF4J+wLErNs85 WwEOTQ146XTyvnKzfXZC0EqyrvAkJc8= X-Google-Smtp-Source: ABdhPJzCqPjLU4bdftZ4T4EWj6Av4d3KuQyQmyqLotE894JAfMKLhsBFjtXLYwGR9Yra7K+lyO9Ebw== X-Received: by 2002:a05:620a:2283:: with SMTP id o3mr54238868qkh.157.1621195556549; Sun, 16 May 2021 13:05:56 -0700 (PDT) Received: from gusbrs-laptop ([143.244.34.133]) by smtp.gmail.com with ESMTPSA id n19sm8709133qtp.65.2021.05.16.13.05.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 May 2021 13:05:55 -0700 (PDT) User-agent: mu4e 1.4.15; emacs 27.2 From: Gustavo Barros To: bug-gnu-emacs@gnu.org Subject: [FR] A small suggestion for repeat-mode Message-ID: <87bl9atpen.fsf@gmail.com> Date: Sun, 16 May 2021 17:05:52 -0300 MIME-Version: 1.0 Content-Type: text/plain; format=flowed Received-SPF: pass client-ip=2607:f8b0:4864:20::733; envelope-from=gusbrs.2016@gmail.com; helo=mail-qk1-x733.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) Hi All, I've just taken notice of the recently introduced `repeat-mode', in `repeat.el', and welcome it. I haven't yet tried it out, since I'm running on 27.2, but I understand what it does, and how. I'll definitely use it when Emacs 28 comes, since I have some commands for which I use current `repeat.el' functionality to do something equivalent in my setup, and the new mode makes this much more convenient, so thank you (Juri) for adding it. But I write to give one small suggestion to the mode. Namely that an option be added to make the transient keymap expire after a (configurable) timeout. The idea is that the repeating last key press is very handy indeed, but if you happen to stop at a repeatable key, stop some "idle" time (thinking, reading, whatever) and then hit the key again, it might not be what was actually meant. In other words, besides `repeat-exit-key', some idle time after the last repeatable key may serve as a good indicator for breaking the repetition chain. As far as I can see, this should not be particularly complicated, since `set-transient-map' returns an "exit function" which could be stored and ran on a timer, as appropriate. And, of course, it can be optional. Thanks again for the useful addition. I'm looking forward to using it already. Best regards, Gustavo. From debbugs-submit-bounces@debbugs.gnu.org Mon May 17 18:30:19 2021 Received: (at 48472) by debbugs.gnu.org; 17 May 2021 22:30:19 +0000 Received: from localhost ([127.0.0.1]:53988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lilkh-0003n2-7o for submit@debbugs.gnu.org; Mon, 17 May 2021 18:30:19 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:57063) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lilkZ-0003lF-0C for 48472@debbugs.gnu.org; Mon, 17 May 2021 18:30:11 -0400 Received: (Authenticated sender: juri@linkov.net) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id D8A861C0004; Mon, 17 May 2021 22:30:04 +0000 (UTC) From: Juri Linkov To: Gustavo Barros Subject: Re: bug#48472: [FR] A small suggestion for repeat-mode Organization: LINKOV.NET References: <87bl9atpen.fsf@gmail.com> Date: Tue, 18 May 2021 00:24:23 +0300 In-Reply-To: <87bl9atpen.fsf@gmail.com> (Gustavo Barros's message of "Sun, 16 May 2021 17:05:52 -0300") Message-ID: <871ra5xalk.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 48472 Cc: 48472@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > I've just taken notice of the recently introduced `repeat-mode', in > `repeat.el', and welcome it. > > I haven't yet tried it out, since I'm running on 27.2, but I understand > what it does, and how. I'll definitely use it when Emacs 28 comes, since > I have some commands for which I use current `repeat.el' functionality to > do something equivalent in my setup, and the new mode makes this much more > convenient, so thank you (Juri) for adding it. > > But I write to give one small suggestion to the mode. Namely that an > option be added to make the transient keymap expire after a (configurable) > timeout. The idea is that the repeating last key press is very handy > indeed, but if you happen to stop at a repeatable key, stop some "idle" > time (thinking, reading, whatever) and then hit the key again, it might not > be what was actually meant. In other words, besides `repeat-exit-key', > some idle time after the last repeatable key may serve as a good indicator > for breaking the repetition chain. Thanks for the suggestion, this is a very good idea. > As far as I can see, this should not be particularly complicated, since > `set-transient-map' returns an "exit function" which could be stored and > ran on a timer, as appropriate. An "exit function" returned by `set-transient-map' is a clever thing, without such returned function it would be more complicated to implement. I quickly tried it out, and it works indeed. > And, of course, it can be optional. A new user option could be named `repeat-exit-timeout'. From debbugs-submit-bounces@debbugs.gnu.org Tue May 18 07:14:20 2021 Received: (at 48472) by debbugs.gnu.org; 18 May 2021 11:14:20 +0000 Received: from localhost ([127.0.0.1]:54561 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lixg4-0008FL-D3 for submit@debbugs.gnu.org; Tue, 18 May 2021 07:14:20 -0400 Received: from mail-qt1-f174.google.com ([209.85.160.174]:41499) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lixg2-0008F8-CR for 48472@debbugs.gnu.org; Tue, 18 May 2021 07:14:18 -0400 Received: by mail-qt1-f174.google.com with SMTP id t20so7089081qtx.8 for <48472@debbugs.gnu.org>; Tue, 18 May 2021 04:14:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:references:user-agent:from:to:cc:subject:in-reply-to :message-id:date:mime-version; bh=YhzUXUN7wE5YVPtzq7JguQwDCl4b6XEXAmjy9gKCB3k=; b=YkHBKKIgACTwi0Edv3SipZLS64/DJp8N43EIHt2sVWT3VKozkoRX3dbMbK7cSNSRS1 bbFPUZUT0FwWdp7hxOQdq5UaHQ/tN+84zKBlLs3iB/S+tLNJTyQDaeGo2WUPtnzMP2/O xe62nE3ZdH6iB/9oZDLALeBCet2G6st5Ji1DNczSCilGyS1pyD43FgI2z8Vzy44sD7pV v+jtqkXIrTgmmuwoZo2FuaB1Cjj04DbY99QBCqknmCegcY1FHi+nRgzHFWvXF0eXWcqU vKKWWumxWm4079AkL4e7DgTGXYlCQblf+5hLn905x1vaMZzm7ClFVai2EG8OTw4OJIMQ 1IeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:references:user-agent:from:to:cc:subject :in-reply-to:message-id:date:mime-version; bh=YhzUXUN7wE5YVPtzq7JguQwDCl4b6XEXAmjy9gKCB3k=; b=DO5oFBO6++FFKGloZy0eUcX/yvwnvSgw1R1a+XVneMwrRtuuCM469a3AWd/IMTd/Pa E4wZhvBX3BG6f9WxFVZ4mrVpQiRRf8x2NQwWlxoE9L+yWOI1vptimWCTxvVQTSdn2RlJ 3co6eKeY/MZE0dGA6MyKOlU1PAUeNKqfTmGWw/QWUN5vwDUwmNkxj9D0Zpu06u9YUKdk B5ivK5yKb+eErCJbbwqmLJc3qnsH10PltXtQR1//vfCWYLTHZDClIWYtseMiigt6Skrm 7y2KzRyGdGt/pFmJCnRjVa/eCbThevP8KvxEYLroDFmJWC+CmvjYGsuP4z6XkPNkhQA9 XBzQ== X-Gm-Message-State: AOAM5333AAGxG9iDgXhmg62edYI/qCd73h1OQJSg09ZE+v+srzUmzEIq HX8JUgt/PhtMBdNFTBqwBAsKhrw6UCJJrw== X-Google-Smtp-Source: ABdhPJwO+vLlpvI2N8BqbLG2Hhg5ph0iZxR+MhHwMp1cbpFkzcU7MKjxIV4ILcWwyfwlDpUyMPr1tw== X-Received: by 2002:ac8:7ed2:: with SMTP id x18mr4145170qtj.26.1621336452302; Tue, 18 May 2021 04:14:12 -0700 (PDT) Received: from gusbrs-laptop ([143.244.35.87]) by smtp.gmail.com with ESMTPSA id m7sm12317415qki.67.2021.05.18.04.14.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 May 2021 04:14:11 -0700 (PDT) References: <87bl9atpen.fsf@gmail.com> <871ra5xalk.fsf@mail.linkov.net> User-agent: mu4e 1.4.15; emacs 27.2 From: Gustavo Barros To: Juri Linkov Subject: Re: bug#48472: [FR] A small suggestion for repeat-mode In-reply-to: <871ra5xalk.fsf@mail.linkov.net> Message-ID: <87o8d847ls.fsf@gmail.com> Date: Tue, 18 May 2021 08:14:08 -0300 MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 48472 Cc: 48472@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hi Juri, On Mon, 17 May 2021 at 18:24, Juri Linkov wrote: >> But I write to give one small suggestion to the mode. Namely that an >> option be added to make the transient keymap expire after a >> (configurable) >> timeout. The idea is that the repeating last key press is very handy >> indeed, but if you happen to stop at a repeatable key, stop some >> "idle" >> time (thinking, reading, whatever) and then hit the key again, it >> might not >> be what was actually meant. In other words, besides >> `repeat-exit-key', >> some idle time after the last repeatable key may serve as a good >> indicator >> for breaking the repetition chain. > > Thanks for the suggestion, this is a very good idea. > I'm glad you liked it. And thanks for answering. > > An "exit function" returned by `set-transient-map' is a clever thing, > without such returned function it would be more complicated to > implement. > I quickly tried it out, and it works indeed. > We have to thank whoever put it there. And it seems to be there out of design and foresight. As far as my grepping went (not that thorough), I didn't find an instance of usage of this return value in Emacs' code base as of yet. > > A new user option could be named `repeat-exit-timeout'. > Sounds good to me. And, I'm not sure I should be reading between the lines of your answer, but I could not avoid it, so I'll be forthcoming. I've gone as far as I'm allowed to. I'd be happy to offer a patch, but no papers... Best, Gustavo. From debbugs-submit-bounces@debbugs.gnu.org Tue May 18 17:05:57 2021 Received: (at 48472) by debbugs.gnu.org; 18 May 2021 21:05:58 +0000 Received: from localhost ([127.0.0.1]:57459 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lj6ub-0003TY-J5 for submit@debbugs.gnu.org; Tue, 18 May 2021 17:05:57 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:35141) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lj6uZ-0003TH-KT; Tue, 18 May 2021 17:05:56 -0400 Received: (Authenticated sender: juri@linkov.net) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id D8FBBC0008; Tue, 18 May 2021 21:05:47 +0000 (UTC) From: Juri Linkov To: Gustavo Barros Subject: Re: bug#48472: [FR] A small suggestion for repeat-mode Organization: LINKOV.NET References: <87bl9atpen.fsf@gmail.com> <871ra5xalk.fsf@mail.linkov.net> <87o8d847ls.fsf@gmail.com> Date: Wed, 19 May 2021 00:04:38 +0300 In-Reply-To: <87o8d847ls.fsf@gmail.com> (Gustavo Barros's message of "Tue, 18 May 2021 08:14:08 -0300") Message-ID: <87a6orwy6x.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 48472 Cc: 48472@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) tags 48472 fixed close 48472 28.0.50 thanks Hi Gustavo, >> An "exit function" returned by `set-transient-map' is a clever thing, >> without such returned function it would be more complicated to implement. >> I quickly tried it out, and it works indeed. > > We have to thank whoever put it there. And it seems to be there out of > design and foresight. As far as my grepping went (not that thorough), > I didn't find an instance of usage of this return value in Emacs' code base > as of yet. It's amazing that the function returns exactly what we need even though its return value is not yet used anywhere. So I copied the same design to another similar function display-buffer-override-next-command to return exitfun as well. >> A new user option could be named `repeat-exit-timeout'. >> > > Sounds good to me. And, I'm not sure I should be reading between the lines > of your answer, but I could not avoid it, so I'll be forthcoming. I've gone > as far as I'm allowed to. I'd be happy to offer a patch, but no papers... You are welcome to sign papers, so the next time you could offer a patch. Now I pushed the implementation based on your suggestion, thanks for it! (The implementation also includes a lot of small details like correctly handling the messages, etc.) If you are running on 27.2, you could still take the second part of repeat.el from Emacs 28. From debbugs-submit-bounces@debbugs.gnu.org Tue May 18 18:09:49 2021 Received: (at 48472) by debbugs.gnu.org; 18 May 2021 22:09:49 +0000 Received: from localhost ([127.0.0.1]:57520 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lj7uP-00079I-Fw for submit@debbugs.gnu.org; Tue, 18 May 2021 18:09:49 -0400 Received: from mail-qv1-f49.google.com ([209.85.219.49]:37401) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lj7uN-000794-GD for 48472@debbugs.gnu.org; Tue, 18 May 2021 18:09:48 -0400 Received: by mail-qv1-f49.google.com with SMTP id z1so5807958qvo.4 for <48472@debbugs.gnu.org>; Tue, 18 May 2021 15:09:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:references:user-agent:from:to:cc:subject:in-reply-to :message-id:date:mime-version; bh=A9nrSN7Ho3xTo8vyIG+O2ttT9AYJJ8PDR8OdZ+6JT+Q=; b=QU1cLUeAwKSk6zBHN8hLbnRtJhWCQT/MtC3aQMBx3eaPuXAZemBCuPIQC4Djx1/Cbu IP/P5YRMhXZKqXOg9U/ClNQF7Ax4LLTecIalqm25jDypANyArCvsdsd+X0w1mohtSyqO HiQajJK11aZqAVOGSUvwGEV+p/W5DLaPx+QrONwvnsQp06vwRUYWASsAEoiK74N6FlT8 5SYMay7FF3FY3Hl5bMjDJwQbz/ofZqp7O77dReW6YBiBl23/MAQh/tYOKHAKOg2m0gjS G8KqMyPiK3cOmIZGMC0vxiT9wwVmynGFKX41vK/uBQtLZKtE4shrh7OZqxtUOxatFA/3 bMIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:references:user-agent:from:to:cc:subject :in-reply-to:message-id:date:mime-version; bh=A9nrSN7Ho3xTo8vyIG+O2ttT9AYJJ8PDR8OdZ+6JT+Q=; b=slXK9xJwX1g9nWSvuuVBGAYy8r7o+Z2ygbIGwy9wPhUEEe5hxAtpYll3YGKWVY/z/G Tl3Lse2HOilGy2BxS3dznty3CRFSHkSCQzdYP1szNy05E8Ti5tn42+Ua9W0NSq8YAzPq E/VnuI69KoJ9pKZGTRcZWgJDQgrj0BqxaLQXqJkHQUO1FBlLcXTEqsaoq2pAapOslVnl /pd1jCDQKASsxeluT7TRvFkeO0e1groA5k7ZOvb9u4zME81mwpxtDEFUyKBrETR1qq+n OxBzUqy7wpaCYj4H3Qeiv7Gi3mIjLJjpg10OE3qg2KjgksPWNV/DwY7T2XDgzIkuUlX/ edkA== X-Gm-Message-State: AOAM531r3/5sSAU1TLbSimXRuLH/aAUSb9TxbyTfo1h9+GmKatcfvUWH 5Y2t1Mthqr9ZrwYvIHXbF2frzWRfAIo= X-Google-Smtp-Source: ABdhPJyOM5XJGZFXxEykIp9hOcD0jMHE8T8SsuC5BxeXpKhCVzxdCGq+aGSbhPW48WBC8t5RvGdA1g== X-Received: by 2002:ad4:5ca2:: with SMTP id q2mr8511521qvh.49.1621375781608; Tue, 18 May 2021 15:09:41 -0700 (PDT) Received: from gusbrs-laptop ([143.244.35.87]) by smtp.gmail.com with ESMTPSA id d28sm13478651qkl.105.2021.05.18.15.09.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 May 2021 15:09:40 -0700 (PDT) References: <87bl9atpen.fsf@gmail.com> <871ra5xalk.fsf@mail.linkov.net> <87o8d847ls.fsf@gmail.com> <87a6orwy6x.fsf@mail.linkov.net> User-agent: mu4e 1.4.15; emacs 27.2 From: Gustavo Barros To: Juri Linkov Subject: Re: bug#48472: [FR] A small suggestion for repeat-mode In-reply-to: <87a6orwy6x.fsf@mail.linkov.net> Message-ID: <87h7izn17i.fsf@gmail.com> Date: Tue, 18 May 2021 19:09:37 -0300 MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 48472 Cc: 48472@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Hi Juri, On Tue, 18 May 2021 at 18:04, Juri Linkov wrote: > It's amazing that the function returns exactly what we need > even though its return value is not yet used anywhere. > So I copied the same design to another similar function > display-buffer-override-next-command to return exitfun as well. Indeed it is pretty cool, nice that it has fulfilled its purpose and even "reproduced". > You are welcome to sign papers, so the next time you could offer a > patch. Well, I'd love to, and have tried to, but it turns out I can't sign them. > Now I pushed the implementation based on your suggestion, thanks for > it! > > (The implementation also includes a lot of small details like > correctly > handling the messages, etc.) I thank you! And I had assumed the timer would have to be stored and canceled at every repeat, and also that somehow the message would have to be cleared when the exit function timer ran. I see you handled all that. Looks good to me. > If you are running on 27.2, you could still take the second part > of repeat.el from Emacs 28. I might! :-) But if you push me to you it, you run the risk of getting yet other "small suggestions". Thanks again! Gustavo. From unknown Sat Jun 14 19:07:19 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 16 Jun 2021 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator