GNU bug report logs - #48463
gnu: Add j.

Previous Next

Full log

View this message in rfc822 format

From: elaexuotee <at> wilsonb.com
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: Liliana Marie Prikler <liliana.prikler <at> gmail.com>, 48463 <at> debbugs.gnu.org
Subject: [bug#48463] gnu: Add j.
Date: Wed, 12 Jan 2022 21:07:45 +0900

[Message part 1 (text/plain, inline)]

> > +    `(#:tests? #f
> >          [...]
> > +        (replace 'check
> > +          (lambda* (#:key tests? #:allow-other-keys)
> > +            (when tests? [...]))))
> 
> I think #:tests? #false should be removed, otherwise this
> check phase would never do anything.

Nice catch! Thanks. Disabled tests when tweaking builds and forgot to remove.

> > +                ;; The jlibrary/dev directory only sometimes exists,
> > but needs
> > +                ;; to be copied into the ~system directory when it
> > does.
> > +                (for-each
> > +                  (lambda (dev-dir)
> > +                    (if (access? dev-dir R_OK)
> > +                      (copy-recursively dev-dir
> > "test/bin/system/dev")))
> 
> 
> Are you testing for file permissions, or for the existence of the file?
> If the latter, I'd recommend using 'file-exists?' instead.
> 
> > +                  (if (access? source-dev R_OK)

Just existence. Thanks for the pointer. Changed.

[0001-gnu-Add-j.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.