From unknown Sun Jun 15 10:54:17 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#48443 <48443@debbugs.gnu.org> To: bug#48443 <48443@debbugs.gnu.org> Subject: Status: [PATCH 0/2] Add libkpathsea. Reply-To: bug#48443 <48443@debbugs.gnu.org> Date: Sun, 15 Jun 2025 17:54:17 +0000 retitle 48443 [PATCH 0/2] Add libkpathsea. reassign 48443 guix-patches submitter 48443 Leo Prikler severity 48443 normal tag 48443 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sat May 15 10:40:02 2021 Received: (at submit) by debbugs.gnu.org; 15 May 2021 14:40:02 +0000 Received: from localhost ([127.0.0.1]:49045 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhvSU-0002Uh-Gy for submit@debbugs.gnu.org; Sat, 15 May 2021 10:40:02 -0400 Received: from lists.gnu.org ([209.51.188.17]:56258) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhvSS-0002UF-Tf for submit@debbugs.gnu.org; Sat, 15 May 2021 10:40:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50140) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhvSL-0003UX-Sk for guix-patches@gnu.org; Sat, 15 May 2021 10:39:53 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:20061) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhvSI-000317-Jc for guix-patches@gnu.org; Sat, 15 May 2021 10:39:53 -0400 Received: from nijino.local (91-114-247-246.adsl.highway.telekom.at [91.114.247.246]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4Fj7Mh0r9Jz1DH8w for ; Sat, 15 May 2021 16:39:43 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4Fj7Mh0r9Jz1DH8w DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1621089584; bh=WgriEvxhHNKQAunRlxL1+eEM4lb0NiU6QrxdnaFh894=; h=Subject:From:To:Date:From; b=HARv1uTYC4sbJJLP2AFDvI4AJALyvRiwEXS0h8K+SxR0fUIUX20ecPwf9kDipUHva j9ykar0vfiJgdHQggdt2mdhXLGzaSmis6Obr6PX544Q6t2VhA00ucU+49gwoGDJo57 y+6tNm/FyLs9ndHi1aq4IRRtpltLeheWGxvKlago= Message-ID: Subject: [PATCH 0/2] Add libkpathsea. From: Leo Prikler To: guix-patches@gnu.org Date: Sat, 15 May 2021 16:39:43 +0200 Content-Type: text/plain User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 Received-SPF: pass client-ip=129.27.2.202; envelope-from=leo.prikler@student.tugraz.at; helo=mailrelay.tugraz.at X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Some nice thing for y'all who want to read .dvi files. From debbugs-submit-bounces@debbugs.gnu.org Sat May 15 10:42:58 2021 Received: (at 48443) by debbugs.gnu.org; 15 May 2021 14:42:58 +0000 Received: from localhost ([127.0.0.1]:49052 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhvVJ-0002Z7-Ug for submit@debbugs.gnu.org; Sat, 15 May 2021 10:42:58 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:11551) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhvVH-0002Ys-NU for 48443@debbugs.gnu.org; Sat, 15 May 2021 10:42:56 -0400 Received: from localhost.localdomain (91-114-247-246.adsl.highway.telekom.at [91.114.247.246]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4Fj7RJ2psgz1DH8w for <48443@debbugs.gnu.org>; Sat, 15 May 2021 16:42:52 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4Fj7RJ2psgz1DH8w DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1621089772; bh=u4oV2sSmQuRfHbdaWFLoFGh/UtJSP4sD3QfQM4WvDVQ=; h=From:To:Subject:Date:From; b=BJFoZ+OKClT5RRpRug1S4n9IvViYdqqCBK3OdBIRdNTJGNPTyFGget8IOFrg5ZLD8 PQQF6eNOakQtJUA4usHAWe/F7svEd4Do7xlsrWGQa3oN0TBvvTwC/6patEX0ftXv4D Yx0sIQaBVlG0JblIE1AKr7cGtp72E3mgGGhPoQLM= From: Leo Prikler To: 48443@debbugs.gnu.org Subject: [PATCH 1/2] gnu: Add texlive-libkpathsea. Date: Sat, 15 May 2021 16:42:29 +0200 Message-Id: <20210515144230.22035-1-leo.prikler@student.tugraz.at> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48443 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/tex.scm (texlive-libkpathsea): New variable. --- gnu/packages/tex.scm | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/gnu/packages/tex.scm b/gnu/packages/tex.scm index b9eeb0e792..3e8384eaad 100644 --- a/gnu/packages/tex.scm +++ b/gnu/packages/tex.scm @@ -457,6 +457,38 @@ This package contains the binaries.") (license (license:fsf-free "https://www.tug.org/texlive/copying.html")) (home-page "https://www.tug.org/texlive/"))) +(define-public texlive-libkpathsea + (package/inherit texlive-bin + (name "texlive-libkpathsea") + (source + (origin + (inherit (package-source texlive-bin)) + (snippet + `(begin + ,(origin-snippet (package-source texlive-bin)) + (with-directory-excursion "texk" + (let ((preserved-directories '("." ".." "kpathsea"))) + (for-each + delete-file-recursively + (scandir "." + (lambda (file) + (and (not (member file preserved-directories)) + (eq? 'directory (stat:type (stat file))))))))))))) + (arguments + (substitute-keyword-arguments (package-arguments texlive-bin) + ((#:configure-flags flags) + `(cons* "--disable-all-pkgs" "--enable-kpathsea" + "--enable-shared" ,flags)) + ((#:phases phases) + `(modify-phases ,phases + (delete 'configure-ghostscript-executable) + (delete 'use-code-for-new-poppler) + (delete 'patch-dvisvgm-build-files) + (delete 'disable-failing-test) + (replace 'postint + (lambda* (#:key inputs outputs #:allow-other-keys) + (with-directory-excursion "texk/kpathsea" + (invoke "make" "install")))))))))) (define texlive-docstrip (package -- 2.31.1 From debbugs-submit-bounces@debbugs.gnu.org Sat May 15 10:42:58 2021 Received: (at 48443) by debbugs.gnu.org; 15 May 2021 14:42:58 +0000 Received: from localhost ([127.0.0.1]:49054 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhvVK-0002Z9-67 for submit@debbugs.gnu.org; Sat, 15 May 2021 10:42:58 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:37690) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhvVI-0002Yu-Nr for 48443@debbugs.gnu.org; Sat, 15 May 2021 10:42:57 -0400 Received: from localhost.localdomain (91-114-247-246.adsl.highway.telekom.at [91.114.247.246]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4Fj7RL3kkqz1LWp5 for <48443@debbugs.gnu.org>; Sat, 15 May 2021 16:42:54 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4Fj7RL3kkqz1LWp5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1621089774; bh=uu3p2kIsfPb7lBNVzpCIYnyujyi62O0tWqjxEwPipnM=; h=From:To:Subject:Date:In-Reply-To:References:From; b=oBG9z5UiHEgihDRHn4lCt/VY6i4qvp55Ia+16NMpb68SVFaA3R5ss6IFbJkr8gncg tRAIYO2GEe0jxMPcgm6Pc1/+2sj1EIQCYUpbu/7GC7ljMSzEOIdxQufceoQ1d+MrPk +g/0lNIraUE/uir0HPcZyaLQy/uO8XbQHPaFDhVs= From: Leo Prikler To: 48443@debbugs.gnu.org Subject: [PATCH 2/2] gnu: evince: Build with libkpathsea. Date: Sat, 15 May 2021 16:42:30 +0200 Message-Id: <20210515144230.22035-2-leo.prikler@student.tugraz.at> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210515144230.22035-1-leo.prikler@student.tugraz.at> References: <20210515144230.22035-1-leo.prikler@student.tugraz.at> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48443 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/gnome.scm (evince)[inputs]: Add libkpathsea. --- gnu/packages/gnome.scm | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm index be458c07bb..93f74d8c95 100644 --- a/gnu/packages/gnome.scm +++ b/gnu/packages/gnome.scm @@ -2592,9 +2592,7 @@ forgotten when the session ends.") ("ghostscript" ,ghostscript) ("poppler" ,poppler) ("libtiff" ,libtiff) - ;; TODO: - ;; Build libkpathsea as a shared library for DVI support. - ;; ("libkpathsea" ,texlive-bin) + ("libkpathsea" ,texlive-libkpathsea) ("gnome-desktop" ,gnome-desktop) ("gsettings-desktop-schemas" ,gsettings-desktop-schemas) ("gspell" ,gspell) -- 2.31.1 From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 12 20:33:06 2021 Received: (at 48443) by debbugs.gnu.org; 13 Jul 2021 00:33:06 +0000 Received: from localhost ([127.0.0.1]:39071 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m36ME-0006mh-7J for submit@debbugs.gnu.org; Mon, 12 Jul 2021 20:33:06 -0400 Received: from mx.kolabnow.com ([95.128.36.41]:62586) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m36MB-0006mB-UA for 48443@debbugs.gnu.org; Mon, 12 Jul 2021 20:33:04 -0400 Received: from localhost (unknown [127.0.0.1]) by ext-mx-out001.mykolab.com (Postfix) with ESMTP id 72122A6F; Tue, 13 Jul 2021 02:32:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kolabnow.com; h= content-type:content-type:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:date:subject:subject :from:from:received:received:received; s=dkim20160331; t= 1626136376; x=1627950777; bh=4gqbvRn1WpvsBRz45tFUsK4xOMQe1JS9FPd jMvIT+vE=; b=L6Qzni5nWuFn/Ga2RvB+sQOdjA0wYN32X8suPZAuXzGYimcgaVU NCOQVqd5GpVWTCaiU4gvbdir4HyT5+qvnEVQpgPfcxfSu7s1eplKUrJPhEtqRt6P yYezNu7dgMyKUFGmZadgJHxYuuh178zWxzteydGtU/kUDIwDCiU+ajJ9aUnFBlS+ rSANRFRh3PqzjsjJqLQgO02J0X6DEkFMdkSKhUy80+hxr4S+QbCata7bN/p/g/xr CUNN7kYVqCKvPlS64jPdgDbNi5kUIhRarD1whGfn+plItt2sNvlLTtN9/tfgLauK AaILEhACRvPqmKydSk1ddO+MM0jpDHzGXIlbh4tDjds/m6jEHtll0N6YafgOFItE 7nFZdb1yQ6ffZK17Jzb9NEQdklO+4/bRPlH4gSoBWpZ3+bMyE8LAQ0Zyz1hewBbV 55j0s+y78fo3vGlr/84Yi3GupA9SWY5rP+G2PeZHEnqdbJLw2fd6SfvAH1tFg78W 5OPVMK2MVfByRZyF1j95Z+EccEdGIM9kI4Q4G8NwjoumzSHx9gFMLVJzn19a7B0t hKC+wlYEYFx2h8+pMka71/a6SULWs6E3bK6oytVrPATnsfCboAqV2oj1bYb0QJpY NnoAaPK0CGe4nRScRYNhuneNxcEPYbZhdjidLJfwSim0Pyhk0R1yCHLU= X-Virus-Scanned: amavisd-new at mykolab.com X-Spam-Flag: NO X-Spam-Score: -1.899 X-Spam-Level: X-Spam-Status: No, score=-1.899 tagged_above=-10 required=5 tests=[BAYES_00=-1.9, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out001.mykolab.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iaJhrlfxDERv; Tue, 13 Jul 2021 02:32:56 +0200 (CEST) Received: from int-mx003.mykolab.com (unknown [10.9.13.3]) by ext-mx-out001.mykolab.com (Postfix) with ESMTPS id 02EFA63E; Tue, 13 Jul 2021 02:32:54 +0200 (CEST) Received: from ext-subm003.mykolab.com (unknown [10.9.6.3]) by int-mx003.mykolab.com (Postfix) with ESMTPS id E69731BF0; Tue, 13 Jul 2021 02:32:53 +0200 (CEST) From: Thiago Jung Bauermann To: Leo Prikler Subject: Re: [bug#48443] [PATCH 1/2] gnu: Add texlive-libkpathsea. Date: Mon, 12 Jul 2021 21:32:47 -0300 Message-ID: <7264704.8eCzXKmJsZ@popigai> In-Reply-To: <20210515144230.22035-1-leo.prikler@student.tugraz.at> References: <20210515144230.22035-1-leo.prikler@student.tugraz.at> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 48443 Cc: 48443@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello Leo, I have very little experience creating Guix packages, but I spent some time working on the TeX Live ones recently so hopefully my comments=20 and suggestions below are helpful. I like adding a separate package for libkpathsea, and it=E2=80=99s what oth= er=20 distros such as Debian and Ubuntu do. Thank you for implementing it. I just= =20 have a few comments below: Em s=C3=A1bado, 15 de maio de 2021, =C3=A0s 11:42:29 -03, Leo Prikler escre= veu: > * gnu/packages/tex.scm (texlive-libkpathsea): New variable. > --- > gnu/packages/tex.scm | 32 ++++++++++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) >=20 > diff --git a/gnu/packages/tex.scm b/gnu/packages/tex.scm > index b9eeb0e792..3e8384eaad 100644 > --- a/gnu/packages/tex.scm > +++ b/gnu/packages/tex.scm > @@ -457,6 +457,38 @@ This package contains the binaries.") > (license (license:fsf-free > "https://www.tug.org/texlive/copying.html")) (home-page > "https://www.tug.org/texlive/"))) >=20 > +(define-public texlive-libkpathsea > + (package/inherit texlive-bin According to a recent message from Ludo=C2=B9, =E2=80=98package/inherit=E2= =80=99 is meant to be=20 used in specific situations, and IIUC it doesn=E2=80=99t apply here: > It should also be (package (inherit =E2=80=A6) =E2=80=A6) rather than (pa= ckage/inherit > =E2=80=A6). The latter is only useful when defining variants of a packag= e (same > version, same code) where the same security updates would apply. I also wonder whether inheriting from texlive-bin is the best option. One=20 disadvantage is that it makes this package too sensitive to changes in=20 texlive-bin. As an example, it doesn=E2=80=99t work anymore with the versio= n in=20 core-updates because in the branch, the =E2=80=98postint=E2=80=99 phase has= been renamed to=20 =E2=80=98post-install=E2=80=99. Also, I assume many texlive-bin inputs aren= =E2=80=99t needed for=20 texlive-kpathsea, causing unnecessary work when building texlive-libkpathsea and packages depending on it such as evince. In addition, if it were a separate package then texlive-bin could be made=20 to use it, rather than shipping its own copy. > + (name "texlive-libkpathsea") > + (source > + (origin > + (inherit (package-source texlive-bin)) Perhaps a =E2=80=98texlive-source-src=E2=80=99 variable analogous to =E2=80= =98texlive-extra-src=E2=80=99=20 and =E2=80=98texlive-texmf-src=E2=80=99 would be useful? > + (snippet > + `(begin > + ,(origin-snippet (package-source texlive-bin)) > + (with-directory-excursion "texk" > + (let ((preserved-directories '("." ".." "kpathsea"))) > + (for-each > + delete-file-recursively > + (scandir "." > + (lambda (file) > + (and (not (member file > preserved-directories)) + (eq? 'directory > (stat:type (stat file))))))))))))) + (arguments > + (substitute-keyword-arguments (package-arguments texlive-bin) > + ((#:configure-flags flags) > + `(cons* "--disable-all-pkgs" "--enable-kpathsea" > + "--enable-shared" ,flags)) > + ((#:phases phases) > + `(modify-phases ,phases > + (delete 'configure-ghostscript-executable) > + (delete 'use-code-for-new-poppler) > + (delete 'patch-dvisvgm-build-files) > + (delete 'disable-failing-test) > + (replace 'postint > + (lambda* (#:key inputs outputs #:allow-other-keys) > + (with-directory-excursion "texk/kpathsea" > + (invoke "make" "install")))))))))) If you decide to continue inheriting from texlive-bin, you=E2=80=99d also n= eed to=20 change the synopsis and description. =2D-=20 Thanks, Thiago =C2=B9 https://lists.gnu.org/archive/html/guix-patches/2021-07/msg00610.html From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 13 03:56:55 2021 Received: (at 48443) by debbugs.gnu.org; 13 Jul 2021 07:56:55 +0000 Received: from localhost ([127.0.0.1]:39334 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3DHj-0000Tq-AQ for submit@debbugs.gnu.org; Tue, 13 Jul 2021 03:56:55 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:9099) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3DHg-0000Ta-OB for 48443@debbugs.gnu.org; Tue, 13 Jul 2021 03:56:53 -0400 Received: from localhost.localdomain (80-121-26-175.adsl.highway.telekom.at [80.121.26.175]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4GPCdZ3yV4z1LWpG; Tue, 13 Jul 2021 09:56:50 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4GPCdZ3yV4z1LWpG DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1626163010; bh=nwHLlJLUtiFFI2+RJyINWUCvausYcYT9f8Dr0oHT5YM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uGyC/CSbQtl4FicLZK5IrnlY5LXoSNvy36P8cGG+tSZBgX+eyrOxDsfyXFZS5Kpb5 cteALoHTm6TAjlx8C9jh3Rp1zX2pgkPtiLxhPZ5RpqzeagrmYzm8WqOd/bQ1F3wKoW r8YvIneWaPc2MOh1FeoOqSm1jG0lJobO3VRgrI50= From: Leo Prikler To: 48443@debbugs.gnu.org Subject: [PATCH v2 2/2] gnu: evince: Build with libkpathsea. Date: Tue, 13 Jul 2021 09:56:09 +0200 Message-Id: <20210713075608.12929-2-leo.prikler@student.tugraz.at> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210713075608.12929-1-leo.prikler@student.tugraz.at> References: <20210713075608.12929-1-leo.prikler@student.tugraz.at> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48443 Cc: bauermann@kolabnow.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/gnome.scm (evince)[inputs]: Add libkpathsea. --- gnu/packages/gnome.scm | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm index f3133c98ae..82ad709f98 100644 --- a/gnu/packages/gnome.scm +++ b/gnu/packages/gnome.scm @@ -2606,9 +2606,7 @@ forgotten when the session ends.") ("ghostscript" ,ghostscript) ("poppler" ,poppler) ("libtiff" ,libtiff) - ;; TODO: - ;; Build libkpathsea as a shared library for DVI support. - ;; ("libkpathsea" ,texlive-bin) + ("libkpathsea" ,texlive-libkpathsea) ("gnome-desktop" ,gnome-desktop) ("gsettings-desktop-schemas" ,gsettings-desktop-schemas) ("gspell" ,gspell) -- 2.32.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 13 03:56:55 2021 Received: (at 48443) by debbugs.gnu.org; 13 Jul 2021 07:56:55 +0000 Received: from localhost ([127.0.0.1]:39336 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3DHj-0000Ts-GA for submit@debbugs.gnu.org; Tue, 13 Jul 2021 03:56:55 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:8912) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3DHg-0000TX-Jm for 48443@debbugs.gnu.org; Tue, 13 Jul 2021 03:56:54 -0400 Received: from localhost.localdomain (80-121-26-175.adsl.highway.telekom.at [80.121.26.175]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4GPCdW3v3bz1LWny; Tue, 13 Jul 2021 09:56:47 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4GPCdW3v3bz1LWny DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1626163007; bh=1snC2GgpcMsDBODlVt4TeLhCVbQ6hj/K91gcOt3tTe0=; h=From:To:Cc:Subject:Date:From; b=vI70tsR6oXmFAy1FtYcMOxAOCbpoWl3xL17t0ukEmn1QMajaRl+SyKnkxrBWAnMX/ wWjt0aqG1aStfGjC1awDDAnYpay5LsccKxvn90dI6oeKQqNyDo+EClu4YmBtqL5mGL IqBmKHVURGYJROExmab2fiudZALzBqyreIO7R+NE= From: Leo Prikler To: 48443@debbugs.gnu.org Subject: [PATCH v2 1/2] gnu: Add texlive-libkpathsea. Date: Tue, 13 Jul 2021 09:56:08 +0200 Message-Id: <20210713075608.12929-1-leo.prikler@student.tugraz.at> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48443 Cc: bauermann@kolabnow.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/tex.scm (texlive-libkpathsea): New variable. --- gnu/packages/tex.scm | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/gnu/packages/tex.scm b/gnu/packages/tex.scm index 8d86264209..9256f56842 100644 --- a/gnu/packages/tex.scm +++ b/gnu/packages/tex.scm @@ -460,6 +460,38 @@ This package contains the binaries.") (license (license:fsf-free "https://www.tug.org/texlive/copying.html")) (home-page "https://www.tug.org/texlive/"))) +(define-public texlive-libkpathsea + (package/inherit texlive-bin + (name "texlive-libkpathsea") + (source + (origin + (inherit (package-source texlive-bin)) + (snippet + `(begin + ,(origin-snippet (package-source texlive-bin)) + (with-directory-excursion "texk" + (let ((preserved-directories '("." ".." "kpathsea"))) + (for-each + delete-file-recursively + (scandir "." + (lambda (file) + (and (not (member file preserved-directories)) + (eq? 'directory (stat:type (stat file))))))))))))) + (arguments + (substitute-keyword-arguments (package-arguments texlive-bin) + ((#:configure-flags flags) + `(cons* "--disable-all-pkgs" "--enable-kpathsea" + "--enable-shared" ,flags)) + ((#:phases phases) + `(modify-phases %standard-phases + (add-after 'install 'post-install + (lambda* (#:key inputs outputs #:allow-other-keys) + (with-directory-excursion "texk/kpathsea" + (invoke "make" "install")))))))) + (synopsis "Path searching library") + (description "kpathsea is a library, whose purpose is to return a filename +from a list of user-specified directories similar to how shells look up +executables. It is maintained as a part of TeX Live."))) (define texlive-docstrip (package -- 2.32.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 13 03:58:27 2021 Received: (at 48443) by debbugs.gnu.org; 13 Jul 2021 07:58:27 +0000 Received: from localhost ([127.0.0.1]:39341 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3DJC-0000WV-U3 for submit@debbugs.gnu.org; Tue, 13 Jul 2021 03:58:27 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:44266) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3DJB-0000WN-5h for 48443@debbugs.gnu.org; Tue, 13 Jul 2021 03:58:25 -0400 Received: from nijino.local (80-121-26-175.adsl.highway.telekom.at [80.121.26.175]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4GPCgM1qDtz3wmc; Tue, 13 Jul 2021 09:58:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1626163103; bh=KWcNa2P18lOxVVVoscaZ82esy2RKzovSVmaYNPTxQqo=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=KHhdN6JP7BkfAzr84u+EDSKMiaXtIQXnJ6kOoO63CsxhF9N9/IQUGpBWMj6jBRKib Et91Jvr7Wy/vlJQLO01efqLPyIBbiO1/IuK3+PpseMOtFpoIHdqhtTZCwZ/05dwhS2 qOCrhiDf8C4PVR3sJRwybPoA4E5CORLT5RRRO4P8= Message-ID: Subject: Re: [bug#48443] [PATCH 1/2] gnu: Add texlive-libkpathsea. From: Leo Prikler To: Thiago Jung Bauermann Date: Tue, 13 Jul 2021 09:58:22 +0200 In-Reply-To: <7264704.8eCzXKmJsZ@popigai> References: <20210515144230.22035-1-leo.prikler@student.tugraz.at> <7264704.8eCzXKmJsZ@popigai> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48443 Cc: 48443@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello Thiago, Am Montag, den 12.07.2021, 21:32 -0300 schrieb Thiago Jung Bauermann: > [...] > > +(define-public texlive-libkpathsea > > + (package/inherit texlive-bin > > According to a recent message from Ludo¹, ‘package/inherit’ is meant > to be > used in specific situations, and IIUC it doesn’t apply here: > > > It should also be (package (inherit …) …) rather than > > (package/inherit …). The latter is only useful when defining > > variants of a package (same version, same code) where the same > > security updates would apply. I'm a little confused here, as that is exactly the rationale I'm applying. When texlive-bin gets grafted due to kpathsea, the graft also applies to texlive-libkpathsea. Granted, there is a large room for false positives, that would result in gratuitous grafts for texlive-libkpathsea, but I prefer erring on the side of security rather than graftlessness here. > I also wonder whether inheriting from texlive-bin is the best option. > One disadvantage is that it makes this package too sensitive to > changes in texlive-bin. As an example, it doesn’t work anymore with > the version in core-updates because in the branch, the ‘postint’ > phase has been renamed to ‘post-install’. Also, I assume many > texlive-bin inputs aren’t needed for texlive-kpathsea, causing > unnecessary work when building texlive-libkpathsea and packages > depending on it such as evince. The postinst thing was my mistake – instead of inheriting from %standard-phases as I should, I naïvely inherited texlive-bin's phases instead. It turns out, I actually don't need any of those (and if I did they'd be trivially copyable). On the part of inputs, sure, we could make libkpathsea smaller, but I have little experience with TeX Live and its build system, so I decided not to change its inputs for now. If you have suggestions on how a better closure could be achieved, please do bring them forth. > In addition, if it were a separate package then texlive-bin could be > made to use it, rather than shipping its own copy. Perhaps that's an idea worth entertaining, but given the TeX Live build system I fear it's not an overwhelmingly practical one. > > + (name "texlive-libkpathsea") > > + (source > > + (origin > > + (inherit (package-source texlive-bin)) > > Perhaps a ‘texlive-source-src’ variable analogous to ‘texlive-extra- > src’ and ‘texlive-texmf-src’ would be useful? I'm… not too sure on this one. What would texlive-source-src capture? Just the upstream source? Then we'd have to carefully apply all the fitting patches. The same as (package-source texlive-bin)? What's the point then? > > + (snippet > > + `(begin > > + ,(origin-snippet (package-source texlive-bin)) > > + (with-directory-excursion "texk" > > + (let ((preserved-directories '("." ".." "kpathsea"))) > > + (for-each > > + delete-file-recursively > > + (scandir "." > > + (lambda (file) > > + (and (not (member file > > preserved-directories)) + (eq? > > 'directory > > (stat:type (stat file))))))))))))) + (arguments > > + (substitute-keyword-arguments (package-arguments texlive-bin) > > + ((#:configure-flags flags) > > + `(cons* "--disable-all-pkgs" "--enable-kpathsea" > > + "--enable-shared" ,flags)) > > + ((#:phases phases) > > + `(modify-phases ,phases > > + (delete 'configure-ghostscript-executable) > > + (delete 'use-code-for-new-poppler) > > + (delete 'patch-dvisvgm-build-files) > > + (delete 'disable-failing-test) > > + (replace 'postint > > + (lambda* (#:key inputs outputs #:allow-other-keys) > > + (with-directory-excursion "texk/kpathsea" > > + (invoke "make" "install")))))))))) > > If you decide to continue inheriting from texlive-bin, you’d also > need to change the synopsis and description. Fair enough, that's on me. I've sent a v2 applying some of your suggestions. Please feel free to point out anything I've missed or you noticed in addition to what's already discussed. Regards, Leo From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 13 21:48:58 2021 Received: (at 48443) by debbugs.gnu.org; 14 Jul 2021 01:48:58 +0000 Received: from localhost ([127.0.0.1]:42473 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3U1C-0005il-7s for submit@debbugs.gnu.org; Tue, 13 Jul 2021 21:48:58 -0400 Received: from mx.kolabnow.com ([95.128.36.42]:38768) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3U16-0005iU-G3 for 48443@debbugs.gnu.org; Tue, 13 Jul 2021 21:48:56 -0400 Received: from localhost (unknown [127.0.0.1]) by ext-mx-out002.mykolab.com (Postfix) with ESMTP id B5BFE9FF; Wed, 14 Jul 2021 03:48:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kolabnow.com; h= content-type:content-type:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:date:subject:subject :from:from:received:received:received; s=dkim20160331; t= 1626227325; x=1628041726; bh=tQhQpQWK6VnQFGS3Ita9K9QUGvGCZLuY3Al I1MTl2cM=; b=29U69xcYvgrfHcGg+rSyiO4Zj9eHj7y+aVFE3VEaEvKRR/E4ORz jy9luAbI2JBd6OeqkLMHsy8rywXkwPgzy2bng6EOUvaFsymyWoXkN8AwdF/JYJg1 0BpEPNmGHukVA3rjiyh+6wK+mWjUhxq6PmTV6FEbUSbgWQSzBTZBPYpkUxbraaUi fVQ0yPaD2g7Hc4PV1yAOoNI+T1OvB5z7FAD6+ZWAgkzpW8PzLyLIkDr79eS1VvHM KQNbQiWByjOSvVMuSZC+NQYf38cUVNMY7t6qIH10x9pe0AVJMhBo63BJ8f0g56al 9Qx8cWTTD7McU0X3eibttCL0rsGti7xvPXmhR3ofUBIZPewHjOdadbW4an5i//OF uHfWAdWXZU+u/0j/ASh7i39owhSyYJn0qEwoj08cCJJiPZvwNZ6aDoIk/TpZN7to gkS7VGUTvO5fSjSj8YJV4Kgw+iWXXEZCsoHwUhhRsAedbupEwifadzcZR2AXTXDP Es5qSh3txZ0Phn2CLzspCu/jdiJZoO+d55mYS0j82I6n3fd2D79Tah5eBH2mE7Qc S87bceRii2G6Ct6cXmCJLH0zRUC40VhFpWXAXXnamHLtlCo669iWYXdoh+lenGDa 7YMDpRaLSXKjKjiwQaalKiOwnby75IMmixAlTufPj/kXDXpC4WhcZzjE= X-Virus-Scanned: amavisd-new at mykolab.com X-Spam-Flag: NO X-Spam-Score: -1.9 X-Spam-Level: X-Spam-Status: No, score=-1.9 tagged_above=-10 required=5 tests=[BAYES_00=-1.9] autolearn=ham autolearn_force=no Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out002.mykolab.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8f_orkfEB8QR; Wed, 14 Jul 2021 03:48:45 +0200 (CEST) Received: from int-mx003.mykolab.com (unknown [10.9.13.3]) by ext-mx-out002.mykolab.com (Postfix) with ESMTPS id ED4A27FC; Wed, 14 Jul 2021 03:48:44 +0200 (CEST) Received: from ext-subm001.mykolab.com (unknown [10.9.6.1]) by int-mx003.mykolab.com (Postfix) with ESMTPS id DFEC73A7D; Wed, 14 Jul 2021 03:48:43 +0200 (CEST) From: Thiago Jung Bauermann To: Leo Prikler Subject: Re: [bug#48443] [PATCH 1/2] gnu: Add texlive-libkpathsea. Date: Tue, 13 Jul 2021 22:48:37 -0300 Message-ID: <2781292.7Eo9FbQQbZ@popigai> In-Reply-To: References: <7264704.8eCzXKmJsZ@popigai> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 48443 Cc: 48443@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Leo, Thank you for your response and your new version of the patches. Em ter=C3=A7a-feira, 13 de julho de 2021, =C3=A0s 04:58:22 -03, Leo Prikler= escreveu: > Hello Thiago, >=20 > Am Montag, den 12.07.2021, 21:32 -0300 schrieb Thiago Jung Bauermann: > > [...] > >=20 > > > +(define-public texlive-libkpathsea > > > + (package/inherit texlive-bin > >=20 > > According to a recent message from Ludo=C2=B9, =E2=80=98package/inherit= =E2=80=99 is meant > > to be > >=20 > > used in specific situations, and IIUC it doesn=E2=80=99t apply here: > > > It should also be (package (inherit =E2=80=A6) =E2=80=A6) rather than > > > (package/inherit =E2=80=A6). The latter is only useful when defining > > > variants of a package (same version, same code) where the same > > > security updates would apply. >=20 > I'm a little confused here, as that is exactly the rationale I'm > applying. When texlive-bin gets grafted due to kpathsea, the graft > also applies to texlive-libkpathsea. Granted, there is a large room > for false positives, that would result in gratuitous grafts for > texlive-libkpathsea, but I prefer erring on the side of security rather > than graftlessness here. My reasoning was that libkpathsea is just a small part of texlive-bin, so=20 in principle a minority of texlive-bin security updates would apply to it.= =20 But you are right, there may well be some which would apply. > > I also wonder whether inheriting from texlive-bin is the best option. > > One disadvantage is that it makes this package too sensitive to > > changes in texlive-bin. As an example, it doesn=E2=80=99t work anymore = with > > the version in core-updates because in the branch, the =E2=80=98postint= =E2=80=99 > > phase has been renamed to =E2=80=98post-install=E2=80=99. Also, I assum= e many > > texlive-bin inputs aren=E2=80=99t needed for texlive-kpathsea, causing > > unnecessary work when building texlive-libkpathsea and packages > > depending on it such as evince. >=20 > The postinst thing was my mistake =E2=80=93 instead of inheriting from > %standard-phases as I should, I na=C3=AFvely inherited texlive-bin's phas= es > instead. It turns out, I actually don't need any of those (and if I > did they'd be trivially copyable). That is nice solution. > On the part of inputs, sure, we could make libkpathsea smaller, but I > have little experience with TeX Live and its build system, so I decided > not to change its inputs for now. If you have suggestions on how a > better closure could be achieved, please do bring them forth. I was able to build the package with an empty input list. I compared a=20 texlive-libkpathsea built with your unchanged patches and one with the=20 empty input list and they are identical, except for the hash of the /gnu/store directory. Even the binary files, which I compared using=20 hexdump. So my suggestion is to use an empty input list. :-) > > In addition, if it were a separate package then texlive-bin could be > > made to use it, rather than shipping its own copy. >=20 > Perhaps that's an idea worth entertaining, but given the TeX Live build > system I fear it's not an overwhelmingly practical one. I can look into that separately, after your patches go in. > > > + (name "texlive-libkpathsea") > > > + (source > > > + (origin > > > + (inherit (package-source texlive-bin)) > >=20 > > Perhaps a =E2=80=98texlive-source-src=E2=80=99 variable analogous to = =E2=80=98texlive-extra- > > src=E2=80=99 and =E2=80=98texlive-texmf-src=E2=80=99 would be useful? >=20 > I'm=E2=80=A6 not too sure on this one. What would texlive-source-src cap= ture? > Just the upstream source? Then we'd have to carefully apply all the > fitting patches. The same as (package-source texlive-bin)? What's the > point then? Yes, the point would be just to not duplicate the origin information. There= =20 would indeed be more work sorting out which security updates apply. > > > + (snippet > > > + `(begin > > > + ,(origin-snippet (package-source texlive-bin)) > > > + (with-directory-excursion "texk" > > > + (let ((preserved-directories '("." ".." "kpathsea"))) > > > + (for-each > > > + delete-file-recursively > > > + (scandir "." > > > + (lambda (file) > > > + (and (not (member file > > > preserved-directories)) + (eq? > > > 'directory > > > (stat:type (stat file))))))))))))) + (arguments > > > + (substitute-keyword-arguments (package-arguments texlive-bin) > > > + ((#:configure-flags flags) > > > + `(cons* "--disable-all-pkgs" "--enable-kpathsea" > > > + "--enable-shared" ,flags)) > > > + ((#:phases phases) > > > + `(modify-phases ,phases > > > + (delete 'configure-ghostscript-executable) > > > + (delete 'use-code-for-new-poppler) > > > + (delete 'patch-dvisvgm-build-files) > > > + (delete 'disable-failing-test) > > > + (replace 'postint > > > + (lambda* (#:key inputs outputs #:allow-other-keys) > > > + (with-directory-excursion "texk/kpathsea" > > > + (invoke "make" "install")))))))))) > >=20 > > If you decide to continue inheriting from texlive-bin, you=E2=80=99d al= so > > need to change the synopsis and description. >=20 > Fair enough, that's on me. I've sent a v2 applying some of your > suggestions. Please feel free to point out anything I've missed or you > noticed in addition to what's already discussed. Thanks! =2D-=20 Thanks, Thiago From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 14 04:50:20 2021 Received: (at 48443) by debbugs.gnu.org; 14 Jul 2021 08:50:20 +0000 Received: from localhost ([127.0.0.1]:42834 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3aay-0001D4-GK for submit@debbugs.gnu.org; Wed, 14 Jul 2021 04:50:20 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:29024) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3aaw-0001Cv-MS for 48443@debbugs.gnu.org; Wed, 14 Jul 2021 04:50:19 -0400 Received: from localhost.localdomain (80-121-26-175.adsl.highway.telekom.at [80.121.26.175]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4GPrmm4Gk6z1LWpZ; Wed, 14 Jul 2021 10:50:16 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4GPrmm4Gk6z1LWpZ DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1626252616; bh=BqpYT525zoGwKi9cGUJ3LpbYYizbb5/Y2MfMrBQjVuI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EFLjZDMlUuOVdJw8OVY4Tm6/NzALnWkIGJ6Z31I+/1vqQL9hHqfdo1eEw7GLKkWuh iCgHfx04YT547UIEnGlcg9HC1BR6vFk3QbFq15AP2QAQFyJYwzyCLEe0oJB6hFHUMS cSVzR8n3V69t7dqNHmrJ5yBadwfIuUIkqdE1irSg= From: Leo Prikler To: 48443@debbugs.gnu.org Subject: [PATCH v3 2/2] gnu: evince: Build with libkpathsea. Date: Wed, 14 Jul 2021 10:50:06 +0200 Message-Id: <20210714085006.3781-2-leo.prikler@student.tugraz.at> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210714085006.3781-1-leo.prikler@student.tugraz.at> References: <20210714085006.3781-1-leo.prikler@student.tugraz.at> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48443 Cc: bauermann@kolabnow.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/gnome.scm (evince)[inputs]: Add libkpathsea. --- gnu/packages/gnome.scm | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm index f3133c98ae..39102dc798 100644 --- a/gnu/packages/gnome.scm +++ b/gnu/packages/gnome.scm @@ -2606,9 +2606,7 @@ forgotten when the session ends.") ("ghostscript" ,ghostscript) ("poppler" ,poppler) ("libtiff" ,libtiff) - ;; TODO: - ;; Build libkpathsea as a shared library for DVI support. - ;; ("libkpathsea" ,texlive-bin) + ("texlive-libkpathsea" ,texlive-libkpathsea) ; for DVI support ("gnome-desktop" ,gnome-desktop) ("gsettings-desktop-schemas" ,gsettings-desktop-schemas) ("gspell" ,gspell) -- 2.32.0 From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 14 04:50:23 2021 Received: (at 48443) by debbugs.gnu.org; 14 Jul 2021 08:50:24 +0000 Received: from localhost ([127.0.0.1]:42836 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3ab1-0001DL-Mw for submit@debbugs.gnu.org; Wed, 14 Jul 2021 04:50:23 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:59702) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3aaw-0001Cr-9G for 48443@debbugs.gnu.org; Wed, 14 Jul 2021 04:50:22 -0400 Received: from localhost.localdomain (80-121-26-175.adsl.highway.telekom.at [80.121.26.175]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4GPrmk3TtCz1LWpG; Wed, 14 Jul 2021 10:50:14 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4GPrmk3TtCz1LWpG DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1626252614; bh=u5bnfjdegprk4bcVbcHC7i1p3jSmU+acEdmiJber9UQ=; h=From:To:Cc:Subject:Date:From; b=iQDR4fP/HtZ/jUQ/q4BKJFmPq5hX86c02Z1CfXsx3IPUIDFKpVdakR8xpfr7NdFow 3BYhFyDUEw/03oQ3Oo5LOVdwNQ1ZV3Ex/ceHj2Sre0V7ynRahx/Rj+WjsecmqmX3Bu 4LaZFdPpi8nShkpdbpAraXRCY5CZijQx2u0ODZEQ= From: Leo Prikler To: 48443@debbugs.gnu.org Subject: [PATCH v3 1/2] gnu: Add texlive-libkpathsea. Date: Wed, 14 Jul 2021 10:50:05 +0200 Message-Id: <20210714085006.3781-1-leo.prikler@student.tugraz.at> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48443 Cc: bauermann@kolabnow.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/tex.scm (texlive-libkpathsea): New variable. --- gnu/packages/tex.scm | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/gnu/packages/tex.scm b/gnu/packages/tex.scm index 8d86264209..b404ca8ff1 100644 --- a/gnu/packages/tex.scm +++ b/gnu/packages/tex.scm @@ -460,6 +460,39 @@ This package contains the binaries.") (license (license:fsf-free "https://www.tug.org/texlive/copying.html")) (home-page "https://www.tug.org/texlive/"))) +(define-public texlive-libkpathsea + (package/inherit texlive-bin + (name "texlive-libkpathsea") + (source + (origin + (inherit (package-source texlive-bin)) + (snippet + `(begin + ,(origin-snippet (package-source texlive-bin)) + (with-directory-excursion "texk" + (let ((preserved-directories '("." ".." "kpathsea"))) + (for-each + delete-file-recursively + (scandir "." + (lambda (file) + (and (not (member file preserved-directories)) + (eq? 'directory (stat:type (stat file))))))))))))) + (arguments + (substitute-keyword-arguments (package-arguments texlive-bin) + ((#:configure-flags flags) + `(cons* "--disable-all-pkgs" "--enable-kpathsea" + "--enable-shared" ,flags)) + ((#:phases phases) + `(modify-phases %standard-phases + (add-after 'install 'post-install + (lambda* (#:key inputs outputs #:allow-other-keys) + (with-directory-excursion "texk/kpathsea" + (invoke "make" "install")))))))) + (inputs '()) + (synopsis "Path searching library") + (description "kpathsea is a library, whose purpose is to return a filename +from a list of user-specified directories similar to how shells look up +executables. It is maintained as a part of TeX Live."))) (define texlive-docstrip (package -- 2.32.0 From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 14 04:56:00 2021 Received: (at 48443) by debbugs.gnu.org; 14 Jul 2021 08:56:00 +0000 Received: from localhost ([127.0.0.1]:42841 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3agS-0001MD-D5 for submit@debbugs.gnu.org; Wed, 14 Jul 2021 04:56:00 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:47351) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3agQ-0001M5-Kk for 48443@debbugs.gnu.org; Wed, 14 Jul 2021 04:55:59 -0400 Received: from nijino.local (80-121-26-175.adsl.highway.telekom.at [80.121.26.175]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4GPrvJ46yKz3xRR; Wed, 14 Jul 2021 10:55:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1626252956; bh=kJCStXJDWoU+R6GHtSDVTRAn0I2FLiyc8OF81bynfPY=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=R0W/2wKm0i+La/ufvkv5XkBNvw9XNoAUh9PgD1tyzWB0NgfYBl462U9Az+vH7JwmF FYswos7ccEvIAJSxOnMADZhQZ3wsKmmWFs/KYCeFj+/TNBxMbe8UT/7Iau220SRko+ CV7x3WBHj091hWmgxUGpUZMpHvsAqMBfIhQOR8rQ= Message-ID: <969b22ea43c5975192e99570d6ad79ebe26efd04.camel@student.tugraz.at> Subject: Re: [bug#48443] [PATCH 1/2] gnu: Add texlive-libkpathsea. From: Leo Prikler To: Thiago Jung Bauermann Date: Wed, 14 Jul 2021 10:55:55 +0200 In-Reply-To: <2781292.7Eo9FbQQbZ@popigai> References: <7264704.8eCzXKmJsZ@popigai> <2781292.7Eo9FbQQbZ@popigai> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48443 Cc: 48443@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Thiago, Am Dienstag, den 13.07.2021, 22:48 -0300 schrieb Thiago Jung Bauermann: > [...] > > > On the part of inputs, sure, we could make libkpathsea smaller, but > > I > > have little experience with TeX Live and its build system, so I > > decided > > not to change its inputs for now. If you have suggestions on how a > > better closure could be achieved, please do bring them forth. > > I was able to build the package with an empty input list. I compared > a texlive-libkpathsea built with your unchanged patches and one with > the empty input list and they are identical, except for the hash of > the /gnu/store directory. Even the binary files, which I compared > using hexdump. So my suggestion is to use an empty input list. :-) Thanks for checking, v3 now uses an empty input list. > > > In addition, if it were a separate package then texlive-bin could > > > be > > > made to use it, rather than shipping its own copy. > > > > Perhaps that's an idea worth entertaining, but given the TeX Live > > build > > system I fear it's not an overwhelmingly practical one. > > I can look into that separately, after your patches go in. Fair enough. > > > > + (name "texlive-libkpathsea") > > > > + (source > > > > + (origin > > > > + (inherit (package-source texlive-bin)) > > > > > > Perhaps a ‘texlive-source-src’ variable analogous to ‘texlive- > > > extra- > > > src’ and ‘texlive-texmf-src’ would be useful? > > > > I'm… not too sure on this one. What would texlive-source-src > > capture? > > Just the upstream source? Then we'd have to carefully apply all > > the > > fitting patches. The same as (package-source texlive-bin)? What's > > the > > point then? > > Yes, the point would be just to not duplicate the origin information. > There would indeed be more work sorting out which security updates > apply. I'm not really convince that would help us. texlive-libkpathsea still needs to inherit from the origin so as to strip away all the others sources. So would every other part of texlive if built on its own. Perhaps one could instead do computed origins, but that increases complexity rather than reducing it. Therefore I'm not convinced extracting this origin into its own variable is beneficial. Regards, Leo From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 14 12:23:44 2021 Received: (at 48443) by debbugs.gnu.org; 14 Jul 2021 16:23:44 +0000 Received: from localhost ([127.0.0.1]:45815 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3hfj-00058f-NY for submit@debbugs.gnu.org; Wed, 14 Jul 2021 12:23:43 -0400 Received: from mx.kolabnow.com ([95.128.36.42]:60118) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3hfi-00058S-4u for 48443@debbugs.gnu.org; Wed, 14 Jul 2021 12:23:42 -0400 Received: from localhost (unknown [127.0.0.1]) by ext-mx-out002.mykolab.com (Postfix) with ESMTP id EE5F91326; Wed, 14 Jul 2021 18:23:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kolabnow.com; h= content-type:content-type:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:date:subject:subject :from:from:received:received:received; s=dkim20160331; t= 1626279815; x=1628094216; bh=7d5fz1Yot2dFXHnP3b6pgPI/1R5XDWks7bT x+s2l+6s=; b=G4o62hIxZqb9TwOIReVpILRcgK4ZbDFvYV5ZICdvQPA3YirXtBJ r6akrshX9tjO/hH7BETZGbegm1Q23Tv1AMVJzpiIezwbLNn/IblQZsOEscpz8UW7 +8C3LYEoR4nFiRx4kse9z8cQGSugNEEaFv3L06S35+QSdOKayh87nTlQujjmzZtU 8fr4rXuvtwfLzbf79ipeTlY4PqwqueQDwtdzhd4C9reztwRwWVg3uDEsQWUrW7Nu +ZsbYFvVtUpjV7PKixl26KKDWjyIdgzAZ30C5S5TWHk0WhqYVlxX6I4A+wrIhmro G0LFLdDZevkRxHM2FxtwBnIS97dwSajR+Mga6AOHqjritWnowz0c0dlbCW04hCqi c8JiVAE3yurJAA8AVonZabdXEBHPKTBuz1HM3/wL12VZIIk5xqwJmIGBgbqMugjB GCOFh1oG1N7TJTQcF39/2pnXEOVMa6ueeYVsXYNKuzwnDzHgQc9lLLapGVHGAP2i Mint2msw8nbfzqhrmHemMMqnWHVFQWRvIbahybHjzCdocYs8soRua8rWi2Z9ab7x UM/MJ1HdqIMI0js2sitDS160qGO8hV14tD8SRBRGdTJTCMPBcbyWaaoji8sxfTYZ gQ8Pt9EZwsiTusbU+cbiuZ5/2DRLoXdGZe/eCUUjWE3Zu7epsOCsxJkA= X-Virus-Scanned: amavisd-new at mykolab.com X-Spam-Flag: NO X-Spam-Score: -1.9 X-Spam-Level: X-Spam-Status: No, score=-1.9 tagged_above=-10 required=5 tests=[BAYES_00=-1.9] autolearn=ham autolearn_force=no Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out002.mykolab.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7JmGiweNAkzA; Wed, 14 Jul 2021 18:23:35 +0200 (CEST) Received: from int-mx001.mykolab.com (unknown [10.9.13.1]) by ext-mx-out002.mykolab.com (Postfix) with ESMTPS id 6033A1288; Wed, 14 Jul 2021 18:23:34 +0200 (CEST) Received: from ext-subm002.mykolab.com (unknown [10.9.6.2]) by int-mx001.mykolab.com (Postfix) with ESMTPS id 01913192B; Wed, 14 Jul 2021 18:23:32 +0200 (CEST) From: Thiago Jung Bauermann To: Leo Prikler Subject: Re: [bug#48443] [PATCH 1/2] gnu: Add texlive-libkpathsea. Date: Wed, 14 Jul 2021 13:23:26 -0300 Message-ID: <10314452.DzVqUJa3KR@popigai> In-Reply-To: <969b22ea43c5975192e99570d6ad79ebe26efd04.camel@student.tugraz.at> References: <2781292.7Eo9FbQQbZ@popigai> <969b22ea43c5975192e99570d6ad79ebe26efd04.camel@student.tugraz.at> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 48443 Cc: 48443@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Leo, Em quarta-feira, 14 de julho de 2021, =C3=A0s 05:55:55 -03, Leo Prikler=20 escreveu: > Am Dienstag, den 13.07.2021, 22:48 -0300 schrieb Thiago Jung Bauermann: > > [...] > >=20 > > > On the part of inputs, sure, we could make libkpathsea smaller, but > > > I > > > have little experience with TeX Live and its build system, so I > > > decided > > > not to change its inputs for now. If you have suggestions on how a > > > better closure could be achieved, please do bring them forth. > >=20 > > I was able to build the package with an empty input list. I compared > > a texlive-libkpathsea built with your unchanged patches and one with > > the empty input list and they are identical, except for the hash of > > the /gnu/store directory. Even the binary files, which I compared > > using hexdump. So my suggestion is to use an empty input list. :-) >=20 > Thanks for checking, v3 now uses an empty input list. Thanks! v3 looks great to me. =20 > > > > > + (name "texlive-libkpathsea") > > > > > + (source > > > > > + (origin > > > > > + (inherit (package-source texlive-bin)) > > > >=20 > > > > Perhaps a =E2=80=98texlive-source-src=E2=80=99 variable analogous t= o =E2=80=98texlive- > > > > extra- > > > > src=E2=80=99 and =E2=80=98texlive-texmf-src=E2=80=99 would be usefu= l? > > >=20 > > > I'm=E2=80=A6 not too sure on this one. What would texlive-source-src > > > capture? > > > Just the upstream source? Then we'd have to carefully apply all > > > the > > > fitting patches. The same as (package-source texlive-bin)? What's > > > the > > > point then? > >=20 > > Yes, the point would be just to not duplicate the origin information. > > There would indeed be more work sorting out which security updates > > apply. >=20 > I'm not really convince that would help us. texlive-libkpathsea still > needs to inherit from the origin so as to strip away all the others > sources. So would every other part of texlive if built on its own. > Perhaps one could instead do computed origins, but that increases > complexity rather than reducing it. Therefore I'm not convinced > extracting this origin into its own variable is beneficial. Yes, that is true. In my previous message I was agreeing with you that the= =20 origin idea didn=E2=80=99t bring much benefit. Sorry for not being clear. =2D-=20 Thanks, Thiago From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 15 07:45:03 2021 Received: (at 48443-done) by debbugs.gnu.org; 15 Jul 2021 11:45:03 +0000 Received: from localhost ([127.0.0.1]:46938 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3znb-0005Gs-Hp for submit@debbugs.gnu.org; Thu, 15 Jul 2021 07:45:03 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:52354) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3znY-0005G8-8z for 48443-done@debbugs.gnu.org; Thu, 15 Jul 2021 07:45:01 -0400 Received: from [10.0.0.4] (80-121-26-175.adsl.highway.telekom.at [80.121.26.175]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4GQXbs11jbz3xRv; Thu, 15 Jul 2021 13:44:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1626349497; bh=9m6B/GkJ6bf7pinxsUORvcELL0jPVi2jQm/Wq3cCEco=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=Tdel1xjEuSewsdCgHD8EnNtnRJOmRvg2COH+B/Fj5yfrs5+jKg9Aviqr61y1wF7QY N2BR6MKoQ0O17ZM54SZXO5zvEWXK7HN7CJRxbSgrPB0/J34UfZJ/SBqSzlcZ65vRAQ 32cYBzhF1pApTKqixr0+jzYn5bjYNIvAvZqzBYGY= Message-ID: Subject: Re: [bug#48443] [PATCH 1/2] gnu: Add texlive-libkpathsea. From: Leo Prikler To: Thiago Jung Bauermann Date: Thu, 15 Jul 2021 13:44:36 +0200 In-Reply-To: <10314452.DzVqUJa3KR@popigai> References: <2781292.7Eo9FbQQbZ@popigai> <969b22ea43c5975192e99570d6ad79ebe26efd04.camel@student.tugraz.at> <10314452.DzVqUJa3KR@popigai> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48443-done Cc: 48443-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Am Mittwoch, den 14.07.2021, 13:23 -0300 schrieb Thiago Jung Bauermann: > [...] > Yes, that is true. In my previous message I was agreeing with you > that the origin idea didn’t bring much benefit. Sorry for not being > clear. No problem. I've pushed this now, thanks for your review! From unknown Sun Jun 15 10:54:17 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 13 Aug 2021 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator