GNU bug report logs - #48408
BUGFIX: window-default-font-height: check for nil string

Previous Next

Package: emacs;

Reported by: Boruch Baum <boruch_baum <at> gmx.com>

Date: Fri, 14 May 2021 01:16:02 UTC

Severity: normal

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: rudalics <at> gmx.at
Cc: boruch_baum <at> gmx.com, 48408 <at> debbugs.gnu.org
Subject: bug#48408: BUGFIX: window-default-font-height: check for nil string
Date: Sun, 16 May 2021 12:08:59 +0300

> Date: Sun, 16 May 2021 11:56:45 +0300
> From: Eli Zaretskii <eliz <at> gnu.org>
> Cc: boruch_baum <at> gmx.com, 48408 <at> debbugs.gnu.org
> 
> > OK.  But was Boruch's original idea just checking for
> > 
> > (stringp default-font)
> > 
> > worse?
> 
> I'm asking for your opinion about that ;-)

Actually, no, I do have an opinion on that: face-font can return a
string even on a TTY frame, at least in a build --without-x.  (Which
seems to be an inconsistency in and of itself, btw.)

In general, trusting frame parameters too much is IME not a good idea,
as they are too loosely defined.
This bug report was last modified 3 years and 27 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.