GNU bug report logs - #48408
BUGFIX: window-default-font-height: check for nil string

Previous Next

Package: emacs;

Reported by: Boruch Baum <boruch_baum <at> gmx.com>

Date: Fri, 14 May 2021 01:16:02 UTC

Severity: normal

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


Message #11 received at 48408 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Boruch Baum <boruch_baum <at> gmx.com>, 48408 <at> debbugs.gnu.org
Subject: Re: bug#48408: BUGFIX: window-default-font-height: check for nil
 string
Date: Fri, 14 May 2021 09:09:38 +0200
> In package windows.el, function `window-default-font-height' calls
> function `face-font', which can return a nil value, but performs a
> `string-equal' operation on the output without checking for that
> possibiliy.

Please report this to the author(s) of that package.

> I came across this in an unusual case, of having an 'emacs -nw' server
> an 'emacsclient -nw', and opening a GUI emacsclient to connect to it.
>  From that point forward until the fix, every *second* attempt to use the
> minibuffer on the 'emacsclient -nw' would fail.
>
> The fix I'm using is:
>
>      (if (and (display-multi-font-p (frame-parameter frame 'display))
>               (stringp default-font)  ; <<<---!!!

What is `default-font'?

> 	     (not (string-equal (frame-parameter frame 'font) default-font)))
>
> But there could be other considerations to performing things in another way.

martin




This bug report was last modified 3 years and 12 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.