From debbugs-submit-bounces@debbugs.gnu.org Thu May 13 16:50:19 2021 Received: (at submit) by debbugs.gnu.org; 13 May 2021 20:50:19 +0000 Received: from localhost ([127.0.0.1]:44402 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhIHi-0005vf-E1 for submit@debbugs.gnu.org; Thu, 13 May 2021 16:50:19 -0400 Received: from lists.gnu.org ([209.51.188.17]:56668) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhIHd-0005vT-So for submit@debbugs.gnu.org; Thu, 13 May 2021 16:50:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34976) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhIHd-0000qs-Il for bug-gnu-emacs@gnu.org; Thu, 13 May 2021 16:50:13 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57406) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhIHd-0002g0-9a; Thu, 13 May 2021 16:50:13 -0400 Received: from auth2-smtp.messagingengine.com ([66.111.4.228]:54211) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhIHd-0007Wh-21; Thu, 13 May 2021 16:50:13 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailauth.nyi.internal (Postfix) with ESMTP id A72A327C0054; Thu, 13 May 2021 16:50:12 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 13 May 2021 16:50:12 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdehgedgudehgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpegfhffvufffkfggtgfgsehtqhertddtreejnecuhfhrohhmpefvrghsshhi lhhoucfjohhrnhcuoehtshguhhesghhnuhdrohhrgheqnecuggftrfgrthhtvghrnhephf ehhedvjeduteeftdelgefgheevjeelheefudfhffehjeevieefleeiffeifedtnecukfhp peekjedrudeifedrfedurdduheegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrg hmpehmrghilhhfrhhomhepthhhohhrnhdomhgvshhmthhprghuthhhphgvrhhsohhnrghl ihhthidqkeeijeefkeejkeegqdeifeehvdelkedqthhsughhpeepghhnuhdrohhrghesfh grshhtmhgrihhlrdhfmh X-ME-Proxy: Received: from thinkpad-t440p (p57a31f9a.dip0.t-ipconnect.de [87.163.31.154]) by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 13 May 2021 16:50:11 -0400 (EDT) User-agent: mu4e 1.5.13; emacs 28.0.50 From: Tassilo Horn To: bug-gnu-emacs@gnu.org Subject: 28.0.50; "Invalid version syntax" errors with read-extended-command Date: Thu, 13 May 2021 22:45:01 +0200 Message-ID: <875yzms6im.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: Stefan Kangas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Since commit 1af91d271e077134e272055407fb8c4312a7579b I get strange "Invalid version syntax: (must start with a number)" errors during M-x completion in the minibuffer. I can't reproduce with emacs -Q but in the error, is always some (M)ELPA package. For example, M-x mag TAB gives completion--some: Invalid version syntax: =E2=80=98Magit 3.0.0=E2=80=99 (= must start with a number) Here is a backtrace: --8<---------------cut here---------------start------------->8--- Debugger entered--Lisp error: (error "Invalid version syntax: =E2=80=98Magi= t 3.0.0=E2=80=99 (must start ...") error("Invalid version syntax: `%s' (must start with a nu..." "Magit 3.0.= 0") version-to-list("Magit 3.0.0") #f(compiled-function (sym) #)(magit-dispatc= h-popup) try-completion("mag" [## magit-section-show-headings vc-src-responsible-p= Read\ manual tag-end dashboard-ls Set\ Slice debbugs-gnu-log-edit-mode mu4= e-kill-update-mail Reduce\ To:\ to\ Cc: mu4e-view-header-field-keymap c-ele= ctric-lt-gt :neither yas-x-prompt cc-vars rainbow-colorize-ansi znc magit-x= ref-insert-button inactive gnus-agent-group-covered-p web-mode-extra-snippe= ts smiley-directory message-expand-name-databases transient:magit-diff-refr= esh:--irreversible-delete er/looking-back-max tree-widget-button-keymap rus= t--same-line-p gnus-summary-show-article-from-menu-as-charset-ebcdic-int :w= here org-switch-to-buffer-other-window nexus th/visual-line-mode-init :mac = xref--push-markers vc-bzr-shelve-menu display-even-when-displayed widget-fa= ce-sample-face-get time-subsecond gnus-summary-limit-to-marks he-line-searc= h-regexp symbol-before-point-for-complete magit-filename utf7-direct-encodi= ng-chars generic--normalize-comments org-get-org-file check-declare xref-gr= oup :org-comment stack-mode Boring\ headers ...] #f(compiled-function (sym)= #)) complete-with-action(nil [## magit-section-show-headings vc-src-responsib= le-p Read\ manual tag-end dashboard-ls Set\ Slice debbugs-gnu-log-edit-mode= mu4e-kill-update-mail Reduce\ To:\ to\ Cc: mu4e-view-header-field-keymap c= -electric-lt-gt :neither yas-x-prompt cc-vars rainbow-colorize-ansi znc mag= it-xref-insert-button inactive gnus-agent-group-covered-p web-mode-extra-sn= ippets smiley-directory message-expand-name-databases transient:magit-diff-= refresh:--irreversible-delete er/looking-back-max tree-widget-button-keymap= rust--same-line-p gnus-summary-show-article-from-menu-as-charset-ebcdic-in= t :where org-switch-to-buffer-other-window nexus th/visual-line-mode-init := mac xref--push-markers vc-bzr-shelve-menu display-even-when-displayed widge= t-face-sample-face-get time-subsecond gnus-summary-limit-to-marks he-line-s= earch-regexp symbol-before-point-for-complete magit-filename utf7-direct-en= coding-chars generic--normalize-comments org-get-org-file check-declare xre= f-group :org-comment stack-mode Boring\ headers ...] "mag" #f(compiled-func= tion (sym) #)) #("mag" #f(co= mpiled-function (sym) #) nil) completion-basic-try-completion("mag" # #f(compiled-function (sym) #) 3) #f(compiled-function (style) #)(basic) completion--some(#f(compiled-function (style) #) (basic partial-completion substring initials flex)) completion--nth-completion(1 "mag" # #f(compiled-function (sym) #) 3 (metadata (affixation-function . read-extended-command--affixation= ) (category . command))) completion-try-completion("mag" # #f(compiled-function (sym) #) 3 (metadata (affixation-function . read-extended-command--affixation) (= category . command))) completion--do-completion(5 8) completion--in-region-1(5 8) #f(compiled-function (start end collection predicate) #)(5 8 # #f(compiled-function (sym) #)) apply(#f(compiled-function (start end collection predicate) #) (5 8 # #f(compiled-function (sym) #))) #f(compiled-function (funs global args) #)(ni= l nil (5 8 # #f= (compiled-function (sym) #))) completion--in-region(5 8 # #f(compiled-function (sym) #)) completion-in-region(5 8 # #f(compiled-function (sym) #)) minibuffer-complete() funcall-interactively(minibuffer-complete) command-execute(minibuffer-complete) completing-read-default("M-x " # #f(compiled-function (sym) #) t nil extended-command-history nil nil) read-extended-command() byte-code("\302\30\11\303 \10E)\207" [execute-extended-command--last-type= d current-prefix-arg nil read-extended-command] 3) command-execute(execute-extended-command) --8<---------------cut here---------------end--------------->8--- In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.29, c= airo version 1.17.4) of 2021-05-13 built on thinkpad-t440p Repository revision: 43701a84367b76ccc93ad46f89110486988eec10 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101001 System Description: Arch Linux Configured using: 'configure --with-modules --with-native-compilation' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSYSTEMD LIBXML2 M17N_FLT MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB Important settings: value of $LC_MONETARY: de_DE.utf8 value of $LC_NUMERIC: de_DE.utf8 value of $LC_TIME: de_DE.utf8 value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: mu4e:main Minor modes in effect: global-aggressive-indent-mode: t dynamic-completion-mode: t which-key-mode: t company-posframe-mode: t global-company-mode: t yas-global-mode: t yas-minor-mode: t global-git-commit-mode: t magit-auto-revert-mode: t override-global-mode: t minibuffer-depth-indicate-mode: t recentf-mode: t pixel-scroll-mode: t save-place-mode: t savehist-mode: t show-paren-mode: t shell-dirtrack-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t column-number-mode: t line-number-mode: t transient-mark-mode: t overwrite-mode: overwrite-mode-binary Load-path shadows: ~/Repos/el/mu/build/mu4e/mu4e hides ~/Repos/el/mu/mu4e/mu4e ~/Repos/el/mu/build/mu4e/mu4e-main hides ~/Repos/el/mu/mu4e/mu4e-main ~/Repos/el/mu/build/mu4e/mu4e-view hides ~/Repos/el/mu/mu4e/mu4e-view ~/Repos/el/mu/build/mu4e/mu4e-org hides ~/Repos/el/mu/mu4e/mu4e-org ~/Repos/el/mu/build/mu4e/mu4e-lists hides ~/Repos/el/mu/mu4e/mu4e-lists ~/Repos/el/mu/build/mu4e/mu4e-actions hides ~/Repos/el/mu/mu4e/mu4e-actions ~/Repos/el/mu/build/mu4e/mu4e-utils hides ~/Repos/el/mu/mu4e/mu4e-utils ~/Repos/el/mu/build/mu4e/mu4e-context hides ~/Repos/el/mu/mu4e/mu4e-context ~/Repos/el/mu/build/mu4e/mu4e-draft hides ~/Repos/el/mu/mu4e/mu4e-draft ~/Repos/el/mu/build/mu4e/mu4e-message hides ~/Repos/el/mu/mu4e/mu4e-message ~/Repos/el/mu/build/mu4e/mu4e-compose hides ~/Repos/el/mu/mu4e/mu4e-compose ~/Repos/el/mu/build/mu4e/mu4e-view-common hides ~/Repos/el/mu/mu4e/mu4e-vie= w-common ~/Repos/el/mu/build/mu4e/mu4e-view-old hides ~/Repos/el/mu/mu4e/mu4e-view-o= ld ~/Repos/el/mu/build/mu4e/mu4e-view-gnus hides ~/Repos/el/mu/mu4e/mu4e-view-= gnus ~/Repos/el/mu/build/mu4e/mu4e-headers hides ~/Repos/el/mu/mu4e/mu4e-headers ~/Repos/el/mu/build/mu4e/mu4e-mark hides ~/Repos/el/mu/mu4e/mu4e-mark ~/Repos/el/mu/build/mu4e/mu4e-icalendar hides ~/Repos/el/mu/mu4e/mu4e-icale= ndar ~/Repos/el/mu/build/mu4e/mu4e-speedbar hides ~/Repos/el/mu/mu4e/mu4e-speedb= ar ~/Repos/el/mu/build/mu4e/mu4e-contrib hides ~/Repos/el/mu/mu4e/mu4e-contrib ~/Repos/el/mu/build/mu4e/mu4e-proc hides ~/Repos/el/mu/mu4e/mu4e-proc ~/Repos/el/mu/build/mu4e/mu4e-meta hides ~/Repos/el/mu/mu4e/mu4e-meta ~/Repos/el/mu/build/mu4e/mu4e-vars hides ~/Repos/el/mu/mu4e/mu4e-vars /home/horn/.emacs.d/elpa/transient-20210427.833/transient hides /home/horn/= Repos/el/emacs/lisp/transient Features: (shadow hippie-exp emacsbug debbugs-gnu qp sort gnus-cite mail-extr goto-addr magit-extras cursor-sensor face-remap paredit vc-mtn vc-hg vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs display-fill-column-indicator company-oddmuse company-keywords company-etags etags fileloop generator xref project company-gtags company-dabbrev-code company-dabbrev company-files company-clang company-capf company-cmake company-semantic company-template company-bbdb cus-edit pp cus-start cus-load auto-package-update generic yaml-mode fish-mode cargo cargo-process rust-utils rust-mode rust-rustfmt rust-playpen rust-compile rust-cargo web-mode disp-table preview-latex auto-loads tex-site deadgrep spinner hl-todo aggressive-indent rainbow-mode vc-git vc-dir ewoc vc vc-dispatcher epa-file dired-x mu4e-alert time ht s mu4e-icalendar gnus-icalendar org-capture org-refile icalendar diary-lib diary-loaddefs mu4e mu4e-org mu4e-main mu4e-view mu4e-view-gnus mu4e-view-common mu4e-headers mu4e-compose mu4e-context mu4e-draft mu4e-actions ido rfc2368 mu4e-mark mu4e-proc mu4e-utils doc-view jka-compr image-mode exif mu4e-lists mu4e-message flow-fill org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-footnote org-src ob-comint org-pcomplete org-list org-faces org-entities org-version ob-emacs-lisp ob-core ob-eval org-table ol org-keys org-compat org-macs org-loaddefs cal-menu calendar cal-loaddefs mule-util hl-line mu4e-vars mu4e-meta smtpmail-multi smtpmail sendmail ecomplete completion auto-dictionary flyspell ispell tramp-smb which-key highlight-parentheses company-restclient know-your-http-well http-status-codes http-relations http-methods http-headers restclient company-posframe posframe company pcase yasnippet compile find-func autoload radix-tree lisp-mnt finder-inf mm-archive network-stream url-cache forge-list forge-commands forge-semi forge-bitbucket buck forge-gogs gogs forge-gitea gtea forge-gitlab glab forge-github ghub-graphql treepy gsexp ghub let-alist gnutls forge-notify forge-revnote forge-pullreq forge-issue forge-topic forge-post markdown-mode color thingatpt noutline outline forge-repo forge forge-core forge-db closql emacsql-sqlite advice emacsql emacsql-compiler magit-submodule magit-obsolete magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log which-func imenu magit-diff smerge-mode diff diff-mode git-commit log-edit pcvs-util add-log magit-core magit-autorevert autorevert filenotify magit-margin magit-transient magit-process with-editor server magit-mode transient comp comp-cstr magit-git magit-section magit-utils crm dash visual-filename-abbrev debbugs soap-client url-http url-auth url-gw nsm warnings rng-xsd rng-dt rng-util xsd-regexp bug-reference use-package-bind-key bind-key easy-mmode vertico aggressive-completion icomplete mb-depth use-package-diminish windmove alert log4e notifications gntp rx tramp-cache tramp-sh recentf tree-widget pixel-scroll saveplace savehist paren smiley gnus-art mm-uu mml2015 mm-view mml-smime smime dig gnus-sum shr kinsoku svg dom gnus-group gnus-undo gnus-start gnus-dbus dbus xml gnus-cloud nnimap nnmail mail-source utf7 netrc nnoo gnus-spec gnus-int gnus-range message rmc puny dired dired-loaddefs rfc822 mml mml-sec epa derived epg epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader gnus-win gnus wid-edit nnheader gnus-util rmail rmail-loaddefs rfc2047 rfc2045 ietf-drums text-property-search mm-util mail-prsvr mail-utils edmacro kmacro dracula-theme diminish cl-extra help-mode use-package-ensure use-package-core tramp tramp-loaddefs trampver tramp-integration files-x tramp-compat shell pcomplete comint ansi-color ring parse-time iso8601 time-date ls-lisp format-spec info package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json subr-x map url-vars seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process native-compile emacs) Memory information: ((conses 16 720190 82629) (symbols 48 47153 5) (strings 32 211165 12252) (string-bytes 1 6287106) (vectors 16 84612) (vector-slots 8 1466836 93450) (floats 8 635 676) (intervals 56 4752 453) (buffers 992 30)) From debbugs-submit-bounces@debbugs.gnu.org Fri May 14 02:21:00 2021 Received: (at 48404) by debbugs.gnu.org; 14 May 2021 06:21:00 +0000 Received: from localhost ([127.0.0.1]:44760 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhRC0-0005dL-1D for submit@debbugs.gnu.org; Fri, 14 May 2021 02:21:00 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43322) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhRBy-0005dA-70 for 48404@debbugs.gnu.org; Fri, 14 May 2021 02:20:59 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44144) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhRBs-0003Vs-V0; Fri, 14 May 2021 02:20:52 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2410 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhRBs-0007FN-4f; Fri, 14 May 2021 02:20:52 -0400 Date: Fri, 14 May 2021 09:21:03 +0300 Message-Id: <83wns1zvhs.fsf@gnu.org> From: Eli Zaretskii To: Tassilo Horn In-Reply-To: <875yzms6im.fsf@gnu.org> (message from Tassilo Horn on Thu, 13 May 2021 22:45:01 +0200) Subject: Re: bug#48404: 28.0.50; "Invalid version syntax" errors with read-extended-command References: <875yzms6im.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48404 Cc: 48404@debbugs.gnu.org, stefan@marxist.se X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Tassilo Horn > Date: Thu, 13 May 2021 22:45:01 +0200 > Cc: Stefan Kangas > > Since commit 1af91d271e077134e272055407fb8c4312a7579b I get strange > "Invalid version syntax: (must start with a number)" > errors during M-x completion in the minibuffer. I can't reproduce with > emacs -Q but in the error, is always some (M)ELPA package. > > For example, M-x mag TAB gives > > completion--some: Invalid version syntax: ‘Magit 3.0.0’ (must start with a number) That commit uses byte-obsolete-info property of a symbol, and expects its caddr to be a valid version number. It sounds like in some cases it is not an Emacs version, but something else. So, questions: . can you find out what kind of value does the byte-obsolete-info property is there on Magit functions? and . how come these properties were added to something that is not an Emacs core code? In any case, it sounds like blindly trusting the value of that property is not a good idea, and we should wrap the call to version-to-list there in condition-case. Could you try that? From debbugs-submit-bounces@debbugs.gnu.org Fri May 14 02:59:43 2021 Received: (at 48404) by debbugs.gnu.org; 14 May 2021 06:59:43 +0000 Received: from localhost ([127.0.0.1]:44793 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhRnT-0006ZA-EK for submit@debbugs.gnu.org; Fri, 14 May 2021 02:59:43 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50414) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhRnR-0006Yx-AP for 48404@debbugs.gnu.org; Fri, 14 May 2021 02:59:42 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44642) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhRnL-0003BJ-Sw; Fri, 14 May 2021 02:59:35 -0400 Received: from auth2-smtp.messagingengine.com ([66.111.4.228]:36075) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhRnL-0004um-7b; Fri, 14 May 2021 02:59:35 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailauth.nyi.internal (Postfix) with ESMTP id E332227C0054; Fri, 14 May 2021 02:59:34 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 14 May 2021 02:59:34 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdehhedgudduvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpehffgfhvffuffgjkfggtgfgsehtqhertddtreejnecuhfhrohhmpefvrghs shhilhhoucfjohhrnhcuoehtshguhhesghhnuhdrohhrgheqnecuggftrfgrthhtvghrnh epiedugffhhfejveevvdfhffegteelleejffefgefgueeggeelheefieeujefhheegnecu kfhppeekjedrudeifedrfedurdduheegnecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomhepthhhohhrnhdomhgvshhmthhprghuthhhphgvrhhsohhn rghlihhthidqkeeijeefkeejkeegqdeifeehvdelkedqthhsughhpeepghhnuhdrohhrgh esfhgrshhtmhgrihhlrdhfmh X-ME-Proxy: Received: from thinkpad-t440p (p57a31f9a.dip0.t-ipconnect.de [87.163.31.154]) by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 14 May 2021 02:59:34 -0400 (EDT) References: <875yzms6im.fsf@gnu.org> <83wns1zvhs.fsf@gnu.org> User-agent: mu4e 1.5.13; emacs 28.0.50 From: Tassilo Horn To: Eli Zaretskii Subject: Re: bug#48404: 28.0.50; "Invalid version syntax" errors with read-extended-command Date: Fri, 14 May 2021 08:47:32 +0200 In-reply-to: <83wns1zvhs.fsf@gnu.org> Message-ID: <871ra9kdgs.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48404 Cc: 48404@debbugs.gnu.org, stefan@marxist.se X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: >> For example, M-x mag TAB gives >>=20 >> completion--some: Invalid version syntax: =E2=80=98Magit 3.0.0=E2=80= =99 (must start with a number) > > That commit uses byte-obsolete-info property of a symbol, and expects > its caddr to be a valid version number. It sounds like in some cases > it is not an Emacs version, but something else. So, questions: > > . can you find out what kind of value does the byte-obsolete-info > property is there on Magit functions? and It's not just Magit. I've grepped my ~/.emacs.d/elpa/ and here are some values: (make-obsolete-variable 'magit-refresh-args nil "Magit 3.0.0") (make-obsolete-variable backported sym "yasnippet 0.8") (make-obsolete-variable 'which-key-key-replacement-alist 'which-key-replacement-alist "2016-11-21") So at least magit and yasnippet use " " syntax here, and which-key uses a date (which seems fine for version-to-list). > . how come these properties were added to something that is not an > Emacs core code? It seems to be added by `make-obsolete', no? Otherwise, there is no writing menion of byte-obsolete-info. > In any case, it sounds like blindly trusting the value of that > property is not a good idea, and we should wrap the call to > version-to-list there in condition-case. Could you try that? I've tried this --8<---------------cut here---------------start------------->8--- diff --git a/lisp/simple.el b/lisp/simple.el index 0255f69e42..573e344fea 100644 --- a/lisp/simple.el +++ b/lisp/simple.el @@ -2020,8 +2020,10 @@ read-extended-command ;; Has a current-name. (functionp (car obsolete)) ;; when >=3D emacs-major-version - (>=3D (car (version-to-list (caddr obs= olete))) - emacs-major-version)))))) + (condition-case nil + (>=3D (car (version-to-list (caddr= obsolete))) + emacs-major-version) + (t nil))))))) pred))) (complete-with-action action obarray string pred)))) --8<---------------cut here---------------end--------------->8--- which does the trick. Should I write bug reports for Magit and Yasnippets so that they should only specify the version number in `make-obsolete' / `make-obsolete-variable'? Or should emacs support the " " syntax? Bye, Tassilo From debbugs-submit-bounces@debbugs.gnu.org Fri May 14 03:18:37 2021 Received: (at 48404) by debbugs.gnu.org; 14 May 2021 07:18:37 +0000 Received: from localhost ([127.0.0.1]:44831 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhS5l-00074a-4D for submit@debbugs.gnu.org; Fri, 14 May 2021 03:18:37 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53978) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhS5i-00074M-I2 for 48404@debbugs.gnu.org; Fri, 14 May 2021 03:18:36 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45004) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhS5d-0006hT-5D; Fri, 14 May 2021 03:18:29 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2048 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhS5c-00059M-M6; Fri, 14 May 2021 03:18:29 -0400 Date: Fri, 14 May 2021 10:18:40 +0300 Message-Id: <83czttzstr.fsf@gnu.org> From: Eli Zaretskii To: Tassilo Horn In-Reply-To: <871ra9kdgs.fsf@gnu.org> (message from Tassilo Horn on Fri, 14 May 2021 08:47:32 +0200) Subject: Re: bug#48404: 28.0.50; "Invalid version syntax" errors with read-extended-command References: <875yzms6im.fsf@gnu.org> <83wns1zvhs.fsf@gnu.org> <871ra9kdgs.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48404 Cc: 48404@debbugs.gnu.org, stefan@marxist.se X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Tassilo Horn > Cc: 48404@debbugs.gnu.org, stefan@marxist.se > Date: Fri, 14 May 2021 08:47:32 +0200 > > > In any case, it sounds like blindly trusting the value of that > > property is not a good idea, and we should wrap the call to > > version-to-list there in condition-case. Could you try that? > > I've tried this > > --8<---------------cut here---------------start------------->8--- > diff --git a/lisp/simple.el b/lisp/simple.el > index 0255f69e42..573e344fea 100644 > --- a/lisp/simple.el > +++ b/lisp/simple.el > @@ -2020,8 +2020,10 @@ read-extended-command > ;; Has a current-name. > (functionp (car obsolete)) > ;; when >= emacs-major-version > - (>= (car (version-to-list (caddr obsolete))) > - emacs-major-version)))))) > + (condition-case nil > + (>= (car (version-to-list (caddr obsolete))) > + emacs-major-version) > + (t nil))))))) > pred))) > (complete-with-action action obarray string pred)))) > --8<---------------cut here---------------end--------------->8--- > > which does the trick. Thanks, I think this should be installed unless someone comes up with a better idea (but see below). > Should I write bug reports for Magit and Yasnippets so that they should > only specify the version number in `make-obsolete' / > `make-obsolete-variable'? Or should emacs support the " > " syntax? I don't think we will support the deviant syntax in version-to-list, no. But I don't really understand why we compare versions in the snippet above -- the command is already established as being obsolete, so we've got to be running an Emacs version where it is indeed obsolete, and the version text sounds redundant to me. Stefan? If we remove the version check, the problem with 3rd-party packages will be automatically resolved. Otherwise, I don't think we can solve this except by ignoring those non-Emacs versions, because there's no way for us to know whether, e.g., "Magit 3.0.0" is older or newer that Emacs whose version is emacs-major-version. IOW, if we insist on checking the version, AFAIU this feature cannot possibly work for obsolete commands from 3rd-party packages, they will always be included in completion lists. From debbugs-submit-bounces@debbugs.gnu.org Fri May 14 03:28:26 2021 Received: (at 48404) by debbugs.gnu.org; 14 May 2021 07:28:26 +0000 Received: from localhost ([127.0.0.1]:44850 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhSFF-0007KK-Pu for submit@debbugs.gnu.org; Fri, 14 May 2021 03:28:25 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55494) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhSFD-0007K4-NV for 48404@debbugs.gnu.org; Fri, 14 May 2021 03:28:24 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45326) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhSF8-00056F-B8; Fri, 14 May 2021 03:28:18 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2652 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhSF6-0001Zg-Lv; Fri, 14 May 2021 03:28:17 -0400 Date: Fri, 14 May 2021 10:28:30 +0300 Message-Id: <83a6oxzsdd.fsf@gnu.org> From: Eli Zaretskii To: tsdh@gnu.org In-Reply-To: <83czttzstr.fsf@gnu.org> (message from Eli Zaretskii on Fri, 14 May 2021 10:18:40 +0300) Subject: Re: bug#48404: 28.0.50; "Invalid version syntax" errors with read-extended-command References: <875yzms6im.fsf@gnu.org> <83wns1zvhs.fsf@gnu.org> <871ra9kdgs.fsf@gnu.org> <83czttzstr.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48404 Cc: 48404@debbugs.gnu.org, stefan@marxist.se X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Fri, 14 May 2021 10:18:40 +0300 > From: Eli Zaretskii > Cc: 48404@debbugs.gnu.org, stefan@marxist.se > > But I don't really understand why we compare versions in the snippet > above -- the command is already established as being obsolete, so > we've got to be running an Emacs version where it is indeed obsolete, > and the version text sounds redundant to me. Stefan? ^^^^ Should be "test", sorry. My fingers sometimes think they know better... From debbugs-submit-bounces@debbugs.gnu.org Fri May 14 03:35:49 2021 Received: (at control) by debbugs.gnu.org; 14 May 2021 07:35:49 +0000 Received: from localhost ([127.0.0.1]:44881 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhSMP-0007Xl-8D for submit@debbugs.gnu.org; Fri, 14 May 2021 03:35:49 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56756) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhSMO-0007XW-6H; Fri, 14 May 2021 03:35:48 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45470) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhSMG-0001AJ-Bo; Fri, 14 May 2021 03:35:41 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3101 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhSME-0003Pm-BR; Fri, 14 May 2021 03:35:40 -0400 Date: Fri, 14 May 2021 10:35:51 +0300 Message-Id: <838s4hzs14.fsf@gnu.org> From: Eli Zaretskii To: Daniel Mendler In-Reply-To: (message from Daniel Mendler on Fri, 14 May 2021 09:22:43 +0200) Subject: Re: bug#48410: 28.0.50; M-x is broken since 1af91d271e077134e272055407fb8c4312a7579b References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control Cc: stefan@marxist.se, larsi@gnus.org, 48410@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) merge 48410 48404 thanks > From: Daniel Mendler > Date: Fri, 14 May 2021 09:22:43 +0200 > Cc: larsi@gnus.org, stefan@marxist.se > > Load a package like so-long, then press M-x TAB. I observe an error > "Invalid version syntax: `so-long 1.0` must start with a number. The > error occurs within `all-completions` and is probably due to the > predicate modified in 1af91d271e077134e272055407fb8c4312a7579b. > > Original bug report: https://github.com/minad/vertico/issues/31 This is a duplicate of bug#48404, which was filed a few hours ago. See there for relevant discussions. From debbugs-submit-bounces@debbugs.gnu.org Fri May 14 03:41:46 2021 Received: (at 48404) by debbugs.gnu.org; 14 May 2021 07:41:46 +0000 Received: from localhost ([127.0.0.1]:44892 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhSSA-0007hJ-4l for submit@debbugs.gnu.org; Fri, 14 May 2021 03:41:46 -0400 Received: from quimby.gnus.org ([95.216.78.240]:51116) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhSS7-0007h4-3E for 48404@debbugs.gnu.org; Fri, 14 May 2021 03:41:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=lAwX/Ye6pSfJExhuio+ICf66r9MjKX7ZIchwCEqjfLk=; b=Do3uqwajNgZ8/Q7UPMd5hFbNlY Ir2uZsAwR+2/t+J4gcrej6BdNeBruA/DipLvRQTN+ZbPVE+0vwDuQnBsTrlQ7jY5bE8b2st5qr11V pkkzX/9mNs1PVYP1EzQSP5QqGln/8Krx4Ek55YsTd9zULyC03KuhgVwXHv3ceUJUScew=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lhSRx-0000b8-TB; Fri, 14 May 2021 09:41:36 +0200 From: Lars Ingebrigtsen To: Tassilo Horn Subject: Re: bug#48404: 28.0.50; "Invalid version syntax" errors with read-extended-command References: <875yzms6im.fsf@gnu.org> <83wns1zvhs.fsf@gnu.org> <871ra9kdgs.fsf@gnu.org> X-Now-Playing: Sudan Archives's _Athena_: "Coming Up" Date: Fri, 14 May 2021 09:41:33 +0200 In-Reply-To: <871ra9kdgs.fsf@gnu.org> (Tassilo Horn's message of "Fri, 14 May 2021 08:47:32 +0200") Message-ID: <871ra9oj82.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Tassilo Horn writes: > I've tried this [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 48404 Cc: Eli Zaretskii , 48404@debbugs.gnu.org, stefan@marxist.se X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Tassilo Horn writes: > I've tried this [...] > - (>= (car (version-to-list (caddr obsolete))) > - emacs-major-version)))))) > + (condition-case nil > + (>= (car (version-to-list (caddr obsolete))) > + emacs-major-version) > + (t nil))))))) Yes, I think this is the right solution. (Or just `ignore-errors'.) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri May 14 03:43:47 2021 Received: (at 48404) by debbugs.gnu.org; 14 May 2021 07:43:47 +0000 Received: from localhost ([127.0.0.1]:44896 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhSU7-0007kE-Gl for submit@debbugs.gnu.org; Fri, 14 May 2021 03:43:47 -0400 Received: from quimby.gnus.org ([95.216.78.240]:51136) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhSU6-0007k2-7M for 48404@debbugs.gnu.org; Fri, 14 May 2021 03:43:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=b9EVNHsd+Bv4wQdF36cCFpKPaqis25TlFy3ywzA/mTM=; b=mfxvDIQ+nOcEHfN5tEXQSMuqkR zB1180x+NU+F4mzYV3EmytPzbzCYDMk1e5nc+dwWBwJWtc7uPjWY+4+N3Qs2TF0TFu4Fw06LvgJwP B39e2IwAgKJDICs+K+rcSQqS7TxRMSGbeE5jiwEoIQs7EPp/w7ek4tdMbY9MmwjMHqc8=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lhSTy-0000bv-9q; Fri, 14 May 2021 09:43:40 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#48404: 28.0.50; "Invalid version syntax" errors with read-extended-command References: <875yzms6im.fsf@gnu.org> <83wns1zvhs.fsf@gnu.org> <871ra9kdgs.fsf@gnu.org> <83czttzstr.fsf@gnu.org> X-Now-Playing: Sudan Archives's _Athena_: "Coming Up" Date: Fri, 14 May 2021 09:43:37 +0200 In-Reply-To: <83czttzstr.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 14 May 2021 10:18:40 +0300") Message-ID: <87wns1n4k6.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > But I don't really understand why we compare versions in the snippet > above -- the command is already established as being obsolete, so > we've got to be running an Emacs version where it is indeed [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 48404 Cc: 48404@debbugs.gnu.org, stefan@marxist.se, Tassilo Horn X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > But I don't really understand why we compare versions in the snippet > above -- the command is already established as being obsolete, so > we've got to be running an Emacs version where it is indeed obsolete, > and the version text sounds redundant to me. Stefan? The idea is to have a softer transition when obsoleting commands -- `M-x some-obsoleteTAB' will list the command if it's been "recently" obsoleted, but also list the new command name (in parentheses). This will hopefully help people to learn the new command name. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri May 14 03:50:56 2021 Received: (at 48404) by debbugs.gnu.org; 14 May 2021 07:50:56 +0000 Received: from localhost ([127.0.0.1]:44937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhSb1-0001es-TA for submit@debbugs.gnu.org; Fri, 14 May 2021 03:50:56 -0400 Received: from server.qxqx.de ([178.63.65.180]:60883 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhSay-0001eb-J8 for 48404@debbugs.gnu.org; Fri, 14 May 2021 03:50:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Date: Message-ID:Subject:From:To:Sender:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=FqimoSWBudEVkpt4/R/k63YyDWK0W9b3tfds2ufzfzI=; b=e3kEOAvnfr+ZoYwKxna7XwK5+s 2wW209moWfIy91CLpuZw83iuIp5r//2J1c9Z0A2VBOn2ojKr0c9o26bIEiWojTwKvn8M9d7xAzspo BZprTasMgqSyNplteLtEhnFpVlf2k93xc0j3+v9yEZvuwmgysmBQhF9yxNC2fy1CDLts=; To: 48404@debbugs.gnu.org From: Daniel Mendler Subject: Re: bug#48404 Message-ID: <52744ef2-304f-b037-2fae-2f97d6732b38@daniel-mendler.de> Date: Fri, 14 May 2021 09:50:45 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48404 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) If the check does not work reliably for third-party packages, it should probably better reverted altogether. Why slap an ignore-errors around the broken code now? According to the commit message, which introduced this bug, there has been some alternative solution, which clearly sounds better: Either omit obsolete commands altogether or annotate them as obsolete. Omitting is probably too problematic since people may rely on running obsolete commands. What about making the behavior around obsolete commands a customizable option? 1. omit obsolete commands, 2. annotate obsolete commands, 3. do nothing. From debbugs-submit-bounces@debbugs.gnu.org Fri May 14 03:56:12 2021 Received: (at 48404) by debbugs.gnu.org; 14 May 2021 07:56:12 +0000 Received: from localhost ([127.0.0.1]:44941 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhSg8-0001mb-Fz for submit@debbugs.gnu.org; Fri, 14 May 2021 03:56:12 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60700) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhSg3-0001mJ-6l for 48404@debbugs.gnu.org; Fri, 14 May 2021 03:56:10 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45796) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhSfx-0006mb-9y; Fri, 14 May 2021 03:56:01 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4434 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhSfw-0005DV-HV; Fri, 14 May 2021 03:56:00 -0400 Date: Fri, 14 May 2021 10:56:12 +0300 Message-Id: <835yzlzr37.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-Reply-To: <87wns1n4k6.fsf@gnus.org> (message from Lars Ingebrigtsen on Fri, 14 May 2021 09:43:37 +0200) Subject: Re: bug#48404: 28.0.50; "Invalid version syntax" errors with read-extended-command References: <875yzms6im.fsf@gnu.org> <83wns1zvhs.fsf@gnu.org> <871ra9kdgs.fsf@gnu.org> <83czttzstr.fsf@gnu.org> <87wns1n4k6.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48404 Cc: 48404@debbugs.gnu.org, stefan@marxist.se, tsdh@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Cc: Tassilo Horn , 48404@debbugs.gnu.org, stefan@marxist.se > Date: Fri, 14 May 2021 09:43:37 +0200 > > Eli Zaretskii writes: > > > But I don't really understand why we compare versions in the snippet > > above -- the command is already established as being obsolete, so > > we've got to be running an Emacs version where it is indeed obsolete, > > and the version text sounds redundant to me. Stefan? > > The idea is to have a softer transition when obsoleting commands -- `M-x > some-obsoleteTAB' will list the command if it's been "recently" > obsoleted, but also list the new command name (in parentheses). This > will hopefully help people to learn the new command name. But this comes with a heavy price: commands from any package that is not bundled with Emacs will not be able to take advantage of this feature, ever. Is it worth punishing those packages' users to have a softer transition? Given our conservative approach to obsoleting stuff, I'm not sure. From debbugs-submit-bounces@debbugs.gnu.org Fri May 14 12:45:38 2021 Received: (at 48404) by debbugs.gnu.org; 14 May 2021 16:45:38 +0000 Received: from localhost ([127.0.0.1]:46937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhawT-0005ES-Sx for submit@debbugs.gnu.org; Fri, 14 May 2021 12:45:38 -0400 Received: from mail-pg1-f179.google.com ([209.85.215.179]:41580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhawR-0005EA-FT for 48404@debbugs.gnu.org; Fri, 14 May 2021 12:45:36 -0400 Received: by mail-pg1-f179.google.com with SMTP id t30so3158482pgl.8 for <48404@debbugs.gnu.org>; Fri, 14 May 2021 09:45:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ihzJ8GlAB16khCyEsNJTpoNAcaVobZN3X07uL6d2Pec=; b=nZGg0l0ufvtKtyvTexUbdMrg3CswaqJFdHnzsCab2YgfoRNor4JSolyC/SnQM9g0qN xZVar/JvSJlvhs4LSMFdeWoz3EGo4WciXomdqQ7ttoyk4ebN0e5o7VN4VFa1Uf61l7Vb LX4KgR6s8gGAGKDUR6c9OwemyeTBio9FHUWuaHytAL1ERt34zNjCtk6Z1Rn9zc+Q1xww yRJeKaOApxlWDzujYr4b2ADPZx25rtFR/DK5GWvdAx0hhsJDHqVQvymbec+1MAE/KePK nWvD2DtRvbSi+p+MzhYTCz630pzYlLYZqWICmhJ0lfgqfJY30WRa9J2N/kLIi6iNfDYk AUFw== X-Gm-Message-State: AOAM533x96tKRjPlPfdeDMEWfD10jrarzSyLWLDMMyKazAjMaEtARGCi PvFZ1hDsMTnaFtiI8tmhmJ63j9rBU1rMtyjYfTxQGIgT X-Google-Smtp-Source: ABdhPJwDoTfEZHCjlpx7dpuRuoSoiTLYTEjXouVWYwsgfI0zgRJ3YY76wJyq+jOiA/bkGclQ3mhpxWhBA9QeUAunUvQ= X-Received: by 2002:a63:e4a:: with SMTP id 10mr34510761pgo.67.1621010729555; Fri, 14 May 2021 09:45:29 -0700 (PDT) MIME-Version: 1.0 References: <875yzms6im.fsf@gnu.org> <83wns1zvhs.fsf@gnu.org> In-Reply-To: <83wns1zvhs.fsf@gnu.org> From: Stefan Kangas Date: Fri, 14 May 2021 18:45:16 +0200 Message-ID: Subject: Re: bug#48404: 28.0.50; "Invalid version syntax" errors with read-extended-command To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 48404 Cc: 48404@debbugs.gnu.org, Tassilo Horn X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Eli Zaretskii writes: > > Since commit 1af91d271e077134e272055407fb8c4312a7579b I get strange > > "Invalid version syntax: (must start with a number)= " > > errors during M-x completion in the minibuffer. I can't reproduce with > > emacs -Q but in the error, is always some (M)ELPA package. > > > > For example, M-x mag TAB gives > > > > completion--some: Invalid version syntax: =E2=80=98Magit 3.0.0=E2=80= =99 (must start with a number) > > That commit uses byte-obsolete-info property of a symbol, and expects > its caddr to be a valid version number. It sounds like in some cases > it is not an Emacs version, but something else. So, questions: > > . can you find out what kind of value does the byte-obsolete-info > property is there on Magit functions? and > . how come these properties were added to something that is not an > Emacs core code? > > In any case, it sounds like blindly trusting the value of that > property is not a good idea, and we should wrap the call to > version-to-list there in condition-case. Could you try that? The timing for Lars pushing my patch was a bit unfortunate, as I'm currently away traveling and won't have any time to look at this in the next week or two at least. I unfortunately didn't say so in the relevant bug thread, but I hadn't yet convinced myself that the patch was the correct one, and had the intention of returning to it for a closer look before pushing. If any immediate issues can be resolved, this is on my todo list and I will take a look at this when I'm back home. It would also be fine to just revert my patch for now and re-open the bug report. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri May 14 12:51:22 2021 Received: (at 48404) by debbugs.gnu.org; 14 May 2021 16:51:22 +0000 Received: from localhost ([127.0.0.1]:46941 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhb22-0005Mp-Ij for submit@debbugs.gnu.org; Fri, 14 May 2021 12:51:22 -0400 Received: from quimby.gnus.org ([95.216.78.240]:55892) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhb1y-0005MZ-BB for 48404@debbugs.gnu.org; Fri, 14 May 2021 12:51:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=dZqnCbZ7qRm923G2LKl65oNPKfh1na5HAvGFptpI8d0=; b=oBxP5ozLBWcUIE6d+2nwRRhBJY 6rQHiS1Zrjme5K68pp7S3O5p+WkrKKbDNEpzU1VTwbIyfbhztAeMmkmwg8TCpNbKHDPNEYgyaLVOY vWMwngHq89jxK7XXyg2DPVnt0juvpGD3PmubGBwK44Fgeg7nSQjPsrYLRiGclQWRWm2U=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lhb1p-0005hs-Dq; Fri, 14 May 2021 18:51:11 +0200 From: Lars Ingebrigtsen To: Stefan Kangas Subject: Re: bug#48404: 28.0.50; "Invalid version syntax" errors with read-extended-command References: <875yzms6im.fsf@gnu.org> <83wns1zvhs.fsf@gnu.org> X-Now-Playing: Sam Amidon's _Bright Sunny South_: "Bright Sunny South" Date: Fri, 14 May 2021 18:51:08 +0200 In-Reply-To: (Stefan Kangas's message of "Fri, 14 May 2021 18:45:16 +0200") Message-ID: <87sg2pmf7n.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Kangas writes: > If any immediate issues can be resolved, this is on my todo list and I > will take a look at this when I'm back home. It would also be fine to > just revert my patch for now and re-open the bug repo [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 48404 Cc: Eli Zaretskii , 48404@debbugs.gnu.org, Tassilo Horn X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Kangas writes: > If any immediate issues can be resolved, this is on my todo list and I > will take a look at this when I'm back home. It would also be fine to > just revert my patch for now and re-open the bug report. No prob -- I've pushed a fix that should stop `M-x' bugging out on invalid versions strings now. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri May 14 14:31:11 2021 Received: (at 48404) by debbugs.gnu.org; 14 May 2021 18:31:11 +0000 Received: from localhost ([127.0.0.1]:47035 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhcad-000810-82 for submit@debbugs.gnu.org; Fri, 14 May 2021 14:31:11 -0400 Received: from server.qxqx.de ([178.63.65.180]:36227 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhcab-00080e-Bj for 48404@debbugs.gnu.org; Fri, 14 May 2021 14:31:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Date: Message-ID:Subject:From:Cc:To:Sender:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=hJMc1zpDjdnLq++8BsTJLE1HBAjLizSkXgCocMtEmlA=; b=UnCQHu2fg+10aotpNgUSK7ixtW 0vxw9ORZhDRs+fVUnNRoz+IjU9NnmzQLJgZdnG5aGJgH4Z60TdJi9eNiuqr8Z08TwOgjQXjt4BLM1 Io4uDJhWD/sotMrITdULdQdJM1Y2fIXa+kcnaoS2lGGrT+7b4mIqyOFFLObsxrCuDLgM=; To: 48404@debbugs.gnu.org From: Daniel Mendler Subject: Re: bug#48404 Message-ID: <5bb442e3-00f1-752e-eb9e-51dea78b17bd@daniel-mendler.de> Date: Fri, 14 May 2021 20:31:01 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48404 Cc: larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Why not revert the broken M-x predicate until a better solution is found? For example as I mentioned adding an option which allows to customize the treatment of obsolete commands (hide, annotate, keep). It looks like the solution we got now is suboptimal: 1. The version check does not work for third-party packages, it does not even work for packages which are part of Emacs (so-long). 2. Since the version check is broken, an `ignore-errors` wrapper is needed. 3. The behavior is not customizable, some users may prefer to hide obsolete commands altogether, some would like to see an annotation and some would like to keep the obsolete commands in M-x. Daniel From debbugs-submit-bounces@debbugs.gnu.org Sun May 16 10:06:14 2021 Received: (at 48404) by debbugs.gnu.org; 16 May 2021 14:06:14 +0000 Received: from localhost ([127.0.0.1]:51113 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1liHPK-0002Aj-Gk for submit@debbugs.gnu.org; Sun, 16 May 2021 10:06:14 -0400 Received: from quimby.gnus.org ([95.216.78.240]:47316) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1liHPI-0002AX-S9 for 48404@debbugs.gnu.org; Sun, 16 May 2021 10:06:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=k2UJLvlaFQ7SG0lVHXe6hF9pvJXwoNHLb77gulTfcEU=; b=bNUbpibzYdhnK2RSbFnP2Kw4sD RT2WN64LRnTyEMYLebzgXfqTj9nEhP+Uvea92gHFgfu+R23qaAB+ZHywQE5qiCGd9lH/CT56ARbuo jpPYvpUiQQGdWnDmroRwcL0kTmTFIBaVtnf010KJ6egmJR5fxZDxPKmzk4LIMsxFfueY=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1liHPA-0007fF-3b; Sun, 16 May 2021 16:06:06 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#48404: 28.0.50; "Invalid version syntax" errors with read-extended-command References: <875yzms6im.fsf@gnu.org> <83wns1zvhs.fsf@gnu.org> <871ra9kdgs.fsf@gnu.org> <83czttzstr.fsf@gnu.org> <87wns1n4k6.fsf@gnus.org> <835yzlzr37.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAIVBMVEUxLCgiHRlhXFdD Pjr19PDEwbuGgnumo53W1M6AfHb///9QeSwYAAAAAWJLR0QKaND0VgAAAAd0SU1FB+UFEA01Ekv0 2NMAAAGoSURBVDjLjZO9b9swEMVPUlJ5lB0IWkWLjNVNdm1UY6BQpUZ/yBCyuV2ySi0Fc3Qlu1TG Fh3y5zZLhpAskBvvh3ePdw8EeK0xmMuKPDOaULQwAnu5KdemSd9IPWOGYTe0gHFFkAaCnoeW4Jmn gWZUW5UnNeAjcj/pvUgf9dstxBo0AfhNm8pe78OoOo1v8pdnq+CKItHhtWfPlf0I/S676xpdKQDc B2YFxeUuDlXzwzlvT885blQFXMRs02KuAoDM8vv2mmrXcvLH0V25yPU8KFudyvlB29GZgrv7ZUtt w5f6QDK/cCNVkyLM8zRfUnUTHOIhJyzCGwX8PZDzQKpOfH3bT3iYDlxyShNFwUMSiww3WPNAf+JZ N2o+K69ylrKeRlgUvbL4eTt8Sh7Jdq8cyz0ev/iodRtLmbSw7BLX+9UPxdniefgssjJVHADkfpBb MSxPSn/y06/YE85WawUELJ4fWdC4WuRUJAsW7xwti/AWjtNLZkgpQJVtSg/wbh/L0AAkG0R50PvO PR8600e3GWbsNtHBhAVbykyKJw8+mrwhgf+W8z7wD1jTW5FlsOchAAAAJXRFWHRkYXRlOmNyZWF0 ZQAyMDIxLTA1LTE2VDEzOjUzOjE4KzAwOjAwtOn5LwAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMS0w NS0xNlQxMzo1MzoxOCswMDowMMW0QZMAAAAASUVORK5CYII= X-Now-Playing: Rocketnumbernine's _Meyouweyou_: "Slide" Date: Sun, 16 May 2021 16:06:03 +0200 In-Reply-To: <835yzlzr37.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 14 May 2021 10:56:12 +0300") Message-ID: <87cztqojsk.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: >> The idea is to have a softer transition when obsoleting commands -- `M-x >> some-obsoleteTAB' will list the command if it's been "recently" >> obsoleted, but also list the new command name (in pare [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 48404 Cc: 48404@debbugs.gnu.org, stefan@marxist.se, tsdh@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> The idea is to have a softer transition when obsoleting commands -- `M-x >> some-obsoleteTAB' will list the command if it's been "recently" >> obsoleted, but also list the new command name (in parentheses). This >> will hopefully help people to learn the new command name. > > But this comes with a heavy price: commands from any package that is > not bundled with Emacs will not be able to take advantage of this > feature, ever. Is it worth punishing those packages' users to have a > softer transition? Given our conservative approach to obsoleting > stuff, I'm not sure. I'm not quite sure I understand you here? If the version can't be parsed, then the command will still show up in `M-x TAB', which means that the obsoletion of these commands is very soft indeed. But I'm wondering whether `version-to-list' should be more lax here. That is, currently it'll barf of things like: (version-to-list "28.1 Magit/2.5") It might make sense to allow the obsoletion versions to refer to both an (approximate) Emacs version, as well as a package version. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun May 16 10:09:13 2021 Received: (at 48404) by debbugs.gnu.org; 16 May 2021 14:09:13 +0000 Received: from localhost ([127.0.0.1]:51272 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1liHSD-0002S4-L6 for submit@debbugs.gnu.org; Sun, 16 May 2021 10:09:13 -0400 Received: from quimby.gnus.org ([95.216.78.240]:47392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1liHSB-0002Rr-PI for 48404@debbugs.gnu.org; Sun, 16 May 2021 10:09:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=zjY6/W9g0aP9WKMEYTcx5OrL8Dwp0t9rKlIAMV5hqSA=; b=W2DgjX9cyi5K+gD9RBQOT11XGM hZzpx1u0IDU+qmo6B+CIsx7HHO9ZqtvJpQhhJipxDqxb92hlgNYCtkvcjPPwbqEk1hN5J205fWKEW msSo3Xc86GacJ5Hl/Qb7wZV57a/9zld/NpGD3xhOH31SDk4A08ZUTCg2z7KXcWO/A9Yc=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1liHS3-0007g4-SQ; Sun, 16 May 2021 16:09:06 +0200 From: Lars Ingebrigtsen To: Daniel Mendler Subject: Re: bug#48404 References: <5bb442e3-00f1-752e-eb9e-51dea78b17bd@daniel-mendler.de> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAIVBMVEUxLCgiHRlhXFdD Pjr19PDEwbuGgnumo53W1M6AfHb///9QeSwYAAAAAWJLR0QKaND0VgAAAAd0SU1FB+UFEA01Ekv0 2NMAAAGoSURBVDjLjZO9b9swEMVPUlJ5lB0IWkWLjNVNdm1UY6BQpUZ/yBCyuV2ySi0Fc3Qlu1TG Fh3y5zZLhpAskBvvh3ePdw8EeK0xmMuKPDOaULQwAnu5KdemSd9IPWOGYTe0gHFFkAaCnoeW4Jmn gWZUW5UnNeAjcj/pvUgf9dstxBo0AfhNm8pe78OoOo1v8pdnq+CKItHhtWfPlf0I/S676xpdKQDc B2YFxeUuDlXzwzlvT885blQFXMRs02KuAoDM8vv2mmrXcvLH0V25yPU8KFudyvlB29GZgrv7ZUtt w5f6QDK/cCNVkyLM8zRfUnUTHOIhJyzCGwX8PZDzQKpOfH3bT3iYDlxyShNFwUMSiww3WPNAf+JZ N2o+K69ylrKeRlgUvbL4eTt8Sh7Jdq8cyz0ev/iodRtLmbSw7BLX+9UPxdniefgssjJVHADkfpBb MSxPSn/y06/YE85WawUELJ4fWdC4WuRUJAsW7xwti/AWjtNLZkgpQJVtSg/wbh/L0AAkG0R50PvO PR8600e3GWbsNtHBhAVbykyKJw8+mrwhgf+W8z7wD1jTW5FlsOchAAAAJXRFWHRkYXRlOmNyZWF0 ZQAyMDIxLTA1LTE2VDEzOjUzOjE4KzAwOjAwtOn5LwAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMS0w NS0xNlQxMzo1MzoxOCswMDowMMW0QZMAAAAASUVORK5CYII= X-Now-Playing: Rocketnumbernine's _Meyouweyou_: "Steel Drummer" Date: Sun, 16 May 2021 16:09:03 +0200 In-Reply-To: <5bb442e3-00f1-752e-eb9e-51dea78b17bd@daniel-mendler.de> (Daniel Mendler's message of "Fri, 14 May 2021 20:31:01 +0200") Message-ID: <8735umojnk.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Daniel Mendler writes: > 3. The behavior is not customizable, some users may prefer to hide > obsolete commands altogether, some would like to see an annotation and > some would like to keep the obsolete commands in M-x. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 48404 Cc: 48404@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Daniel Mendler writes: > 3. The behavior is not customizable, some users may prefer to hide > obsolete commands altogether, some would like to see an annotation and > some would like to keep the obsolete commands in M-x. Yes, it might make sense to allow `read-extended-command-predicate' to be a list of predicates, and this obsoletion predicate might be in that list by default. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun May 16 10:10:41 2021 Received: (at control) by debbugs.gnu.org; 16 May 2021 14:10:41 +0000 Received: from localhost ([127.0.0.1]:51276 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1liHTc-0002Up-Ve for submit@debbugs.gnu.org; Sun, 16 May 2021 10:10:41 -0400 Received: from quimby.gnus.org ([95.216.78.240]:47438) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1liHTb-0002Ua-AI for control@debbugs.gnu.org; Sun, 16 May 2021 10:10:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=UOp94TvucXFqMrDrbkfImyUT/NmLjNkR46WkkJOPQPI=; b=rsK4VkG7xG9ooiTllGYyB5PZdZ XrpHWFV0OVjX+QlX5+KLiTBQ3mvo4OqL8Rm4hwll7M7529VFlOq5OFHtSR4PC3aI1LYVA6gQCA/QB vRDzbJP4MM8JoyA0nBio5LVG0JzRX9/dZ4IO9MAbg3ySfoGEhC4cjdftthe3IGgYddus=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1liHTT-0007hb-LL for control@debbugs.gnu.org; Sun, 16 May 2021 16:10:33 +0200 Date: Sun, 16 May 2021 16:10:31 +0200 Message-Id: <87zgwun50o.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #48410 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 48410 fixed close 48410 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 48410 fixed close 48410 28.1 quit From debbugs-submit-bounces@debbugs.gnu.org Sun May 16 10:27:29 2021 Received: (at 48404) by debbugs.gnu.org; 16 May 2021 14:27:29 +0000 Received: from localhost ([127.0.0.1]:51293 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1liHjt-00055J-In for submit@debbugs.gnu.org; Sun, 16 May 2021 10:27:29 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44130) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1liHjr-000557-V2 for 48404@debbugs.gnu.org; Sun, 16 May 2021 10:27:28 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50638) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1liHjm-0001PQ-CH; Sun, 16 May 2021 10:27:22 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1828 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liHjk-0003sO-3K; Sun, 16 May 2021 10:27:20 -0400 Date: Sun, 16 May 2021 17:27:19 +0300 Message-Id: <835yzivjnc.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-Reply-To: <87cztqojsk.fsf@gnus.org> (message from Lars Ingebrigtsen on Sun, 16 May 2021 16:06:03 +0200) Subject: Re: bug#48404: 28.0.50; "Invalid version syntax" errors with read-extended-command References: <875yzms6im.fsf@gnu.org> <83wns1zvhs.fsf@gnu.org> <871ra9kdgs.fsf@gnu.org> <83czttzstr.fsf@gnu.org> <87wns1n4k6.fsf@gnus.org> <835yzlzr37.fsf@gnu.org> <87cztqojsk.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48404 Cc: 48404@debbugs.gnu.org, stefan@marxist.se, tsdh@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Cc: tsdh@gnu.org, 48404@debbugs.gnu.org, stefan@marxist.se > Date: Sun, 16 May 2021 16:06:03 +0200 > > > But this comes with a heavy price: commands from any package that is > > not bundled with Emacs will not be able to take advantage of this > > feature, ever. Is it worth punishing those packages' users to have a > > softer transition? Given our conservative approach to obsoleting > > stuff, I'm not sure. > > I'm not quite sure I understand you here? If the version can't be > parsed, then the command will still show up in `M-x TAB', which means > that the obsoletion of these commands is very soft indeed. For obsolete commands from 3rd-party packages, which state something like "Magit 3.0" in the version since which they are obsolete, the obsolescence will never happen, in the sense that they will _always_ appear in "M-x TAB", even 100 years from now. Is that what we want? > But I'm wondering whether `version-to-list' should be more lax here. > That is, currently it'll barf of things like: > > (version-to-list "28.1 Magit/2.5") I'm not sure it's possible without introducing ambiguity into the version string and complicating comparison of versions. We already support some non-numeric versions, and that's not easy. > It might make sense to allow the obsoletion versions to refer to both an > (approximate) Emacs version, as well as a package version. How can this be done, even in principle? Versions of unbundled packages are unrelated to Emacs versions; typically, a given version of an unbundled package supports quite a few Emacs versions. So what Emacs version will you put there? From debbugs-submit-bounces@debbugs.gnu.org Sun May 16 10:39:10 2021 Received: (at 48404) by debbugs.gnu.org; 16 May 2021 14:39:10 +0000 Received: from localhost ([127.0.0.1]:51326 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1liHvC-0005Pb-13 for submit@debbugs.gnu.org; Sun, 16 May 2021 10:39:10 -0400 Received: from quimby.gnus.org ([95.216.78.240]:47764) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1liHvA-0005PO-Fs for 48404@debbugs.gnu.org; Sun, 16 May 2021 10:39:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=hEhROE5UaAmz/UQ00iiuC5uMT6sU8xpyT6rGkXkhrZE=; b=Faojl4YbpWNVHa3lK1ZCrLJFR1 CJaEMfsyrJrdZB7X6U6xB6PvvzeywA4LLIKMCE4gZxWlrsCybhpj875MiX6ffkWItjSDC0KgOEhKj pEphhQEYBPlHMcsd9U98SAsBNP0H0/e7zSmrlpHa99i3VBQZW8sAWk1TCRHj4d0M20VY=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1liHv1-0007tQ-P1; Sun, 16 May 2021 16:39:02 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#48404: 28.0.50; "Invalid version syntax" errors with read-extended-command References: <875yzms6im.fsf@gnu.org> <83wns1zvhs.fsf@gnu.org> <871ra9kdgs.fsf@gnu.org> <83czttzstr.fsf@gnu.org> <87wns1n4k6.fsf@gnus.org> <835yzlzr37.fsf@gnu.org> <87cztqojsk.fsf@gnus.org> <835yzivjnc.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAIVBMVEUxLCgiHRlhXFdD Pjr19PDEwbuGgnumo53W1M6AfHb///9QeSwYAAAAAWJLR0QKaND0VgAAAAd0SU1FB+UFEA01Ekv0 2NMAAAGoSURBVDjLjZO9b9swEMVPUlJ5lB0IWkWLjNVNdm1UY6BQpUZ/yBCyuV2ySi0Fc3Qlu1TG Fh3y5zZLhpAskBvvh3ePdw8EeK0xmMuKPDOaULQwAnu5KdemSd9IPWOGYTe0gHFFkAaCnoeW4Jmn gWZUW5UnNeAjcj/pvUgf9dstxBo0AfhNm8pe78OoOo1v8pdnq+CKItHhtWfPlf0I/S676xpdKQDc B2YFxeUuDlXzwzlvT885blQFXMRs02KuAoDM8vv2mmrXcvLH0V25yPU8KFudyvlB29GZgrv7ZUtt w5f6QDK/cCNVkyLM8zRfUnUTHOIhJyzCGwX8PZDzQKpOfH3bT3iYDlxyShNFwUMSiww3WPNAf+JZ N2o+K69ylrKeRlgUvbL4eTt8Sh7Jdq8cyz0ev/iodRtLmbSw7BLX+9UPxdniefgssjJVHADkfpBb MSxPSn/y06/YE85WawUELJ4fWdC4WuRUJAsW7xwti/AWjtNLZkgpQJVtSg/wbh/L0AAkG0R50PvO PR8600e3GWbsNtHBhAVbykyKJw8+mrwhgf+W8z7wD1jTW5FlsOchAAAAJXRFWHRkYXRlOmNyZWF0 ZQAyMDIxLTA1LTE2VDEzOjUzOjE4KzAwOjAwtOn5LwAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMS0w NS0xNlQxMzo1MzoxOCswMDowMMW0QZMAAAAASUVORK5CYII= X-Now-Playing: Rocketnumbernine's _Meyouweyou_: "Lope" Date: Sun, 16 May 2021 16:38:58 +0200 In-Reply-To: <835yzivjnc.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 16 May 2021 17:27:19 +0300") Message-ID: <87cztqn3p9.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > For obsolete commands from 3rd-party packages, which state something > like "Magit 3.0" in the version since which they are obsolete, the > obsolescence will never happen, in the sense that they wil [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 48404 Cc: 48404@debbugs.gnu.org, stefan@marxist.se, tsdh@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > For obsolete commands from 3rd-party packages, which state something > like "Magit 3.0" in the version since which they are obsolete, the > obsolescence will never happen, in the sense that they will _always_ > appear in "M-x TAB", even 100 years from now. Is that what we want? That is what was the case before applying the patch, so it's no change for those commands. >> But I'm wondering whether `version-to-list' should be more lax here. >> That is, currently it'll barf of things like: >> >> (version-to-list "28.1 Magit/2.5") > > I'm not sure it's possible without introducing ambiguity into the > version string and complicating comparison of versions. We already > support some non-numeric versions, and that's not easy. Sorry, I was imprecise here -- I didn't mean that we should change `version-to-list' itself here, but add a new function that's more permissive, just for use in this context. It would basically be something along the lines of (version-to-list (car (split-string string))) >> It might make sense to allow the obsoletion versions to refer to both an >> (approximate) Emacs version, as well as a package version. > > How can this be done, even in principle? Versions of unbundled > packages are unrelated to Emacs versions; typically, a given version > of an unbundled package supports quite a few Emacs versions. So what > Emacs version will you put there? That would be up to the package maintainers -- they get to choose what Emacs version(s) the obsolete command would show up in `M-x TAB' completions. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun May 16 10:48:27 2021 Received: (at 48404) by debbugs.gnu.org; 16 May 2021 14:48:27 +0000 Received: from localhost ([127.0.0.1]:51330 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1liI4A-0007ny-Va for submit@debbugs.gnu.org; Sun, 16 May 2021 10:48:27 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48102) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1liI49-0007nl-A6 for 48404@debbugs.gnu.org; Sun, 16 May 2021 10:48:25 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50940) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1liI43-000610-Qg; Sun, 16 May 2021 10:48:19 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3208 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liI41-0006MY-8K; Sun, 16 May 2021 10:48:19 -0400 Date: Sun, 16 May 2021 17:48:16 +0300 Message-Id: <834kf2viof.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-Reply-To: <87cztqn3p9.fsf@gnus.org> (message from Lars Ingebrigtsen on Sun, 16 May 2021 16:38:58 +0200) Subject: Re: bug#48404: 28.0.50; "Invalid version syntax" errors with read-extended-command References: <875yzms6im.fsf@gnu.org> <83wns1zvhs.fsf@gnu.org> <871ra9kdgs.fsf@gnu.org> <83czttzstr.fsf@gnu.org> <87wns1n4k6.fsf@gnus.org> <835yzlzr37.fsf@gnu.org> <87cztqojsk.fsf@gnus.org> <835yzivjnc.fsf@gnu.org> <87cztqn3p9.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48404 Cc: 48404@debbugs.gnu.org, stefan@marxist.se, tsdh@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Cc: tsdh@gnu.org, 48404@debbugs.gnu.org, stefan@marxist.se > Date: Sun, 16 May 2021 16:38:58 +0200 > > Eli Zaretskii writes: > > > For obsolete commands from 3rd-party packages, which state something > > like "Magit 3.0" in the version since which they are obsolete, the > > obsolescence will never happen, in the sense that they will _always_ > > appear in "M-x TAB", even 100 years from now. Is that what we want? > > That is what was the case before applying the patch, so it's no change > for those commands. No change for the worse, sure. That's what I meant when I said they will not be able to take advantage of this feature. They will be excluded. > >> (version-to-list "28.1 Magit/2.5") > > > > I'm not sure it's possible without introducing ambiguity into the > > version string and complicating comparison of versions. We already > > support some non-numeric versions, and that's not easy. > > Sorry, I was imprecise here -- I didn't mean that we should change > `version-to-list' itself here, but add a new function that's more > permissive, just for use in this context. It would basically be > something along the lines of (version-to-list (car (split-string string))) The main purpose is to compare versions. How would you do that with loose version strings such as the one above? > >> It might make sense to allow the obsoletion versions to refer to both an > >> (approximate) Emacs version, as well as a package version. > > > > How can this be done, even in principle? Versions of unbundled > > packages are unrelated to Emacs versions; typically, a given version > > of an unbundled package supports quite a few Emacs versions. So what > > Emacs version will you put there? > > That would be up to the package maintainers -- they get to choose what > Emacs version(s) the obsolete command would show up in `M-x TAB' > completions. I don't think they will be able to solve this problem, not in satisfactory ways anyway. From debbugs-submit-bounces@debbugs.gnu.org Sun May 16 16:26:19 2021 Received: (at 48404) by debbugs.gnu.org; 16 May 2021 20:26:19 +0000 Received: from localhost ([127.0.0.1]:51575 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1liNL9-00088T-Kp for submit@debbugs.gnu.org; Sun, 16 May 2021 16:26:19 -0400 Received: from server.qxqx.de ([178.63.65.180]:56609 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1liNL8-000889-Et for 48404@debbugs.gnu.org; Sun, 16 May 2021 16:26:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ezluTbC50t7oUnroKcc4PRQedu76QtHQhcunBqWBstk=; b=N57bZTZ4kKon7xbGhmT1MOM8Mr 83yhZ//yJm0V8x5AP+UMzHHpi/NXHBs4GnpoC5elJCNN8msAhbh4hwa9d/wZs5uiHM8HojPr253bk jjpBjL174eRLGe8IElNU+dzomhiwPAfWII1XEyotsAlAhQj0HiQPJZMgvUrI6SlF03W4=; Subject: Re: bug#48404 To: Lars Ingebrigtsen References: <5bb442e3-00f1-752e-eb9e-51dea78b17bd@daniel-mendler.de> <8735umojnk.fsf@gnus.org> From: Daniel Mendler Message-ID: Date: Sun, 16 May 2021 22:26:09 +0200 MIME-Version: 1.0 In-Reply-To: <8735umojnk.fsf@gnus.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48404 Cc: 48404@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 5/16/21 4:09 PM, Lars Ingebrigtsen wrote: > Daniel Mendler writes: > >> 3. The behavior is not customizable, some users may prefer to hide >> obsolete commands altogether, some would like to see an annotation and >> some would like to keep the obsolete commands in M-x. > > Yes, it might make sense to allow `read-extended-command-predicate' to > be a list of predicates, and this obsoletion predicate might be in that > list by default. This sounds like a good resolution of the issue. Thanks! Daniel From debbugs-submit-bounces@debbugs.gnu.org Mon May 17 09:54:58 2021 Received: (at 48404) by debbugs.gnu.org; 17 May 2021 13:54:58 +0000 Received: from localhost ([127.0.0.1]:52118 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lidhy-00020u-8S for submit@debbugs.gnu.org; Mon, 17 May 2021 09:54:58 -0400 Received: from quimby.gnus.org ([95.216.78.240]:57828) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lidht-00020V-5b for 48404@debbugs.gnu.org; Mon, 17 May 2021 09:54:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Z+hc32m/MNzPq44ilZvvF/8oY6FIBr3GCMGzx+t7+fg=; b=FRNPk7Dmv9syd8Gjs/sZRqo5Xx m4Vys1lWdZclJ9hj66GltVtoHoM7dqKc/8yxwGH5g/0W8a8E5FP7CdRRBTbF2KIdYgdLrkh7vV4bT CbBava8rK5pJDrrQoHjcWCtsqMgJ8A8I1eHxUufYfN6MuXY6yV8PkPbH82+40XNmMXwU=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lidhj-0008PM-TF; Mon, 17 May 2021 15:54:46 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#48404: 28.0.50; "Invalid version syntax" errors with read-extended-command References: <875yzms6im.fsf@gnu.org> <83wns1zvhs.fsf@gnu.org> <871ra9kdgs.fsf@gnu.org> <83czttzstr.fsf@gnu.org> <87wns1n4k6.fsf@gnus.org> <835yzlzr37.fsf@gnu.org> <87cztqojsk.fsf@gnus.org> <835yzivjnc.fsf@gnu.org> <87cztqn3p9.fsf@gnus.org> <834kf2viof.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEVIbDtPakO1k4Fh VTidTDe6PjlIUD////+9YGZ5AAAAAWJLR0QHFmGI6wAAAAd0SU1FB+UFEQ01Gv2TN4QAAAGlSURB VDjLdZNBb+sgDMed0fWcbNLOT920c/RMOFcCen5S8D0Trb//R3g27RZIO6tExj//bZNQgG4oBl0/ dEMPALrkMWysl8QOYLgC8cTpb6DXjaxeHtBJKflJrFOnk5guFTyV2ppyLSVpr7p/OUANygCvYwE3 xWoDWIkdDn/uQG+S+zr8/XRtXEexc0ZEXrAhOqNjRp9d2JQCMMwcEPOmuYI3jh5Ll2ND2QY6cekx N2CPuJjMi7i2CuMIGSVoji2IRC57vpVZZ94RUToHrymI4w/orQAKgRajWlqbT6oIRGhDpERjVUr3 wkSaKK0vC2Kk+VKA8EoBONEpS5egzag++TPNbxd/jW9AOp1LPEX6VwE5SYglfZZ2fgXmB+h0qZJE iqEEy+THSiF7H1W0ObtsE9jvgmsTNGikso3JUXNETZl0eSfiaip1n0cwclF2Y/VKCtid3BktLs1d 0DJm5gsFxw0wRYbTzF/cXhL9kB4xyL3zWwApO7m/jHdg3Ctx070EsuMAOR7vCZj32/Bb230oHR+A kv0A7JfyLL783x/brwB+BY/tP0rubGCTDWEYAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIxLTA1LTE3 VDEzOjUzOjI2KzAwOjAwxDEUAAAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMS0wNS0xN1QxMzo1Mzoy NiswMDowMLVsrLwAAAAASUVORK5CYII= X-Now-Playing: Jay Glass Dubs's _Nyx_: "The Controversial Control" Date: Mon, 17 May 2021 15:54:43 +0200 In-Reply-To: <834kf2viof.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 16 May 2021 17:48:16 +0300") Message-ID: <87h7j1lb30.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: >> >> (version-to-list "28.1 Magit/2.5") >> > >> > I'm not sure it's possible without introducing ambiguity into the >> > version string and complicating comparison of versions. We already >> > suppor [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 48404 Cc: 48404@debbugs.gnu.org, stefan@marxist.se, tsdh@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> >> (version-to-list "28.1 Magit/2.5") >> > >> > I'm not sure it's possible without introducing ambiguity into the >> > version string and complicating comparison of versions. We already >> > support some non-numeric versions, and that's not easy. >> >> Sorry, I was imprecise here -- I didn't mean that we should change >> `version-to-list' itself here, but add a new function that's more >> permissive, just for use in this context. It would basically be >> something along the lines of (version-to-list (car (split-string string))) > > The main purpose is to compare versions. How would you do that with > loose version strings such as the one above? We're looking at the Emacs version (which we'd put first in the version string, while the rest is essentially a free text used as a comment). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon May 17 10:10:48 2021 Received: (at 48404) by debbugs.gnu.org; 17 May 2021 14:10:48 +0000 Received: from localhost ([127.0.0.1]:53300 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lidxI-0002hD-Aa for submit@debbugs.gnu.org; Mon, 17 May 2021 10:10:48 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59258) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lidxF-0002gz-5c for 48404@debbugs.gnu.org; Mon, 17 May 2021 10:10:46 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43412) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lidx9-0004Xv-RA; Mon, 17 May 2021 10:10:39 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3367 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lidx8-00041J-QK; Mon, 17 May 2021 10:10:39 -0400 Date: Mon, 17 May 2021 17:10:40 +0300 Message-Id: <83eee5tpr3.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-Reply-To: <87h7j1lb30.fsf@gnus.org> (message from Lars Ingebrigtsen on Mon, 17 May 2021 15:54:43 +0200) Subject: Re: bug#48404: 28.0.50; "Invalid version syntax" errors with read-extended-command References: <875yzms6im.fsf@gnu.org> <83wns1zvhs.fsf@gnu.org> <871ra9kdgs.fsf@gnu.org> <83czttzstr.fsf@gnu.org> <87wns1n4k6.fsf@gnus.org> <835yzlzr37.fsf@gnu.org> <87cztqojsk.fsf@gnus.org> <835yzivjnc.fsf@gnu.org> <87cztqn3p9.fsf@gnus.org> <834kf2viof.fsf@gnu.org> <87h7j1lb30.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48404 Cc: 48404@debbugs.gnu.org, stefan@marxist.se, tsdh@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Cc: tsdh@gnu.org, 48404@debbugs.gnu.org, stefan@marxist.se > Date: Mon, 17 May 2021 15:54:43 +0200 > > >> >> (version-to-list "28.1 Magit/2.5") > >> > > > > > The main purpose is to compare versions. How would you do that with > > loose version strings such as the one above? > > We're looking at the Emacs version (which we'd put first in the version > string, while the rest is essentially a free text used as a comment). What do you mean by "first"? We already support the likes of "28.3 Beta3", and "Beta3" is not ignored there as some free-text comment. And that is assuming the developers of 3rd-party packages can have some reasonable way of associating their versions with Emacs versions, which I still think is a problem with no solution. From debbugs-submit-bounces@debbugs.gnu.org Mon May 17 10:20:42 2021 Received: (at 48404) by debbugs.gnu.org; 17 May 2021 14:20:42 +0000 Received: from localhost ([127.0.0.1]:53322 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lie6o-00057w-Rn for submit@debbugs.gnu.org; Mon, 17 May 2021 10:20:42 -0400 Received: from quimby.gnus.org ([95.216.78.240]:58140) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lie6k-00057c-Co for 48404@debbugs.gnu.org; Mon, 17 May 2021 10:20:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=8TB4AaecVYYZ7hUOUMmf0wgustCj6dqcfzyEV9gUj9U=; b=WEbfUqrimm5NtUnQLburCqVEB1 9WIognWpaVsyVMmCyyEJLFDaajiT5a9c0Wnb2EiEvE7U6/Y6UIAYE7SUg0lyNuO/L2Y9Wokc7eDx4 +iaMuink7gudOf0EAmzfDAbPEM68FoqbwuWuSlQQbsZeHzuc53hWYep3RniM39PSJZiM=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lie6c-0000N2-2I; Mon, 17 May 2021 16:20:28 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#48404: 28.0.50; "Invalid version syntax" errors with read-extended-command References: <875yzms6im.fsf@gnu.org> <83wns1zvhs.fsf@gnu.org> <871ra9kdgs.fsf@gnu.org> <83czttzstr.fsf@gnu.org> <87wns1n4k6.fsf@gnus.org> <835yzlzr37.fsf@gnu.org> <87cztqojsk.fsf@gnus.org> <835yzivjnc.fsf@gnu.org> <87cztqn3p9.fsf@gnus.org> <834kf2viof.fsf@gnu.org> <87h7j1lb30.fsf@gnus.org> <83eee5tpr3.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEVIbDtPakO1k4Fh VTidTDe6PjlIUD////+9YGZ5AAAAAWJLR0QHFmGI6wAAAAd0SU1FB+UFEQ01Gv2TN4QAAAGlSURB VDjLdZNBb+sgDMed0fWcbNLOT920c/RMOFcCen5S8D0Trb//R3g27RZIO6tExj//bZNQgG4oBl0/ dEMPALrkMWysl8QOYLgC8cTpb6DXjaxeHtBJKflJrFOnk5guFTyV2ppyLSVpr7p/OUANygCvYwE3 xWoDWIkdDn/uQG+S+zr8/XRtXEexc0ZEXrAhOqNjRp9d2JQCMMwcEPOmuYI3jh5Ll2ND2QY6cekx N2CPuJjMi7i2CuMIGSVoji2IRC57vpVZZ94RUToHrymI4w/orQAKgRajWlqbT6oIRGhDpERjVUr3 wkSaKK0vC2Kk+VKA8EoBONEpS5egzag++TPNbxd/jW9AOp1LPEX6VwE5SYglfZZ2fgXmB+h0qZJE iqEEy+THSiF7H1W0ObtsE9jvgmsTNGikso3JUXNETZl0eSfiaip1n0cwclF2Y/VKCtid3BktLs1d 0DJm5gsFxw0wRYbTzF/cXhL9kB4xyL3zWwApO7m/jHdg3Ctx070EsuMAOR7vCZj32/Bb230oHR+A kv0A7JfyLL783x/brwB+BY/tP0rubGCTDWEYAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIxLTA1LTE3 VDEzOjUzOjI2KzAwOjAwxDEUAAAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMS0wNS0xN1QxMzo1Mzoy NiswMDowMLVsrLwAAAAASUVORK5CYII= X-Now-Playing: Jay Glass Dubs's _Nyx_: "Atremes" Date: Mon, 17 May 2021 16:20:25 +0200 In-Reply-To: <83eee5tpr3.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 17 May 2021 17:10:40 +0300") Message-ID: <87tun1jvbq.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > What do you mean by "first"? We already support the likes of > "28.3 Beta3", and "Beta3" is not ignored there as some free-text > comment. For this purpose, it doesn't matter -- we're only interested in the major version. But if you want to expand the language in a more regular way, then a different separating character (between the part [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 48404 Cc: 48404@debbugs.gnu.org, stefan@marxist.se, tsdh@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > What do you mean by "first"? We already support the likes of > "28.3 Beta3", and "Beta3" is not ignored there as some free-text > comment. For this purpose, it doesn't matter -- we're only interested in the major version. But if you want to expand the language in a more regular way, then a different separating character (between the part we parse and the one that's free text) can be used, of course. Semicolon? > And that is assuming the developers of 3rd-party packages can have > some reasonable way of associating their versions with Emacs versions, > which I still think is a problem with no solution. They don't really need to. They decide "we think people with Emacs 25 shouldn't have this in their M-x TAX" and then put "26.1;Magit/1.2" in the string. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon May 17 10:27:08 2021 Received: (at 48404) by debbugs.gnu.org; 17 May 2021 14:27:08 +0000 Received: from localhost ([127.0.0.1]:53338 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lieD6-0005Hz-9o for submit@debbugs.gnu.org; Mon, 17 May 2021 10:27:08 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lieD4-0005HV-Lj for 48404@debbugs.gnu.org; Mon, 17 May 2021 10:27:07 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44070) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lieCz-0006Fg-Ey; Mon, 17 May 2021 10:27:01 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4421 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lieCy-0005pK-8H; Mon, 17 May 2021 10:27:00 -0400 Date: Mon, 17 May 2021 17:27:05 +0300 Message-Id: <838s4dtozq.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-Reply-To: <87tun1jvbq.fsf@gnus.org> (message from Lars Ingebrigtsen on Mon, 17 May 2021 16:20:25 +0200) Subject: Re: bug#48404: 28.0.50; "Invalid version syntax" errors with read-extended-command References: <875yzms6im.fsf@gnu.org> <83wns1zvhs.fsf@gnu.org> <871ra9kdgs.fsf@gnu.org> <83czttzstr.fsf@gnu.org> <87wns1n4k6.fsf@gnus.org> <835yzlzr37.fsf@gnu.org> <87cztqojsk.fsf@gnus.org> <835yzivjnc.fsf@gnu.org> <87cztqn3p9.fsf@gnus.org> <834kf2viof.fsf@gnu.org> <87h7j1lb30.fsf@gnus.org> <83eee5tpr3.fsf@gnu.org> <87tun1jvbq.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48404 Cc: 48404@debbugs.gnu.org, stefan@marxist.se, tsdh@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Cc: tsdh@gnu.org, 48404@debbugs.gnu.org, stefan@marxist.se > Date: Mon, 17 May 2021 16:20:25 +0200 > > Eli Zaretskii writes: > > > What do you mean by "first"? We already support the likes of > > "28.3 Beta3", and "Beta3" is not ignored there as some free-text > > comment. > > For this purpose, it doesn't matter -- we're only interested in the > major version. But if you want to expand the language in a more regular > way, then a different separating character (between the part we parse > and the one that's free text) can be used, of course. Semicolon? Maybe, I don't know. My point is that simply ignoring something after the first space is not a good idea. > > And that is assuming the developers of 3rd-party packages can have > > some reasonable way of associating their versions with Emacs versions, > > which I still think is a problem with no solution. > > They don't really need to. They decide "we think people with Emacs 25 > shouldn't have this in their M-x TAX" and then put "26.1;Magit/1.2" in > the string. We need to talk to them to get their agreement, I think. We cannot decide for them that this is what they should do. From debbugs-submit-bounces@debbugs.gnu.org Tue May 18 09:31:57 2021 Received: (at 48404) by debbugs.gnu.org; 18 May 2021 13:31:57 +0000 Received: from localhost ([127.0.0.1]:54685 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lizpE-0000fw-PV for submit@debbugs.gnu.org; Tue, 18 May 2021 09:31:57 -0400 Received: from quimby.gnus.org ([95.216.78.240]:41892) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lizpC-0000aV-D9 for 48404@debbugs.gnu.org; Tue, 18 May 2021 09:31:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=kAZzgZm0G8Gf3zxUgP5rSNOTZwbZrLJVFp+hyZf9/Bo=; b=dZuhO4H+u1gnMJ0KMVsjoTey4V 2mbm2yxMq+dYie5QBW0Qp7KZVub7FRyhmKIbktn252aZcIbCfsvOB7kEKII68rIoUCpCFPUC6efmm SCbBO8IBFetg1bvXwjNugYkkVBahKOevBheW+Rak1p4rDFO9XKYOdaD7UYTRlAKyJZNo=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lizp2-0005ZL-Df; Tue, 18 May 2021 15:31:47 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#48404: 28.0.50; "Invalid version syntax" errors with read-extended-command References: <875yzms6im.fsf@gnu.org> <83wns1zvhs.fsf@gnu.org> <871ra9kdgs.fsf@gnu.org> <83czttzstr.fsf@gnu.org> <87wns1n4k6.fsf@gnus.org> <835yzlzr37.fsf@gnu.org> <87cztqojsk.fsf@gnus.org> <835yzivjnc.fsf@gnu.org> <87cztqn3p9.fsf@gnus.org> <834kf2viof.fsf@gnu.org> <87h7j1lb30.fsf@gnus.org> <83eee5tpr3.fsf@gnu.org> <87tun1jvbq.fsf@gnus.org> <838s4dtozq.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAFVBMVEX+/vzlzZ6/lWz7 98+XbEs2Lif///9n/utRAAAAAWJLR0QGYWa4fQAAAAd0SU1FB+UFEg0PE7NT/rcAAAGpSURBVDjL ddRLdusgDABQJ7TzAO68UsncDukCqoj5ey3sfyuVIORLPXAc3YMEipxpul7OrzHG6ekyEOMQNju5 XeFr6U+Huiz27+W7g32A0gHq/ZKrlPe/4N/5iWAyfok9V7kUOdnFSPwKvQjhYuJ0OYnArp1PYIO7 W2hFjJfI/Yr/DXbnXfVtuVTOsNyDUI2Y9yc4N/e02qXC8gR+GsH0tcYx0AE/hsAr+CGEKMXlmE/w qSdcB/BykrgdpNqytdYPYMOEQ9gygR+NVuC24BGOzNhm8T6XY2Yq5B9gdUEgp5LhNpd1YEOoUEq2 lyVbQrkCJ1YohTrNEoZag0u7oGUTADvfQmHfAGwtjpS61Mn5RGu1BiHtO2SFV5A4EkvGuQZTbnO7 Bd0Vkm4hl5Q5/TQwkqcSAuTC3ylJyjpjR5Y1TtfBnIn2bN8aHAIgoEOy6DjvCVNQMHElhxJDuVnC ULdVIWpZmLWQlR/LhgbSzVkhBDkIEEinzFzqCxOP2kZpSajgo9EebuIVWE8jo7Iq6D/OAZAFpFvy KUOk74OOXnRLYO2iJMvyy0uy6RfLPnvmOhjsugAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMS0wNS0x OFQxMzoxNToxOCswMDowMCmsDEEAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjEtMDUtMThUMTM6MTU6 MTgrMDA6MDBY8bT9AAAAAElFTkSuQmCC X-Now-Playing: Zola Jesus's _Taiga_: "Nail" Date: Tue, 18 May 2021 15:31:43 +0200 In-Reply-To: <838s4dtozq.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 17 May 2021 17:27:05 +0300") Message-ID: <875yzggocg.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: >> They don't really need to. They decide "we think people with Emacs 25 >> shouldn't have this in their M-x TAX" and then put "26.1;Magit/1.2" in >> the string. > > We need to talk to them to get the [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 48404 Cc: 48404@debbugs.gnu.org, stefan@marxist.se, tsdh@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> They don't really need to. They decide "we think people with Emacs 25 >> shouldn't have this in their M-x TAX" and then put "26.1;Magit/1.2" in >> the string. > > We need to talk to them to get their agreement, I think. We cannot > decide for them that this is what they should do. I think we just have to establish a convention that external packages could use. Whether they then want to use it is up to them. That is, if they don't want to, then Emacs' behaviour with regards to obsoleted commands won't change -- but if they want to see this new behaviour, they'll need to reformat their obsoletion strings. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed May 19 08:04:51 2021 Received: (at 48404) by debbugs.gnu.org; 19 May 2021 12:04:51 +0000 Received: from localhost ([127.0.0.1]:58304 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ljKwV-00058h-9h for submit@debbugs.gnu.org; Wed, 19 May 2021 08:04:51 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56186) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ljKwT-00058T-Jf for 48404@debbugs.gnu.org; Wed, 19 May 2021 08:04:49 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46094) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ljKwO-0006hn-7w; Wed, 19 May 2021 08:04:44 -0400 Received: from auth2-smtp.messagingengine.com ([66.111.4.228]:36881) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ljKwK-0006ep-Aq; Wed, 19 May 2021 08:04:42 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailauth.nyi.internal (Postfix) with ESMTP id D06CA27C005A; Wed, 19 May 2021 08:04:39 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 19 May 2021 08:04:39 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdeiledggeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfhgfhffvufffjgfkgggtsehttdertddtredtnecuhfhrohhmpefvrghsshhi lhhoucfjohhrnhcuoehtshguhhesghhnuhdrohhrgheqnecuggftrfgrthhtvghrnhepve evieekteekveeigfefffeivdetgeduvdffueeuudevgedttdehvdfhueevfffhnecukfhp peekjedrudeifedrfedurdduheegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrg hmpehmrghilhhfrhhomhepthhhohhrnhdomhgvshhmthhprghuthhhphgvrhhsohhnrghl ihhthidqkeeijeefkeejkeegqdeifeehvdelkedqthhsughhpeepghhnuhdrohhrghesfh grshhtmhgrihhlrdhfmh X-ME-Proxy: Received: from thinkpad-t440p (p57a31f9a.dip0.t-ipconnect.de [87.163.31.154]) by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 19 May 2021 08:04:38 -0400 (EDT) References: <875yzms6im.fsf@gnu.org> <83wns1zvhs.fsf@gnu.org> <871ra9kdgs.fsf@gnu.org> <83czttzstr.fsf@gnu.org> <87wns1n4k6.fsf@gnus.org> <835yzlzr37.fsf@gnu.org> <87cztqojsk.fsf@gnus.org> <835yzivjnc.fsf@gnu.org> <87cztqn3p9.fsf@gnus.org> <834kf2viof.fsf@gnu.org> <87h7j1lb30.fsf@gnus.org> <83eee5tpr3.fsf@gnu.org> <87tun1jvbq.fsf@gnus.org> User-agent: mu4e 1.5.13; emacs 28.0.50 From: Tassilo Horn To: Lars Ingebrigtsen Subject: Re: bug#48404: 28.0.50; "Invalid version syntax" errors with read-extended-command Date: Wed, 19 May 2021 13:54:22 +0200 In-reply-to: <87tun1jvbq.fsf@gnus.org> Message-ID: <874kezj5ez.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48404 Cc: Eli Zaretskii , 48404@debbugs.gnu.org, stefan@marxist.se X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> And that is assuming the developers of 3rd-party packages can have >> some reasonable way of associating their versions with Emacs >> versions, which I still think is a problem with no solution. > > They don't really need to. They decide "we think people with Emacs 25 > shouldn't have this in their M-x TAX" and then put "26.1;Magit/1.2" in > the string. FWIW, as a 3rd-party package maintainer, I've never have the need to define that some commands should not show up in completion with a specific emacs version. In auctex, we deal with emacs versions by just requiring a minimal version (which gets bumpt very conservatively), and that's about it. But of course, YMMV. In auctex, all our obsoletion versions are just version numbers "11.97" like and represent the auctex version and our bug reports show that old versions are still used much more often as one would expect. So as long as those "normal" versions don't cause the package version be compared to the emacs version and just recently deprecated commands vanish from completion, I'm neutral. Bye, Tassilo From debbugs-submit-bounces@debbugs.gnu.org Wed May 19 09:59:18 2021 Received: (at 48404) by debbugs.gnu.org; 19 May 2021 13:59:19 +0000 Received: from localhost ([127.0.0.1]:60351 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ljMjG-0004OO-Nd for submit@debbugs.gnu.org; Wed, 19 May 2021 09:59:18 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55294) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ljMjE-0004O9-Oo for 48404@debbugs.gnu.org; Wed, 19 May 2021 09:59:17 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49540) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ljMj9-0006Gz-8I; Wed, 19 May 2021 09:59:11 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2812 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ljMj7-00050g-F4; Wed, 19 May 2021 09:59:10 -0400 Date: Wed, 19 May 2021 16:59:19 +0300 Message-Id: <83v97eq0y0.fsf@gnu.org> From: Eli Zaretskii To: Tassilo Horn In-Reply-To: <874kezj5ez.fsf@gnu.org> (message from Tassilo Horn on Wed, 19 May 2021 13:54:22 +0200) Subject: Re: bug#48404: 28.0.50; "Invalid version syntax" errors with read-extended-command References: <875yzms6im.fsf@gnu.org> <83wns1zvhs.fsf@gnu.org> <871ra9kdgs.fsf@gnu.org> <83czttzstr.fsf@gnu.org> <87wns1n4k6.fsf@gnus.org> <835yzlzr37.fsf@gnu.org> <87cztqojsk.fsf@gnus.org> <835yzivjnc.fsf@gnu.org> <87cztqn3p9.fsf@gnus.org> <834kf2viof.fsf@gnu.org> <87h7j1lb30.fsf@gnus.org> <83eee5tpr3.fsf@gnu.org> <87tun1jvbq.fsf@gnus.org> <874kezj5ez.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48404 Cc: larsi@gnus.org, 48404@debbugs.gnu.org, stefan@marxist.se X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Tassilo Horn > Cc: Eli Zaretskii , 48404@debbugs.gnu.org, stefan@marxist.se > Date: Wed, 19 May 2021 13:54:22 +0200 > > In auctex, all our obsoletion versions are just version numbers "11.97" > like and represent the auctex version and our bug reports show that old > versions are still used much more often as one would expect. So as long > as those "normal" versions don't cause the package version be compared > to the emacs version and just recently deprecated commands vanish from > completion, I'm neutral. AFAIU, they do get compared with Emacs version numbers. From unknown Sun Jun 15 08:48:45 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 17 Jun 2021 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator