GNU bug report logs - #48384
[PATCH] gnu: Add emacs-tshell.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Reichör <stefan <at> xsteve.at>
Subject: bug#48384: closed (Re: [bug#48384] [PATCH] gnu: Add emacs-tshell.)
Date: Fri, 14 May 2021 22:08:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#48384: [PATCH] gnu: Add emacs-tshell.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 48384 <at> debbugs.gnu.org.

-- 
48384: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=48384
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Stefan Reichör <stefan <at> xsteve.at>
Cc: 48384-done <at> debbugs.gnu.org
Subject: Re: [bug#48384] [PATCH] gnu: Add emacs-tshell.
Date: Sat, 15 May 2021 00:07:20 +0200

Hello,

Stefan Reichör <stefan <at> xsteve.at> writes:

> * gnu/packages/emacs-xyz.scm (emacs-tshell): New variable.

I applied it with the changes explained below. Thank you!

> +(define-public emacs-tshell
> +  (let ((commit "47ef3a6c537b06eb422d9a124e1c44062223e323")
> +        (revision "0"))

I added a comment explaining why we are not using a tagged release.

> +    (package
> +      (name "emacs-tshell")
> +      (version (git-version "0.1" revision commit))

I changed "0.1" into "0.1.0" because that is what the Version keywords
says.

> +      (synopsis "A buffer-oriented Emacs shell.")

Synopsis must not start with an article and end with a period. You may
want to run "guix lint" to catch these.

> +      (description
> +       "This shell allows to run one line commands by hitting RET.  It supports
> +shell and emacs lisp commands.")

I slightly reworded the description.

Regards,
-- 
Nicolas Goaziou

[Message part 3 (message/rfc822, inline)]

From: Stefan Reichör <stefan <at> xsteve.at>
To: guix-patches <at> gnu.org
Cc: Stefan Reichör <stefan <at> xsteve.at>
Subject: [PATCH] gnu: Add emacs-tshell.
Date: Wed, 12 May 2021 23:05:07 +0200

* gnu/packages/emacs-xyz.scm (emacs-tshell): New variable.
---
 gnu/packages/emacs-xyz.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index ff90c6bd3a..193cdcad6e 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -27204,6 +27204,31 @@ easily.  Four pre-set options are: @samp{shell}, @samp{terminal},
 you use some other configuration.")
       (license license:gpl3+))))
 
+(define-public emacs-tshell
+  (let ((commit "47ef3a6c537b06eb422d9a124e1c44062223e323")
+        (revision "0"))
+    (package
+      (name "emacs-tshell")
+      (version (git-version "0.1" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/TatriX/tshell")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "0yv38bqdp6b614lbj4v408vv5mlic3vs1v7266xrfxm1cm903apj"))))
+      (build-system emacs-build-system)
+      (propagated-inputs
+       `(("emacs-transient" ,emacs-transient)))
+      (home-page "https://github.com/TatriX/tshell")
+      (synopsis "A buffer-oriented Emacs shell.")
+      (description
+       "This shell allows to run one line commands by hitting RET.  It supports
+shell and emacs lisp commands.")
+      (license license:gpl3+))))
+
 (define-public emacs-extmap
   (package
     (name "emacs-extmap")
-- 
2.25.1

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.