Subject: Re: [bug#48384] [PATCH] gnu: Add emacs-tshell.

From: Nicolas Goaziou <[email-masked]>
Date: Sat, 15 May 2021 00:07:20 +0200

Hello,

Stefan Reichör <[email-masked]> writes:

> * gnu/packages/emacs-xyz.scm (emacs-tshell): New variable.

I applied it with the changes explained below. Thank you!

> +(define-public emacs-tshell
> +  (let ((commit "47ef3a6c537b06eb422d9a124e1c44062223e323")
> +        (revision "0"))

I added a comment explaining why we are not using a tagged release.

> +    (package
> +      (name "emacs-tshell")
> +      (version (git-version "0.1" revision commit))

I changed "0.1" into "0.1.0" because that is what the Version keywords
says.

> +      (synopsis "A buffer-oriented Emacs shell.")

Synopsis must not start with an article and end with a period. You may
want to run "guix lint" to catch these.

> +      (description
> +       "This shell allows to run one line commands by hitting RET.  It supports
> +shell and emacs lisp commands.")

I slightly reworded the description.

Regards,
-- 
Nicolas Goaziou